prreviewbuddy 0.39.3 → 0.42.0

package/CHANGELOG.md

@@ -1,5 +1,67 @@
 # Changelog
 
+## 0.42.0
+
+**A review page no longer says "Review up to date" when it isn't.** The status beside **Check for
+updates** used to be worked out once, when the page opened. It now checks again on its own when you
+come back to the tab and once a minute while you're looking at it, so a commit to the branch you're
+reviewing shows as **Code changed** without pressing anything. These checks never contact GitHub and
+are silent: nothing flashes, and a warning you dismissed stays dismissed until something newer
+arrives.
+
+**Pull request pushes show on the page, not just in notifications.** The workspace server already
+checked your pull requests on GitHub every few minutes and told you when one moved. The page itself
+could only see commits your repository had fetched, so it could say "up to date", and **Check for
+updates** could say **No change**, right after a **PR updated** notification. The page now shows
+**PR updated** as soon as the server has seen the push, with **Update review** beside it, whether or
+not anything has been fetched. The server watches the pull requests of reviews that are queued,
+saved, or not yet marked reviewed, so those are the ones this applies to. Once **Update review** finishes, the page and the card on the
+Reviews page stop saying the pull request moved straight away; an unread **PR updated** notification
+clears at the next check a few minutes later, as before. If the author pushes again while the update
+is running, the page says so rather than hiding the newer push.
+
+## 0.41.0
+
+**Your place is kept when a page reloads itself.** The Reviews page reloads whenever something on it
+changes, such as a review finishing or the review queue changing in another tab, and a review
+reloads when its analysis produces something new. Both used to jump back to the top. They now come
+back where you were. Opening a page from a link still starts at the top, and each view of a review
+and each filter of the list keeps its own place.
+
+**Add a selection to the review queue.** In selection mode, the bar has **Add to review queue**,
+which adds every ticked review in the order the list shows them. Reviews already queued keep their
+place. The queue holds fifty reviews; anything that does not fit stays ticked, and the bar says why.
+Reviews deleted since they were queued no longer take up any of those fifty places.
+
+**Save a review from its own page.** The review page's **...** menu has **Save review**, which does
+what the star on the Reviews page does. When the review is saved it reads **Remove from saved**.
+
+**Copy an issue or a question, ready to post.** Every issue and question has a **Copy** button that
+puts it on the clipboard as Markdown. An issue copies its title in bold, its description, then the
+file and line. A question copies the question in bold, why it matters, then the file. Both list any
+unchanged files they rely on. The severity, confidence and theme labels are left out, so it pastes
+straight into a pull request comment.
+
+## 0.40.0
+
+**See which reviewed pull requests have merged.** The workspace server's regular pull request check
+now also reads whether each pull request is open, merged or closed, from GitHub, in the same request
+it already made. A card whose pull request has merged says **Merged** beside its status, and one
+closed without merging says **PR closed**. Neither changes the review's own status: a review stays
+**In progress** until you mark it reviewed, and a reviewed card keeps its **Merged** badge. When a
+pull request you are watching merges or closes you get one notification, **PR merged** or **PR
+closed**, and never a repeat. Pull requests that had already merged before this version are marked
+quietly, without a notification each. A merged pull request is not checked again.
+
+**A PR filter on the Reviews page.** Beside **Status**, **PR** narrows the list to pull requests that
+are **Open**, **Merged** or **Closed**. It combines with Status, so **In progress** with **Merged**
+lists the merged reviews you have not finished. Reviews with no pull request only appear under
+**Any**.
+
+**Select all in selection mode.** The bar at the bottom has **Select all**, which ticks every review
+the search and filters are showing, on every page. To clear out merged reviews: set PR to Merged,
+press Select, **Select all**, then **Mark reviewed**.
+
 ## 0.39.3
 
 **Reviews of a branch now notice when the branch moves, not only reviews of a pull request.** The

package/dist/{delete_review-yHciIgD4.js → delete_review-DPRL5IPt.js}

@@ -3885,6 +3885,29 @@ function queueAdd(id) {
 	if (current.includes(id)) return current;
 	return writeQueue([...current, id]);
 }
+/**
+* Append several, in the order given, for the reviews index's bulk bar.
+*
+* The same rules as `queueAdd` for each one, in one write. The cap is where this differs: one Add
+* at a time never meets it in practice, but a selection can hold a hundred cards, and `normalise`
+* would drop everything past fifty without a word. So what does not fit is left out *here* and
+* named in `full`, and the caller has something true to say about it.
+*/
+function queueAddMany(ids) {
+	const current = readQueue();
+	const fresh = ids.filter((id, at) => !current.includes(id) && ids.indexOf(id) === at);
+	const room = Math.max(0, 50 - current.length);
+	const full = fresh.slice(room);
+	if (fresh.length <= full.length) return {
+		queue: current,
+		full
+	};
+	const queue = writeQueue([...current, ...fresh.slice(0, room)]);
+	return queue === null ? null : {
+		queue,
+		full
+	};
+}
 function queueRemove(id) {
 	const current = readQueue();
 	if (!current.includes(id)) return current;
@@ -6475,14 +6498,22 @@ function identity(raw) {
 	};
 }
 /**
-* The watcher's query: one field.
+* The watcher's query: where the branch is, and whether the request is still open.
 *
 * Deliberately not `PR_FIELDS`. That list exists because a review needs all nine of them, and its
 * docblock warns that trimming it fails silently rather than loudly. Sharing it here would put a
 * nine-field query on a five-minute timer across the whole working set, and would put the watcher
 * in a position to "optimise" a list that must never shrink.
+*
+* `state` rides on the same call rather than being a second one, which keeps the watcher's rate
+* limit arithmetic in `MAX_WATCHED` true as written.
 */
-var HEAD_FIELDS = "headRefOid";
+var HEAD_FIELDS = "headRefOid,state";
+var STATES = /* @__PURE__ */ new Map([
+	["OPEN", "open"],
+	["MERGED", "merged"],
+	["CLOSED", "closed"]
+]);
 /**
 * The head sha out of `gh`'s answer, or a refusal.
 *
@@ -6501,7 +6532,8 @@ function readHeadSha(raw) {
 	};
 	return {
 		kind: "head",
-		sha
+		sha,
+		state: STATES.get(text(raw?.state)) ?? null
 	};
 }
 async function headOf(repo, number, env, cwd) {
@@ -9805,6 +9837,7 @@ var OPERATION_NAMES = {
 /** What happened, in the words the list uses: `Review ready`, `Review update failed`, `PR updated`. */
 function eventName(notification) {
 	if (notification.kind === "pr-updated") return notification.source === "branch" ? "Branch updated" : "PR updated";
+	if (notification.kind === "pr-state") return notification.state === "merged" ? "PR merged" : "PR closed";
 	return `${OPERATION_NAMES[notification.operation]} ${notification.outcome}`;
 }
 /**
@@ -9825,7 +9858,7 @@ function headline(notification) {
 * so adding the next kind is a compiler error here instead of a silently untinted toast there.
 */
 function toneOf(notification) {
-	return notification.kind === "pr-updated" ? "updated" : notification.outcome;
+	return notification.kind === "analysis" ? notification.outcome : "updated";
 }
 var OPERATIONS = [
 	"review",
@@ -9867,6 +9900,18 @@ function createPrUpdate(input, now = Date.now()) {
 		createdAt: now
 	});
 }
+/**
+* Record that a watched pull request merged or closed, or return null because this is already
+* recorded. Same `wx` contract: the id names the state and the head.
+*/
+function createPrState(input, now = Date.now()) {
+	return create({
+		version: 1,
+		kind: "pr-state",
+		...input,
+		createdAt: now
+	});
+}
 function create(record) {
 	if (!ID.test(record.id)) return null;
 	try {
@@ -9993,6 +10038,7 @@ function isNotification(value) {
 	if (!(record.version === 1 && typeof record.id === "string" && typeof record.reviewId === "string" && typeof record.subject === "string" && (record.branch === void 0 || typeof record.branch === "string") && typeof record.repo === "string" && typeof record.createdAt === "number" && (record.readAt === void 0 || typeof record.readAt === "number"))) return false;
 	if (record.kind === "analysis") return OPERATIONS.includes(record.operation) && OUTCOMES.includes(record.outcome);
 	if (record.kind === "pr-updated") return typeof record.headSha === "string" && typeof record.detail === "string" && (record.source === void 0 || record.source === "branch");
+	if (record.kind === "pr-state") return (record.state === "merged" || record.state === "closed") && typeof record.headSha === "string";
 	return false;
 }
 //#endregion
@@ -11834,7 +11880,9 @@ async function updateReview(workspace, runners = {}) {
 	const current = () => loadJob(held.job.id) ?? held.job;
 	const step = (phase) => saveJob(advance(current(), phase));
 	try {
+		const fetchStartedAt = Date.now();
 		const outcome = await bringForward(workspace, runners, reviewedSha, held, step);
+		if (outcome.ok && !outcome.fetchFailed && outcome.toSha) workspace.headSeenAt = fetchStartedAt;
 		const ended = outcome.stop === "analysis-failed" ? fail(current(), outcome.message) : advance(current(), "done", outcome.message);
 		saveJob(ended);
 		announceJob(ended);
@@ -12015,7 +12063,8 @@ var UPDATE_OWNED_FIELDS = [
 	"prContext",
 	"lastPrRefresh",
 	"dismissedFreshnessSha",
-	"lastUpdate"
+	"lastUpdate",
+	"headSeenAt"
 ];
 /**
 * What an update writes, laid over the review as it is on disk now rather than as it was when the
@@ -12466,4 +12515,4 @@ function lineageIds(id) {
 	return [.../* @__PURE__ */ new Set([id, ...lineage.map((review) => review.id)])];
 }
 //#endregion
-export { readServerRecord as $, summarise as $t, createPrUpdate as A, agentById as An, saveJob as At, unreadCount as B, groupByLineage as Bt, readEvents as C, clearAgentPreference as Cn, followedBranch as Ct, announceJob as D, STORE_ROOT as Dn, fail as Dt, telemetryUploadConsent as E, CONFIG_PATH as En, endedAt as Et, markRead as F, purposeOf as Ft, readMarker as G, loadWorkspace as Gt, EXPLAIN_SIMPLY_PROMPT as H, latestKissRun as Ht, pruneNotifications as I, clearClaim as It, relativeTime as J, positionInLineage as Jt, removeWorktree as K, matchingWorkspaceIds as Kt, readNotification as L, driverGone as Lt, headline as M, detectAgents as Mn, isLiveJob as Mt, listNotifications as N, AgentCancelledError as Nn, phasesFor as Nt, branchOf as O, AGENT_IDS as On, isTerminal as Ot, markAllRead as P, AgentUnavailableError as Pn, progressSteps as Pt, ensureServer as Q, reviewedRepositories as Qt, removeNotification as R, isClaimed as Rt, startJob as S, resolveModel as Sn, checkReview as St, recordTelemetryUploadConsent as T, writeAgentPreference as Tn, allJobs as Tt, ReviewBeingDeletedError as U, lineageKeyFor as Ut, withUsageRecorded as V, indexReviewGroups as Vt, MANAGED_ROOT as W, lineagePosition as Wt, bootstrapUrl as X, recentWorkspaces as Xt, readIndexToken as Y, previousKissResult as Yt, clearServerRecord as Z, reviewedCommit as Zt, agentEnvOf as _, resolveTarget as _n, forgeResolver as _t, wasBlocked as a, queueRemove as an, writeServerRecord as at, reanalyseReview as b, git as bn, fillFileUrlTemplate as bt, RefreshUnavailableError as c, writeQueue as cn, feedbackUrl as ct, refreshPrContext as d, isQuestionOutstanding as dn, MIN_WORKSPACE_PORT as dt, touchWorkspace as en, reviewsUrl as et, isUnchanged as f, issuesOutstanding as fn, parseWorkspacePort as ft, runningJobs as g, describeAuthorship as gn, claimRequestUrl as gt, liveUpdateFor as h, processDiscussion as hn, writePortPreference as ht, liveJobsFor as i, queueAdd as in, workspaceUrl as it, eventName as j, agentFor as jn, PHASES as jt, subjectOf as k, DEFAULT_AGENT_ID as kn, loadJob as kt, mergeUpdateInto as l, doneVerb as ln, DEFAULT_WORKSPACE_PORT as lt, UpdateAlreadyRunningError as m, reviewerDispositions as mn, statedWorkspacePort as mt, deleteReview as n, workspaceStamps as nn, spawnServer as nt, discardJob as o, queueStamp as on, BUILD_VERSION as ot, askCheckout as p, questionsOutstanding as pn, resolveWorkspacePort as pt, modelHelpLines as q, mutateWorkspace as qt, lineageIds as r, dequeueOnComplete as rn, stopServer as rt, FETCH_TIMEOUT_MS as s, readQueue as sn, PACKAGE_NAME as st, deleteLineage as t, workspaceRevision as tn, serverEntryExists as tt, updateReview as u, isIssueOutstanding as un, MAX_WORKSPACE_PORT as ut, recordKissRun as v, displayRef as vn, forgeFor as vt, record as w, readAgentPreference as wn, reviewedShaOf as wt, runJob as x, resolveAgent as xn, checkCodeFreshness as xt, startKissJob as y, isCommitReview as yn, remoteHost as yt, toneOf as z, followedRefName as zt };
+export { ensureServer as $, reviewedRepositories as $t, createPrState as A, AGENT_IDS as An, loadJob as At, toneOf as B, followedRefName as Bt, readEvents as C, resolveAgent as Cn, checkReview as Ct, announceJob as D, writeAgentPreference as Dn, endedAt as Dt, telemetryUploadConsent as E, readAgentPreference as En, allJobs as Et, markAllRead as F, AgentCancelledError as Fn, progressSteps as Ft, MANAGED_ROOT as G, lineagePosition as Gt, withUsageRecorded as H, indexReviewGroups as Ht, markRead as I, AgentUnavailableError as In, purposeOf as It, modelHelpLines as J, mutateWorkspace as Jt, readMarker as K, loadWorkspace as Kt, pruneNotifications as L, clearClaim as Lt, eventName as M, agentById as Mn, PHASES as Mt, headline as N, agentFor as Nn, isLiveJob as Nt, branchOf as O, CONFIG_PATH as On, fail as Ot, listNotifications as P, detectAgents as Pn, phasesFor as Pt, clearServerRecord as Q, reviewedCommit as Qt, readNotification as R, driverGone as Rt, startJob as S, git as Sn, checkCodeFreshness as St, recordTelemetryUploadConsent as T, clearAgentPreference as Tn, reviewedShaOf as Tt, EXPLAIN_SIMPLY_PROMPT as U, latestKissRun as Ut, unreadCount as V, groupByLineage as Vt, ReviewBeingDeletedError as W, lineageKeyFor as Wt, readIndexToken as X, previousKissResult as Xt, relativeTime as Y, positionInLineage as Yt, bootstrapUrl as Z, recentWorkspaces as Zt, agentEnvOf as _, processDiscussion as _n, claimRequestUrl as _t, wasBlocked as a, queueAdd as an, workspaceUrl as at, reanalyseReview as b, displayRef as bn, remoteHost as bt, RefreshUnavailableError as c, queueStamp as cn, PACKAGE_NAME as ct, refreshPrContext as d, doneVerb as dn, MAX_WORKSPACE_PORT as dt, summarise as en, readServerRecord as et, isUnchanged as f, isIssueOutstanding as fn, MIN_WORKSPACE_PORT as ft, runningJobs as g, reviewerDispositions as gn, writePortPreference as gt, liveUpdateFor as h, questionsOutstanding as hn, statedWorkspacePort as ht, liveJobsFor as i, dequeueOnComplete as in, stopServer as it, createPrUpdate as j, DEFAULT_AGENT_ID as jn, saveJob as jt, subjectOf as k, STORE_ROOT as kn, isTerminal as kt, mergeUpdateInto as l, readQueue as ln, feedbackUrl as lt, UpdateAlreadyRunningError as m, issuesOutstanding as mn, resolveWorkspacePort as mt, deleteReview as n, workspaceRevision as nn, serverEntryExists as nt, discardJob as o, queueAddMany as on, writeServerRecord as ot, askCheckout as p, isQuestionOutstanding as pn, parseWorkspacePort as pt, removeWorktree as q, matchingWorkspaceIds as qt, lineageIds as r, workspaceStamps as rn, spawnServer as rt, FETCH_TIMEOUT_MS as s, queueRemove as sn, BUILD_VERSION as st, deleteLineage as t, touchWorkspace as tn, reviewsUrl as tt, updateReview as u, writeQueue as un, DEFAULT_WORKSPACE_PORT as ut, recordKissRun as v, describeAuthorship as vn, forgeResolver as vt, record as w, resolveModel as wn, followedBranch as wt, runJob as x, isCommitReview as xn, fillFileUrlTemplate as xt, startKissJob as y, resolveTarget as yn, forgeFor as yt, removeNotification as z, isClaimed as zt };

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $t as summarise, An as agentById, Bt as groupByLineage, Dn as STORE_ROOT, E as telemetryUploadConsent, En as CONFIG_PATH, Ft as purposeOf, G as readMarker, Gt as loadWorkspace, It as clearClaim, J as relativeTime, Jt as positionInLineage, K as removeWorktree, Kt as matchingWorkspaceIds, Lt as driverGone, Mn as detectAgents, On as AGENT_IDS, Ot as isTerminal, Pt as progressSteps, Q as ensureServer, Qt as reviewedRepositories, Rt as isClaimed, S as startJob, Sn as resolveModel, St as checkReview, T as recordTelemetryUploadConsent, Tn as writeAgentPreference, Tt as allJobs, Ut as lineageKeyFor, W as MANAGED_ROOT, X as bootstrapUrl, Xt as recentWorkspaces, Y as readIndexToken, _n as resolveTarget, _t as forgeResolver, a as wasBlocked, b as reanalyseReview, bn as git, dt as MIN_WORKSPACE_PORT, et as reviewsUrl, ft as parseWorkspacePort, g as runningJobs, h as liveUpdateFor, ht as writePortPreference, i as liveJobsFor, it as workspaceUrl, jt as PHASES, kn as DEFAULT_AGENT_ID, kt as loadJob, l as mergeUpdateInto, lt as DEFAULT_WORKSPACE_PORT, m as UpdateAlreadyRunningError, mt as statedWorkspacePort, n as deleteReview$1, ot as BUILD_VERSION, q as modelHelpLines, qt as mutateWorkspace, rt as stopServer, st as PACKAGE_NAME, u as updateReview, ut as MAX_WORKSPACE_PORT, v as recordKissRun, vn as displayRef, w as record$1, wn as readAgentPreference, x as runJob, xn as resolveAgent, zt as followedRefName } from "./delete_review-yHciIgD4.js";
+import { $ as ensureServer, $t as reviewedRepositories, An as AGENT_IDS, At as loadJob, Bt as followedRefName, Cn as resolveAgent, Ct as checkReview, Dn as writeAgentPreference, E as telemetryUploadConsent, En as readAgentPreference, Et as allJobs, Ft as progressSteps, G as MANAGED_ROOT, It as purposeOf, J as modelHelpLines, Jt as mutateWorkspace, K as readMarker, Kt as loadWorkspace, Lt as clearClaim, Mn as agentById, Mt as PHASES, On as CONFIG_PATH, Pn as detectAgents, Rt as driverGone, S as startJob, Sn as git, T as recordTelemetryUploadConsent, Vt as groupByLineage, Wt as lineageKeyFor, X as readIndexToken, Y as relativeTime, Yt as positionInLineage, Z as bootstrapUrl, Zt as recentWorkspaces, a as wasBlocked, at as workspaceUrl, b as reanalyseReview, bn as displayRef, ct as PACKAGE_NAME, dt as MAX_WORKSPACE_PORT, en as summarise, ft as MIN_WORKSPACE_PORT, g as runningJobs, gt as writePortPreference, h as liveUpdateFor, ht as statedWorkspacePort, i as liveJobsFor, it as stopServer, jn as DEFAULT_AGENT_ID, kn as STORE_ROOT, kt as isTerminal, l as mergeUpdateInto, m as UpdateAlreadyRunningError, n as deleteReview$1, pt as parseWorkspacePort, q as removeWorktree, qt as matchingWorkspaceIds, st as BUILD_VERSION, tt as reviewsUrl, u as updateReview, ut as DEFAULT_WORKSPACE_PORT, v as recordKissRun, vt as forgeResolver, w as record$1, wn as resolveModel, x as runJob, yn as resolveTarget, zt as isClaimed } from "./delete_review-DPRL5IPt.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";