prreviewbuddy 0.31.0 → 0.36.3

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $t as writeAgentPreference, A as removeWorktree, B as workspaceUrl, C as recordTelemetryUploadConsent, Dt as saveWorkspace, Et as reviewedRepositories, G as DEFAULT_WORKSPACE_PORT, H as BUILD_VERSION, I as ensureServer, J as parseWorkspacePort, Jt as git, K as MAX_WORKSPACE_PORT, Kt as resolveTarget, M as relativeTime, N as readIndexToken, O as MANAGED_ROOT, Ot as summarise, P as bootstrapUrl, Q as forgeResolver, Qt as readAgentPreference, R as reviewsUrl, S as record$1, St as positionInLineage, U as PACKAGE_NAME, X as statedWorkspacePort, Xt as resolveModel, Yt as resolveAgent, Z as writePortPreference, a as wasBlocked, at as isTerminal, b as startJob, bt as loadWorkspace, c as updateReview, ct as PHASES, dt as purposeOf, en as CONFIG_PATH, f as UpdateAlreadyRunningError, ft as clearClaim, g as recordKissRun, ht as groupByLineage, i as liveJobsFor, in as agentById, j as modelHelpLines, k as readMarker, m as runningJobs, mt as followedRefName, n as deleteReview$1, nn as AGENT_IDS, nt as allJobs, on as detectAgents, ot as loadJob, p as liveUpdateFor, pt as isClaimed, q as MIN_WORKSPACE_PORT, qt as displayRef, rn as DEFAULT_AGENT_ID, tn as STORE_ROOT, tt as checkReview, ut as progressSteps, v as reanalyseReview, vt as lineageKeyFor, w as telemetryUploadConsent, wt as recentWorkspaces, xt as matchingWorkspaceIds, y as runJob, z as stopServer } from "./delete_review-C2wax0ED.js";
+import { $ as BUILD_VERSION, At as lineageKeyFor, B as modelHelpLines, Bt as summarise, C as recordTelemetryUploadConsent, Ct as clearClaim, Dt as groupByLineage, Et as followedRefName, G as ensureServer, H as readIndexToken, It as recentWorkspaces, L as MANAGED_ROOT, Mt as loadWorkspace, Nt as matchingWorkspaceIds, Pt as positionInLineage, R as readMarker, Rt as reviewedRepositories, S as record$1, St as purposeOf, Tt as isClaimed, U as bootstrapUrl, V as relativeTime, X as stopServer, Z as workspaceUrl, _t as loadJob, a as wasBlocked, an as displayRef, at as parseWorkspacePort, b as startJob, c as updateReview, cn as resolveModel, ct as writePortPreference, dn as writeAgentPreference, et as PACKAGE_NAME, f as UpdateAlreadyRunningError, fn as CONFIG_PATH, ft as checkReview, g as recordKissRun, gn as agentById, gt as isTerminal, hn as DEFAULT_AGENT_ID, i as liveJobsFor, in as resolveTarget, it as MIN_WORKSPACE_PORT, lt as forgeResolver, m as runningJobs, mn as AGENT_IDS, n as deleteReview$1, nt as DEFAULT_WORKSPACE_PORT, on as git, p as liveUpdateFor, pn as STORE_ROOT, pt as allJobs, q as reviewsUrl, rt as MAX_WORKSPACE_PORT, sn as resolveAgent, st as statedWorkspacePort, un as readAgentPreference, v as reanalyseReview, vn as detectAgents, w as telemetryUploadConsent, wt as driverGone, xt as progressSteps, y as runJob, yt as PHASES, z as removeWorktree, zt as saveWorkspace } from "./delete_review-Kup1LXD_.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";
@@ -705,11 +705,17 @@ function madeAgainst(requested) {
 	const wanted = displayRef(requested);
 	return (review) => review.baseRef !== "" && displayRef(review.baseRef) === wanted;
 }
-/** Whether the job behind a stored review is still working. A review with no job never was. */
+/**
+* Whether the job behind a stored review is still working. A review with no job never was.
+*
+* A job whose driver has gone is not working, whatever phase its record was left at. Calling it in
+* progress told the reviewer who had just closed a terminal that there was "nothing to do but wait",
+* for a process that no longer existed, until the sweep called it failed half an hour later.
+*/
 function isRunning(jobId) {
 	if (!jobId) return false;
 	const job = loadJob(jobId);
-	return !!job && !isTerminal(job);
+	return !!job && !isTerminal(job) && !driverGone(job.id);
 }
 /**
 * What the review is of, as the clause both surfaces hang off "Made two hours ago".
@@ -1264,7 +1270,7 @@ function unknownAgent(id, known) {
 * mistake; `Open workspace now` and `Review ready` read as a beginning and an end.
 */
 function startedReview(url, _target) {
-	return [`Open workspace now  ${url}`, "The review continues if this terminal closes."].join("\n");
+	return [`Open workspace now  ${url}`, "Keep this terminal open while it runs. If it closes, run the same command again to carry on."].join("\n");
 }
 /**
 * The one-review-per-branch rule, said to a person rather than to a session.
@@ -1517,8 +1523,9 @@ function commitReviewCannotUpdate(sha) {
 * Said before the update starts, so the command answers at once and the link is there to open while
 * it works. The same label the creation path uses, because it is the same offer.
 *
-* Not "continues if this terminal closes", which the creation path can say and this cannot: the
-* update runs in this process, so closing the terminal stops it.
+* Without the creation path's line about carrying on if the terminal closes. An update runs in this
+* process and ends with it, and running the command again starts the update over rather than
+* picking one up, because `liveUpdateFor` reads a dead driver as nothing running.
 */
 function startedUpdate(url, acted) {
 	return `${subjectLine(acted)}\nOpen workspace now  ${url}`;
@@ -2178,8 +2185,10 @@ function describe(deps, id) {
 * One thing differs, and it is a property of the surface rather than of the review. An MCP tool
 * returns to a session that must not sit and wait, so it fires `runJob` and returns the link at
 * once. A person who typed a command is already waiting, so this awaits the job and reports what
-* it is doing. Either way the job is durable and either way the link works from the moment it is
-* printed, so a terminal closed halfway through loses nothing.
+* it is doing. Either way the job is durable and the link works from the moment it is printed. The
+* job does not outlive this process, though: the agent shares the terminal's process group, so a
+* terminal closed halfway through ends both. What it loses is time, not work. The claim it leaves
+* behind is `driverGone`, and running the command again carries on from the phase it reached.
 *
 * **Two axes, and this file is where they meet.** A command names a target and an operation, and
 * the operations are `update` and `reanalyse`, which were `prreviewbuddy update` until 0.15.0.
@@ -2480,15 +2489,19 @@ function makeCommandFor(command) {
 	if (command.commitRef) return `prreviewbuddy review --commit ${command.commitRef}`;
 	return "prreviewbuddy review";
 }
+/** Why an unfinished review is being picked up, when nothing recorded a failure because nothing could. */
+var DRIVER_GONE = "the command that was running it ended before it finished, most often because its terminal closed.";
 function failureOf(workspaceId) {
 	const workspace = loadWorkspace(workspaceId);
 	if (!workspace?.jobId) return null;
 	const job = loadJob(workspace.jobId);
-	if (!job || !isTerminal(job) || job.phase !== "failed") return null;
+	if (!job) return null;
+	const abandoned = !isTerminal(job) && driverGone(job.id);
+	if (!abandoned && (!isTerminal(job) || job.phase !== "failed")) return null;
 	if (isClaimed(job.id)) return null;
 	return {
-		message: job.failure?.message ?? "The reason was not recorded.",
-		stopped: job.failure?.stopped === true,
+		message: abandoned ? DRIVER_GONE : job.failure?.message ?? "The reason was not recorded.",
+		stopped: !abandoned && job.failure?.stopped === true,
 		agentId: job.env.agentId ?? DEFAULT_AGENT_ID,
 		...job.requestedModel ? { requestedModel: job.requestedModel } : {}
 	};
@@ -3202,8 +3215,7 @@ async function cleanUp(options) {
 *
 * It stops the workspace server, which the help screen says on purpose there is no command to do.
 * That is not a hole in the rule but the end of it: "no command to stop the server" exists so that
-* a review outlives the terminal that asked for it, and there are no reviews left to outlive
-* anything here.
+* the workspace outlives the terminal that opened it, and there are no reviews left to serve here.
 *
 * What it does not do is remove its own npm package. A running binary deleting the install it is
 * executing from depends on which package manager put it there and fails in ways that leave a