prreviewbuddy 0.27.2 → 0.29.1

package/CHANGELOG.md

@@ -1,5 +1,55 @@
 # Changelog
 
+## 0.29.1
+
+**Icons in the review sidebar.** Every item in a review's sidebar now has an icon: Review, KISS,
+Issues, Questions, Files, PR context, Diagrams, Recommendations, and the links at the bottom. All
+reviews and Settings had small text symbols before; they now have full-size icons like the rest.
+The themes in the review path keep their numbers.
+
+**Review path themes start collapsed.** On a review's path page, each theme now opens folded to
+its title, priority and size, so you can see the whole path at a glance. Click a theme to open it,
+or choose it in the sidebar to jump straight to it opened.
+
+## 0.29.0
+
+**Filter your reviews by author.** The reviews list has a dropdown beside the search that lists
+everyone whose pull requests you have reviewed. Choose someone and the list shows only their
+reviews. It works together with the filters beside it, so you can see, say, everything of one
+person's that is still in progress. Reviews of a local branch with no pull request have no GitHub
+username, so they show under Everyone only.
+
+**Mark a review reviewed from the list.** Each review's menu in the reviews list now has Mark
+reviewed, so you no longer have to open a review to mark it. Once it is reviewed, the same menu
+offers Mark in progress to undo it. As before, marking a review reviewed takes it out of your
+review queue.
+
+**Delete a review from its own page.** The menu at the top of a review now has Delete review,
+with the same confirmation the list uses. It deletes only the review you are looking at, not
+earlier reviews of the same branch, and then takes you back to your reviews. A review that is
+still being analysed cannot be deleted.
+
+**Easier to scan sidebar.** In a review's sidebar, Issues, Questions, Files, PR context and the
+links at the bottom are now white, so the review path above them stands out as its own list.
+
+## 0.28.0
+
+**Save a review, and work through a queue.** The star on each review in your reviews list now
+means Saved. A saved review still sits at the top of the list, and the new Saved filter shows only
+those. For a batch you are working through right now, choose Add to review queue from a review's
+menu: the Queue filter lists them in the order you added them, and Continue reviewing at the top of
+the list opens the first one. Marking a review Reviewed takes it out of the queue. Moving it back
+to In progress does not put it back, so the queue only ever holds what you chose to put there.
+
+**Saved and queued reviews are kept for ninety days.** Other reviews are still kept for thirty
+days. The ninety days count from the last time you opened the review, so one you keep coming back
+to stays. A saved review is not kept forever: after ninety days without being opened it is removed
+like any other.
+
+**A saved review no longer disappears from the list.** The list shows your fifty most recent
+branches, and a review saved or queued further back than that used to be missing from it
+altogether. Saved and queued reviews are now always listed, in addition to the fifty most recent.
+
 ## 0.27.2
 
 **Choose the model a review runs under.** `prreviewbuddy review --model <model>` asks the agent for

package/dist/{delete_review-B3xciJ03.js → delete_review-DUCSC5Bc.js}

@@ -3651,10 +3651,135 @@ function doneVerb(counts) {
 	return counts.reviewerClosed > 0 ? "dealt with" : "resolved";
 }
 //#endregion
+//#region ../../packages/review-harness/src/workspace/queue.ts
+/**
+* The review queue: the set the reviewer is working through now, in the order they chose.
+*
+* **Its own file, not a field on `StoredWorkspace`.** The reason is already written at the top of
+* `store.ts`'s save path: every caller puts back a record it loaded earlier, `runJob` holds one for
+* an entire analysis, and the write clobbers whatever changed in between without saying so. Queue
+* membership changed from the index while an analysis was running would simply vanish. A record
+* also carries the whole diff inline, so a reorder would rewrite megabytes to move one string.
+*
+* **Not a key in `ui.json` either**, despite being reviewer state of exactly the kind that file
+* describes. `preferences.ts` read-modify-writes that file whole, and one unparsable byte in there
+* currently costs a pane width. Sharing it would make the same byte cost the working set.
+*
+* `STORE_ROOT` comes from `store_root.ts` rather than from `store.ts`, which is the import
+* `preferences.ts` uses. That one is safe only because nothing in `store.ts` imports preferences
+* back -- and the prune in there *does* import this module, so taking the same shortcut here would
+* close the cycle.
+*/
+var QUEUE_PATH = join(STORE_ROOT, "queue.json");
+/**
+* An object rather than a bare array, because an array is the one JSON shape that cannot grow a
+* sibling field, and "when was this queued" is a plausible second column.
+*
+* `version` is not branched on today. It exists so that a later shape change is a decision rather
+* than a guess about what an old file meant.
+*/
+var VERSION = 1;
+/**
+* What is queued, in order.
+*
+* Best-effort in the same way as `readPreferences`, and for the same reason: missing, unreadable
+* and corrupt all mean "nothing queued", and none of them is worth an error standing between the
+* reviewer and the list. Position is the array index throughout -- never stored per entry, because
+* two representations of one order eventually disagree about it.
+*/
+function readQueue() {
+	try {
+		const parsed = JSON.parse(readFileSync(QUEUE_PATH, "utf8"));
+		if (!parsed || typeof parsed !== "object" || Array.isArray(parsed)) return [];
+		const ids = parsed.ids;
+		return Array.isArray(ids) ? normalise(ids) : [];
+	} catch {
+		return [];
+	}
+}
+/**
+* Store a queue, and say what was stored.
+*
+* The return is what landed on disk, which is not necessarily what was handed in -- duplicates are
+* collapsed and the cap applies. Same contract as the prompt bank: the caller gets the list as
+* stored so a page can paint the truth rather than its own request.
+*
+* `null` on a write failure, and that is the point at which this stops resembling `preferences.ts`.
+* A pane width that fails to save costs one session and nothing depends on it. A queue entry that
+* fails to save is contradicted by a pill showing a count and by a button that navigates somewhere,
+* so the caller has to be able to tell the reviewer it did not happen.
+*/
+function writeQueue(ids) {
+	const next = normalise(ids);
+	try {
+		mkdirSync(STORE_ROOT, { recursive: true });
+		writeFileSync(QUEUE_PATH, `${JSON.stringify({
+			version: VERSION,
+			ids: next
+		}, null, 2)}\n`);
+		return next;
+	} catch {
+		return null;
+	}
+}
+/**
+* Append, and leave a review already queued exactly where it is.
+*
+* Adding something twice is a no-op rather than a move. Nothing in this UI reorders a queue, so a
+* second Add that silently promoted a review would be the only control in the product that did --
+* and it would do it without ever saying so.
+*/
+function queueAdd(id) {
+	const current = readQueue();
+	if (current.includes(id)) return current;
+	return writeQueue([...current, id]);
+}
+function queueRemove(id) {
+	const current = readQueue();
+	if (!current.includes(id)) return current;
+	return writeQueue(current.filter((queued) => queued !== id));
+}
+/**
+* The invariant, as one named thing: the queue holds unfinished work only.
+*
+* Removing on completion is half of it. The other half is that this **does nothing** when
+* `complete` is false, and that half only exists as a written rule -- there is no line of code for
+* it to be visible in. Re-adding there would make membership something inferred from status rather
+* than chosen, so a reviewer who took a review out of the queue and later moved it back to In
+* progress would find it queued again with no idea why.
+*/
+function dequeueOnComplete(id, complete) {
+	if (!complete) return;
+	queueRemove(id);
+}
+/**
+* A token for the index's revision, equality only.
+*
+* The queue changes only when a person deliberately changes it, so unlike a running job's progress
+* this cannot make the page reload itself in a loop. Absent reads as a stable empty string rather
+* than as a change, for the reason `refreshAction` gives: a missing field that reads as "different"
+* is a reload that asks again and reloads again.
+*/
+function queueStamp() {
+	try {
+		return String(statSync(QUEUE_PATH).mtimeMs);
+	} catch {
+		return "";
+	}
+}
+/** Strings only, first position wins, and never more than the cap. */
+function normalise(ids) {
+	const seen = [];
+	for (const id of ids) {
+		if (typeof id !== "string" || id === "" || seen.includes(id)) continue;
+		seen.push(id);
+		if (seen.length === 50) break;
+	}
+	return seen;
+}
+//#endregion
 //#region ../../packages/review-harness/src/workspace/store.ts
 var WORKSPACES_DIR = join(STORE_ROOT, "workspaces");
-/** Reviews older than this are cleared on write. A review of a branch from a month ago is history. */
-var MAX_AGE_MS = 2592e6;
 function workspacePath(id) {
 	return join(WORKSPACES_DIR, `${id}.json`);
 }
@@ -3944,14 +4069,38 @@ function followedRefName(branch, followedRef) {
 	return followedRef;
 }
 /**
-* The index's list: one entry per branch, each carrying its own history.
+* The index's list: recent branches, plus the ones the reviewer explicitly kept.
+*
+* `recentReviewGroups` above is a pure recency window, and it stays that way because other callers
+* want exactly that. This is the index's own question, and it is a different one, because Saved and
+* Queue exist to defeat recency: a review saved three weeks ago has to be reachable from the list
+* or the pill that claims to show it is simply broken.
+*
+* **Two windows, and the page shows their sum.** Drawing both from one limit would mean saving
+* eleven reviews pushed eleven recent ones off the page -- the working set eating the list it was
+* added to. So `limit` bounds recency, `keptLimit` bounds what was kept, and the most cards this
+* can return is the two added together. Neither constant says that on its own, which is why it is
+* said here.
+*/
+function indexReviewGroups(limit, keptLimit, keptIds) {
+	return selectIndexGroups(groupByLineage(recentWorkspaces(Number.MAX_SAFE_INTEGER)), limit, keptLimit, keptIds);
+}
+/**
+* The choosing, with the disk left out, in the same spirit as `groupByLineage` next door.
+*
+* Membership is tested against a group's **whole history** rather than its newest review. A pin is
+* written on whichever review the star was clicked on, so a review saved and then re-analysed
+* carries its pin on the older entry; asking only `latest` would lose the card at exactly the
+* moment the reviewer was most likely to want it.
 *
-* The limit counts branches rather than reviews, and the grouping happens before it rather than
-* after. Limiting first and grouping second would show a card claiming "2 reviews" for a branch
-* that has five, which is worse than showing no count at all.
+* The kept side is capped for the same reason the recent side is: `queue.json` is a file on a disk
+* somebody can edit, and an uncapped read of it is an index with five thousand cards on it.
 */
-function recentReviewGroups(limit = 10) {
-	return groupByLineage(recentWorkspaces(Number.MAX_SAFE_INTEGER)).slice(0, limit);
+function selectIndexGroups(groups, limit, keptLimit, keptIds) {
+	const kept = [];
+	const rest = [];
+	for (const group of groups) (group.history.some((review) => keptIds.has(review.id)) ? kept : rest).push(group);
+	return [...rest.slice(0, limit), ...kept.slice(0, keptLimit)].sort((a, b) => b.latest.createdAt - a.latest.createdAt);
 }
 /**
 * The grouping itself, with the disk left out.
@@ -4076,7 +4225,8 @@ function summarise(workspace) {
 		paths: files.slice(0, MAX_INDEXED_PATHS).map((file) => file.name),
 		prNumber: workspace.changeSet.data.pullRequest?.number || workspace.prContext?.pullRequest.number,
 		commitSha: workspace.session.metadata?.commitSha || void 0,
-		author: describeAuthorship(workspace.changeSet, workspace.prContext?.pullRequest)?.label
+		author: describeAuthorship(workspace.changeSet, workspace.prContext?.pullRequest)?.label,
+		authorHandle: workspace.prContext?.pullRequest.author?.handle || void 0
 	};
 }
 /**
@@ -4185,14 +4335,53 @@ function touchWorkspace(workspace) {
 		saveWorkspace(workspace);
 	} catch {}
 }
+/**
+* Housekeeping, in two tiers.
+*
+* The cheap gate comes first: anything inside the ordinary window is not a candidate under either
+* tier, so the great majority of files never reach the read below. Only those already past thirty
+* days pay for a parse -- and a parse here is over a record holding an entire diff, which is why
+* that ordering is load-bearing rather than tidy.
+*
+* The loop walks the directory without filtering by extension, which is what makes the suffix rule
+* matter: `<id>.tokens.jsonl` ages on its own mtime, and stripping only `.json` would leave a saved
+* review holding its record while its usage history was quietly deleted from under it. The tier
+* belongs to the review, not to the file.
+*
+* Exported for `retention.test.ts`. It is a real unit with a rule worth stating in cases, and the
+* alternative -- reaching it only through `createWorkspace` -- would test the retention policy
+* through a function that exists to do something else.
+*/
 function pruneOldWorkspaces() {
 	try {
+		const queued = new Set(readQueue());
 		for (const entry of readdirSync(WORKSPACES_DIR)) {
 			const path = join(WORKSPACES_DIR, entry);
-			if (Date.now() - statSync(path).mtimeMs > MAX_AGE_MS) unlinkSync(path);
+			const age = Date.now() - statSync(path).mtimeMs;
+			if (age <= 2592e6) continue;
+			if (age <= 7776e6 && isKept(entry, queued)) continue;
+			unlinkSync(path);
 		}
 	} catch {}
 }
+/**
+* Whether the reviewer said to keep this one, asked of a directory entry rather than of a record.
+*
+* A record that will not parse cannot claim to be saved, so it falls to the ordinary window. That
+* is the safe direction: the alternative keeps unreadable files for three months on the strength of
+* a question nobody could answer.
+*/
+function isKept(entry, queued) {
+	const id = workspaceIdFrom(entry);
+	if (id === null) return false;
+	if (queued.has(id)) return true;
+	return loadWorkspace(id)?.pinned === true;
+}
+/** The review an entry belongs to, whether it is the record or the usage sidecar beside it. */
+function workspaceIdFrom(entry) {
+	for (const suffix of [".tokens.jsonl", ".json"]) if (entry.endsWith(suffix)) return entry.slice(0, -suffix.length);
+	return null;
+}
 //#endregion
 //#region ../../packages/review-harness/src/workspace/exclusive_claim.ts
 /**
@@ -11383,4 +11572,4 @@ function lineageIds(id) {
 	return [.../* @__PURE__ */ new Set([id, ...lineage.map((review) => review.id)])];
 }
 //#endregion
-export { fillFileUrlTemplate as $, agentFor as $t, removeWorktree as A, workspaceRevision as At, workspaceUrl as B, resolveTarget as Bt, recordTelemetryUploadConsent as C, recentReviewGroups as Ct, ReviewBeingDeletedError as D, saveWorkspace as Dt, EXPLAIN_SIMPLY_PROMPT as E, reviewedRepositories as Et, clearServerRecord as F, issuesOutstanding as Ft, DEFAULT_WORKSPACE_PORT as G, clearAgentPreference as Gt, BUILD_VERSION as H, git as Ht, ensureServer as I, questionsOutstanding as It, parseWorkspacePort as J, CONFIG_PATH as Jt, MAX_WORKSPACE_PORT as K, readAgentPreference as Kt, readServerRecord as L, reviewerDispositions as Lt, relativeTime as M, doneVerb as Mt, readIndexToken as N, isIssueOutstanding as Nt, MANAGED_ROOT as O, summarise as Ot, bootstrapUrl as P, isQuestionOutstanding as Pt, forgeResolver as Q, agentById as Qt, reviewsUrl as R, processDiscussion as Rt, record as S, previousKissResult as St, withUsageRecorded as T, reviewedCommit as Tt, PACKAGE_NAME as U, resolveAgent as Ut, writeServerRecord as V, displayRef as Vt, feedbackUrl as W, resolveModel as Wt, statedWorkspacePort as X, AGENT_IDS as Xt, resolveWorkspacePort as Y, STORE_ROOT as Yt, writePortPreference as Z, DEFAULT_AGENT_ID as Zt, startKissJob as _, lineageKeyFor as _t, wasBlocked as a, isTerminal as at, startJob as b, matchingWorkspaceIds as bt, updateReview as c, PHASES as ct, askCheckout as d, purposeOf as dt, detectAgents as en, checkCodeFreshness as et, UpdateAlreadyRunningError as f, clearClaim as ft, recordKissRun as g, latestKissRun as gt, agentEnvOf as h, groupByLineage as ht, liveJobsFor as i, fail as it, modelHelpLines as j, workspaceStamps as jt, readMarker as k, touchWorkspace as kt, refreshPrContext as l, phasesFor as lt, runningJobs as m, followedRefName as mt, deleteReview as n, AgentUnavailableError as nn, allJobs as nt, discardJob as o, loadJob as ot, liveUpdateFor as p, isClaimed as pt, MIN_WORKSPACE_PORT as q, writeAgentPreference as qt, lineageIds as r, endedAt as rt, RefreshUnavailableError as s, saveJob as st, deleteLineage as t, AgentCancelledError as tn, checkFreshness as tt, isUnchanged as u, progressSteps as ut, reanalyseReview as v, lineagePosition as vt, telemetryUploadConsent as w, recentWorkspaces as wt, readEvents as x, positionInLineage as xt, runJob as y, loadWorkspace as yt, stopServer as z, describeAuthorship as zt };
+export { fillFileUrlTemplate as $, writeAgentPreference as $t, removeWorktree as A, workspaceRevision as At, workspaceUrl as B, isQuestionOutstanding as Bt, recordTelemetryUploadConsent as C, previousKissResult as Ct, ReviewBeingDeletedError as D, saveWorkspace as Dt, EXPLAIN_SIMPLY_PROMPT as E, reviewedRepositories as Et, clearServerRecord as F, queueStamp as Ft, DEFAULT_WORKSPACE_PORT as G, describeAuthorship as Gt, BUILD_VERSION as H, questionsOutstanding as Ht, ensureServer as I, readQueue as It, parseWorkspacePort as J, git as Jt, MAX_WORKSPACE_PORT as K, resolveTarget as Kt, readServerRecord as L, writeQueue as Lt, relativeTime as M, dequeueOnComplete as Mt, readIndexToken as N, queueAdd as Nt, MANAGED_ROOT as O, summarise as Ot, bootstrapUrl as P, queueRemove as Pt, forgeResolver as Q, readAgentPreference as Qt, reviewsUrl as R, doneVerb as Rt, record as S, positionInLineage as St, withUsageRecorded as T, reviewedCommit as Tt, PACKAGE_NAME as U, reviewerDispositions as Ut, writeServerRecord as V, issuesOutstanding as Vt, feedbackUrl as W, processDiscussion as Wt, statedWorkspacePort as X, resolveModel as Xt, resolveWorkspacePort as Y, resolveAgent as Yt, writePortPreference as Z, clearAgentPreference as Zt, startKissJob as _, latestKissRun as _t, wasBlocked as a, agentFor as an, isTerminal as at, startJob as b, loadWorkspace as bt, updateReview as c, AgentUnavailableError as cn, PHASES as ct, askCheckout as d, purposeOf as dt, CONFIG_PATH as en, checkCodeFreshness as et, UpdateAlreadyRunningError as f, clearClaim as ft, recordKissRun as g, indexReviewGroups as gt, agentEnvOf as h, groupByLineage as ht, liveJobsFor as i, agentById as in, fail as it, modelHelpLines as j, workspaceStamps as jt, readMarker as k, touchWorkspace as kt, refreshPrContext as l, phasesFor as lt, runningJobs as m, followedRefName as mt, deleteReview as n, AGENT_IDS as nn, allJobs as nt, discardJob as o, detectAgents as on, loadJob as ot, liveUpdateFor as p, isClaimed as pt, MIN_WORKSPACE_PORT as q, displayRef as qt, lineageIds as r, DEFAULT_AGENT_ID as rn, endedAt as rt, RefreshUnavailableError as s, AgentCancelledError as sn, saveJob as st, deleteLineage as t, STORE_ROOT as tn, checkFreshness as tt, isUnchanged as u, progressSteps as ut, reanalyseReview as v, lineageKeyFor as vt, telemetryUploadConsent as w, recentWorkspaces as wt, readEvents as x, matchingWorkspaceIds as xt, runJob as y, lineagePosition as yt, stopServer as z, isIssueOutstanding as zt };

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { A as removeWorktree, B as workspaceUrl, Bt as resolveTarget, C as recordTelemetryUploadConsent, Dt as saveWorkspace, Et as reviewedRepositories, G as DEFAULT_WORKSPACE_PORT, H as BUILD_VERSION, Ht as git, I as ensureServer, J as parseWorkspacePort, Jt as CONFIG_PATH, K as MAX_WORKSPACE_PORT, Kt as readAgentPreference, M as relativeTime, N as readIndexToken, O as MANAGED_ROOT, Ot as summarise, P as bootstrapUrl, Q as forgeResolver, Qt as agentById, R as reviewsUrl, S as record, U as PACKAGE_NAME, Ut as resolveAgent, Vt as displayRef, Wt as resolveModel, X as statedWorkspacePort, Xt as AGENT_IDS, Yt as STORE_ROOT, Z as writePortPreference, Zt as DEFAULT_AGENT_ID, _t as lineageKeyFor, a as wasBlocked, at as isTerminal, b as startJob, bt as matchingWorkspaceIds, c as updateReview, ct as PHASES, dt as purposeOf, en as detectAgents, f as UpdateAlreadyRunningError, ft as clearClaim, g as recordKissRun, ht as groupByLineage, i as liveJobsFor, j as modelHelpLines, k as readMarker, m as runningJobs, mt as followedRefName, n as deleteReview$1, nt as allJobs, ot as loadJob, p as liveUpdateFor, pt as isClaimed, q as MIN_WORKSPACE_PORT, qt as writeAgentPreference, tt as checkFreshness, ut as progressSteps, v as reanalyseReview, w as telemetryUploadConsent, wt as recentWorkspaces, xt as positionInLineage, y as runJob, yt as loadWorkspace, z as stopServer } from "./delete_review-B3xciJ03.js";
+import { $t as writeAgentPreference, A as removeWorktree, B as workspaceUrl, C as recordTelemetryUploadConsent, Dt as saveWorkspace, Et as reviewedRepositories, G as DEFAULT_WORKSPACE_PORT, H as BUILD_VERSION, I as ensureServer, J as parseWorkspacePort, Jt as git, K as MAX_WORKSPACE_PORT, Kt as resolveTarget, M as relativeTime, N as readIndexToken, O as MANAGED_ROOT, Ot as summarise, P as bootstrapUrl, Q as forgeResolver, Qt as readAgentPreference, R as reviewsUrl, S as record, St as positionInLineage, U as PACKAGE_NAME, X as statedWorkspacePort, Xt as resolveModel, Yt as resolveAgent, Z as writePortPreference, a as wasBlocked, at as isTerminal, b as startJob, bt as loadWorkspace, c as updateReview, ct as PHASES, dt as purposeOf, en as CONFIG_PATH, f as UpdateAlreadyRunningError, ft as clearClaim, g as recordKissRun, ht as groupByLineage, i as liveJobsFor, in as agentById, j as modelHelpLines, k as readMarker, m as runningJobs, mt as followedRefName, n as deleteReview$1, nn as AGENT_IDS, nt as allJobs, on as detectAgents, ot as loadJob, p as liveUpdateFor, pt as isClaimed, q as MIN_WORKSPACE_PORT, qt as displayRef, rn as DEFAULT_AGENT_ID, tn as STORE_ROOT, tt as checkFreshness, ut as progressSteps, v as reanalyseReview, vt as lineageKeyFor, w as telemetryUploadConsent, wt as recentWorkspaces, xt as matchingWorkspaceIds, y as runJob, z as stopServer } from "./delete_review-DUCSC5Bc.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";