prreviewbuddy 0.25.13 → 0.27.2

package/dist/server.js

@@ -1,4 +1,4 @@
-import { $ as checkCodeFreshness, $t as AgentCancelledError, A as liveUpdateFor, At as workspaceStamps, B as recordTelemetryUploadConsent, C as writePortPreference, D as isUnchanged, E as refreshPrContext, Et as saveWorkspace, Ft as questionsOutstanding, G as withUsageRecorded, Gt as writeAgentPreference, H as BUILD_VERSION, I as runJob, It as reviewerDispositions, J as fillFileUrlTemplate, Jt as AGENT_IDS, K as EXPLAIN_SIMPLY_PROMPT, Lt as processDiscussion, M as agentEnvOf, Mt as isIssueOutstanding, Nt as isQuestionOutstanding, O as askCheckout, Ot as touchWorkspace, P as startKissJob, Pt as issuesOutstanding, Q as removeWorktree, R as readEvents, Rt as describeAuthorship, S as statedWorkspacePort, St as recentReviewGroups, T as updateReview, Ut as clearAgentPreference, V as telemetryUploadConsent, Vt as git, W as feedbackUrl, Wt as readAgentPreference, X as MANAGED_ROOT, Y as ReviewBeingDeletedError, Z as readMarker, Zt as agentFor, _ as DEFAULT_WORKSPACE_PORT, _t as lineagePosition, a as liveJobsFor, at as loadJob, b as parseWorkspacePort, c as readIndexToken, ct as phasesFor, en as AgentUnavailableError, et as checkFreshness, f as readServerRecord, ft as isClaimed, g as writeServerRecord, ht as latestKissRun, i as lineageIds, it as isTerminal, jt as doneVerb, k as UpdateAlreadyRunningError, kt as workspaceRevision, lt as progressSteps, n as deleteLineage, nt as endedAt, o as wasBlocked, ot as saveJob, pt as followedRefName, qt as STORE_ROOT, r as deleteReview, rt as fail, s as discardJob, t as relativeTime$1, tt as allJobs, u as clearServerRecord, ut as purposeOf, v as MAX_WORKSPACE_PORT, vt as loadWorkspace, w as RefreshUnavailableError, wt as reviewedCommit, x as resolveWorkspacePort, xt as previousKissResult, y as MIN_WORKSPACE_PORT, z as record } from "./relative_time-vn8Ex9E8.js";
+import { $ as fillFileUrlTemplate, $t as agentFor, A as removeWorktree, At as workspaceRevision, C as recordTelemetryUploadConsent, Ct as recentReviewGroups, D as ReviewBeingDeletedError, Dt as saveWorkspace, E as EXPLAIN_SIMPLY_PROMPT, F as clearServerRecord, Ft as issuesOutstanding, G as DEFAULT_WORKSPACE_PORT, Gt as clearAgentPreference, H as BUILD_VERSION, Ht as git, It as questionsOutstanding, J as parseWorkspacePort, K as MAX_WORKSPACE_PORT, Kt as readAgentPreference, L as readServerRecord, Lt as reviewerDispositions, M as relativeTime$1, Mt as doneVerb, N as readIndexToken, Nt as isIssueOutstanding, O as MANAGED_ROOT, Pt as isQuestionOutstanding, Rt as processDiscussion, S as record, St as previousKissResult, T as withUsageRecorded, Tt as reviewedCommit, V as writeServerRecord, W as feedbackUrl, Wt as resolveModel, X as statedWorkspacePort, Xt as AGENT_IDS, Y as resolveWorkspacePort, Yt as STORE_ROOT, Z as writePortPreference, _ as startKissJob, a as wasBlocked, at as isTerminal, c as updateReview, d as askCheckout, dt as purposeOf, et as checkCodeFreshness, f as UpdateAlreadyRunningError, gt as latestKissRun, h as agentEnvOf, i as liveJobsFor, it as fail, jt as workspaceStamps, k as readMarker, kt as touchWorkspace, l as refreshPrContext, lt as phasesFor, mt as followedRefName, n as deleteReview, nn as AgentUnavailableError, nt as allJobs, o as discardJob, ot as loadJob, p as liveUpdateFor, pt as isClaimed, q as MIN_WORKSPACE_PORT, qt as writeAgentPreference, r as lineageIds, rt as endedAt, s as RefreshUnavailableError, st as saveJob, t as deleteLineage, tn as AgentCancelledError, tt as checkFreshness, u as isUnchanged, ut as progressSteps, vt as lineagePosition, w as telemetryUploadConsent, x as readEvents, y as runJob, yt as loadWorkspace, zt as describeAuthorship } from "./delete_review-B3xciJ03.js";
 import { isAbsolute, join, relative, resolve } from "node:path";
 import { existsSync, mkdirSync, readFileSync, readdirSync, statSync, writeFileSync } from "node:fs";
 import { createHash, timingSafeEqual } from "node:crypto";
@@ -571,6 +571,119 @@ function humanizeModelId(id) {
 	return display;
 }
 //#endregion
+//#region ../../packages/review-harness/src/domain/utils/agent_label.ts
+/**
+* What a person is shown when a review names the tool that produced it.
+*
+* Here in the domain rather than read off `AgentIdentity.displayName`, because this runs in the
+* extension bundle and the adapter registry reaches `node:child_process`. Deriving the label from
+* the stored `agentId` keeps the client free of node builtins and adds no stored field.
+*
+* A closed set of this product's own adapter ids, which is not the kind of table that goes stale
+* invisibly: adding an adapter is our own act, and anything unrecognised still renders through
+* `humanizeModelId` rather than disappearing. That is why this is not folded into
+* `humanizeModelId` itself, whose value is knowing nothing about which names exist.
+*/
+var AGENT_DISPLAY_NAMES = {
+	claude: "Claude Code",
+	codex: "Codex",
+	gemini: "Gemini CLI"
+};
+/**
+* Absent reads as Claude, matching `agentIdOf` and `agentName`: a session written before agents
+* were selectable ran under Claude, and showing it as unknown would invent a gap in the oldest
+* reviews on disk.
+*/
+var DEFAULT_AGENT_DISPLAY_NAME = AGENT_DISPLAY_NAMES.claude;
+function agentDisplayName(agentId) {
+	if (!agentId) return DEFAULT_AGENT_DISPLAY_NAME;
+	return AGENT_DISPLAY_NAMES[agentId] ?? humanizeModelId(agentId);
+}
+//#endregion
+//#region ../../packages/review-harness/src/domain/ai_review/model_provenance.ts
+/**
+* Values `model` carried when it meant "which agent", before the field was frozen.
+*
+* A closed set of three of our own historical strings, not a catalogue of vendor models, so it
+* never grows and never goes stale. It lives here rather than in `humanizeModelId` on purpose:
+* the corruption belongs to how sessions were once written, and that label function's whole value
+* is knowing nothing about which models exist.
+*/
+var LEGACY_AGENT_IDS = /* @__PURE__ */ new Set([
+	"codex",
+	"claude-code",
+	"gemini-cli"
+]);
+var present = (value) => typeof value === "string" && value !== "" ? value : null;
+function modelProvenanceOf(session) {
+	return {
+		requestedModel: present(session.requestedModel) ?? legacyModel(session.model),
+		observedModel: present(session.observedModel),
+		agentVersion: present(session.agentVersion)
+	};
+}
+/**
+* A legacy `model`, read as a request or discarded.
+*
+* The extension put the model it was about to call into this field, so for its sessions the value
+* really is what was requested. The CLI put an agent id there, which is not a model at all and is
+* dropped rather than displayed: showing "Reviewed with Codex, model Codex" would be the record
+* inventing provenance out of its own filing.
+*/
+function legacyModel(model) {
+	const value = present(model);
+	if (value === null || LEGACY_AGENT_IDS.has(value)) return null;
+	return value;
+}
+/**
+* Whether a coding agent made this, as opposed to the extension calling a provider API.
+*
+* The awkward case is a session with no `agentId` at all, because two different producers leave it
+* empty. A CLI review from before agents were selectable means Claude, which is why
+* `agentDisplayName` defaults that way. An extension review means no agent ran at all, and naming
+* one would credit Claude Code for somebody's OpenAI review.
+*
+* The legacy sentinel tells them apart, which is the last job that field has: only the CLI ever
+* wrote one, so a record with no agent id and no sentinel came from the extension.
+*/
+function producedByAgent(session) {
+	if (session.agentId) return true;
+	const legacy = present(session.model);
+	return legacy !== null && LEGACY_AGENT_IDS.has(legacy);
+}
+/**
+* The full provenance, for the disclosure rather than the page.
+*
+* Opens with "Reviewed with X" rather than "Agent: X", keeping the sentence that was already here:
+* a review is not owned by an agent, it holds analyses, and this names the one being shown.
+*
+* The line that earns this list its place is the last one: a pinned model that nobody confirmed.
+* `--model X` states what we asked for, and on an agent that reports nothing back there is no way
+* to know it was honoured, so the pin is shown alongside the fact that it is unverified. Without
+* that line a reader would take a requested model for a measured one, which is the overstatement
+* this whole split exists to prevent.
+*
+* Said only when something was pinned. On an unpinned run there is no claim outstanding, and a
+* standing "not reported" would be noise on every review anybody ever runs.
+*
+* Both sentences that name an agent are withheld from a review no agent produced, through the same
+* `producedByAgent` distinction `attributionLabel` makes. An extension review has no agent id, and
+* naming one anyway credited Claude Code for somebody's OpenAI review and then reported that Claude
+* Code had not confirmed a model nobody had asked it for. What remains for such a review is the
+* model it requested and the model that answered, which is the whole of what is known about it.
+*/
+function provenanceDetailLines(session) {
+	const agent = producedByAgent(session) ? agentDisplayName(session.agentId) : null;
+	const { requestedModel, observedModel, agentVersion } = modelProvenanceOf(session);
+	return [
+		...agent ? [`Reviewed with ${agent}`] : [],
+		...agentVersion ? [`Agent version ${agentVersion}`] : [],
+		...requestedModel ? [`Requested model ${humanizeModelId(requestedModel)}`] : [],
+		...observedModel ? [`Reported model ${humanizeModelId(observedModel)}`] : [],
+		...agent && requestedModel && !observedModel ? [`Reported model not reported by ${agent}`] : []
+	];
+}
+//#endregion
 //#region ../../packages/review-harness/src/domain/ui/components/pill_tooltips.ts
 /**
 * What every pill in the sidebar actually means, in one place.
@@ -881,7 +994,8 @@ var CANCEL_BUTTON = `<button type="button" class="pr-helper-cancel-button">Cance
 function renderGeneratingOverview(session, iconUrl) {
 	const activeIndex = session.progress.findIndex((step) => !step.done);
 	const brandMark = iconUrl ? `<img src="${escapeHtml$1(iconUrl)}" class="pr-helper-brand-mark" alt="" />` : "";
-	const poweredByName = session.provider === "openai_compatible" ? humanizeModelId(session.model) : PROVIDER_DISPLAY_NAME[session.provider];
+	const pickedModel = modelProvenanceOf(session).requestedModel;
+	const poweredByName = session.provider === "openai_compatible" && pickedModel ? humanizeModelId(pickedModel) : PROVIDER_DISPLAY_NAME[session.provider];
 	const isThinking = activeIndex === 2;
 	return `
     <div class="pr-helper-generating pr-helper-generating-focused">
@@ -991,8 +1105,7 @@ function coverageDetails(session) {
 * agent: it holds analyses, and this names the one it is currently showing.
 */
 function agentDetails(session) {
-	const name = humanizeModelId(session.model);
-	return name ? [`Reviewed with ${name}`] : [];
+	return provenanceDetailLines(session);
 }
 /**
 * Everything the Analysis details disclosure says, as facts rather than as markup.
@@ -2220,6 +2333,9 @@ function phaseSentence(job) {
 function renderFailureBody(job, options = {}) {
 	if (!job.failure) return "";
 	const noun = isWorkPhase(job.failure.phase) ? PHASE_NOUN[job.failure.phase] : job.failure.phase;
+	if (job.failure.stopped) return `<p>${options.lead === false ? "" : "<strong>Review stopped.</strong> "}Nothing went wrong, and what it had finished is kept.</p>
+  <button type="button" class="prb-job-retry" data-job-retry>Carry on</button>
+  <p class="prb-job-note">It picks up from the ${escapeHtml$1(noun)}, not from the start.</p>`;
 	const next = job.failure.kind === "agent_authentication_failed" ? `<p class="prb-job-note">Signing that agent in is what changes this. Once it is signed in, update the review.</p>` : `<button type="button" class="prb-job-retry" data-job-retry>Retry</button>
   <p class="prb-job-note">Retry picks up from the ${escapeHtml$1(noun)}, not from the start.</p>`;
 	return `<p>${options.lead === false ? "" : "<strong>Review paused.</strong> "}${escapeHtml$1(job.failure.message)}</p>
@@ -2584,7 +2700,7 @@ function provenanceFacts(run) {
 		run.completedAt ? `Completed ${relativeTime$1(run.completedAt)}` : "",
 		`Commit ${run.reviewedSha.slice(0, 7)}`,
 		audienceSentence(run.audience),
-		run.agentId ? `Analysed by ${run.agentId}${run.model ? ` (${run.model})` : ""}` : "",
+		run.agentId ? `Analysed by ${agentDisplayName(run.agentId)}${modelSuffix(run)}` : "",
 		`Rubric version ${run.promptVersion}`
 	].filter((fact) => fact !== "");
 }
@@ -2725,6 +2841,22 @@ function renderLocationList(locations) {
     </button></li>`;
 	}).join("")}</ul>`;
 }
+/**
+* The model this run ran under, as far as it is known.
+*
+* Observed over requested, which is the precedence `attributionLabel` applies to a standard
+* review's line and the reason this reads `modelProvenanceOf` rather than a field: what the agent
+* said answered outranks what it was asked for, and only one of the two is ever a claim about what
+* actually happened. Neither known leaves the agent to stand alone rather than inventing a pin.
+*
+* `modelProvenanceOf` is also what keeps the frozen `model` out of here, which on a KISS run only
+* ever held an agent id: "Analysed by Codex (Codex)" was the shape that produced.
+*/
+function modelSuffix(run) {
+	const { requestedModel, observedModel } = modelProvenanceOf(run);
+	const model = observedModel ?? requestedModel;
+	return model ? ` (${humanizeModelId(model)})` : "";
+}
 //#endregion
 //#region ../../packages/review-harness/src/workspace/update_view.ts
 /**
@@ -3352,7 +3484,7 @@ function renderStandardViews(view, sections) {
 		detailsInHeader: true
 	})}</section>
       <section class="prb-view" data-view="guide" hidden>${renderGuideTab(session, null, null, { diagrams: true })}</section>
-      <section class="prb-view" data-view="diagram" hidden data-diagram-pane>
+      <section class="prb-view" data-view="diagram" hidden data-diagram-pane${view.pendingDiagram ? ` data-diagram-running="${escapeHtml$1(view.pendingDiagram.sectionId ?? "")}"` : ""}>
         <h3 class="prb-doc-title">Diagrams</h3>
         ${renderDiagrams(view.diagrams ?? [], sections, view.reviewedSha ?? null)}
       </section>
@@ -4058,6 +4190,9 @@ function renderShutdownDialog() {
 function renderAsk(view, sections) {
 	const suggestions = buildSuggestions(view, sections);
 	const transcript = view.transcript ?? [];
+	const pending = view.pendingAsk ?? null;
+	const pendingTurn = pending ? `<div class="prb-msg prb-msg-user">${escapeHtml$1(pending.question ?? "")}</div>
+      <div class="prb-thinking" data-ask-pending><i></i><i></i><i></i><span>Reading the change…</span></div>` : "";
 	return `<aside class="prb-ask" aria-label="Ask Buddy AI">
   <div
     class="prb-ask-resize"
@@ -4073,8 +4208,8 @@ function renderAsk(view, sections) {
   </div>
   ${renderPromptBank(view.prompts ?? [])}
   <div class="prb-ask-log" data-ask-log>
-    ${transcript.length > 0 ? transcript.map((exchange) => `<div class="prb-msg prb-msg-user">${escapeHtml$1(exchange.question)}</div>
-      <div class="prb-msg prb-msg-assistant prb-md">${renderMarkdown(exchange.answer)}${renderMessageCopySource(exchange.answer)}</div>`).join("") : `<div class="prb-ask-empty">
+    ${transcript.length > 0 || pending ? transcript.map((exchange) => `<div class="prb-msg prb-msg-user">${escapeHtml$1(exchange.question)}</div>
+      <div class="prb-msg prb-msg-assistant prb-md">${renderMarkdown(exchange.answer)}${renderMessageCopySource(exchange.answer)}</div>`).join("") + pendingTurn : `<div class="prb-ask-empty">
       <p>Ask about this change. Answers come from the review, the diff and the repository on disk — not from anywhere else.</p>
       ${suggestions.map((text) => `<button type="button" class="prb-suggestion" data-suggestion>${escapeHtml$1(text)}</button>`).join("")}
     </div>`}
@@ -4481,7 +4616,7 @@ function renderHistoryRow(review, number, latest, now) {
 */
 function renderAnalysisState(analysis) {
 	if (analysis === void 0) return "";
-	if (analysis.phase === "failed") return "<span class=\"prb-card-analysis\" data-analysis=\"stopped\">Analysis stopped</span>";
+	if (analysis.phase === "failed") return analysis.stopped ? "<span class=\"prb-card-analysis\" data-analysis=\"stopped\">Analysis stopped</span>" : "<span class=\"prb-card-analysis\" data-analysis=\"failed\">Analysis failed</span>";
 	return `<span class="prb-card-analysis" data-analysis="running"><i></i>${escapeHtml$1(phasesFor({ purpose: analysis.purpose })[analysis.phase].doing)}</span>`;
 }
 /**
@@ -4916,9 +5051,11 @@ function analysisStates(now = Date.now(), jobs = allJobs()) {
 			});
 			continue;
 		}
-		if (jobs.filter((job) => isTerminal(job) && purposeOf(job) === "review").sort(endedLast)[0]?.phase === "failed") states.set(reviewId, {
+		const ended = jobs.filter((job) => isTerminal(job) && purposeOf(job) === "review").sort(endedLast);
+		if (ended[0]?.phase === "failed") states.set(reviewId, {
 			phase: "failed",
-			purpose: "review"
+			purpose: "review",
+			...ended[0].failure?.stopped ? { stopped: true } : {}
 		});
 	}
 	return states;
@@ -4936,7 +5073,7 @@ function reviewsRevision(live = analysisStates()) {
 	for (const [id, revision] of workspaceStamps()) hash.update(`${id}:${revision}\n`);
 	for (const id of [...live.keys()].sort()) {
 		const state = live.get(id);
-		hash.update(`${id}@${state.purpose}:${state.phase}\n`);
+		hash.update(`${id}@${state.purpose}:${state.phase}${state.stopped ? ":stopped" : ""}\n`);
 	}
 	return hash.digest("base64url");
 }
@@ -4979,6 +5116,7 @@ var AskFailedError = class extends Error {};
 async function askAboutChange(workspace, question, sectionId, signal) {
 	const cwd = await askCheckout(workspace);
 	const env = agentEnvOf(workspace);
+	const requestedModel = resolveModel({ review: { session: workspace.session } }) ?? void 0;
 	try {
 		return extractAnswer(await withUsageRecorded(workspace.id, "ask", env, (onUsage) => agentFor(env).run({
 			capability: "read-code",
@@ -4986,10 +5124,11 @@ async function askAboutChange(workspace, question, sectionId, signal) {
 			cwd,
 			originRepoPath: workspace.repoPath,
 			env,
+			...requestedModel ? { requestedModel } : {},
 			timeoutMs: ASK_TIMEOUT_MS,
 			signal,
 			onUsage
-		})));
+		}), void 0, requestedModel));
 	} catch (error) {
 		if (error instanceof AgentUnavailableError) throw new AskUnavailableError(`${error.message} It is what this review was made with, so the assistant cannot answer.`);
 		throw explained(error, env);
@@ -5064,6 +5203,86 @@ function buildPrompt$1(workspace, question, sectionId, cwd) {
 	].join("\n");
 }
 //#endregion
+//#region ../../packages/review-harness/src/workspace/assistant_runs.ts
+var RUN_KINDS = ["ask", "diagram"];
+var runs = /* @__PURE__ */ new Map();
+function keyOf(workspaceId, kind) {
+	return `${workspaceId}:${kind}`;
+}
+/**
+* Start a run, or learn that one is already going.
+*
+* One call rather than a check followed by a start, so there is no gap between them for a second
+* request to fall through. The existing run comes back rather than a bare refusal because the
+* caller's next move is to show it, not to report an error.
+*
+* A stopped run gives up its place at once, though its handler may still be unwinding. Stop is
+* over for the reviewer when it answers, and the page reopens Ask then. A stopped run can keep
+* nothing, and `endRun` leaves a newer run alone, so the two cannot collide. An answered run still
+* holds its place until it is saved, or the next question would be asked without it.
+*/
+function beginRun(workspaceId, kind, detail, now = Date.now()) {
+	const key = keyOf(workspaceId, kind);
+	const existing = runs.get(key);
+	if (existing && existing.state !== "stopped") return { alreadyRunning: existing };
+	const controller = new AbortController();
+	const run = {
+		workspaceId,
+		kind,
+		question: detail.question ?? null,
+		sectionId: detail.sectionId,
+		startedAt: now,
+		signal: controller.signal,
+		state: "running",
+		controller
+	};
+	runs.set(key, run);
+	return { run };
+}
+/** Null for a stopped run as well: it is over for the page, whatever its handler is still doing. */
+function reportRun(workspaceId, kind) {
+	const run = runs.get(keyOf(workspaceId, kind));
+	if (!run || run.state === "stopped") return null;
+	return {
+		question: run.question,
+		sectionId: run.sectionId,
+		startedAt: run.startedAt
+	};
+}
+/**
+* The reviewer pressed Stop.
+*
+* Idempotent: a second press, a press after the answer landed, and a press with nothing running are
+* all harmless and all answer false. True only when this call is the one that stopped the run.
+*/
+function stopRun(workspaceId, kind) {
+	const run = runs.get(keyOf(workspaceId, kind));
+	if (!run || run.state !== "running") return false;
+	run.state = "stopped";
+	run.controller.abort();
+	return true;
+}
+/**
+* The agent answered. Call this in the same continuation that received the answer, before anything
+* else is awaited, so a Stop handled in between cannot slip ahead of an answer that had already won.
+*
+* False when Stop got there first, and then the answer must not be kept however complete it is.
+*/
+function completeRun(run) {
+	const held = run;
+	if (held.state !== "running") return false;
+	held.state = "completed";
+	return true;
+}
+/**
+* The run is over, whichever way. Removes this run and only this one: by the time a slow handler
+* gets here a newer run of the same kind may have begun, and it is not this handler's to end.
+*/
+function endRun(run) {
+	const key = keyOf(run.workspaceId, run.kind);
+	if (runs.get(key) === run) runs.delete(key);
+}
+//#endregion
 //#region ../../packages/review-harness/src/workspace/diagram.ts
 /** The same budget a question gets. Drawing is reading, and reading is what takes the time. */
 var DIAGRAM_TIMEOUT_MS = 18e4;
@@ -5120,6 +5339,7 @@ flowchart LR
 async function drawDiagram(workspace, sectionId, signal) {
 	const cwd = await askCheckout(workspace);
 	const env = agentEnvOf(workspace);
+	const requestedModel = resolveModel({ review: { session: workspace.session } }) ?? void 0;
 	let raw;
 	try {
 		raw = await withUsageRecorded(workspace.id, "diagram", env, (onUsage) => agentFor(env).run({
@@ -5128,10 +5348,11 @@ async function drawDiagram(workspace, sectionId, signal) {
 			cwd,
 			originRepoPath: workspace.repoPath,
 			env,
+			...requestedModel ? { requestedModel } : {},
 			timeoutMs: DIAGRAM_TIMEOUT_MS,
 			signal,
 			onUsage
-		}));
+		}), void 0, requestedModel);
 	} catch (error) {
 		if (error instanceof AgentUnavailableError) throw new DiagramUnavailableError(`${error.message} It is what this review was made with, so nothing can be drawn.`);
 		throw error;
@@ -5704,6 +5925,7 @@ async function handle(req, res, options) {
 	if (action === "/file") return void sendFile(res, workspace, url.searchParams);
 	if (action === "/ask") return handleAsk(req, res, workspace);
 	if (action === "/diagram") return handleDiagram(req, res, workspace);
+	if (action === "/stop") return handleStop(req, res, workspace);
 	if (action === "/kiss") return handleKiss(req, res, workspace);
 	if (action === "/state") return handleState(req, res, workspace);
 	if (action === "/event") return handleEvent(req, res, workspace);
@@ -6162,6 +6384,8 @@ async function sendWorkspacePage(res, workspace) {
 		repoPath: workspace.repoPath,
 		askWidth: readPreferences().askWidth,
 		transcript: workspace.transcript,
+		pendingAsk: reportRun(workspace.id, "ask"),
+		pendingDiagram: reportRun(workspace.id, "diagram"),
 		prompts: readPromptBank(),
 		complete: workspace.completedAt !== void 0,
 		prContext: workspace.prContext ? {
@@ -6265,7 +6489,9 @@ function jobReport(workspace) {
 	return {
 		...jobStatus(workspace.jobId ? loadJob(workspace.jobId) : null),
 		kiss: jobStatus(kissRun ? loadJob(kissRun.jobId) : null),
-		update: jobStatus(liveUpdateFor(workspace.id))
+		update: jobStatus(liveUpdateFor(workspace.id)),
+		ask: reportRun(workspace.id, "ask"),
+		diagram: reportRun(workspace.id, "diagram")
 	};
 }
 /**
@@ -6474,6 +6700,15 @@ async function handleAsk(req, res, workspace) {
 	const question = typeof body?.question === "string" ? body.question.trim() : "";
 	if (!question) return send(res, 400, { error: "No question given." });
 	const sectionId = typeof body?.sectionId === "string" ? body.sectionId : null;
+	const started = beginRun(workspace.id, "ask", {
+		question,
+		sectionId
+	});
+	if ("alreadyRunning" in started) return send(res, 409, {
+		error: "Buddy AI is still answering the last question on this review.",
+		running: true
+	});
+	const run = started.run;
 	record({
 		event: "assistant_question_asked",
 		reviewId: workspace.id,
@@ -6481,40 +6716,64 @@ async function handleAsk(req, res, workspace) {
 		scoped: sectionId !== null,
 		turn: workspace.transcript.length + 1
 	});
-	const cancel = new AbortController();
-	res.on("close", () => {
-		if (!res.writableEnded) cancel.abort();
-	});
 	const startedAt = Date.now();
-	let answer;
+	const failed = () => record({
+		event: "assistant_answered",
+		reviewId: workspace.id,
+		durationMs: Date.now() - startedAt,
+		ok: false,
+		...run.state === "stopped" ? { cancelled: true } : {}
+	});
 	try {
-		answer = await askAboutChange(workspace, question, sectionId, cancel.signal);
-	} catch (error) {
-		const cancelled = error instanceof AgentCancelledError;
+		let answer;
+		try {
+			answer = await askAboutChange(workspace, question, sectionId, run.signal);
+		} catch (error) {
+			failed();
+			if (run.state === "stopped") return sendIfOpen(res, 200, { stopped: true });
+			throw error;
+		}
+		if (!completeRun(run)) {
+			failed();
+			return sendIfOpen(res, 200, { stopped: true });
+		}
 		record({
 			event: "assistant_answered",
 			reviewId: workspace.id,
 			durationMs: Date.now() - startedAt,
-			ok: false,
-			...cancelled ? { cancelled: true } : {}
+			ok: true
 		});
-		if (cancelled) return;
-		throw error;
+		const fresh = loadWorkspace(workspace.id);
+		if (fresh) {
+			fresh.transcript.push({
+				question,
+				answer,
+				sectionId,
+				askedAt: Date.now()
+			});
+			saveWorkspace(fresh);
+		}
+		sendIfOpen(res, 200, { answer });
+	} finally {
+		endRun(run);
 	}
-	record({
-		event: "assistant_answered",
-		reviewId: workspace.id,
-		durationMs: Date.now() - startedAt,
-		ok: true
-	});
-	workspace.transcript.push({
-		question,
-		answer,
-		sectionId,
-		askedAt: Date.now()
-	});
-	saveWorkspace(workspace);
-	send(res, 200, { answer });
+}
+/** Only while somebody is listening. A page that left took its socket with it. */
+function sendIfOpen(res, status, body) {
+	if (res.writableEnded || res.destroyed) return;
+	send(res, status, body);
+}
+/**
+* The reviewer pressed Stop, on this page or on another one showing the same review.
+*
+* The only way a question or a drawing ends early. Idempotent, so a double press and a press that
+* lands as the answer does are both harmless: the run decides once which of the two won.
+*/
+async function handleStop(req, res, workspace) {
+	const body = await readJson(req);
+	const kind = RUN_KINDS.find((candidate) => candidate === body?.kind);
+	if (!kind) return send(res, 400, { error: "Say what to stop: the question or the drawing." });
+	send(res, 200, { stopped: stopRun(workspace.id, kind) });
 }
 /**
 * Draw the change, or one theme of it, and keep the drawing.
@@ -6528,46 +6787,60 @@ async function handleDiagram(req, res, workspace) {
 	const body = await readJson(req);
 	const sectionId = typeof body?.sectionId === "string" ? body.sectionId : null;
 	const scope = sectionId ?? "change";
-	const existing = (workspace.diagrams ?? []).findIndex((diagram) => diagram.scope === scope);
+	const redraw = (workspace.diagrams ?? []).some((diagram) => diagram.scope === scope);
+	const started = beginRun(workspace.id, "diagram", { sectionId });
+	if ("alreadyRunning" in started) return send(res, 409, {
+		error: "A diagram of this review is already being drawn.",
+		running: true
+	});
+	const run = started.run;
 	record({
 		event: "diagram_requested",
 		reviewId: workspace.id,
 		scoped: sectionId !== null,
-		redraw: existing !== -1
-	});
-	const cancel = new AbortController();
-	res.on("close", () => {
-		if (!res.writableEnded) cancel.abort();
+		redraw
 	});
 	const startedAt = Date.now();
-	let diagram;
+	const failed = () => record({
+		event: "diagram_drawn",
+		reviewId: workspace.id,
+		durationMs: Date.now() - startedAt,
+		ok: false,
+		...run.state === "stopped" ? { cancelled: true } : {}
+	});
 	try {
-		diagram = await drawDiagram(workspace, sectionId, cancel.signal);
-	} catch (error) {
-		const cancelled = error instanceof AgentCancelledError;
+		let diagram;
+		try {
+			diagram = await drawDiagram(workspace, sectionId, run.signal);
+		} catch (error) {
+			failed();
+			if (run.state === "stopped") return sendIfOpen(res, 200, { stopped: true });
+			if (error instanceof DiagramUnavailableError || error instanceof DiagramMalformedError) return sendIfOpen(res, 502, { error: error.message });
+			throw error;
+		}
+		if (!completeRun(run)) {
+			failed();
+			return sendIfOpen(res, 200, { stopped: true });
+		}
 		record({
 			event: "diagram_drawn",
 			reviewId: workspace.id,
 			durationMs: Date.now() - startedAt,
-			ok: false,
-			...cancelled ? { cancelled: true } : {}
+			ok: true
 		});
-		if (cancelled) return;
-		if (error instanceof DiagramUnavailableError || error instanceof DiagramMalformedError) return send(res, 502, { error: error.message });
-		throw error;
+		const fresh = loadWorkspace(workspace.id);
+		if (fresh) {
+			const diagrams = [...fresh.diagrams ?? []];
+			const existing = diagrams.findIndex((one) => one.scope === scope);
+			if (existing === -1) diagrams.push(diagram);
+			else diagrams[existing] = diagram;
+			fresh.diagrams = diagrams;
+			saveWorkspace(fresh);
+		}
+		sendIfOpen(res, 200, { diagram });
+	} finally {
+		endRun(run);
 	}
-	record({
-		event: "diagram_drawn",
-		reviewId: workspace.id,
-		durationMs: Date.now() - startedAt,
-		ok: true
-	});
-	const diagrams = [...workspace.diagrams ?? []];
-	if (existing === -1) diagrams.push(diagram);
-	else diagrams[existing] = diagram;
-	workspace.diagrams = diagrams;
-	saveWorkspace(workspace);
-	send(res, 200, { diagram });
 }
 /**
 * Stop serving, at the request of a workspace.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prreviewbuddy",
-  "version": "0.25.13",
+  "version": "0.27.2",
   "description": "Review a branch or pull request in an isolated checkout, from your terminal, with the coding agent you already have installed.",
   "license": "UNLICENSED",
   "homepage": "https://prreviewbuddy.com",