prreviewbuddy 0.25.0 → 0.25.6

package/CHANGELOG.md

@@ -1,5 +1,68 @@
 # Changelog
 
+## 0.25.6
+
+**A review you open while it is still running now looks like one that is running.** Following the
+link the moment it is printed used to show the finished layout with most of it missing: a two line
+status strip, the KISS card, a screen of white below it, and an empty column down the right where
+the assistant would go. It read as a page that had failed to draw rather than as a review being
+made.
+
+There is now a **Review in progress** page, and it is what a running review opens on. It lists the
+steps of the run, ticks them off as they finish, and marks the one going with the note the agent is
+writing as it works:
+
+```
+✓ Prepared isolated checkout
+✓ Read what changed
+✓ Read pull request conversation
+● Analysing the change
+    Reading packages/alerts/src/ede/adapter.ts
+```
+
+Those are the same step names the terminal prints while you wait, so switching between the two
+shows one operation rather than two descriptions of it. The elapsed time counts in seconds while it
+is under a minute, because a number that does not move is no evidence that anything is happening.
+
+**The changed files open before the review is finished.** They are known minutes before anything
+has been concluded about them, so once the change has been read the page offers them, and the Files
+tab works exactly as it does on a finished review. You can start reading the code while the model
+is still thinking about it. The findings, questions and assistant stay behind until they exist,
+since an empty Issues tab cannot be told apart from a review that found nothing.
+
+Going into Files while it runs keeps you there. The page refreshes itself only when it has
+something new to show you, not on every step.
+
+**A run that stopped says which step it stopped on.** The message and **Retry** used to sit in the
+strip, which had room to say a review had paused but not where. The failure now sits under the same
+checklist, with the step that broke marked and the ones after it left unclaimed, so what failed is
+a thing you read rather than a thing you infer.
+
+**KISS is no longer where you land by accident.** A change whose standard review had not finished
+opened on the KISS run form, because it was the only page with anything on it. It is a peer review
+type, not the fallback for whichever review is busy, and it is still one click away in the sidebar.
+
+**Locations under a KISS recommendation fit the page.** A repository path is one long unbreakable
+word, and the buttons holding them grew wider than the document, cutting off the end of the path,
+which is the half naming the file. They now wrap the way the standard review's file rows always
+have: a quiet directory line above a filename that wraps.
+
+The **Main** badge on those rows is gone. It was our word for a flag in the data, worn as a label,
+so it read as a fact about the file and left you to work out what it was for. The rows now sit
+under **Start here** and **Also relevant**, which say what to do instead of what we call it. Both
+headings are dropped where a recommendation cites a single file.
+
+**"Show more of this file" shows more of the file.** Under a finding at line 804 it used to jump to
+the top of the file and then do nothing at all when pressed again, because it meant "the first 600
+lines" rather than "more". Each press now widens the window around the line you arrived at, and the
+button is only there while there is more to show.
+
+**Your own saved prompts no longer look unavailable.** In the selection menu they appeared greyed
+out, under a dividing rule, from the first one you saved. A rule written when "Ask a question" was
+the last item in the menu was landing on the last saved prompt instead. They now sit under a **Your
+prompts** heading, in the same words the assistant panel uses for the same set, and read as the
+most available thing in the menu rather than the least.
+
 ## 0.25.0
 
 **PR Review Buddy no longer guesses which `main` you meant.** A repository usually holds two

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { B as BUILD_VERSION, Bt as AGENT_IDS, C as statedWorkspacePort, E as updateReview, F as startJob, G as forgeResolver, It as readAgentPreference, J as clearClaim, L as record, Lt as writeAgentPreference, Mt as displayRef, N as reanalyseReview, Nt as git, P as runJob, Pt as agentIdOf, Q as removeWorktree, R as recordTelemetryUploadConsent, Rt as CONFIG_PATH, Ut as detectAgents, V as PACKAGE_NAME, Vt as agentById, X as MANAGED_ROOT, Y as isClaimed, Z as readMarker, _t as recentWorkspaces, a as liveJobsFor, at as loadJob, b as MIN_WORKSPACE_PORT, bt as saveWorkspace, ct as groupByLineage, et as checkFreshness, f as ensureServer, ft as loadWorkspace, g as workspaceUrl, h as stopServer, it as isTerminal, j as recordKissRun, jt as resolveTarget, l as readIndexToken, m as reviewsUrl, mt as positionInLineage, nt as allJobs, o as wasBlocked, pt as matchingWorkspaceIds, r as deleteReview$1, s as runningJobs, st as followedRefName, t as relativeTime, tt as WORK_PHASES, u as bootstrapUrl, ut as lineageKeyFor, v as DEFAULT_WORKSPACE_PORT, w as writePortPreference, x as parseWorkspacePort, xt as summarise, y as MAX_WORKSPACE_PORT, yt as reviewedRepositories, z as telemetryUploadConsent, zt as STORE_ROOT } from "./relative_time-BeAMrdB1.js";
+import { B as BUILD_VERSION, Bt as STORE_ROOT, C as statedWorkspacePort, E as updateReview, F as startJob, Ft as agentIdOf, G as forgeResolver, Ht as agentById, J as clearClaim, L as record, Lt as readAgentPreference, Mt as resolveTarget, N as reanalyseReview, Nt as displayRef, P as runJob, Pt as git, Q as removeWorktree, R as recordTelemetryUploadConsent, Rt as writeAgentPreference, St as summarise, V as PACKAGE_NAME, Vt as AGENT_IDS, Wt as detectAgents, X as MANAGED_ROOT, Y as isClaimed, Z as readMarker, a as liveJobsFor, b as MIN_WORKSPACE_PORT, bt as reviewedRepositories, ct as followedRefName, dt as lineageKeyFor, et as checkFreshness, f as ensureServer, g as workspaceUrl, h as stopServer, ht as positionInLineage, it as loadJob, j as recordKissRun, l as readIndexToken, lt as groupByLineage, m as reviewsUrl, mt as matchingWorkspaceIds, o as wasBlocked, pt as loadWorkspace, r as deleteReview$1, rt as isTerminal, s as runningJobs, st as progressSteps, t as relativeTime, tt as allJobs, u as bootstrapUrl, v as DEFAULT_WORKSPACE_PORT, vt as recentWorkspaces, w as writePortPreference, x as parseWorkspacePort, xt as saveWorkspace, y as MAX_WORKSPACE_PORT, z as telemetryUploadConsent, zt as CONFIG_PATH } from "./relative_time-DJ9iHDDG.js";
 import { basename, dirname, join, resolve } from "node:path";
 import { spawn } from "node:child_process";
 import { existsSync, mkdirSync, readdirSync, realpathSync, rmSync, statSync, writeFileSync } from "node:fs";
@@ -1546,39 +1546,6 @@ function describe(deps, id) {
 */
 var POLL_INTERVAL_MS = 500;
 /**
-* Two forms per phase, because a finished step and a running one are different sentences.
-*
-* The page says these differently again (`job_view.ts`), and deliberately: it is describing a
-* review to someone who arrived after the fact, while this is narrating one to someone watching it
-* happen. Sharing the strings would force one of the two to read wrongly.
-*/
-var PHASES = {
-	preparing: {
-		doing: "Preparing isolated checkout",
-		done: "Prepared isolated checkout"
-	},
-	context: {
-		doing: "Reading what changed",
-		done: "Read what changed"
-	},
-	conversation: {
-		doing: "Reading pull request conversation",
-		done: "Read pull request conversation"
-	},
-	analysing: {
-		doing: "Analysing the change",
-		done: "Analysed the change"
-	},
-	done: {
-		doing: "Finishing",
-		done: "Finished"
-	},
-	failed: {
-		doing: "Stopped",
-		done: "Stopped"
-	}
-};
-/**
 * Colour only where it means something, and never where it cannot be seen.
 *
 * `NO_COLOR` is honoured because this writes to stderr, which people redirect into files and CI
@@ -1606,58 +1573,26 @@ function header(target, colour) {
 * Completed phases stay visible because they are the part that says how far along this is. Their
 * detail does not: a note about a file read two phases ago is history, and history is what the
 * transcript was made of.
+*
+* Which phases there are, what they are called and what has become of each is `progressSteps`,
+* shared with the workspace page so the browser and this block never name one phase two things.
+* What is left here is how a terminal draws that: a mark, a colour, and an indent.
 */
 function phaseLines(job, colour) {
 	const lines = [];
-	const failedAt = job.phase === "failed" ? job.failure?.phase : void 0;
-	for (const phase of WORK_PHASES) {
-		if (!applies(job, phase)) continue;
-		const complete = job.completed.includes(phase) || job.phase === "done";
-		const failed = failedAt === phase;
-		const current = !complete && !failed && job.phase === phase;
-		const mark = failed ? "✕" : complete ? "✓" : current ? "⟳" : " ";
-		const label = complete || failed ? PHASES[phase].done : PHASES[phase].doing;
-		const paint = failed ? RED : complete ? GREEN : "";
-		if (!complete && !current && !failed) {
-			lines.push(colour ? `${DIM}  ${mark} ${label}${RESET}` : `  ${mark} ${label}`);
+	for (const step of progressSteps(job)) {
+		const mark = step.state === "failed" ? "✕" : step.state === "complete" ? "✓" : step.state === "active" ? "⟳" : " ";
+		const paint = step.state === "failed" ? RED : step.state === "complete" ? GREEN : "";
+		if (step.state === "pending") {
+			lines.push(colour ? `${DIM}  ${mark} ${step.label}${RESET}` : `  ${mark} ${step.label}`);
 			continue;
 		}
-		lines.push(colour && paint ? `${paint}${mark}${RESET} ${label}` : `${mark} ${label}`);
-		if (current && job.progress && !restates(job.progress, label)) lines.push(colour ? `${DIM}    ${job.progress}${RESET}` : `    ${job.progress}`);
+		lines.push(colour && paint ? `${paint}${mark}${RESET} ${step.label}` : `${mark} ${step.label}`);
+		if (step.note) lines.push(colour ? `${DIM}    ${step.note}${RESET}` : `    ${step.note}`);
 	}
 	return lines;
 }
 /**
-* Whether a phase is part of *this* review, rather than part of the pipeline in general.
-*
-* Only `conversation` is ever optional, and reviewing a branch with no pull request is an ordinary
-* supported thing to do rather than a degraded version of something else. Ticking "Read pull
-* request conversation" on such a review claims a step that did not happen and makes a complete
-* review look like an incomplete one; printing "No pull request found" instead is no better,
-* because a line in a checklist reads as something missing whatever words are in it.
-*
-* So the rule is that an optional stage which did not apply is not rendered at all:
-*
-* - A pull request review always shows it. It is the point of that review, and it is known before
-*   the phase runs, so the line never appears late.
-* - A branch review shows it only once a conversation was actually attached, which happens when the
-*   branch turns out to have a request on a forge we read. Real work, worth saying.
-* - Everything else — no request, an unsupported host, `gh` missing — shows nothing.
-*
-* The absent cases are still explained, once, at the end: the closing summary says the review was
-* made without the conversation and why. That is the right place for it, because by then it is a
-* fact about the finished review rather than a gap in a list of things still happening.
-*/
-function applies(job, phase) {
-	if (phase !== "conversation") return true;
-	return job.target.pullRequest !== void 0 || job.conversation?.kind === "attached";
-}
-/** Same words as the phase heading, give or take the articles and the trailing full stop. */
-function restates(note, label) {
-	const bare = (text) => text.toLowerCase().replace(/\bthe\b/g, "").replace(/[^a-z]/g, "");
-	return bare(note) === bare(label);
-}
-/**
 * How many rows this block will actually occupy, which is not how many strings it is.
 *
 * The redraw moves the cursor up by a count and clears from there, so that count has to be in the

package/dist/{relative_time-BeAMrdB1.js → relative_time-DJ9iHDDG.js}

@@ -3869,6 +3869,112 @@ function pruneOldWorkspaces() {
 	} catch {}
 }
 //#endregion
+//#region ../../packages/review-harness/src/workspace/job_progress.ts
+/**
+* The phases that do work, in the order they run. `done` and `failed` are outcomes, not work.
+*
+* Declared here rather than in `job_store.ts`, which is where it used to live, because this module
+* is imported by the browser bundle and that one opens files. Everything here is a string table
+* and a fold over a record; the store reads this rather than the other way round, so the client
+* can share the phase model without dragging `node:fs` in behind it. The type still comes from the
+* store, which is harmless: types are erased.
+*/
+var WORK_PHASES = [
+	"preparing",
+	"context",
+	"conversation",
+	"analysing"
+];
+/**
+* Two forms per phase, because a finished step and a running one are different sentences.
+*
+* `done` and `failed` are outcomes rather than work, so they never appear in a checklist; they
+* are named anyway because `JobPhase` includes them and a partial table would make every lookup
+* a possible undefined.
+*/
+var PHASES = {
+	preparing: {
+		doing: "Preparing isolated checkout",
+		done: "Prepared isolated checkout"
+	},
+	context: {
+		doing: "Reading what changed",
+		done: "Read what changed"
+	},
+	conversation: {
+		doing: "Reading pull request conversation",
+		done: "Read pull request conversation"
+	},
+	analysing: {
+		doing: "Analysing the change",
+		done: "Analysed the change"
+	},
+	done: {
+		doing: "Finishing",
+		done: "Finished"
+	},
+	failed: {
+		doing: "Stopped",
+		done: "Stopped"
+	}
+};
+/**
+* Whether a phase is part of *this* review, rather than part of the pipeline in general.
+*
+* Only `conversation` is ever optional, and reviewing a branch with no pull request is an ordinary
+* supported thing to do rather than a degraded version of something else. Ticking "Read pull
+* request conversation" on such a review claims a step that did not happen and makes a complete
+* review look like an incomplete one; printing "No pull request found" instead is no better,
+* because a line in a checklist reads as something missing whatever words are in it.
+*
+* So the rule is that an optional stage which did not apply is not rendered at all:
+*
+* - A pull request review always shows it. It is the point of that review, and it is known before
+*   the phase runs, so the line never appears late.
+* - A branch review shows it only once a conversation was actually attached, which happens when the
+*   branch turns out to have a request on a forge we read. Real work, worth saying.
+* - Everything else — no request, an unsupported host, `gh` missing — shows nothing.
+*
+* The absent cases are still explained, once, at the end: the CLI's closing summary and the page's
+* `conversationNote` both say the review was made without the conversation and why. That is the
+* right place for it, because by then it is a fact about the finished review rather than a gap in
+* a list of things still happening.
+*/
+function appliesTo(job, phase) {
+	if (phase !== "conversation") return true;
+	return job.target.pullRequest !== void 0 || job.conversation?.kind === "attached";
+}
+/**
+* Every step this review runs, in order, with what has become of each.
+*
+* Read from `job.completed` rather than inferred from the position of `job.phase` in the list.
+* The job records a phase as complete when it is *left*, so a run that died inside a phase leaves
+* it uncompleted — which is the honest shape of that, and the thing a retry resumes from. Working
+* it out from ordering instead would tick a step the job never finished.
+*/
+function progressSteps(job) {
+	const failedAt = job.phase === "failed" ? job.failure?.phase : void 0;
+	return WORK_PHASES.filter((phase) => appliesTo(job, phase)).map((phase) => {
+		const complete = job.completed.includes(phase) || job.phase === "done";
+		const failed = failedAt === phase;
+		const active = !complete && !failed && job.phase === phase;
+		const state = failed ? "failed" : complete ? "complete" : active ? "active" : "pending";
+		const label = complete ? PHASES[phase].done : PHASES[phase].doing;
+		const note = active && job.progress && !restates(job.progress, label) ? job.progress : void 0;
+		return {
+			phase,
+			label,
+			state,
+			...note ? { note } : {}
+		};
+	});
+}
+/** Same words as the phase heading, give or take the articles and the trailing full stop. */
+function restates(note, label) {
+	const bare = (text) => text.toLowerCase().replace(/\bthe\b/g, "").replace(/[^a-z]/g, "");
+	return bare(note) === bare(label);
+}
+//#endregion
 //#region ../../packages/review-harness/src/workspace/job_store.ts
 /**
 * What a review is doing right now, kept apart from the review itself.
@@ -3878,14 +3984,14 @@ function pruneOldWorkspaces() {
 * process that rewrites reviews. And a job is finished business within hours while a review is
 * kept for thirty days, so one record with two lifetimes would have to encode both.
 */
+/**
+* The phases that do work, in the order they run. `done` and `failed` are outcomes, not work.
+*
+* Defined in `job_progress.ts` and re-exported here, where every existing caller already looks for
+* it. It lives there because the workspace page's client bundle needs the phase model and must not
+* import this module, which opens files.
+*/
 var JOBS_DIR = join(STORE_ROOT, "jobs");
-/** The phases that do work, in the order they run. `done` and `failed` are outcomes, not work. */
-var WORK_PHASES = [
-	"preparing",
-	"context",
-	"conversation",
-	"analysing"
-];
 /**
 * Whether this job asks the forge for the conversation, or reads what is already on the workspace.
 *
@@ -10629,4 +10735,4 @@ function relativeTime(ms) {
 	return `${days} day${days === 1 ? "" : "s"} ago`;
 }
 //#endregion
-export { checkCodeFreshness as $, agentEnvOf as A, describeAuthorship as At, BUILD_VERSION as B, AGENT_IDS as Bt, statedWorkspacePort as C, doneVerb as Ct, refreshPrContext as D, questionsOutstanding as Dt, updateReview as E, issuesOutstanding as Et, startJob as F, clearAgentPreference as Ft, forgeResolver as G, AgentUnavailableError as Gt, feedbackUrl as H, agentFor as Ht, readEvents as I, readAgentPreference as It, clearClaim as J, fillFileUrlTemplate as K, record as L, writeAgentPreference as Lt, startKissJob as M, displayRef as Mt, reanalyseReview as N, git as Nt, isUnchanged as O, reviewerDispositions as Ot, runJob as P, agentIdOf as Pt, removeWorktree as Q, recordTelemetryUploadConsent as R, CONFIG_PATH as Rt, resolveWorkspacePort as S, touchWorkspace as St, RefreshUnavailableError as T, isQuestionOutstanding as Tt, withUsageRecorded as U, detectAgents as Ut, PACKAGE_NAME as V, agentById as Vt, EXPLAIN_SIMPLY_PROMPT as W, AgentCancelledError as Wt, MANAGED_ROOT as X, isClaimed as Y, readMarker as Z, writeServerRecord as _, recentWorkspaces as _t, liveJobsFor as a, loadJob as at, MIN_WORKSPACE_PORT as b, saveWorkspace as bt, discardJob as c, groupByLineage as ct, clearServerRecord as d, lineagePosition as dt, checkFreshness as et, ensureServer as f, loadWorkspace as ft, workspaceUrl as g, recentReviewGroups as gt, stopServer as h, previousKissResult as ht, lineageIds as i, isTerminal as it, recordKissRun as j, resolveTarget as jt, askCheckout as k, processDiscussion as kt, readIndexToken as l, latestKissRun as lt, reviewsUrl as m, positionInLineage as mt, deleteLineage as n, allJobs as nt, wasBlocked as o, saveJob as ot, readServerRecord as p, matchingWorkspaceIds as pt, ReviewBeingDeletedError as q, deleteReview as r, fail as rt, runningJobs as s, followedRefName as st, relativeTime as t, WORK_PHASES as tt, bootstrapUrl as u, lineageKeyFor as ut, DEFAULT_WORKSPACE_PORT as v, reviewedCommit as vt, writePortPreference as w, isIssueOutstanding as wt, parseWorkspacePort as x, summarise as xt, MAX_WORKSPACE_PORT as y, reviewedRepositories as yt, telemetryUploadConsent as z, STORE_ROOT as zt };
+export { checkCodeFreshness as $, agentEnvOf as A, processDiscussion as At, BUILD_VERSION as B, STORE_ROOT as Bt, statedWorkspacePort as C, touchWorkspace as Ct, refreshPrContext as D, issuesOutstanding as Dt, updateReview as E, isQuestionOutstanding as Et, startJob as F, agentIdOf as Ft, forgeResolver as G, AgentCancelledError as Gt, feedbackUrl as H, agentById as Ht, readEvents as I, clearAgentPreference as It, clearClaim as J, fillFileUrlTemplate as K, AgentUnavailableError as Kt, record as L, readAgentPreference as Lt, startKissJob as M, resolveTarget as Mt, reanalyseReview as N, displayRef as Nt, isUnchanged as O, questionsOutstanding as Ot, runJob as P, git as Pt, removeWorktree as Q, recordTelemetryUploadConsent as R, writeAgentPreference as Rt, resolveWorkspacePort as S, summarise as St, RefreshUnavailableError as T, isIssueOutstanding as Tt, withUsageRecorded as U, agentFor as Ut, PACKAGE_NAME as V, AGENT_IDS as Vt, EXPLAIN_SIMPLY_PROMPT as W, detectAgents as Wt, MANAGED_ROOT as X, isClaimed as Y, readMarker as Z, writeServerRecord as _, recentReviewGroups as _t, liveJobsFor as a, saveJob as at, MIN_WORKSPACE_PORT as b, reviewedRepositories as bt, discardJob as c, followedRefName as ct, clearServerRecord as d, lineageKeyFor as dt, checkFreshness as et, ensureServer as f, lineagePosition as ft, workspaceUrl as g, previousKissResult as gt, stopServer as h, positionInLineage as ht, lineageIds as i, loadJob as it, recordKissRun as j, describeAuthorship as jt, askCheckout as k, reviewerDispositions as kt, readIndexToken as l, groupByLineage as lt, reviewsUrl as m, matchingWorkspaceIds as mt, deleteLineage as n, fail as nt, wasBlocked as o, PHASES as ot, readServerRecord as p, loadWorkspace as pt, ReviewBeingDeletedError as q, deleteReview as r, isTerminal as rt, runningJobs as s, progressSteps as st, relativeTime as t, allJobs as tt, bootstrapUrl as u, latestKissRun as ut, DEFAULT_WORKSPACE_PORT as v, recentWorkspaces as vt, writePortPreference as w, doneVerb as wt, parseWorkspacePort as x, saveWorkspace as xt, MAX_WORKSPACE_PORT as y, reviewedCommit as yt, telemetryUploadConsent as z, CONFIG_PATH as zt };