prreviewbuddy 0.12.0 → 0.12.1

package/dist/{log-DdPaO6Wo.js → log-PmeEgome.js}

@@ -404,11 +404,7 @@ var GitError = class extends Error {
 };
 async function git(cwd, args, options = {}) {
 	try {
-		const { stdout } = await execFileAsync$1("git", [
-			"-c",
-			"core.quotePath=false",
-			...args
-		], {
+		const { stdout } = await execFileAsync$1("git", [...["core.quotePath=false", ...options.config ?? []].flatMap((one) => ["-c", one]), ...args], {
 			cwd,
 			encoding: "utf8",
 			maxBuffer: MAX_BUFFER$1,
@@ -2092,6 +2088,25 @@ function relativeTime(ms) {
 */
 var MANAGED_ROOT = join(STORE_ROOT, "worktrees");
 /**
+* An empty directory, pointed at so that the repository's own hooks do not run in our checkout.
+*
+* `git worktree add` checks the tree out, which fires `post-checkout` in the reviewer's repository.
+* Found on a 31,644 file monorepo with husky: its hook asks for `HEAD@{1}`, a brand new worktree's
+* HEAD reflog has exactly one entry, git answers `fatal: log for 'HEAD' only has 1 entries`, and the
+* add exits 128 *after* writing the whole tree. Every review of that repository failed, in the first
+* phase, for a reason that was nothing to do with the review.
+*
+* Turning them off is the right answer rather than a workaround. These hooks were written for a
+* person checking out a branch to work on: install dependencies, warn about a stale lockfile, prompt
+* something. Nobody works in this directory. It is read once by an agent and deleted. It is also
+* arbitrary code from the repository being reviewed, and a review that runs it has quietly made
+* "point PR Review Buddy at this repository" mean "execute this repository".
+*
+* A directory rather than `/dev/null` because git is being told where hooks live, and a real empty
+* one is true on every platform.
+*/
+var NO_HOOKS = join(STORE_ROOT, "no-hooks");
+/**
 * The proof that we made a directory, kept inside the directory itself.
 *
 * It exists for the removal guard. Git normally answers "is this yours", and when git has
@@ -2101,14 +2116,26 @@ var MANAGED_ROOT = join(STORE_ROOT, "worktrees");
 var MARKER_FILE = ".prreviewbuddy-worktree.json";
 async function createWorktree(input) {
 	mkdirSync(MANAGED_ROOT, { recursive: true });
+	mkdirSync(NO_HOOKS, { recursive: true });
 	const path = join(MANAGED_ROOT, input.jobId);
-	await git(input.originRepoPath, [
-		"worktree",
-		"add",
-		"--detach",
-		path,
-		input.sha
-	], { timeoutMs: WORKTREE_TIMEOUT_MS });
+	try {
+		await git(input.originRepoPath, [
+			"worktree",
+			"add",
+			"--detach",
+			path,
+			input.sha
+		], {
+			config: [`core.hooksPath=${NO_HOOKS}`],
+			timeoutMs: WORKTREE_TIMEOUT_MS
+		});
+	} catch (error) {
+		await removeWorktree({
+			originRepoPath: input.originRepoPath,
+			worktreePath: path
+		}).catch(() => {});
+		throw error;
+	}
 	const marker = {
 		jobId: input.jobId,
 		originRepoPath: input.originRepoPath,

package/dist/main.js

@@ -1,5 +1,5 @@
 #!/usr/bin/env node
-import { $ as agentById, A as WORK_PHASES, F as loadJob, G as saveWorkspace, H as positionInLineage, K as summarise, L as displayRef, O as relativeTime, P as isTerminal, Q as AGENT_IDS, V as loadWorkspace, W as recentWorkspaces, X as resolveTarget, Z as withBase, d as ensureServer, f as readServerRecord, g as BUILD_VERSION, i as updateReview, k as checkFreshness, l as LANDING_PAGE, m as workspaceUrl, n as record, nt as AgentUnavailableError, p as reviewsUrl, tt as defaultAgent, v as runJob, w as isClaimed, x as forgeResolver, y as startJob, z as groupByLineage } from "./log-DdPaO6Wo.js";
+import { $ as agentById, A as WORK_PHASES, F as loadJob, G as saveWorkspace, H as positionInLineage, K as summarise, L as displayRef, O as relativeTime, P as isTerminal, Q as AGENT_IDS, V as loadWorkspace, W as recentWorkspaces, X as resolveTarget, Z as withBase, d as ensureServer, f as readServerRecord, g as BUILD_VERSION, i as updateReview, k as checkFreshness, l as LANDING_PAGE, m as workspaceUrl, n as record, nt as AgentUnavailableError, p as reviewsUrl, tt as defaultAgent, v as runJob, w as isClaimed, x as forgeResolver, y as startJob, z as groupByLineage } from "./log-PmeEgome.js";
 import { basename } from "node:path";
 import { spawn } from "node:child_process";
 import { platform } from "node:process";
@@ -318,6 +318,23 @@ function restates(note, label) {
 	return bare(note) === bare(label);
 }
 /**
+* How many rows this block will actually occupy, which is not how many strings it is.
+*
+* The redraw moves the cursor up by a count and clears from there, so that count has to be in the
+* unit the terminal moves in: rows on screen, after wrapping. Counting strings instead lands the
+* cursor short and clears output the block never drew. The header's second line carries a full
+* repository path and wraps in any normal window, so this was not a corner case.
+*
+* Escape sequences are removed first because they occupy no columns. A resize between drawing and
+* redrawing still misplaces the cursor; nothing short of tracking the resize can fix that, and the
+* next repaint corrects itself.
+*/
+function rowsOccupied(lines, columns) {
+	if (!columns) return lines.length;
+	const visible = (line) => line.replace(/\u001b\[[0-9;]*m/g, "").length;
+	return lines.reduce((rows, line) => rows + Math.max(1, Math.ceil(visible(line) / columns)), 0);
+}
+/**
 * Watch a job and keep one block on the screen describing it.
 *
 * Returns the stop function the caller must call: nothing here may outlive the command, and a
@@ -339,12 +356,15 @@ function followJob(jobId, target, options = {}) {
 		if (inPlace && drawn > 0) stream.write(`\u001b[${drawn}A\u001b[0J`);
 		stream.write(`${block}\n`);
 		last = block;
-		drawn = lines.length;
+		drawn = rowsOccupied(lines, stream.columns ?? 0);
 	};
 	const timer = setInterval(paint, POLL_INTERVAL_MS);
 	timer.unref();
 	paint();
+	let stopped = false;
 	return () => {
+		if (stopped) return;
+		stopped = true;
 		clearInterval(timer);
 		paint();
 	};
@@ -675,10 +695,12 @@ async function drive(workspaceId, url) {
 	try {
 		finished = await runJob(workspaceId);
 		if (finished.phase === "failed") {
+			stop();
 			err(reviewFailed(finished.failure?.message ?? "The reason was not recorded.", await linkNow(workspace, url)));
 			return 1;
 		}
 	} catch (error) {
+		stop();
 		err(reviewFailed(error instanceof Error ? error.message : String(error), await linkNow(workspace, url)));
 		return 1;
 	} finally {

package/dist/server.js

@@ -1,4 +1,4 @@
-import { B as lineagePosition, C as clearClaim, D as removeWorktree, E as readMarker, F as loadJob, G as saveWorkspace, I as saveJob, J as processDiscussion, M as deleteJob, N as fail, O as relativeTime$1, P as isTerminal, R as STORE_ROOT, S as fillFileUrlTemplate, T as MANAGED_ROOT, U as recentReviewGroups, V as loadWorkspace, Y as describeAuthorship, _ as feedbackUrl, a as refreshPrContext, b as EXPLAIN_SIMPLY_PROMPT, c as agentEnvOf, et as agentFor, g as BUILD_VERSION, h as writeServerRecord, i as updateReview, j as allJobs, k as checkFreshness, n as record, nt as AgentUnavailableError, o as isUnchanged, q as touchWorkspace, r as RefreshUnavailableError, s as askCheckout, t as readEvents, u as clearServerRecord, v as runJob, w as isClaimed } from "./log-DdPaO6Wo.js";
+import { B as lineagePosition, C as clearClaim, D as removeWorktree, E as readMarker, F as loadJob, G as saveWorkspace, I as saveJob, J as processDiscussion, M as deleteJob, N as fail, O as relativeTime$1, P as isTerminal, R as STORE_ROOT, S as fillFileUrlTemplate, T as MANAGED_ROOT, U as recentReviewGroups, V as loadWorkspace, Y as describeAuthorship, _ as feedbackUrl, a as refreshPrContext, b as EXPLAIN_SIMPLY_PROMPT, c as agentEnvOf, et as agentFor, g as BUILD_VERSION, h as writeServerRecord, i as updateReview, j as allJobs, k as checkFreshness, n as record, nt as AgentUnavailableError, o as isUnchanged, q as touchWorkspace, r as RefreshUnavailableError, s as askCheckout, t as readEvents, u as clearServerRecord, v as runJob, w as isClaimed } from "./log-PmeEgome.js";
 import { isAbsolute, join, relative, resolve } from "node:path";
 import { randomBytes, timingSafeEqual } from "node:crypto";
 import { existsSync, mkdirSync, readFileSync, readdirSync, statSync, writeFileSync } from "node:fs";

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "prreviewbuddy",
-  "version": "0.12.0",
+  "version": "0.12.1",
   "description": "PR Review Buddy at the command line: review a branch in an isolated checkout and open the workspace.",
   "license": "UNLICENSED",
   "homepage": "https://prreviewbuddy.com",
   "type": "module",
   "bin": {
-    "prreviewbuddy": "./dist/main.js"
+    "prreviewbuddy": "dist/main.js"
   },
   "files": [
     "dist",