prr-kit 1.1.2 → 1.2.0

package/src/prr/workflows/6-report/generate-report/steps/step-01-collect.md

@@ -19,17 +19,24 @@ For each completed review in `review.completed` list, read the corresponding out
 - `security-review` → `{review_output}/security-review-*.md` (latest)
 - `performance-review` → `{review_output}/performance-review-*.md` (latest)
 - `architecture-review` → `{review_output}/architecture-review-*.md` (latest)
+- `business-review` → `{review_output}/business-review-*.md` (latest)
 - `improve-code` → `{review_output}/improve-code-*.md` (latest)
 
 ### 3. Parse All Findings
 
 From each file, extract all findings with their:
-- Severity (🔴 Blocker / 🟡 Warning / 🟢 Suggestion / Critical/High/Medium/Low)
-- Category (general/security/performance/architecture/improvement)
+- Severity (🔴 Blocker / 🟡 Warning / 🟢 Suggestion / ❓ Question / Critical/High/Medium/Low)
+- Category (general/security/performance/architecture/business/improvement)
 - File + line reference
 - Description
 - Suggested fix
 
+**Severity mapping:**
+- `🔴` or `Critical`/`High` → Blocker
+- `🟡` or `Medium` → Warning
+- `🟢` or `Low` → Suggestion
+- `❓` → Question (collect separately — do not count as blocker/warning/suggestion)
+
 ### 4. Count Statistics
 
 Count:

package/src/prr/workflows/6-report/generate-report/steps/step-02-organize.md

@@ -10,7 +10,7 @@ nextStepFile: "./step-03-write.md"
 
 ### 1. Sort by Severity
 
-Order: 🔴 Blockers/Critical → 🟡 Warnings/High → 🟡 Medium → 🟢 Suggestions/Low → 📌 Questions
+Order: 🔴 Blockers (Critical/High) → 🟡 Warnings (Medium) → 🟢 Suggestions (Low) → ❓ Questions
 
 ### 2. Group by Category
 
@@ -19,20 +19,41 @@ Within each severity level, group by review category:
 - ⚡ Performance
 - 🏗️ Architecture
 - 👁️ General Quality
+- 💼 Business Impact
 - 💡 Improvements
 
 ### 3. Create Executive Summary
 
-Write 3-5 bullet points summarizing the overall review:
-- Overall quality assessment (1 sentence)
-- Highest priority issues to address
+Write a two-part summary:
+
+**Technical part:**
+- Overall code quality assessment (1 sentence)
+- Highest priority technical issues
 - Positive findings (good practices found)
-- Recommendation: approved / needs changes / request changes
 
-### 4. Identify Files with Multiple Issues
+**Business part (if business-review was completed):**
+- Overall business risk level: CRITICAL / HIGH / MEDIUM / LOW / MINIMAL
+- Top business concern (1 sentence): what is the biggest real-world risk?
+- Deployment recommendation from business perspective
+
+**Combined verdict:**
+- ✅ APPROVE — no blockers, low business risk, safe to ship
+- ⚠️ APPROVE WITH NOTES — warnings only, medium business risk, monitor post-ship
+- 🚫 REQUEST CHANGES — blockers present OR high/critical business risk
+
+### 4. Compile Business Risk Summary
+
+If business-review findings exist:
+- Extract overall business risk level
+- List top 3 business concerns with their severity
+- List any data/migration risks
+- Note observability gaps
+- Note deployment concerns
+
+### 5. Identify Files with Multiple Issues
 
 List files that have 3+ findings — these may need more significant rework.
 
-### 5. Load Next Step
+### 6. Load Next Step
 
 Add `step-02-organize` to `stepsCompleted`. Load: `{nextStepFile}`

package/src/prr/workflows/6-report/generate-report/steps/step-03-write.md

@@ -1,7 +1,7 @@
 ---
 name: "step-03-write"
 description: "Write the final review report to file"
-outputFile: "{review_output}/review-report-{pr_branch}-{date}.md"
+outputFile: "{review_output}/review-{target_branch_slug}-{date}.md"
 templateFile: "../templates/review-report.template.md"
 ---
 
@@ -15,17 +15,19 @@ Using `{templateFile}`, write the complete review report to `{outputFile}`.
 
 The report includes:
 - PR metadata and review summary
-- Executive summary with overall verdict
+- Executive summary with technical verdict + business risk level
+- Business Impact section (if business-review was completed)
 - All findings organized by severity and category
 - Files with multiple issues highlighted
 - Recommended actions (must-fix vs nice-to-have)
+- Post-ship monitoring checklist (if business-review completed)
 
 ### 2. Display Completion
 
 ```
 ✅ Review Report Generated!
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-📄 File: {outputFile}
+📄 File: {review_output}/review-{target_branch_slug}-{date}.md
 
 Summary:
   🔴 Blockers: {blocker_count}
@@ -37,7 +39,7 @@ Verdict: {verdict}
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
 Next steps:
-  [PC] Post Comments — post these findings to GitHub PR
+  [PC] Post Comments — post these findings to GitHub / GitLab / Azure / Bitbucket PR/MR
   or share the report file directly with the PR author
 ```
 

package/src/prr/workflows/6-report/generate-report/templates/review-report.template.md

@@ -1,78 +1,124 @@
----
-pr_branch: "{{target_branch}}"
-base_branch: "{{base_branch}}"
-pr_number: "{{pr_number}}"
-date: "{{date}}"
-verdict: "{{verdict}}"
-reviews_completed:
-{{reviews_completed_list}}
-stepsCompleted: []
----
-
-# Code Review Report: {{pr_title}}
-
-**PR:** `{{target_branch}}` → `{{base_branch}}`
-{{#if pr_number}}**GitHub PR #{{pr_number}}** | {{/if}}**Date:** {{date}} | **Reviewer:** {{user_name}}
-
----
-
-## Executive Summary
-
-{{executive_summary}}
-
-**Verdict:** {{verdict}}
-
-| Category | 🔴 Blockers | 🟡 Warnings | 🟢 Suggestions |
-|----------|------------|------------|----------------|
-| 🔒 Security | {{security_blockers}} | {{security_warnings}} | {{security_suggestions}} |
-| ⚡ Performance | {{perf_blockers}} | {{perf_warnings}} | {{perf_suggestions}} |
-| 🏗️ Architecture | {{arch_blockers}} | {{arch_warnings}} | {{arch_suggestions}} |
-| 👁️ General | {{general_blockers}} | {{general_warnings}} | {{general_suggestions}} |
-| **Total** | **{{total_blockers}}** | **{{total_warnings}}** | **{{total_suggestions}}** |
-
----
-
-## 🔴 Blockers — Must Fix Before Merge
-
-{{blockers_section}}
-
----
-
-## 🟡 Warnings — Should Fix
-
-{{warnings_section}}
-
----
-
-## 🟢 Suggestions — Nice to Have
-
-{{suggestions_section}}
-
----
-
-## 📌 Questions for Author
-
-{{questions_section}}
-
----
-
-## 💡 Code Improvement Suggestions
-
-{{improvements_section}}
-
----
-
-## Files with Multiple Issues
-
-{{files_with_issues}}
-
----
-
-## ✅ Positive Observations
-
-{{positive_observations}}
-
----
-
-*Generated by PR Review Kit*
-*Reviews completed: {{reviews_completed}}*
+---
+pr_branch: "{{target_branch}}"
+base_branch: "{{base_branch}}"
+pr_number: "{{pr_number}}"
+date: "{{date}}"
+verdict: "{{verdict}}"
+reviews_completed:
+{{reviews_completed_list}}
+stepsCompleted: []
+---
+
+# Code Review Report: {{pr_title}}
+
+**PR:** `{{target_branch}}` → `{{base_branch}}`
+{{#if pr_number}}**PR/MR #{{pr_number}}** | {{/if}}**Date:** {{date}} | **Reviewer:** {{user_name}}
+
+---
+
+## Executive Summary
+
+{{executive_summary}}
+
+**Technical Verdict:** {{technical_verdict}}
+**Business Risk:** {{business_risk_level}} — {{business_risk_summary}}
+
+**Overall Verdict:** {{verdict}}
+
+| Category | 🔴 Blockers | 🟡 Warnings | 🟢 Suggestions |
+|----------|------------|------------|----------------|
+| 🔒 Security | {{security_blockers}} | {{security_warnings}} | {{security_suggestions}} |
+| ⚡ Performance | {{perf_blockers}} | {{perf_warnings}} | {{perf_suggestions}} |
+| 🏗️ Architecture | {{arch_blockers}} | {{arch_warnings}} | {{arch_suggestions}} |
+| 👁️ General | {{general_blockers}} | {{general_warnings}} | {{general_suggestions}} |
+| 💼 Business | {{business_blockers}} | {{business_warnings}} | {{business_suggestions}} |
+| **Total** | **{{total_blockers}}** | **{{total_warnings}}** | **{{total_suggestions}}** |
+
+---
+
+## 💼 Business Impact
+
+> *This section translates technical findings into real-world consequences for users and the business.*
+
+### Overall Business Risk: {{business_risk_level}}
+
+{{business_risk_overview}}
+
+### Feature Completeness
+
+{{feature_completeness_section}}
+
+### User Impact
+
+{{user_impact_section}}
+
+### Business Risk Breakdown
+
+{{business_risk_breakdown}}
+
+### Data & Migration Risk
+
+{{data_migration_section}}
+
+### Observability & Measurability
+
+{{observability_section}}
+
+### Cross-cutting Concerns
+
+{{cross_cutting_section}}
+
+### Deployment Recommendation
+
+{{deployment_recommendation}}
+
+### Post-Ship Monitoring
+
+{{post_ship_monitoring}}
+
+---
+
+## 🔴 Blockers — Must Fix Before Merge
+
+{{blockers_section}}
+
+---
+
+## 🟡 Warnings — Should Fix
+
+{{warnings_section}}
+
+---
+
+## 🟢 Suggestions — Nice to Have
+
+{{suggestions_section}}
+
+---
+
+## 📌 Questions for Author
+
+{{questions_section}}
+
+---
+
+## 💡 Code Improvement Suggestions
+
+{{improvements_section}}
+
+---
+
+## Files with Multiple Issues
+
+{{files_with_issues}}
+
+---
+
+## ✅ Positive Observations
+
+{{positive_observations}}
+
+---
+
+*Generated by PR Review Kit*
+*Reviews completed: {{reviews_completed}}*

package/src/prr/workflows/6-report/post-comments/steps/step-01-format.md

@@ -24,11 +24,24 @@ Verify platform CLI is available:
 | bitbucket | check env `BB_TOKEN` or `~/.config/bb` | `❌ Set Bitbucket credentials` |
 | none | — | show: `ℹ️ No platform configured — findings saved to report only.` then stop |
 
+**⚠️ GitHub CLI path detection** — `gh` may not be in `PATH` even if installed. If `gh auth status` fails, probe common locations before giving up:
+```bash
+# Windows
+"/c/Program Files/GitHub CLI/gh" auth status
+# macOS Homebrew
+/opt/homebrew/bin/gh auth status
+/usr/local/bin/gh auth status
+# Linux
+/usr/bin/gh auth status
+~/.local/bin/gh auth status
+```
+Store the working path as `{gh_path}` (e.g. `"/c/Program Files/GitHub CLI/gh"`). Use `{gh_path}` for **all** subsequent `gh` calls in this workflow instead of bare `gh`.
+
 ### 2. Get Head Commit SHA
 
 **GitHub / GitLab / Bitbucket:**
 ```bash
-git -C {target_repo} rev-parse origin/{selected_branch}
+git -C {target_repo} rev-parse origin/{target_branch}
 ```
 Or use `{pr_head_sha}` if already stored from select-pr step.
 
@@ -47,8 +60,8 @@ Sort by modification time, take the most recent.
 ### 4. Parse All Findings
 
 Scan the report and extract every finding:
-- `severity`: 🔴 Blocker / 🟡 Warning / 🟢 Suggestion / 📌 Question
-- `category`: security / performance / architecture / general
+- `severity`: 🔴 Blocker / 🟡 Warning / 🟢 Suggestion / ❓ Question (also accept 📌 as alias for Question)
+- `category`: security / performance / architecture / general / business
 - `file_path`: relative path (e.g. `src/auth/login.js`) — null if not specified
 - `line_number`: integer — null if not specified
 - `description`: the issue text
@@ -82,14 +95,14 @@ Limit inline comments to 30 max: include all 🔴 Blockers first, then 🟡 Warn
 {suggested_fix}
 ```
 
-Category emojis: 🔒 security · ⚡ performance · 🏗️ architecture · 👁️ general
+Category emojis: 🔒 security · ⚡ performance · 🏗️ architecture · 👁️ general · 💼 business
 
 ### 6. Build Summary Body
 
 ```markdown
 ## 🔍 AI Code Review
 
-**PR:** `{selected_branch}` → `{base_branch}` | **Date:** {date} | **Reviewer:** {user_name}
+**PR:** `{target_branch}` → `{base_branch}` | **Date:** {date} | **Reviewer:** {user_name}
 
 **Verdict:** {verdict}
 
@@ -99,12 +112,15 @@ Category emojis: 🔒 security · ⚡ performance · 🏗️ architecture ·
 | ⚡ Performance | {n} | {n} | {n} |
 | 🏗️ Architecture | {n} | {n} | {n} |
 | 👁️ General | {n} | {n} | {n} |
+| 💼 Business | {n} | {n} | {n} |
 
 ### Executive Summary
 {bullets}
 
 {fallback_findings_section}
 
+❓ {question_count} questions for author
+
 ---
 *{inline_count} inline comments on code lines*
 ```
@@ -113,7 +129,86 @@ Verdict logic: any 🔴 → `REQUEST_CHANGES` / only 🟡 → `COMMENT` / none
 
 ### 7. Build Platform Payload
 
-**GitHub** — single JSON file for Reviews API:
+**⚠️ CRITICAL — Use Write tool + runtime script. NEVER use bash heredoc.**
+
+Bash heredoc breaks with Unicode characters, emojis, backticks, and nested quotes — all of which appear in review comment bodies. The only reliable approach is:
+
+1. **Write** the build script to `{temp_dir}/build-payload.mjs` using the Write tool
+2. **Execute** it with `node`
+3. Script writes the final JSON to `{temp_dir}/prr-payload.json`
+
+**Step A — Detect available runtime:**
+```bash
+node --version 2>/dev/null && echo "use-node" || (python3 --version 2>/dev/null && echo "use-python3") || echo "no-runtime"
+```
+Prefer `node`. Fallback: `python3`, then `python`.
+
+**Step B — Write the build script using the Write tool** (NOT echo/heredoc/Bash):
+
+Use the Write tool to create `{temp_dir}/build-payload.mjs` (Node.js) or `{temp_dir}/build-payload.py` (Python).
+
+The script must:
+- Define all string values (comment bodies, summary) as native string variables — no manual JSON escaping needed, the runtime handles it
+- Build the payload object in memory
+- Write to `{temp_dir}/prr-payload.json` using native JSON serialization:
+  - Node.js: `JSON.stringify(payload, null, 2)`
+  - Python: `json.dumps(payload, ensure_ascii=False, indent=2)`
+
+**Node.js template** (`build-payload.mjs`):
+```js
+import { writeFileSync } from 'fs'
+
+const payload = {
+  commit_id: "COMMIT_SHA",
+  body: "SUMMARY BODY — full markdown here, no escaping needed",
+  event: "REQUEST_CHANGES", // or "COMMENT" or "APPROVE"
+  comments: [
+    { path: "src/file.js", line: 42, side: "RIGHT", body: "🔴 **[BLOCKER]** ..." },
+    // ... more comments
+  ]
+}
+
+writeFileSync("{temp_dir}/prr-payload.json", JSON.stringify(payload, null, 2), "utf-8")
+console.log(`OK: ${payload.comments.length} comments`)
+```
+
+**Python template** (`build-payload.py`):
+```python
+import json
+
+payload = {
+    "commit_id": "COMMIT_SHA",
+    "body": "SUMMARY BODY",
+    "event": "REQUEST_CHANGES",
+    "comments": [
+        {"path": "src/file.js", "line": 42, "side": "RIGHT", "body": "🔴 **[BLOCKER]** ..."},
+    ]
+}
+
+with open("{temp_dir}/prr-payload.json", "w", encoding="utf-8") as f:
+    json.dump(payload, f, ensure_ascii=False, indent=2)
+print(f"OK: {len(payload['comments'])} comments")
+```
+
+**Step C — Execute:**
+```bash
+node "{temp_dir}/build-payload.mjs"
+# or: python3 "{temp_dir}/build-payload.py"
+```
+
+**Step D — Verify output (optional sanity check):**
+```bash
+# Node.js
+node -e "const p=require('{temp_dir}/prr-payload.json'); console.log('OK:', p.comments.length, 'comments')"
+# Python
+python3 -c "import json; p=json.load(open('{temp_dir}/prr-payload.json')); print('OK:', len(p['comments']), 'comments')"
+```
+
+---
+
+**Payload schema reference:**
+
+**GitHub** — `{temp_dir}/prr-payload.json`:
 ```json
 {
   "commit_id": "{commit_sha}",
@@ -124,17 +219,15 @@ Verdict logic: any 🔴 → `REQUEST_CHANGES` / only 🟡 → `COMMENT` / none
   ]
 }
 ```
-Write to `{review_output}/.prr-payload.json`.
 
-**GitLab** — separate JSON per inline comment:
+**GitLab** — one file per comment `{temp_dir}/prr-payload-{n}.json` + `{temp_dir}/prr-summary.md`:
 ```json
 { "body": "{body}", "position": { "base_sha": "{base_sha}", "head_sha": "{commit_sha}",
   "start_sha": "{base_sha}", "position_type": "text",
   "new_path": "{file_path}", "new_line": {line_number} } }
 ```
-Write each as `{review_output}/.prr-payload-{n}.json`. Write summary as `.prr-summary.md`.
 
-**Azure DevOps** — thread per inline comment:
+**Azure DevOps** — `{temp_dir}/prr-thread-{n}.json` per comment:
 ```json
 { "comments": [{ "parentCommentId": 0, "content": "{body}", "commentType": 1 }],
   "threadContext": { "filePath": "{file_path}",
@@ -142,14 +235,12 @@ Write each as `{review_output}/.prr-payload-{n}.json`. Write summary as `.prr-su
     "rightFileEnd": { "line": {line_number}, "offset": 1 } },
   "status": "active" }
 ```
-Write each as `{review_output}/.prr-thread-{n}.json`.
 
-**Bitbucket** — inline comment per finding:
+**Bitbucket** — `{temp_dir}/prr-bb-{n}.json` per comment:
 ```json
 { "content": { "raw": "{body}" },
   "inline": { "to": {line_number}, "path": "{file_path}" } }
 ```
-Write each as `{review_output}/.prr-bb-{n}.json`.
 
 ### 8. Display Preview