prostgles-server 4.2.646 → 4.2.648

package/debug/after-commit-review-reproductions.patch

@@ -0,0 +1,62 @@
+--- tests/server/withUserRLS.spec.ts
++++ tests/server/withUserRLS.spec.ts
+@@ -398,6 +398,7 @@
+         hasTransactionalHandlers: boolean;
+         context: unknown;
+       }[] = [];
++      let rejectReviewUpdates = false;
+       app.use(express.json());
+ 
+       try {
+@@ -420,6 +421,12 @@
+           publish: "*",
+           tableHooks: {
+             [tableName]: {
++              afterEach: [{
++                commands: { update: 1 },
++                validate: async () => {
++                  if (rejectReviewUpdates) throw new Error("review validation rejection");
++                },
++              }],
+               afterCommit: [
+                 {
+                   commands: { insert: 1, update: 1 },
+@@ -505,6 +512,38 @@
+           assert.equal(afterCommitResults.length, 2);
+         });
+ 
++        await t.test("review: clearing a watched field must trigger afterCommit", async () => {
++          assert(instance);
++          const previousCalls = afterCommitResults.length;
++          await instance.db[tableName]!.update!({ id: -44001 }, { value: null });
++          assert.equal(afterCommitResults.length, previousCalls + 1);
++        });
++
++        await t.test("review: client updateBatch must trigger afterCommit", async () => {
++          assert(instance);
++          const { clientDb } = await instance.getClientDBHandlers(
++            { userId: requestUser.id }, undefined,
++          );
++          const previousCalls = afterCommitResults.length;
++          await clientDb[tableName]!.updateBatch!([[{ id: -44002 }, { value: "batch" }]]);
++          assert.equal((await instance.db[tableName]!.findOne!({ id: -44002 }))!.value, "batch");
++          assert.equal(afterCommitResults.length, previousCalls + 1);
++        });
++
++        await t.test("review: client updateBatch must enforce afterEach validation", async () => {
++          assert(instance);
++          const { clientDb } = await instance.getClientDBHandlers(
++            { userId: requestUser.id }, undefined,
++          );
++          rejectReviewUpdates = true;
++          try {
++            await assert.rejects(clientDb[tableName]!.update!({ id: -44002 }, { value: "blocked" }));
++            await assert.rejects(clientDb[tableName]!.updateBatch!([[{ id: -44002 }, { value: "bypass" }]]));
++          } finally {
++            rejectReviewUpdates = false;
++          }
++        });
++
+         const url = `http://127.0.0.1:${address.port}/rls-context/db/${tableName}/delete`;
+         const deleteRequest = async (sid?: string) => {
+           const response = await fetch(url, {