prostgles-server 3.0.50 → 3.0.52

package/lib/PubSubManager.js

@@ -224,8 +224,8 @@ class PubSubManager {
 
                         -- Force table into cache
                         IF EXISTS (select * from pg_extension where extname = 'pg_prewarm') THEN
-                            CREATE EXTENSION IF NOT EXISTS pg_prewarm;
-                            PERFORM pg_prewarm('prostgles.app_triggers');
+                          CREATE EXTENSION IF NOT EXISTS pg_prewarm;
+                          PERFORM pg_prewarm('prostgles.app_triggers');
                         END IF;
                     */
 
@@ -251,20 +251,24 @@ class PubSubManager {
                                 -- PERFORM pg_notify('debug', concat_ws(' ', 'TABLE', TG_TABLE_NAME, TG_OP));
 
                                 SELECT string_agg(
-                                    concat_ws(
-                                        E' UNION \n ',
-                                        CASE WHEN (TG_OP = 'DELETE' OR TG_OP = 'UPDATE') THEN (p1 || ' old_table ' || p2) END,
-                                        CASE WHEN (TG_OP = 'INSERT' OR TG_OP = 'UPDATE') THEN (p1 || ' new_table ' || p2) END 
-                                    ),
-                                    E' UNION \n '::text
+                                  concat_ws(
+                                    E' UNION \n ',
+                                    CASE WHEN (TG_OP = 'DELETE' OR TG_OP = 'UPDATE') THEN (p1 || ' old_table ' || p2) END,
+                                    CASE WHEN (TG_OP = 'INSERT' OR TG_OP = 'UPDATE') THEN (p1 || ' new_table ' || p2) END 
+                                  ),
+                                  E' UNION \n '::text
                                 )
                                 INTO unions
                                 FROM (
                                     SELECT 
-                                        $z$ SELECT CASE WHEN EXISTS( SELECT 1 FROM $z$     AS p1,
+                                        $z$ 
+                                          SELECT CASE WHEN EXISTS( SELECT 1 FROM 
+                                        $z$ AS p1,
                                         format( 
-                                            $c$ as %I WHERE %s ) THEN %s::text END AS t_ids $c$
-                                            , table_name, condition, id 
+                                          $c$ 
+                                            as %I WHERE %s ) THEN %s::text END AS t_ids 
+                                          $c$, 
+                                          table_name, condition, id 
                                         ) AS p2
                                     FROM prostgles.v_triggers
                                     WHERE table_name = TG_TABLE_NAME
@@ -272,15 +276,15 @@ class PubSubManager {
                                 
                                 /*
                                 PERFORM pg_notify( 
-                                    ${(0, exports.asValue)(this.NOTIF_CHANNEL.preffix)} || (SELECT id FROM prostgles.apps LIMIT 1) , 
-                                    concat_ws(
-                                        ${(0, exports.asValue)(PubSubManager.DELIMITER)},
-
-                                        ${(0, exports.asValue)(this.NOTIF_TYPE.data)}, 
-                                        COALESCE(TG_TABLE_NAME, 'MISSING'), 
-                                        COALESCE(TG_OP, 'MISSING'), 
-                                        unions
-                                    )
+                                  ${(0, exports.asValue)(this.NOTIF_CHANNEL.preffix)} || (SELECT id FROM prostgles.apps LIMIT 1) , 
+                                  concat_ws(
+                                    ${(0, exports.asValue)(PubSubManager.DELIMITER)},
+
+                                    ${(0, exports.asValue)(this.NOTIF_TYPE.data)}, 
+                                    COALESCE(TG_TABLE_NAME, 'MISSING'), 
+                                    COALESCE(TG_OP, 'MISSING'), 
+                                    unions
+                                  )
                                 );
                                 RAISE 'unions: % , cids: %', unions, c_ids;
                                 */
@@ -288,25 +292,25 @@ class PubSubManager {
                                 IF unions IS NOT NULL THEN
                                     query = format(
                                         $s$
-                                            SELECT ARRAY_AGG(DISTINCT t.t_ids)
-                                            FROM ( %s ) t
+                                          SELECT ARRAY_AGG(DISTINCT t.t_ids)
+                                          FROM ( %s ) t
                                         $s$, 
                                         unions
                                     );
 
                                     BEGIN
-                                        EXECUTE query INTO t_ids;
+                                      EXECUTE query INTO t_ids;
 
-                                        --RAISE NOTICE 'trigger fired ok';
+                                      --RAISE NOTICE 'trigger fired ok';
 
                                     EXCEPTION WHEN OTHERS THEN
-                                        
-                                        has_errors := TRUE;
+                                      
+                                      has_errors := TRUE;
 
-                                        GET STACKED DIAGNOSTICS 
-                                            err_text = MESSAGE_TEXT,
-                                            err_detail = PG_EXCEPTION_DETAIL,
-                                            err_hint = PG_EXCEPTION_HINT;
+                                      GET STACKED DIAGNOSTICS 
+                                        err_text = MESSAGE_TEXT,
+                                        err_detail = PG_EXCEPTION_DETAIL,
+                                        err_hint = PG_EXCEPTION_HINT;
 
 
                                     END;
@@ -925,7 +929,6 @@ class PubSubManager {
                 console.warn(190, "Trigger sub issue: ", table_name, condition_ids_str, this._triggers);
             }
         };
-        this.parseCondition = (condition) => Boolean(condition && condition.trim().length) ? condition : "TRUE";
         this.getActiveListeners = () => {
             let result = [];
             const upsert = (t, c) => {
@@ -968,11 +971,11 @@ class PubSubManager {
         */
         this.getMyTriggerQuery = async () => {
             return pgp.as.format(` 
-            SELECT * --, ROW_NUMBER() OVER(PARTITION BY table_name ORDER BY table_name, condition ) - 1 as id
-            FROM prostgles.v_triggers
-            WHERE app_id = $1
-            ORDER BY table_name, condition
-        `, [this.appID]);
+      SELECT * --, ROW_NUMBER() OVER(PARTITION BY table_name ORDER BY table_name, condition ) - 1 as id
+      FROM prostgles.v_triggers
+      WHERE app_id = $1
+      ORDER BY table_name, condition
+    `, [this.appID]);
         };
         this.addTriggerPool = undefined;
         const { wsChannelNamePrefix, pgChannelName, onSchemaChange, dboBuilder } = options;
@@ -999,7 +1002,7 @@ class PubSubManager {
         return this.postgresNotifListenManager.isListening();
     }
     getSubs(table_name, condition) {
-        return (0, utils_1.get)(this.subs, [table_name, condition, "subs"]);
+        return this.subs?.[table_name]?.[condition]?.subs;
     }
     getSyncs(table_name, condition) {
         return (this.syncs || [])
@@ -1065,7 +1068,7 @@ class PubSubManager {
      */
     async addSync(syncParams) {
         const { socket = null, table_info = null, table_rules, synced_field = null, allow_delete = false, id_fields = [], filter = {}, params, condition = "", throttle = 0 } = syncParams || {};
-        let conditionParsed = this.parseCondition(condition);
+        let conditionParsed = parseCondition(condition);
         if (!socket || !table_info)
             throw "socket or table_info missing";
         const { name: table_name } = table_info, channel_name = `${this.socketChannelPreffix}.${table_name}.${JSON.stringify(filter)}.sync`;
@@ -1156,8 +1159,8 @@ class PubSubManager {
     /* Must return a channel for socket */
     /* The distinct list of channel names must have a corresponding trigger in the database */
     async addSub(subscriptionParams) {
-        const { socket, func = null, table_info = null, table_rules, filter = {}, params = {}, condition = "", throttle = 0 //subOne = false, 
-         } = subscriptionParams || {};
+        const { socket, func = null, table_info = null, table_rules, filter = {}, params = {}, condition = "", throttle = 0, //subOne = false, 
+        relatedTableSubscriptions } = subscriptionParams || {};
         let validated_throttle = subscriptionParams.throttle || 10;
         if ((!socket && !func) || !table_info)
             throw "socket/func or table_info missing";
@@ -1168,10 +1171,10 @@ class PubSubManager {
         if (throttle && Number.isInteger(throttle) && throttle >= pubThrottle) {
             validated_throttle = throttle;
         }
-        let channel_name = `${this.socketChannelPreffix}.${table_info.name}.${JSON.stringify(filter)}.${JSON.stringify(params)}.${"m"}.sub`; //.${subOne? "o" : "m"}.sub`;
+        const channel_name = `${this.socketChannelPreffix}.${table_info.name}.${JSON.stringify(filter)}.${JSON.stringify(params)}.${"m"}.sub`;
         this.upsertSocket(socket, channel_name);
         const upsertSub = (newSubData) => {
-            const { table_name, condition: _cond, is_ready = false } = newSubData, condition = this.parseCondition(_cond), newSub = {
+            const { table_name, condition: _cond, is_ready = false, parentSubParams } = newSubData, condition = parseCondition(_cond), newSub = {
                 socket,
                 table_name: table_info.name,
                 table_info,
@@ -1179,17 +1182,17 @@ class PubSubManager {
                 params,
                 table_rules,
                 channel_name,
-                func: func ? func : undefined,
+                parentSubParams,
+                func: func ?? undefined,
                 socket_id: socket?.id,
                 throttle: validated_throttle,
                 is_throttling: null,
                 last_throttled: 0,
                 is_ready,
-                // subOne
             };
-            this.subs[table_name] = this.subs[table_name] || {};
-            this.subs[table_name][condition] = this.subs[table_name][condition] || { subs: [] };
-            this.subs[table_name][condition].subs = this.subs[table_name][condition].subs || [];
+            this.subs[table_name] = this.subs[table_name] ?? {};
+            this.subs[table_name][condition] = this.subs[table_name][condition] ?? { subs: [] };
+            this.subs[table_name][condition].subs = this.subs[table_name][condition].subs ?? [];
             // console.log("1034 upsertSub", this.subs)
             const sub_idx = this.subs[table_name][condition].subs.findIndex(s => s.channel_name === channel_name &&
                 (socket && s.socket_id === socket.id ||
@@ -1212,22 +1215,24 @@ class PubSubManager {
                 this.pushSubData(newSub);
             }
         };
-        if (table_info.is_view && table_info.parent_tables) {
-            if (table_info.parent_tables.length) {
-                let _condition = "TRUE";
-                table_info.parent_tables.map(async (table_name) => {
+        if (table_info.is_view && relatedTableSubscriptions) {
+            if (relatedTableSubscriptions.length) {
+                relatedTableSubscriptions.map(async (relatedTable) => {
+                    const params = {
+                        table_name: relatedTable.tableNameEscaped,
+                        condition: relatedTable.condition,
+                        parentSubParams: {
+                            ...subscriptionParams,
+                            channel_name
+                        },
+                    };
                     upsertSub({
-                        table_name,
-                        condition: _condition,
-                        is_ready: true
-                    });
-                    await this.addTrigger({
-                        table_name,
-                        condition: _condition
+                        ...params,
+                        is_ready: false
                     });
+                    await this.addTrigger(params);
                     upsertSub({
-                        table_name,
-                        condition: _condition,
+                        ...params,
                         is_ready: true
                     });
                 });
@@ -1243,23 +1248,25 @@ class PubSubManager {
             // console.log(table_info, 202);
             upsertSub({
                 table_name: table_info.name,
-                condition: this.parseCondition(condition),
+                condition: parseCondition(condition),
+                parentSubParams: undefined,
                 is_ready: false
             });
             await this.addTrigger({
                 table_name: table_info.name,
-                condition: this.parseCondition(condition),
+                condition: parseCondition(condition),
             });
             upsertSub({
                 table_name: table_info.name,
-                condition: this.parseCondition(condition),
+                condition: parseCondition(condition),
+                parentSubParams: undefined,
                 is_ready: true
             });
             return channel_name;
         }
     }
     removeLocalSub(table_name, condition, func) {
-        let cond = this.parseCondition(condition);
+        let cond = parseCondition(condition);
         if ((0, utils_1.get)(this.subs, [table_name, cond, "subs"])) {
             this.subs[table_name][cond].subs.map((sub, i) => {
                 if (sub.func && sub.func === func) {
@@ -1325,9 +1332,9 @@ class PubSubManager {
                 throw "MISSING table_name";
             if (!this.appID)
                 throw "MISSING appID";
-            if (!condition || !condition.trim().length)
+            if (!condition || !condition.trim().length) {
                 condition = "TRUE";
-            const app_id = this.appID;
+            }
             // console.log(1623, { app_id, addTrigger: { table_name, condition } });
             await this.checkIfTimescaleBug(table_name);
             const trgVals = {
@@ -1335,15 +1342,15 @@ class PubSubManager {
                 cond: (0, exports.asValue)(condition),
             };
             await this.db.any(`
-                BEGIN WORK;
-                LOCK TABLE prostgles.app_triggers IN ACCESS EXCLUSIVE MODE;
-
-                INSERT INTO prostgles.app_triggers (table_name, condition, app_id) 
-                    VALUES (${trgVals.tbl}, ${trgVals.cond}, ${(0, exports.asValue)(this.appID)})
-                ON CONFLICT DO NOTHING;
-                     
-                COMMIT WORK;
-            `);
+        BEGIN WORK;
+        LOCK TABLE prostgles.app_triggers IN ACCESS EXCLUSIVE MODE;
+
+        INSERT INTO prostgles.app_triggers (table_name, condition, app_id) 
+          VALUES (${trgVals.tbl}, ${trgVals.cond}, ${(0, exports.asValue)(this.appID)})
+        ON CONFLICT DO NOTHING;
+              
+        COMMIT WORK;
+      `);
             (0, exports.log)("addTrigger.. ", { table_name, condition });
             const triggers = await this.db.any(await this.getMyTriggerQuery());
             this._triggers = {};
@@ -1392,6 +1399,7 @@ PubSubManager.create = async (options) => {
 };
 PubSubManager.SCHEMA_ALTERING_QUERIES = ['CREATE TABLE', 'ALTER TABLE', 'DROP TABLE', 'CREATE VIEW', 'DROP VIEW', 'ALTER VIEW', 'CREATE TABLE AS', 'SELECT INTO'];
 PubSubManager.EXCLUDE_QUERY_FROM_SCHEMA_WATCH_ID = "prostgles internal query that should be excluded from ";
+const parseCondition = (condition) => Boolean(condition && condition.trim().length) ? condition : "TRUE";
 function omitKeys(obj, exclude) {
     return pickKeys(obj, (0, prostgles_types_1.getKeys)(obj).filter(k => !exclude.includes(k)));
 }

package/lib/PubSubManager.ts

@@ -75,6 +75,17 @@ type SubscriptionParams = {
   channel_name: string;
   table_name: string;
   socket: PRGLIOSocket | undefined;
+
+  /** 
+   * If this is a view then an array with all related tables will be  
+   * */
+  relatedTableSubscriptions?: {
+    tableName: string;
+    tableNameEscaped: string;
+    condition: string;
+  }[];
+  parentSubParams: Omit<SubscriptionParams, "parentSubParams"> | undefined;
+
   table_info: TableOrViewInfo;
   table_rules?: TableRule;
   filter: object;
@@ -342,8 +353,8 @@ export class PubSubManager {
 
                         -- Force table into cache
                         IF EXISTS (select * from pg_extension where extname = 'pg_prewarm') THEN
-                            CREATE EXTENSION IF NOT EXISTS pg_prewarm;
-                            PERFORM pg_prewarm('prostgles.app_triggers');
+                          CREATE EXTENSION IF NOT EXISTS pg_prewarm;
+                          PERFORM pg_prewarm('prostgles.app_triggers');
                         END IF;
                     */
 
@@ -369,20 +380,24 @@ export class PubSubManager {
                                 -- PERFORM pg_notify('debug', concat_ws(' ', 'TABLE', TG_TABLE_NAME, TG_OP));
 
                                 SELECT string_agg(
-                                    concat_ws(
-                                        E' UNION \n ',
-                                        CASE WHEN (TG_OP = 'DELETE' OR TG_OP = 'UPDATE') THEN (p1 || ' old_table ' || p2) END,
-                                        CASE WHEN (TG_OP = 'INSERT' OR TG_OP = 'UPDATE') THEN (p1 || ' new_table ' || p2) END 
-                                    ),
-                                    E' UNION \n '::text
+                                  concat_ws(
+                                    E' UNION \n ',
+                                    CASE WHEN (TG_OP = 'DELETE' OR TG_OP = 'UPDATE') THEN (p1 || ' old_table ' || p2) END,
+                                    CASE WHEN (TG_OP = 'INSERT' OR TG_OP = 'UPDATE') THEN (p1 || ' new_table ' || p2) END 
+                                  ),
+                                  E' UNION \n '::text
                                 )
                                 INTO unions
                                 FROM (
                                     SELECT 
-                                        $z$ SELECT CASE WHEN EXISTS( SELECT 1 FROM $z$     AS p1,
+                                        $z$ 
+                                          SELECT CASE WHEN EXISTS( SELECT 1 FROM 
+                                        $z$ AS p1,
                                         format( 
-                                            $c$ as %I WHERE %s ) THEN %s::text END AS t_ids $c$
-                                            , table_name, condition, id 
+                                          $c$ 
+                                            as %I WHERE %s ) THEN %s::text END AS t_ids 
+                                          $c$, 
+                                          table_name, condition, id 
                                         ) AS p2
                                     FROM prostgles.v_triggers
                                     WHERE table_name = TG_TABLE_NAME
@@ -390,15 +405,15 @@ export class PubSubManager {
                                 
                                 /*
                                 PERFORM pg_notify( 
-                                    ${asValue(this.NOTIF_CHANNEL.preffix)} || (SELECT id FROM prostgles.apps LIMIT 1) , 
-                                    concat_ws(
-                                        ${asValue(PubSubManager.DELIMITER)},
-
-                                        ${asValue(this.NOTIF_TYPE.data)}, 
-                                        COALESCE(TG_TABLE_NAME, 'MISSING'), 
-                                        COALESCE(TG_OP, 'MISSING'), 
-                                        unions
-                                    )
+                                  ${asValue(this.NOTIF_CHANNEL.preffix)} || (SELECT id FROM prostgles.apps LIMIT 1) , 
+                                  concat_ws(
+                                    ${asValue(PubSubManager.DELIMITER)},
+
+                                    ${asValue(this.NOTIF_TYPE.data)}, 
+                                    COALESCE(TG_TABLE_NAME, 'MISSING'), 
+                                    COALESCE(TG_OP, 'MISSING'), 
+                                    unions
+                                  )
                                 );
                                 RAISE 'unions: % , cids: %', unions, c_ids;
                                 */
@@ -406,25 +421,25 @@ export class PubSubManager {
                                 IF unions IS NOT NULL THEN
                                     query = format(
                                         $s$
-                                            SELECT ARRAY_AGG(DISTINCT t.t_ids)
-                                            FROM ( %s ) t
+                                          SELECT ARRAY_AGG(DISTINCT t.t_ids)
+                                          FROM ( %s ) t
                                         $s$, 
                                         unions
                                     );
 
                                     BEGIN
-                                        EXECUTE query INTO t_ids;
+                                      EXECUTE query INTO t_ids;
 
-                                        --RAISE NOTICE 'trigger fired ok';
+                                      --RAISE NOTICE 'trigger fired ok';
 
                                     EXCEPTION WHEN OTHERS THEN
-                                        
-                                        has_errors := TRUE;
+                                      
+                                      has_errors := TRUE;
 
-                                        GET STACKED DIAGNOSTICS 
-                                            err_text = MESSAGE_TEXT,
-                                            err_detail = PG_EXCEPTION_DETAIL,
-                                            err_hint = PG_EXCEPTION_HINT;
+                                      GET STACKED DIAGNOSTICS 
+                                        err_text = MESSAGE_TEXT,
+                                        err_detail = PG_EXCEPTION_DETAIL,
+                                        err_hint = PG_EXCEPTION_HINT;
 
 
                                     END;
@@ -986,7 +1001,7 @@ export class PubSubManager {
   }
 
   getSubs(table_name: string, condition: string): SubscriptionParams[] {
-    return get(this.subs, [table_name, condition, "subs"])
+    return this.subs?.[table_name]?.[condition]?.subs
   }
 
   getSyncs(table_name: string, condition: string) {
@@ -1185,7 +1200,7 @@ export class PubSubManager {
       params, condition = "", throttle = 0
     } = syncParams || {};
 
-    let conditionParsed = this.parseCondition(condition);
+    let conditionParsed = parseCondition(condition);
     if (!socket || !table_info) throw "socket or table_info missing";
 
 
@@ -1289,16 +1304,16 @@ export class PubSubManager {
     await this.addTrigger({ table_name, condition: conditionParsed });
 
     return channel_name;
-  }
-
-  parseCondition = (condition: string): string => Boolean(condition && condition.trim().length) ? condition : "TRUE"
+  } 
+  
 
   /* Must return a channel for socket */
   /* The distinct list of channel names must have a corresponding trigger in the database */
-  async addSub(subscriptionParams: Omit<AddSubscriptionParams, "channel_name">) {
+  async addSub(subscriptionParams: Omit<AddSubscriptionParams, "channel_name" | "parentSubParams">) {
     const {
       socket, func = null, table_info = null, table_rules, filter = {},
-      params = {}, condition = "", throttle = 0  //subOne = false, 
+      params = {}, condition = "", throttle = 0,  //subOne = false, 
+      relatedTableSubscriptions
     } = subscriptionParams || {};
 
     let validated_throttle = subscriptionParams.throttle || 10;
@@ -1312,13 +1327,13 @@ export class PubSubManager {
       validated_throttle = throttle;
     }
 
-    let channel_name = `${this.socketChannelPreffix}.${table_info.name}.${JSON.stringify(filter)}.${JSON.stringify(params)}.${"m"}.sub`;  //.${subOne? "o" : "m"}.sub`;
+    const channel_name = `${this.socketChannelPreffix}.${table_info.name}.${JSON.stringify(filter)}.${JSON.stringify(params)}.${"m"}.sub`;
 
     this.upsertSocket(socket, channel_name);
 
-    const upsertSub = (newSubData: { table_name: string, condition: string, is_ready: boolean }) => {
-      const { table_name, condition: _cond, is_ready = false } = newSubData,
-        condition = this.parseCondition(_cond),
+    const upsertSub = (newSubData: { table_name: string; condition: string; is_ready: boolean; parentSubParams: SubscriptionParams["parentSubParams"] }) => {
+      const { table_name, condition: _cond, is_ready = false, parentSubParams } = newSubData,
+        condition = parseCondition(_cond),
         newSub: SubscriptionParams = {
           socket,
           table_name: table_info.name,
@@ -1327,18 +1342,18 @@ export class PubSubManager {
           params,
           table_rules,
           channel_name,
-          func: func ? func : undefined,
+          parentSubParams,
+          func: func ?? undefined,
           socket_id: socket?.id,
           throttle: validated_throttle,
           is_throttling: null,
           last_throttled: 0,
           is_ready,
-          // subOne
         };
 
-      this.subs[table_name] = this.subs[table_name] || {};
-      this.subs[table_name][condition] = this.subs[table_name][condition] || { subs: [] };
-      this.subs[table_name][condition].subs = this.subs[table_name][condition].subs || [];
+      this.subs[table_name] = this.subs[table_name] ?? {};
+      this.subs[table_name][condition] = this.subs[table_name][condition] ?? { subs: [] };
+      this.subs[table_name][condition].subs = this.subs[table_name][condition].subs ?? [];
 
       // console.log("1034 upsertSub", this.subs)
       const sub_idx = this.subs[table_name][condition].subs.findIndex(s =>
@@ -1368,26 +1383,28 @@ export class PubSubManager {
     };
 
 
-    if (table_info.is_view && table_info.parent_tables) {
-      if (table_info.parent_tables.length) {
-
-        let _condition = "TRUE";
-        table_info.parent_tables.map(async table_name => {
-
+    if (table_info.is_view && relatedTableSubscriptions) {
+      if (relatedTableSubscriptions.length) {
+ 
+        relatedTableSubscriptions.map(async relatedTable => {
+          const params: Omit<Parameters<typeof upsertSub>[0], "is_ready"> = {
+            table_name: relatedTable.tableNameEscaped,
+            condition: relatedTable.condition,
+            parentSubParams: {
+              ...subscriptionParams,
+              channel_name
+            },
+          } 
+          
           upsertSub({
-            table_name,
-            condition: _condition,
-            is_ready: true
+            ...params,
+            is_ready: false
           });
 
-          await this.addTrigger({
-            table_name,
-            condition: _condition
-          });
+          await this.addTrigger(params);
 
           upsertSub({
-            table_name,
-            condition: _condition,
+            ...params,
             is_ready: true
           });
         });
@@ -1403,16 +1420,18 @@ export class PubSubManager {
 
       upsertSub({
         table_name: table_info.name,
-        condition: this.parseCondition(condition),
+        condition: parseCondition(condition),
+        parentSubParams: undefined,
         is_ready: false
       });
       await this.addTrigger({
         table_name: table_info.name,
-        condition: this.parseCondition(condition),
+        condition: parseCondition(condition),
       });
       upsertSub({
         table_name: table_info.name,
-        condition: this.parseCondition(condition),
+        condition: parseCondition(condition),
+        parentSubParams: undefined,
         is_ready: true
       });
 
@@ -1421,7 +1440,7 @@ export class PubSubManager {
   }
 
   removeLocalSub(table_name: string, condition: string, func: (items: object[]) => any) {
-    let cond = this.parseCondition(condition);
+    let cond = parseCondition(condition);
     if (get(this.subs, [table_name, cond, "subs"])) {
       this.subs[table_name][cond].subs.map((sub, i) => {
         if (
@@ -1538,11 +1557,11 @@ export class PubSubManager {
 
   getMyTriggerQuery = async () => {
     return pgp.as.format(` 
-            SELECT * --, ROW_NUMBER() OVER(PARTITION BY table_name ORDER BY table_name, condition ) - 1 as id
-            FROM prostgles.v_triggers
-            WHERE app_id = $1
-            ORDER BY table_name, condition
-        `, [this.appID]
+      SELECT * --, ROW_NUMBER() OVER(PARTITION BY table_name ORDER BY table_name, condition ) - 1 as id
+      FROM prostgles.v_triggers
+      WHERE app_id = $1
+      ORDER BY table_name, condition
+    `, [this.appID]
     )
   }
 
@@ -1556,9 +1575,9 @@ export class PubSubManager {
       if (!table_name) throw "MISSING table_name";
       if (!this.appID) throw "MISSING appID";
 
-      if (!condition || !condition.trim().length) condition = "TRUE";
-
-      const app_id = this.appID;
+      if (!condition || !condition.trim().length) {
+        condition = "TRUE";
+      }
 
       // console.log(1623, { app_id, addTrigger: { table_name, condition } });
 
@@ -1567,18 +1586,18 @@ export class PubSubManager {
       const trgVals = {
         tbl: asValue(table_name),
         cond: asValue(condition),
-      }
+      };
 
       await this.db.any(`
-                BEGIN WORK;
-                LOCK TABLE prostgles.app_triggers IN ACCESS EXCLUSIVE MODE;
+        BEGIN WORK;
+        LOCK TABLE prostgles.app_triggers IN ACCESS EXCLUSIVE MODE;
 
-                INSERT INTO prostgles.app_triggers (table_name, condition, app_id) 
-                    VALUES (${trgVals.tbl}, ${trgVals.cond}, ${asValue(this.appID)})
-                ON CONFLICT DO NOTHING;
-                     
-                COMMIT WORK;
-            `);
+        INSERT INTO prostgles.app_triggers (table_name, condition, app_id) 
+          VALUES (${trgVals.tbl}, ${trgVals.cond}, ${asValue(this.appID)})
+        ON CONFLICT DO NOTHING;
+              
+        COMMIT WORK;
+      `);
 
       log("addTrigger.. ", { table_name, condition });
 
@@ -1611,6 +1630,9 @@ export class PubSubManager {
   }
 }
 
+
+const parseCondition = (condition: string): string => Boolean(condition && condition.trim().length) ? condition : "TRUE"
+
 export function omitKeys<T extends AnyObject, Exclude extends keyof T>(obj: T, exclude: Exclude[]): Omit<T, Exclude> {
   return pickKeys(obj, getKeys(obj).filter(k => !exclude.includes(k as any)))
 }

package/lib/PublishParser.js

@@ -73,7 +73,7 @@ const RULE_TO_METHODS = [
         sqlRule: "select",
         methods: prostgles_types_1.RULE_METHODS.subscribe,
         no_limits: { throttle: 0 },
-        table_only: true,
+        table_only: false,
         allowed_params: ["throttle"],
         hint: ` expecting "*" | true | { throttle: number } \n Will use "select" rules`
     }