prosemirror-view 1.42.3 → 1.42.5

package/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 1.42.5 (2026-09-21)
+
+### Bug fixes
+
+Fix an issue where some kinds of deletions on Chrome Android were interpreted as Enter presses.
+
+Fix a regression where some types of Enter presses on Android would not go through the Enter key handling.
+
+## 1.42.4 (2026-09-18)
+
+### Bug fixes
+
+Prevent uneditable elements rendered as part of node or mark view from blocking cursor motion.
+
+Fix a bug that could break some types of composition input starting with a non-empty selection.
+
 ## 1.42.3 (2026-08-25)
 
 ### Bug fixes

package/dist/index.cjs

@@ -2400,7 +2400,7 @@ function nodeLen(node) {
 }
 function isIgnorable(dom, dir) {
   var desc = dom.pmViewDesc;
-  return desc && desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR");
+  return desc ? desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR") : dom.nodeType == 1 && dom.contentEditable == "false";
 }
 function skipIgnoredNodes(view, dir) {
   return dir < 0 ? skipIgnoredNodesBefore(view) : skipIgnoredNodesAfter(view);
@@ -2913,11 +2913,10 @@ function addContext(slice, context) {
     var type = schema.nodes[array[i]];
     if (!type || type.hasRequiredAttrs()) break;
     try {
-      type.checkAttrs(array[i + 1]);
+      content = prosemirrorModel.Fragment.from(type.create(array[i + 1], content));
     } catch (e) {
       break;
     }
-    content = prosemirrorModel.Fragment.from(type.create(array[i + 1], content));
     openStart++;
     openEnd++;
   }
@@ -3387,7 +3386,7 @@ editHandlers.compositionstart = editHandlers.compositionupdate = function (view)
     view.domObserver.flush();
     var state = view.state,
       $pos = state.selection.$to;
-    if (state.selection instanceof prosemirrorState.TextSelection && (state.storedMarks || !$pos.textOffset && $pos.parentOffset && $pos.nodeBefore.marks.some(function (m) {
+    if (state.selection instanceof prosemirrorState.TextSelection && state.selection.empty && (state.storedMarks || !$pos.textOffset && $pos.parentOffset && $pos.nodeBefore.marks.some(function (m) {
       return m.type.spec.inclusive === false;
     }) || chrome && windows && selectionBeforeUneditable(view))) {
       view.markCursor = view.state.storedMarks || $pos.marks();
@@ -4891,7 +4890,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
   var inlineChange = $from.sameParent($to) && $from.parent.inlineContent && $fromA.end() >= change.endA;
   if ((ios && view.input.lastIOSEnter > Date.now() - 225 && (!inlineChange || addedNodes.some(function (n) {
     return n.nodeName == "DIV" || n.nodeName == "P";
-  })) || !inlineChange && $from.pos < parse.doc.content.size && (!$from.sameParent($to) || !$from.parent.inlineContent) && $from.pos < $to.pos && !/\S/.test(parse.doc.textBetween($from.pos, $to.pos, "", ""))) && view.someProp("handleKeyDown", function (f) {
+  })) || !inlineChange && looksLikeEnter(parse.doc, $from.pos, $to.pos)) && view.someProp("handleKeyDown", function (f) {
     return f(view, keyEvent(13, "Enter"));
   })) {
     view.input.lastIOSEnter = 0;
@@ -5004,6 +5003,14 @@ function looksLikeBackspace(old, start, end, $newStart, $newEnd) {
   if (!$next.parent.isTextblock || $next.pos > end || skipClosingAndOpening($next, true, false) < end) return false;
   return $newStart.parent.content.cut($newStart.parentOffset).eq($next.parent.content);
 }
+function looksLikeEnter(content, from, to) {
+  var newTextlines = 0,
+    newLeaves = 0;
+  content.nodesBetween(from, to, function (node, pos) {
+    if (node.isTextblock && pos >= from && pos < to) newTextlines++;else if (node.isText ? /\S/.test(node.text.slice(Math.max(0, from - pos), Math.min(node.nodeSize, to - pos))) : node.isLeaf) newLeaves++;
+  });
+  return newLeaves == 0 && newTextlines == 1;
+}
 function skipClosingAndOpening($pos, fromEnd, mayOpen) {
   var depth = $pos.depth,
     end = fromEnd ? $pos.end() : $pos.pos;

package/dist/index.js

@@ -2494,7 +2494,8 @@ function nodeLen(node) {
 }
 function isIgnorable(dom, dir) {
     let desc = dom.pmViewDesc;
-    return desc && desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR");
+    return desc ? desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR")
+        : dom.nodeType == 1 && dom.contentEditable == "false";
 }
 function skipIgnoredNodes(view, dir) {
     return dir < 0 ? skipIgnoredNodesBefore(view) : skipIgnoredNodesAfter(view);
@@ -3083,12 +3084,11 @@ function addContext(slice, context) {
         if (!type || type.hasRequiredAttrs())
             break;
         try {
-            type.checkAttrs(array[i + 1]);
+            content = Fragment.from(type.create(array[i + 1], content));
         }
         catch (e) {
             break;
         }
-        content = Fragment.from(type.create(array[i + 1], content));
         openStart++;
         openEnd++;
     }
@@ -3569,7 +3569,7 @@ editHandlers.compositionstart = editHandlers.compositionupdate = view => {
     if (!view.composing) {
         view.domObserver.flush();
         let { state } = view, $pos = state.selection.$to;
-        if (state.selection instanceof TextSelection &&
+        if (state.selection instanceof TextSelection && state.selection.empty &&
             (state.storedMarks ||
                 (!$pos.textOffset && $pos.parentOffset && $pos.nodeBefore.marks.some(m => m.type.spec.inclusive === false)) ||
                 chrome && windows && selectionBeforeUneditable(view))) { // Issue #1500
@@ -5206,9 +5206,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
     // as being an iOS enter press), just dispatch an Enter key instead.
     if (((ios && view.input.lastIOSEnter > Date.now() - 225 &&
         (!inlineChange || addedNodes.some(n => n.nodeName == "DIV" || n.nodeName == "P"))) ||
-        (!inlineChange && $from.pos < parse.doc.content.size &&
-            (!$from.sameParent($to) || !$from.parent.inlineContent) &&
-            $from.pos < $to.pos && !/\S/.test(parse.doc.textBetween($from.pos, $to.pos, "", "")))) &&
+        (!inlineChange && looksLikeEnter(parse.doc, $from.pos, $to.pos))) &&
         view.someProp("handleKeyDown", f => f(view, keyEvent(13, "Enter")))) {
         view.input.lastIOSEnter = 0;
         return;
@@ -5359,6 +5357,16 @@ function looksLikeBackspace(old, start, end, $newStart, $newEnd) {
     // The fragments after the join point must match
     return $newStart.parent.content.cut($newStart.parentOffset).eq($next.parent.content);
 }
+function looksLikeEnter(content, from, to) {
+    let newTextlines = 0, newLeaves = 0;
+    content.nodesBetween(from, to, (node, pos) => {
+        if (node.isTextblock && pos >= from && pos < to)
+            newTextlines++;
+        else if (node.isText ? /\S/.test(node.text.slice(Math.max(0, from - pos), Math.min(node.nodeSize, to - pos))) : node.isLeaf)
+            newLeaves++;
+    });
+    return newLeaves == 0 && newTextlines == 1;
+}
 function skipClosingAndOpening($pos, fromEnd, mayOpen) {
     let depth = $pos.depth, end = fromEnd ? $pos.end() : $pos.pos;
     while (depth > 0 && (fromEnd || $pos.indexAfter(depth) == $pos.node(depth).childCount)) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.42.3",
+  "version": "1.42.5",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",
@@ -28,7 +28,7 @@
     "url": "git+https://code.haverbeke.berlin/prosemirror/prosemirror-view.git"
   },
   "dependencies": {
-    "prosemirror-model": "^1.25.8",
+    "prosemirror-model": "^1.25.12",
     "prosemirror-state": "^1.0.0",
     "prosemirror-transform": "^1.1.0"
   },

package/src/capturekeys.ts

@@ -61,7 +61,8 @@ function nodeLen(node: Node) {
 
 function isIgnorable(dom: Node, dir: number) {
   let desc = dom.pmViewDesc
-  return desc && desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR")
+  return desc ? desc.size == 0 && (dir < 0 || dom.nextSibling || dom.nodeName != "BR")
+    : dom.nodeType == 1 && (dom as HTMLElement).contentEditable == "false"
 }
 
 function skipIgnoredNodes(view: EditorView, dir: number) {

package/src/clipboard.ts

@@ -270,9 +270,11 @@ function addContext(slice: Slice, context: string) {
   for (let i = array.length - 2; i >= 0; i -= 2) {
     let type = schema.nodes[array[i]]
     if (!type || type.hasRequiredAttrs()) break
-    try { type.checkAttrs(array[i + 1]) }
-    catch(e) { break }
-    content = Fragment.from(type.create(array[i + 1], content))
+    try {
+      content = Fragment.from(type.create(array[i + 1], content))
+    } catch(e) {
+      break
+    }
     openStart++; openEnd++
   }
   return new Slice(content, openStart, openEnd)

package/src/domchange.ts

@@ -180,9 +180,7 @@ export function readDOMChange(view: EditorView, from: number, to: number, typeOv
   // as being an iOS enter press), just dispatch an Enter key instead.
   if (((browser.ios && view.input.lastIOSEnter > Date.now() - 225 &&
         (!inlineChange || addedNodes.some(n => n.nodeName == "DIV" || n.nodeName == "P"))) ||
-       (!inlineChange && $from.pos < parse.doc.content.size &&
-        (!$from.sameParent($to) || !$from.parent.inlineContent) &&
-        $from.pos < $to.pos && !/\S/.test(parse.doc.textBetween($from.pos, $to.pos, "", "")))) &&
+       (!inlineChange && looksLikeEnter(parse.doc, $from.pos, $to.pos))) &&
       view.someProp("handleKeyDown", f => f(view, keyEvent(13, "Enter")))) {
     view.input.lastIOSEnter = 0
     return
@@ -333,6 +331,17 @@ function looksLikeBackspace(old: Node, start: number, end: number, $newStart: Re
   return $newStart.parent.content.cut($newStart.parentOffset).eq($next.parent.content)
 }
 
+function looksLikeEnter(content: Node, from: number, to: number) {
+  let newTextlines = 0, newLeaves = 0
+  content.nodesBetween(from, to, (node, pos) => {
+    if (node.isTextblock && pos >= from && pos < to)
+      newTextlines++
+    else if (node.isText ? /\S/.test(node.text!.slice(Math.max(0, from - pos), Math.min(node.nodeSize, to - pos))) : node.isLeaf)
+      newLeaves++
+  })
+  return newLeaves == 0 && newTextlines == 1
+}
+
 function skipClosingAndOpening($pos: ResolvedPos, fromEnd: boolean, mayOpen: boolean) {
   let depth = $pos.depth, end = fromEnd ? $pos.end() : $pos.pos
   while (depth > 0 && (fromEnd || $pos.indexAfter(depth) == $pos.node(depth).childCount)) {

package/src/input.ts

@@ -518,7 +518,7 @@ editHandlers.compositionstart = editHandlers.compositionupdate = view => {
   if (!view.composing) {
     view.domObserver.flush()
     let {state} = view, $pos = state.selection.$to
-    if (state.selection instanceof TextSelection &&
+    if (state.selection instanceof TextSelection && state.selection.empty &&
         (state.storedMarks ||
          (!$pos.textOffset && $pos.parentOffset && $pos.nodeBefore!.marks.some(m => m.type.spec.inclusive === false)) ||
          browser.chrome && browser.windows && selectionBeforeUneditable(view))) { // Issue #1500