prosemirror-view 1.42.0 → 1.42.2

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 1.42.2 (2026-07-24)
+
+### Bug fixes
+
+Enable a workaround for backspace not taking effect on Android for Firefox as well as Chrome (for which it already kicked in).
+
+Work around the situation where Chrome/Webkit replace a node's content DOM with a completely different element.
+
+## 1.42.1 (2026-07-11)
+
+### Bug fixes
+
+Don't scroll to a bogus position when trying to scroll an element that has no layout into view.
+
 ## 1.42.0 (2026-07-01)
 
 ### Bug fixes

package/dist/index.cjs

@@ -202,6 +202,7 @@ function clientRect(node) {
   };
 }
 function scrollRectIntoView(view, rect, startDOM) {
+  if (!nonZero(rect) && rect.left == 0) return;
   var scrollThreshold = view.someProp("scrollThreshold") || 0,
     scrollMargin = view.someProp("scrollMargin") || 5;
   var doc = view.dom.ownerDocument;
@@ -686,7 +687,7 @@ var ViewDesc = function () {
     }
   }, {
     key: "parseRule",
-    value: function parseRule() {
+    value: function parseRule(addedNodes) {
       return null;
     }
   }, {
@@ -1284,7 +1285,7 @@ var NodeViewDesc = function (_ViewDesc4) {
   }
   _createClass(NodeViewDesc, [{
     key: "parseRule",
-    value: function parseRule() {
+    value: function parseRule(addedNodes) {
       var _this5 = this;
       if (this.node.type.spec.reparseInView) return null;
       var rule = {
@@ -1306,9 +1307,14 @@ var NodeViewDesc = function (_ViewDesc4) {
             break;
           }
         }
-        if (!rule.contentElement) rule.getContent = function () {
-          return prosemirrorModel.Fragment.empty;
-        };
+        if (!rule.contentElement) {
+          var found = addedNodes && addedNodes.find(function (n) {
+            return n.nodeType == 1 && addedNodes.indexOf(n.parentNode) < 0 && _this5.dom.contains(n);
+          });
+          if (found) rule.contentElement = found;else rule.getContent = function () {
+            return prosemirrorModel.Fragment.empty;
+          };
+        }
       }
       return rule;
     }
@@ -3668,7 +3674,7 @@ handlers.blur = function (view, _event) {
 };
 handlers.beforeinput = function (view, _event) {
   var event = _event;
-  if (chrome && android && event.inputType == "deleteContentBackward") {
+  if (android && event.inputType == "deleteContentBackward") {
     view.domObserver.flushSoon();
     var domChangeCount = view.input.domChangeCount;
     setTimeout(function () {
@@ -4705,7 +4711,7 @@ function fixUpBadSafariComposition(view, addedNodes) {
     _iterator5.f();
   }
 }
-function parseBetween(view, from_, to_) {
+function parseBetween(view, from_, to_, addedNodes) {
   var _view$docView$parseRa = view.docView.parseRange(from_, to_),
     parent = _view$docView$parseRa.node,
     fromOffset = _view$docView$parseRa.fromOffset,
@@ -4748,7 +4754,7 @@ function parseBetween(view, from_, to_) {
       to: toOffset,
       preserveWhitespace: $from.parent.type.whitespace == "pre" ? "full" : true,
       findPositions: find,
-      ruleFromNode: ruleFromNode,
+      ruleFromNode: ruleFromNode(addedNodes),
       context: $from
     });
   if (find && find[0].pos != null) {
@@ -4767,29 +4773,31 @@ function parseBetween(view, from_, to_) {
     to: to
   };
 }
-function ruleFromNode(dom) {
-  var desc = dom.pmViewDesc;
-  if (desc) {
-    return desc.parseRule();
-  } else if (dom.nodeName == "BR" && dom.parentNode) {
-    if (safari && /^(ul|ol)$/i.test(dom.parentNode.nodeName)) {
-      var skip = document.createElement("div");
-      skip.appendChild(document.createElement("li"));
-      return {
-        skip: skip
-      };
-    } else if (dom.parentNode.lastChild == dom || safari && /^(tr|table)$/i.test(dom.parentNode.nodeName)) {
+var ruleFromNode = function ruleFromNode(added) {
+  return function (dom) {
+    var desc = dom.pmViewDesc;
+    if (desc) {
+      return desc.parseRule(added);
+    } else if (dom.nodeName == "BR" && dom.parentNode) {
+      if (safari && /^(ul|ol)$/i.test(dom.parentNode.nodeName)) {
+        var skip = document.createElement("div");
+        skip.appendChild(document.createElement("li"));
+        return {
+          skip: skip
+        };
+      } else if (dom.parentNode.lastChild == dom || safari && /^(tr|table)$/i.test(dom.parentNode.nodeName)) {
+        return {
+          ignore: true
+        };
+      }
+    } else if (dom.nodeName == "IMG" && dom.getAttribute("mark-placeholder")) {
       return {
         ignore: true
       };
     }
-  } else if (dom.nodeName == "IMG" && dom.getAttribute("mark-placeholder")) {
-    return {
-      ignore: true
-    };
-  }
-  return null;
-}
+    return null;
+  };
+};
 var isInline = /^(a|abbr|acronym|b|bd[io]|big|br|button|cite|code|data(list)?|del|dfn|em|i|img|ins|kbd|label|map|mark|meter|output|q|ruby|s|samp|small|span|strong|su[bp]|time|u|tt|var)$/i;
 function readDOMChange(view, from, to, typeOver, addedNodes) {
   var compositionID = view.input.compositionPendingChanges || (view.composing ? view.input.compositionID : 0);
@@ -4813,7 +4821,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
   from = $before.before(shared + 1);
   to = view.state.doc.resolve(to).after(shared + 1);
   var sel = view.state.selection;
-  var parse = parseBetween(view, from, to);
+  var parse = parseBetween(view, from, to, addedNodes);
   var doc = view.state.doc,
     compare = doc.slice(parse.from, parse.to);
   var preferredPos, preferredSide;

package/dist/index.js

@@ -207,6 +207,9 @@ function clientRect(node) {
         top: rect.top, bottom: rect.top + node.clientHeight * scaleY };
 }
 function scrollRectIntoView(view, rect, startDOM) {
+    // Skip empty rects with all sides at 0, for example, when the element has no CSS box (display: none)
+    if (!nonZero(rect) && rect.left == 0)
+        return;
     let scrollThreshold = view.someProp("scrollThreshold") || 0, scrollMargin = view.someProp("scrollMargin") || 5;
     let doc = view.dom.ownerDocument;
     for (let parent = startDOM || view.dom;;) {
@@ -761,7 +764,7 @@ class ViewDesc {
     // When parsing in-editor content (in domchange.js), we allow
     // descriptions to determine the parse rules that should be used to
     // parse them.
-    parseRule() { return null; }
+    parseRule(addedNodes) { return null; }
     // Used by the editor's event handler to ignore events that come
     // from certain descs.
     stopEvent(event) { return false; }
@@ -1325,7 +1328,7 @@ class NodeViewDesc extends ViewDesc {
         else
             return new NodeViewDesc(parent, node, outerDeco, innerDeco, dom, contentDOM || null, nodeDOM);
     }
-    parseRule() {
+    parseRule(addedNodes) {
         // Experimental kludge to allow opt-in re-parsing of nodes
         if (this.node.type.spec.reparseInView)
             return null;
@@ -1353,8 +1356,14 @@ class NodeViewDesc extends ViewDesc {
                     break;
                 }
             }
-            if (!rule.contentElement)
-                rule.getContent = () => Fragment.empty;
+            if (!rule.contentElement) {
+                let found = addedNodes &&
+                    addedNodes.find(n => n.nodeType == 1 && addedNodes.indexOf(n.parentNode) < 0 && this.dom.contains(n));
+                if (found)
+                    rule.contentElement = found;
+                else
+                    rule.getContent = () => Fragment.empty;
+            }
         }
         return rule;
     }
@@ -3908,8 +3917,8 @@ handlers.beforeinput = (view, _event) => {
     // We should probably do more with beforeinput events, but support
     // is so spotty that I'm still waiting to see where they are going.
     // Very specific hack to deal with backspace sometimes failing on
-    // Chrome Android when after an uneditable node.
-    if (chrome && android && event.inputType == "deleteContentBackward") {
+    // Chrome and Firefox Android when after an uneditable node.
+    if (android && event.inputType == "deleteContentBackward") {
         view.domObserver.flushSoon();
         let { domChangeCount } = view.input;
         setTimeout(() => {
@@ -5013,7 +5022,7 @@ function fixUpBadSafariComposition(view, addedNodes) {
 // that the DOM represents. If any changes came in in the meantime,
 // the modification is mapped over those before it is applied, in
 // readDOMChange.
-function parseBetween(view, from_, to_) {
+function parseBetween(view, from_, to_, addedNodes) {
     let { node: parent, fromOffset, toOffset, from, to } = view.docView.parseRange(from_, to_);
     let domSel = view.domSelectionRange();
     let find;
@@ -5047,7 +5056,7 @@ function parseBetween(view, from_, to_) {
         to: toOffset,
         preserveWhitespace: $from.parent.type.whitespace == "pre" ? "full" : true,
         findPositions: find,
-        ruleFromNode,
+        ruleFromNode: ruleFromNode(addedNodes),
         context: $from
     });
     if (find && find[0].pos != null) {
@@ -5058,10 +5067,10 @@ function parseBetween(view, from_, to_) {
     }
     return { doc, sel, from, to };
 }
-function ruleFromNode(dom) {
+const ruleFromNode = (added) => (dom) => {
     let desc = dom.pmViewDesc;
     if (desc) {
-        return desc.parseRule();
+        return desc.parseRule(added);
     }
     else if (dom.nodeName == "BR" && dom.parentNode) {
         // Safari replaces the list item or table cell with a BR
@@ -5080,7 +5089,7 @@ function ruleFromNode(dom) {
         return { ignore: true };
     }
     return null;
-}
+};
 const isInline = /^(a|abbr|acronym|b|bd[io]|big|br|button|cite|code|data(list)?|del|dfn|em|i|img|ins|kbd|label|map|mark|meter|output|q|ruby|s|samp|small|span|strong|su[bp]|time|u|tt|var)$/i;
 function readDOMChange(view, from, to, typeOver, addedNodes) {
     let compositionID = view.input.compositionPendingChanges || (view.composing ? view.input.compositionID : 0);
@@ -5109,7 +5118,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
     from = $before.before(shared + 1);
     to = view.state.doc.resolve(to).after(shared + 1);
     let sel = view.state.selection;
-    let parse = parseBetween(view, from, to);
+    let parse = parseBetween(view, from, to, addedNodes);
     let doc = view.state.doc, compare = doc.slice(parse.from, parse.to);
     let preferredPos, preferredSide;
     // Prefer anchoring to end when Backspace is pressed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.42.0",
+  "version": "1.42.2",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",

package/src/domchange.ts

@@ -12,7 +12,7 @@ import {EditorView} from "./index"
 // the modification is mapped over those before it is applied, in
 // readDOMChange.
 
-function parseBetween(view: EditorView, from_: number, to_: number) {
+function parseBetween(view: EditorView, from_: number, to_: number, addedNodes: readonly DOMNode[]) {
   let {node: parent, fromOffset, toOffset, from, to} = view.docView.parseRange(from_, to_)
 
   let domSel = view.domSelectionRange()
@@ -44,7 +44,7 @@ function parseBetween(view: EditorView, from_: number, to_: number) {
     to: toOffset,
     preserveWhitespace: $from.parent.type.whitespace == "pre" ? "full" : true,
     findPositions: find,
-    ruleFromNode,
+    ruleFromNode: ruleFromNode(addedNodes),
     context: $from
   })
   if (find && find[0].pos != null) {
@@ -55,10 +55,10 @@ function parseBetween(view: EditorView, from_: number, to_: number) {
   return {doc, sel, from, to}
 }
 
-function ruleFromNode(dom: DOMNode): Omit<TagParseRule, "tag"> | null {
+const ruleFromNode = (added: readonly DOMNode[]) => (dom: DOMNode): Omit<TagParseRule, "tag"> | null => {
   let desc = dom.pmViewDesc
   if (desc) {
-    return desc.parseRule()
+    return desc.parseRule(added)
   } else if (dom.nodeName == "BR" && dom.parentNode) {
     // Safari replaces the list item or table cell with a BR
     // directly in the list node (?!) if you delete the last
@@ -105,7 +105,7 @@ export function readDOMChange(view: EditorView, from: number, to: number, typeOv
   to = view.state.doc.resolve(to).after(shared + 1)
 
   let sel = view.state.selection
-  let parse = parseBetween(view, from, to)
+  let parse = parseBetween(view, from, to, addedNodes)
 
   let doc = view.state.doc, compare = doc.slice(parse.from, parse.to)
   let preferredPos, preferredSide: "start" | "end"

package/src/domcoords.ts

@@ -30,6 +30,9 @@ function clientRect(node: HTMLElement): Rect {
 }
 
 export function scrollRectIntoView(view: EditorView, rect: Rect, startDOM: Node) {
+  // Skip empty rects with all sides at 0, for example, when the element has no CSS box (display: none)
+  if (!nonZero(rect) && rect.left == 0) return
+
   let scrollThreshold = view.someProp("scrollThreshold") || 0, scrollMargin = view.someProp("scrollMargin") || 5
   let doc = view.dom.ownerDocument
   for (let parent: Node | null = startDOM || view.dom;;) {
@@ -328,7 +331,7 @@ export function posAtCoords(view: EditorView, coords: {top: number, left: number
   return {pos, inside: desc ? desc.posAtStart - desc.border : -1}
 }
 
-function nonZero(rect: DOMRect) {
+function nonZero(rect: Rect) {
   return rect.top < rect.bottom || rect.left < rect.right
 }
 

package/src/input.ts

@@ -864,8 +864,8 @@ handlers.beforeinput = (view, _event: Event) => {
   // is so spotty that I'm still waiting to see where they are going.
 
   // Very specific hack to deal with backspace sometimes failing on
-  // Chrome Android when after an uneditable node.
-  if (browser.chrome && browser.android && event.inputType == "deleteContentBackward") {
+  // Chrome and Firefox Android when after an uneditable node.
+  if (browser.android && event.inputType == "deleteContentBackward") {
     view.domObserver.flushSoon()
     let {domChangeCount} = view.input
     setTimeout(() => {

package/src/viewdesc.ts

@@ -167,7 +167,7 @@ export class ViewDesc {
   // When parsing in-editor content (in domchange.js), we allow
   // descriptions to determine the parse rules that should be used to
   // parse them.
-  parseRule(): Omit<TagParseRule, "tag"> | null { return null }
+  parseRule(addedNodes?: readonly DOMNode[]): Omit<TagParseRule, "tag"> | null { return null }
 
   // Used by the editor's event handler to ignore events that come
   // from certain descs.
@@ -727,7 +727,7 @@ export class NodeViewDesc extends ViewDesc {
       return new NodeViewDesc(parent, node, outerDeco, innerDeco, dom, contentDOM || null, nodeDOM)
   }
 
-  parseRule() {
+  parseRule(addedNodes?: readonly DOMNode[]) {
     // Experimental kludge to allow opt-in re-parsing of nodes
     if (this.node.type.spec.reparseInView) return null
     // FIXME the assumption that this can always return the current
@@ -751,7 +751,14 @@ export class NodeViewDesc extends ViewDesc {
           break
         }
       }
-      if (!rule.contentElement) rule.getContent = () => Fragment.empty
+      if (!rule.contentElement) {
+        let found = addedNodes &&
+          addedNodes.find(n => n.nodeType == 1 && addedNodes.indexOf(n.parentNode!) < 0 && this.dom.contains(n))
+        if (found)
+          rule.contentElement = found as HTMLElement
+        else
+          rule.getContent = () => Fragment.empty
+      }
     }
     return rule
   }