prosemirror-view 1.41.6 → 1.41.8

package/CHANGELOG.md

@@ -1,3 +1,19 @@
+## 1.41.8 (2026-04-02)
+
+### Bug fixes
+
+Make the types reflect that mark and node views should render elements, not any DOM node.
+
+Fix a bug causing `dragCopies` to be ignored when it returned false.
+
+## 1.41.7 (2026-03-18)
+
+### Bug fixes
+
+Work around a Chrome bug where it sometimes inserts a random `<br>` node when you press backspace before a widget.
+
+Fix a crash that could happen when deleting content during a node drag.
+
 ## 1.41.6 (2026-02-06)
 
 ### Bug fixes
@@ -2068,7 +2084,7 @@ Fixes a problem where triple-clicking the editor would sometimes cause the scrol
 
 The `inclusiveLeft` and `inclusiveRight` options to inline decorations were renamed to [`inclusiveStart`](https://prosemirror.net/docs/ref/version/0.20.0.html#view.Decoration^inline^spec.inclusiveStart) and [`inclusiveEnd`](https://prosemirror.net/docs/ref/version/0.20.0.html#view.Decoration^inline^spec.inclusiveEnd) so that they also make sense in right-to-left text. The old names work with a warning until the next release.
 
-The default styling for lists and blockquotes was removed from `prosemirror.css`. (They were moved to the [`example-setup`](https://github.com/ProseMirror/prosemirror-example-setup) module.)
+The default styling for lists and blockquotes was removed from `prosemirror.css`. (They were moved to the [`example-setup`](https://code.haverbeke.berlin/prosemirror/prosemirror-example-setup) module.)
 
 ### Bug fixes
 
@@ -2242,7 +2258,7 @@ Fix DOM parsing for decorated text nodes.
 
 The editor view no longer wraps its editable DOM element in a wrapper element. The `ProseMirror` CSS class now applies directly to the editable element. The `ProseMirror-content` CSS class is still present for ease of upgrading but will be dropped in the next release.
 
-The editor view no longer draws a drop cursor when dragging content over the editor. The new [`prosemirror-dropcursor`](https://github.com/prosemirror/prosemirror-dropcursor) module implements this as a plugin.
+The editor view no longer draws a drop cursor when dragging content over the editor. The new [`prosemirror-dropcursor`](https://code.haverbeke.berlin/prosemirror/prosemirror-dropcursor) module implements this as a plugin.
 
 ### Bug fixes
 

package/CONTRIBUTING.md

@@ -12,7 +12,7 @@ Community discussion, questions, and informal bug reporting is done on the
 ## Submitting bug reports
 
 Report bugs on the
-[GitHub issue tracker](http://github.com/prosemirror/prosemirror/issues).
+[issue tracker](https://code.haverbeke.berlin/prosemirror/prosemirror/issues).
 Before reporting a bug, please read these pointers.
 
 - The issue tracker is for *bugs*, not requests for help. Questions
@@ -34,25 +34,28 @@ Before reporting a bug, please read these pointers.
 
 ## Contributing code
 
+Code generated by a language model is not welcome in this project.
+Please don't waste my time with it.
+
 If you want to make a change that involves a significant overhaul of
 the code or introduces a user-visible new feature, create an
-[RFC](https://github.com/ProseMirror/rfcs/) first with your proposal.
+[issue](https://code.haverbeke.berlin/prosemirror/prosemirror/issues/)
+first with your proposal.
 
-- Make sure you have a [GitHub Account](https://github.com/signup/free)
+- Make sure you have a [Codeberg](https://codeberg.org/user/sign_up)
+  or [GitHub](https://github.com/signup/free) account.
+  
+- Use that to create a [code.haverbeke.berlin
+  account](https://code.haverbeke.berlin/user/login).
 
-- Fork the relevant repository
-  ([how to fork a repo](https://help.github.com/articles/fork-a-repo))
+- Fork the relevant repository.
 
 - Create a local checkout of the code. You can use the
-  [main repository](https://github.com/prosemirror/prosemirror) to
+  [main repository](https://code.haverbeke.berlin/prosemirror/prosemirror) to
   easily check out all core modules.
 
 - Make your changes, and commit them
 
-- Follow the code style of the rest of the project (see below). Run
-  `npm run lint` (in the main repository checkout) to make sure that
-  the linter is happy.
-
 - If your changes are easy to test or likely to regress, add tests in
   the relevant `test/` directory. Either put them in an existing
   `test-*.js` file, if they fit there, or add a new file.
@@ -60,13 +63,13 @@ the code or introduces a user-visible new feature, create an
 - Make sure all tests pass. Run `npm run test` to verify tests pass
   (you will need Node.js v6+).
 
-- Submit a pull request ([how to create a pull request](https://help.github.com/articles/fork-a-repo)).
-  Don't put more than one feature/fix in a single pull request.
+- Submit a pull request. Don't put more than one feature/fix in a
+  single pull request.
 
 By contributing code to ProseMirror you
 
  - Agree to license the contributed code under the project's [MIT
-   license](https://github.com/ProseMirror/prosemirror/blob/master/LICENSE).
+   license](https://code.haverbeke.berlin/prosemirror/prosemirror/blob/main/LICENSE).
 
  - Confirm that you have the right to contribute and license the code
    in question. (Either you hold all rights on the code, or the rights
@@ -86,19 +89,16 @@ By contributing code to ProseMirror you
 - Follow the surrounding code when it comes to spacing, brace
   placement, etc.
 
-- Brace-less single-statement bodies are encouraged (whenever they
-  don't impact readability).
+- Brace-less single-statement bodies are encouraged whenever they
+  don't impact readability.
 
-- [getdocs](https://github.com/marijnh/getdocs)-style doc comments
+- [getdocs-ts](https://code.haverbeke.berlin/marijn/getdocs-ts)-style doc comments
   above items that are part of the public API.
 
 - When documenting non-public items, you can put the type after a
   single colon, so that getdocs doesn't pick it up and add it to the
   API reference.
 
-- The linter (`npm run lint`) complains about unused variables and
-  functions. Prefix their names with an underscore to muffle it.
-
 - ProseMirror does *not* follow JSHint or JSLint prescribed style.
   Patches that try to 'fix' code to pass one of these linters will not
   be accepted.

package/README.md

@@ -1,6 +1,6 @@
 # prosemirror-view
 
-[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://github.com/prosemirror/prosemirror/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**CHANGELOG**](https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md) ]
+[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://code.haverbeke.berlin/prosemirror/prosemirror/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**CHANGELOG**](https://code.haverbeke.berlin/prosemirror/prosemirror-view/src/branch/main/CHANGELOG.md) ]
 
 This is a [core module](https://prosemirror.net/docs/ref/#view) of [ProseMirror](https://prosemirror.net).
 ProseMirror is a well-behaved rich semantic content editor based on
@@ -16,10 +16,10 @@ number of [examples](https://prosemirror.net/examples/) and the
 [documentation](https://prosemirror.net/docs/).
 
 This code is released under an
-[MIT license](https://github.com/prosemirror/prosemirror/tree/master/LICENSE).
+[MIT license](https://code.haverbeke.berlin/prosemirror/prosemirror/src/branch/main/LICENSE).
 There's a [forum](http://discuss.prosemirror.net) for general
 discussion and support requests, and the
-[GitHub bug tracker](https://github.com/prosemirror/prosemirror/issues)
+[bug tracker](https://code.haverbeke.berlin/prosemirror/prosemirror/issues)
 is the place to report issues.
 
 We aim to be an inclusive, welcoming community. To make that explicit,

package/dist/index.cjs

@@ -3183,7 +3183,7 @@ var MouseDown = function () {
     var targetDesc = target ? view.docView.nearestDesc(target, true) : null;
     this.target = targetDesc && targetDesc.nodeDOM.nodeType == 1 ? targetDesc.nodeDOM : null;
     var selection = view.state.selection;
-    if (event.button == 0 && targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false || selection instanceof prosemirrorState.NodeSelection && selection.from <= targetPos && selection.to > targetPos) this.mightDrag = {
+    if (event.button == 0 && (targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false || selection instanceof prosemirrorState.NodeSelection && selection.from <= targetPos && selection.to > targetPos)) this.mightDrag = {
       node: targetNode,
       pos: targetPos,
       addAttr: !!(this.target && !this.target.draggable),
@@ -3462,10 +3462,11 @@ var Dragging = _createClass(function Dragging(slice, move, node) {
 });
 var dragCopyModifier = mac ? "altKey" : "ctrlKey";
 function dragMoves(view, event) {
-  var moves = view.someProp("dragCopies", function (test) {
-    return !test(event);
+  var copy;
+  view.someProp("dragCopies", function (test) {
+    copy = copy || test(event);
   });
-  return moves != null ? moves : !event[dragCopyModifier];
+  return copy != null ? !copy : !event[dragCopyModifier];
 }
 handlers.dragstart = function (view, _event) {
   var event = _event;
@@ -4413,7 +4414,13 @@ var DOMObserver = function () {
             var node = _step3.value;
             if (node.nodeName == "BR" && node.parentNode) {
               var after = node.nextSibling;
-              if (after && after.nodeType == 1 && after.contentEditable == "false") node.parentNode.removeChild(node);
+              while (after && after.nodeType == 1) {
+                if (after.contentEditable == "false") {
+                  node.parentNode.removeChild(node);
+                  break;
+                }
+                after = after.firstChild;
+              }
             }
           }
         } catch (err) {
@@ -5129,11 +5136,11 @@ var EditorView = function () {
     value: function updateDraggedNode(dragging, prev) {
       var sel = dragging.node,
         found = -1;
-      if (this.state.doc.nodeAt(sel.from) == sel.node) {
+      if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
         found = sel.from;
       } else {
         var movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size);
-        var moved = movedPos > 0 && this.state.doc.nodeAt(movedPos);
+        var moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos);
         if (moved == sel.node) found = movedPos;
       }
       this.dragging = new Dragging(dragging.slice, dragging.move, found < 0 ? undefined : prosemirrorState.NodeSelection.create(this.state.doc, found));

package/dist/index.d.cts

@@ -275,7 +275,7 @@ interface NodeView {
     /**
     The outer DOM node that represents the document node.
     */
-    dom: DOMNode;
+    dom: HTMLElement;
     /**
     The DOM node that should hold the node's content. Only meaningful
     if the node view also defines a `dom` property and if its node
@@ -356,7 +356,7 @@ interface MarkView {
     /**
     The outer DOM node that represents the document node.
     */
-    dom: DOMNode;
+    dom: HTMLElement;
     /**
     The DOM node that should hold the mark's content. When this is not
     present, the `dom` property is used as the content DOM.

package/dist/index.d.ts

@@ -275,7 +275,7 @@ interface NodeView {
     /**
     The outer DOM node that represents the document node.
     */
-    dom: DOMNode;
+    dom: HTMLElement;
     /**
     The DOM node that should hold the node's content. Only meaningful
     if the node view also defines a `dom` property and if its node
@@ -356,7 +356,7 @@ interface MarkView {
     /**
     The outer DOM node that represents the document node.
     */
-    dom: DOMNode;
+    dom: HTMLElement;
     /**
     The DOM node that should hold the mark's content. When this is not
     present, the `dom` property is used as the content DOM.

package/dist/index.js

@@ -3353,8 +3353,8 @@ class MouseDown {
         this.target = targetDesc && targetDesc.nodeDOM.nodeType == 1 ? targetDesc.nodeDOM : null;
         let { selection } = view.state;
         if (event.button == 0 &&
-            targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false ||
-            selection instanceof NodeSelection && selection.from <= targetPos && selection.to > targetPos)
+            (targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false ||
+                selection instanceof NodeSelection && selection.from <= targetPos && selection.to > targetPos))
             this.mightDrag = {
                 node: targetNode,
                 pos: targetPos,
@@ -3703,8 +3703,9 @@ class Dragging {
 }
 const dragCopyModifier = mac ? "altKey" : "ctrlKey";
 function dragMoves(view, event) {
-    let moves = view.someProp("dragCopies", test => !test(event));
-    return moves != null ? moves : !event[dragCopyModifier];
+    let copy;
+    view.someProp("dragCopies", test => { copy = copy || test(event); });
+    return copy != null ? !copy : !event[dragCopyModifier];
 }
 handlers.dragstart = (view, _event) => {
     let event = _event;
@@ -3731,7 +3732,7 @@ handlers.dragstart = (view, _event) => {
     if (!event.dataTransfer.files.length || !chrome || chrome_version > 120)
         event.dataTransfer.clearData();
     event.dataTransfer.setData(brokenClipboardAPI ? "Text" : "text/html", dom.innerHTML);
-    // See https://github.com/ProseMirror/prosemirror/issues/1156
+    // See https://code.haverbeke.berlin/prosemirror/prosemirror/issues/1156
     event.dataTransfer.effectAllowed = "copyMove";
     if (!brokenClipboardAPI)
         event.dataTransfer.setData("text/plain", text);
@@ -4730,8 +4731,13 @@ class DOMObserver {
             for (let node of added)
                 if (node.nodeName == "BR" && node.parentNode) {
                     let after = node.nextSibling;
-                    if (after && after.nodeType == 1 && after.contentEditable == "false")
-                        node.parentNode.removeChild(node);
+                    while (after && after.nodeType == 1) {
+                        if (after.contentEditable == "false") {
+                            node.parentNode.removeChild(node);
+                            break;
+                        }
+                        after = after.firstChild;
+                    }
                 }
         }
         else if (gecko && added.length) {
@@ -5360,7 +5366,7 @@ class EditorView {
         this.pluginViews = [];
         /**
         Holds `true` when a hack node is needed in Firefox to prevent the
-        [space is eaten issue](https://github.com/ProseMirror/prosemirror/issues/651)
+        [space is eaten issue](https://code.haverbeke.berlin/prosemirror/prosemirror/issues/651)
         @internal
         */
         this.requiresGeckoHackNode = false;
@@ -5578,12 +5584,12 @@ class EditorView {
     }
     updateDraggedNode(dragging, prev) {
         let sel = dragging.node, found = -1;
-        if (this.state.doc.nodeAt(sel.from) == sel.node) {
+        if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
             found = sel.from;
         }
         else {
             let movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size);
-            let moved = movedPos > 0 && this.state.doc.nodeAt(movedPos);
+            let moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos);
             if (moved == sel.node)
                 found = movedPos;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.41.6",
+  "version": "1.41.8",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",
@@ -25,7 +25,7 @@
   ],
   "repository": {
     "type": "git",
-    "url": "git://github.com/prosemirror/prosemirror-view.git"
+    "url": "git+https://code.haverbeke.berlin/prosemirror/prosemirror-view.git"
   },
   "dependencies": {
     "prosemirror-model": "^1.20.0",

package/src/domobserver.ts

@@ -197,8 +197,13 @@ export class DOMObserver {
       // backspace out the last bit of text before an inline-flex node (#1552)
       for (let node of added) if (node.nodeName == "BR" && node.parentNode) {
         let after = node.nextSibling
-        if (after && after.nodeType == 1 && (after as HTMLElement).contentEditable == "false")
-          node.parentNode.removeChild(node)
+        while (after && after.nodeType == 1) {
+          if ((after as HTMLElement).contentEditable == "false") {
+            node.parentNode.removeChild(node)
+            break
+          }
+          after = after.firstChild
+        }
       }
     } else if (browser.gecko && added.length) {
       let brs = added.filter(n => n.nodeName == "BR") as HTMLElement[]

package/src/index.ts

@@ -54,7 +54,7 @@ export class EditorView {
   /// @internal
   declare domObserver: DOMObserver
   /// Holds `true` when a hack node is needed in Firefox to prevent the
-  /// [space is eaten issue](https://github.com/ProseMirror/prosemirror/issues/651)
+  /// [space is eaten issue](https://code.haverbeke.berlin/prosemirror/prosemirror/issues/651)
   /// @internal
   requiresGeckoHackNode: boolean = false
 
@@ -274,11 +274,11 @@ export class EditorView {
 
   private updateDraggedNode(dragging: Dragging, prev: EditorState) {
     let sel = dragging.node!, found = -1
-    if (this.state.doc.nodeAt(sel.from) == sel.node) {
+    if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
       found = sel.from
     } else {
       let movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size)
-      let moved = movedPos > 0 && this.state.doc.nodeAt(movedPos)
+      let moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos)
       if (moved == sel.node) found = movedPos
     }
     this.dragging = new Dragging(dragging.slice, dragging.move,

package/src/input.ts

@@ -334,8 +334,8 @@ class MouseDown {
 
     let {selection} = view.state
     if (event.button == 0 &&
-        targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false ||
-        selection instanceof NodeSelection && selection.from <= targetPos && selection.to > targetPos)
+        (targetNode.type.spec.draggable && targetNode.type.spec.selectable !== false ||
+         selection instanceof NodeSelection && selection.from <= targetPos && selection.to > targetPos))
       this.mightDrag = {
         node: targetNode,
         pos: targetPos,
@@ -673,8 +673,9 @@ export class Dragging {
 const dragCopyModifier: keyof DragEvent = browser.mac ? "altKey" : "ctrlKey"
 
 function dragMoves(view: EditorView, event: DragEvent) {
-  let moves = view.someProp("dragCopies", test => !test(event))
-  return moves != null ? moves : !event[dragCopyModifier]
+  let copy: boolean | undefined
+  view.someProp("dragCopies", test => { copy = copy || test(event) })
+  return copy != null ? !copy : !event[dragCopyModifier]
 }
 
 handlers.dragstart = (view, _event) => {
@@ -701,7 +702,7 @@ handlers.dragstart = (view, _event) => {
   if (!event.dataTransfer.files.length || !browser.chrome || browser.chrome_version > 120)
     event.dataTransfer.clearData()
   event.dataTransfer.setData(brokenClipboardAPI ? "Text" : "text/html", dom.innerHTML)
-  // See https://github.com/ProseMirror/prosemirror/issues/1156
+  // See https://code.haverbeke.berlin/prosemirror/prosemirror/issues/1156
   event.dataTransfer.effectAllowed = "copyMove"
   if (!brokenClipboardAPI) event.dataTransfer.setData("text/plain", text)
   view.dragging = new Dragging(slice, dragMoves(view, event), node)

package/src/viewdesc.ts

@@ -30,7 +30,7 @@ export type ViewMutationRecord = MutationRecord | { type: "selection", target: D
 /// Objects returned as node views must conform to this interface.
 export interface NodeView {
   /// The outer DOM node that represents the document node.
-  dom: DOMNode
+  dom: HTMLElement
 
   /// The DOM node that should hold the node's content. Only meaningful
   /// if the node view also defines a `dom` property and if its node
@@ -99,7 +99,7 @@ export interface NodeView {
 /// Objects returned as mark views must conform to this interface.
 export interface MarkView {
   /// The outer DOM node that represents the document node.
-  dom: DOMNode
+  dom: HTMLElement
 
   /// The DOM node that should hold the mark's content. When this is not
   /// present, the `dom` property is used as the content DOM.
@@ -610,7 +610,7 @@ class CompositionViewDesc extends ViewDesc {
 // some cases they will be split more often than would appear
 // necessary.
 class MarkViewDesc extends ViewDesc {
-  constructor(parent: ViewDesc, readonly mark: Mark, dom: DOMNode, contentDOM: HTMLElement, readonly spec: MarkView) {
+  constructor(parent: ViewDesc, readonly mark: Mark, dom: HTMLElement, contentDOM: HTMLElement, readonly spec: MarkView) {
     super(parent, [], dom, contentDOM)
   }
 
@@ -697,13 +697,13 @@ export class NodeViewDesc extends ViewDesc {
       if (descObj.parent) return descObj.parent.posBeforeChild(descObj)
     }, outerDeco, innerDeco)
 
-    let dom = spec && spec.dom, contentDOM = spec && spec.contentDOM
+    let dom: DOMNode | undefined = spec && spec.dom, contentDOM = spec && spec.contentDOM
     if (node.isText) {
       if (!dom) dom = document.createTextNode(node.text!)
       else if (dom.nodeType != 3) throw new RangeError("Text must be rendered as a DOM text node")
     } else if (!dom) {
       let spec = (DOMSerializer.renderSpec as any)(document, node.type.spec.toDOM!(node), null, node.attrs)
-      ;({dom, contentDOM} = spec as {dom: DOMNode, contentDOM?: HTMLElement})
+      ;({dom, contentDOM} = spec as {dom: HTMLElement, contentDOM?: HTMLElement})
     }
     if (!contentDOM && !node.isText && dom.nodeName != "BR") { // Chrome gets confused by <br contenteditable=false>
       if (!(dom as HTMLElement).hasAttribute("contenteditable")) (dom as HTMLElement).contentEditable = "false"
@@ -714,8 +714,8 @@ export class NodeViewDesc extends ViewDesc {
     dom = applyOuterDeco(dom, outerDeco, node)
 
     if (spec)
-      return descObj = new CustomNodeViewDesc(parent, node, outerDeco, innerDeco, dom, contentDOM || null, nodeDOM,
-                                              spec, view, pos + 1)
+      return descObj = new CustomNodeViewDesc(parent, node, outerDeco, innerDeco, dom as HTMLElement, contentDOM || null,
+                                              nodeDOM as HTMLElement, spec, view, pos + 1)
     else if (node.isText)
       return new TextViewDesc(parent, node, outerDeco, innerDeco, dom, nodeDOM, view)
     else
@@ -985,7 +985,7 @@ class TrailingHackViewDesc extends ViewDesc {
 // customized.
 class CustomNodeViewDesc extends NodeViewDesc {
   constructor(parent: ViewDesc | undefined, node: Node, outerDeco: readonly Decoration[], innerDeco: DecorationSource,
-              dom: DOMNode, contentDOM: HTMLElement | null, nodeDOM: DOMNode, readonly spec: NodeView,
+              dom: HTMLElement, contentDOM: HTMLElement | null, nodeDOM: HTMLElement, readonly spec: NodeView,
               view: EditorView, pos: number) {
     super(parent, node, outerDeco, innerDeco, dom, contentDOM, nodeDOM, view, pos)
   }

package/style/prosemirror.css

@@ -23,7 +23,7 @@
 .ProseMirror-hideselection *::-moz-selection { background: transparent; }
 .ProseMirror-hideselection { caret-color: transparent; }
 
-/* See https://github.com/ProseMirror/prosemirror/issues/1421#issuecomment-1759320191 */
+/* See https://code.haverbeke.berlin/prosemirror/prosemirror/issues/1421#issuecomment-1759320191 */
 .ProseMirror [draggable][contenteditable=false] { user-select: text }
 
 .ProseMirror-selectednode {