prosemirror-view 1.41.5 → 1.41.7

package/CHANGELOG.md

@@ -1,3 +1,17 @@
+## 1.41.7 (2026-03-18)
+
+### Bug fixes
+
+Work around a Chrome bug where it sometimes inserts a random `<br>` node when you press backspace before a widget.
+
+Fix a crash that could happen when deleting content during a node drag.
+
+## 1.41.6 (2026-02-06)
+
+### Bug fixes
+
+Fix an issue where backspacing content before a flexbox or grid styled widget would insert a bogus line break on Firefox.
+
 ## 1.41.5 (2026-01-14)
 
 ### Bug fixes

package/dist/index.cjs

@@ -4403,7 +4403,31 @@ var DOMObserver = function () {
           }
         }
       }
-      if (gecko && added.length) {
+      if (added.some(function (n) {
+        return n.nodeName == "BR";
+      }) && (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
+        var _iterator3 = _createForOfIteratorHelper(added),
+          _step3;
+        try {
+          for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
+            var node = _step3.value;
+            if (node.nodeName == "BR" && node.parentNode) {
+              var after = node.nextSibling;
+              while (after && after.nodeType == 1) {
+                if (after.contentEditable == "false") {
+                  node.parentNode.removeChild(node);
+                  break;
+                }
+                after = after.firstChild;
+              }
+            }
+          }
+        } catch (err) {
+          _iterator3.e(err);
+        } finally {
+          _iterator3.f();
+        }
+      } else if (gecko && added.length) {
         var brs = added.filter(function (n) {
           return n.nodeName == "BR";
         });
@@ -4414,38 +4438,20 @@ var DOMObserver = function () {
           if (a.parentNode && a.parentNode.parentNode == b.parentNode) b.remove();else a.remove();
         } else {
           var focusNode = this.currentSelection.focusNode;
-          var _iterator3 = _createForOfIteratorHelper(brs),
-            _step3;
+          var _iterator4 = _createForOfIteratorHelper(brs),
+            _step4;
           try {
-            for (_iterator3.s(); !(_step3 = _iterator3.n()).done;) {
-              var br = _step3.value;
+            for (_iterator4.s(); !(_step4 = _iterator4.n()).done;) {
+              var br = _step4.value;
               var parent = br.parentNode;
               if (parent && parent.nodeName == "LI" && (!focusNode || blockParent(view, focusNode) != parent)) br.remove();
             }
           } catch (err) {
-            _iterator3.e(err);
+            _iterator4.e(err);
           } finally {
-            _iterator3.f();
+            _iterator4.f();
           }
         }
-      } else if ((chrome || safari) && added.some(function (n) {
-        return n.nodeName == "BR";
-      }) && (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
-        var _iterator4 = _createForOfIteratorHelper(added),
-          _step4;
-        try {
-          for (_iterator4.s(); !(_step4 = _iterator4.n()).done;) {
-            var node = _step4.value;
-            if (node.nodeName == "BR" && node.parentNode) {
-              var after = node.nextSibling;
-              if (after && after.nodeType == 1 && after.contentEditable == "false") node.parentNode.removeChild(node);
-            }
-          }
-        } catch (err) {
-          _iterator4.e(err);
-        } finally {
-          _iterator4.f();
-        }
       }
       var readSel = null;
       if (from < 0 && newSel && view.input.lastFocus > Date.now() - 200 && Math.max(view.input.lastTouch, view.input.lastClick.time) < Date.now() - 300 && selectionCollapsed(sel) && (readSel = selectionFromDOM(view)) && readSel.eq(prosemirrorState.Selection.near(view.state.doc.resolve(0), 1))) {
@@ -5129,11 +5135,11 @@ var EditorView = function () {
     value: function updateDraggedNode(dragging, prev) {
       var sel = dragging.node,
         found = -1;
-      if (this.state.doc.nodeAt(sel.from) == sel.node) {
+      if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
         found = sel.from;
       } else {
         var movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size);
-        var moved = movedPos > 0 && this.state.doc.nodeAt(movedPos);
+        var moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos);
         if (moved == sel.node) found = movedPos;
       }
       this.dragging = new Dragging(dragging.slice, dragging.move, found < 0 ? undefined : prosemirrorState.NodeSelection.create(this.state.doc, found));

package/dist/index.js

@@ -4724,7 +4724,22 @@ class DOMObserver {
                 }
             }
         }
-        if (gecko && added.length) {
+        if (added.some(n => n.nodeName == "BR") && (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
+            // Browsers sometimes insert a bogus break node if you
+            // backspace out the last bit of text before an inline-flex node (#1552)
+            for (let node of added)
+                if (node.nodeName == "BR" && node.parentNode) {
+                    let after = node.nextSibling;
+                    while (after && after.nodeType == 1) {
+                        if (after.contentEditable == "false") {
+                            node.parentNode.removeChild(node);
+                            break;
+                        }
+                        after = after.firstChild;
+                    }
+                }
+        }
+        else if (gecko && added.length) {
             let brs = added.filter(n => n.nodeName == "BR");
             if (brs.length == 2) {
                 let [a, b] = brs;
@@ -4742,17 +4757,6 @@ class DOMObserver {
                 }
             }
         }
-        else if ((chrome || safari) && added.some(n => n.nodeName == "BR") &&
-            (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
-            // Chrome/Safari sometimes insert a bogus break node if you
-            // backspace out the last bit of text before an inline-flex node (#1552)
-            for (let node of added)
-                if (node.nodeName == "BR" && node.parentNode) {
-                    let after = node.nextSibling;
-                    if (after && after.nodeType == 1 && after.contentEditable == "false")
-                        node.parentNode.removeChild(node);
-                }
-        }
         let readSel = null;
         // If it looks like the browser has reset the selection to the
         // start of the document after focus, restore the selection from
@@ -5579,12 +5583,12 @@ class EditorView {
     }
     updateDraggedNode(dragging, prev) {
         let sel = dragging.node, found = -1;
-        if (this.state.doc.nodeAt(sel.from) == sel.node) {
+        if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
             found = sel.from;
         }
         else {
             let movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size);
-            let moved = movedPos > 0 && this.state.doc.nodeAt(movedPos);
+            let moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos);
             if (moved == sel.node)
                 found = movedPos;
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.41.5",
+  "version": "1.41.7",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",

package/src/domobserver.ts

@@ -192,7 +192,20 @@ export class DOMObserver {
       }
     }
 
-    if (browser.gecko && added.length) {
+    if (added.some(n => n.nodeName == "BR") && (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
+      // Browsers sometimes insert a bogus break node if you
+      // backspace out the last bit of text before an inline-flex node (#1552)
+      for (let node of added) if (node.nodeName == "BR" && node.parentNode) {
+        let after = node.nextSibling
+        while (after && after.nodeType == 1) {
+          if ((after as HTMLElement).contentEditable == "false") {
+            node.parentNode.removeChild(node)
+            break
+          }
+          after = after.firstChild
+        }
+      }
+    } else if (browser.gecko && added.length) {
       let brs = added.filter(n => n.nodeName == "BR") as HTMLElement[]
       if (brs.length == 2) {
         let [a, b] = brs
@@ -206,15 +219,6 @@ export class DOMObserver {
             br.remove()
         }
       }
-    } else if ((browser.chrome || browser.safari) && added.some(n => n.nodeName == "BR") &&
-               (view.input.lastKeyCode == 8 || view.input.lastKeyCode == 46)) {
-      // Chrome/Safari sometimes insert a bogus break node if you
-      // backspace out the last bit of text before an inline-flex node (#1552)
-      for (let node of added) if (node.nodeName == "BR" && node.parentNode) {
-        let after = node.nextSibling
-        if (after && after.nodeType == 1 && (after as HTMLElement).contentEditable == "false")
-          node.parentNode.removeChild(node)
-      }
     }
 
     let readSel: Selection | null = null

package/src/index.ts

@@ -274,11 +274,11 @@ export class EditorView {
 
   private updateDraggedNode(dragging: Dragging, prev: EditorState) {
     let sel = dragging.node!, found = -1
-    if (this.state.doc.nodeAt(sel.from) == sel.node) {
+    if (sel.from < this.state.doc.content.size && this.state.doc.nodeAt(sel.from) == sel.node) {
       found = sel.from
     } else {
       let movedPos = sel.from + (this.state.doc.content.size - prev.doc.content.size)
-      let moved = movedPos > 0 && this.state.doc.nodeAt(movedPos)
+      let moved = movedPos > 0 && movedPos < this.state.doc.content.size && this.state.doc.nodeAt(movedPos)
       if (moved == sel.node) found = movedPos
     }
     this.dragging = new Dragging(dragging.slice, dragging.move,