prosemirror-view 1.36.0 → 1.37.1

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 1.37.1 (2024-12-11)
+
+### Bug fixes
+
+Fix an issue where `display: content` elements could break `posAtCoords`.
+
+Work around an issue with Chrome reporting the selection incorrectly during composition.
+
+## 1.37.0 (2024-11-23)
+
+### Bug fixes
+
+Fix an issue on Safari where the (incorrect) top-level selection was used, instead of the workaround that also works inside shadow roots.
+
+### New features
+
+Mark views can now provide an `ignoreMutation` method. Add ViewMutationRecord to doc template
+
 ## 1.36.0 (2024-11-05)
 
 ### Bug fixes

package/dist/index.cjs

@@ -389,10 +389,10 @@ function posFromCaret(view, node, offset, coords) {
   var outsideBlock = -1;
   for (var cur = node, sawBlock = false;;) {
     if (cur == view.dom) break;
-    var desc = view.docView.nearestDesc(cur, true);
+    var desc = view.docView.nearestDesc(cur, true),
+      rect = void 0;
     if (!desc) return null;
-    if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM)) {
-      var rect = desc.dom.getBoundingClientRect();
+    if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM) && ((rect = desc.dom.getBoundingClientRect()).width || rect.height)) {
       if (desc.node.isBlock && desc.parent) {
         if (!sawBlock && rect.left > coords.left || rect.top > coords.top) outsideBlock = desc.posBefore;else if (!sawBlock && rect.right < coords.left || rect.bottom < coords.top) outsideBlock = desc.posAfter;
         sawBlock = true;
@@ -935,19 +935,20 @@ var ViewDesc = function () {
     }
   }, {
     key: "setSelection",
-    value: function setSelection(anchor, head, root) {
+    value: function setSelection(anchor, head, view) {
       var force = arguments.length > 3 && arguments[3] !== undefined ? arguments[3] : false;
       var from = Math.min(anchor, head),
         to = Math.max(anchor, head);
       for (var i = 0, offset = 0; i < this.children.length; i++) {
         var child = this.children[i],
           end = offset + child.size;
-        if (from > offset && to < end) return child.setSelection(anchor - offset - child.border, head - offset - child.border, root, force);
+        if (from > offset && to < end) return child.setSelection(anchor - offset - child.border, head - offset - child.border, view, force);
         offset = end;
       }
       var anchorDOM = this.domFromPos(anchor, anchor ? -1 : 1);
       var headDOM = head == anchor ? anchorDOM : this.domFromPos(head, head ? -1 : 1);
-      var domSel = root.getSelection();
+      var domSel = view.root.getSelection();
+      var selRange = view.domSelectionRange();
       var brKludge = false;
       if ((gecko || safari) && anchor == head) {
         var _anchorDOM = anchorDOM,
@@ -973,11 +974,11 @@ var ViewDesc = function () {
           brKludge = prev && (prev.nodeName == "BR" || prev.contentEditable == "false");
         }
       }
-      if (gecko && domSel.focusNode && domSel.focusNode != headDOM.node && domSel.focusNode.nodeType == 1) {
-        var _after2 = domSel.focusNode.childNodes[domSel.focusOffset];
+      if (gecko && selRange.focusNode && selRange.focusNode != headDOM.node && selRange.focusNode.nodeType == 1) {
+        var _after2 = selRange.focusNode.childNodes[selRange.focusOffset];
         if (_after2 && _after2.contentEditable == "false") force = true;
       }
-      if (!(force || brKludge && safari) && isEquivalentPosition(anchorDOM.node, anchorDOM.offset, domSel.anchorNode, domSel.anchorOffset) && isEquivalentPosition(headDOM.node, headDOM.offset, domSel.focusNode, domSel.focusOffset)) return;
+      if (!(force || brKludge && safari) && isEquivalentPosition(anchorDOM.node, anchorDOM.offset, selRange.anchorNode, selRange.anchorOffset) && isEquivalentPosition(headDOM.node, headDOM.offset, selRange.focusNode, selRange.focusOffset)) return;
       var domSelExtended = false;
       if ((domSel.extend || anchor == head) && !brKludge) {
         domSel.collapse(anchorDOM.node, anchorDOM.offset);
@@ -1213,6 +1214,11 @@ var MarkViewDesc = function (_ViewDesc3) {
       copy.children = nodes;
       return copy;
     }
+  }, {
+    key: "ignoreMutation",
+    value: function ignoreMutation(mutation) {
+      return this.spec.ignoreMutation ? this.spec.ignoreMutation(mutation) : _get(_getPrototypeOf(MarkViewDesc.prototype), "ignoreMutation", this).call(this, mutation);
+    }
   }, {
     key: "destroy",
     value: function destroy() {
@@ -1593,8 +1599,8 @@ var CustomNodeViewDesc = function (_NodeViewDesc2) {
     }
   }, {
     key: "setSelection",
-    value: function setSelection(anchor, head, root, force) {
-      this.spec.setSelection ? this.spec.setSelection(anchor, head, root) : _get(_getPrototypeOf(CustomNodeViewDesc.prototype), "setSelection", this).call(this, anchor, head, root, force);
+    value: function setSelection(anchor, head, view, force) {
+      this.spec.setSelection ? this.spec.setSelection(anchor, head, view.root) : _get(_getPrototypeOf(CustomNodeViewDesc.prototype), "setSelection", this).call(this, anchor, head, view, force);
     }
   }, {
     key: "destroy",
@@ -2179,7 +2185,7 @@ function selectionToDOM(view) {
       if (!sel.$from.parent.inlineContent) resetEditableFrom = temporarilyEditableNear(view, sel.from);
       if (!sel.empty && !sel.$from.parent.inlineContent) resetEditableTo = temporarilyEditableNear(view, sel.to);
     }
-    view.docView.setSelection(anchor, head, view.root, force);
+    view.docView.setSelection(anchor, head, view, force);
     if (brokenSelectBetweenUneditable) {
       if (resetEditableFrom) resetEditable(resetEditableFrom);
       if (resetEditableTo) resetEditable(resetEditableTo);
@@ -2868,7 +2874,7 @@ var InputState = _createClass(function InputState() {
   this.lastIOSEnterFallbackTimeout = -1;
   this.lastFocus = 0;
   this.lastTouch = 0;
-  this.lastAndroidDelete = 0;
+  this.lastChromeDelete = 0;
   this.composing = false;
   this.compositionNode = null;
   this.composingTimeout = -1;
@@ -4655,7 +4661,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
     if (android && chrome) view.domObserver.suppressSelectionUpdates();
     return;
   }
-  if (chrome && android && change.endB == change.start) view.input.lastAndroidDelete = Date.now();
+  if (chrome && change.endB == change.start) view.input.lastChromeDelete = Date.now();
   if (android && !inlineChange && $from.start() != $to.start() && $to.parentOffset == 0 && $from.depth == $to.depth && parse.sel && parse.sel.anchor == parse.sel.head && parse.sel.head == change.endA) {
     change.endB -= 2;
     $to = parse.doc.resolveNoCache(change.endB - parse.from);
@@ -4692,7 +4698,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
   if (!tr) tr = view.state.tr.replace(chFrom, chTo, parse.doc.slice(change.start - parse.from, change.endB - parse.from));
   if (parse.sel) {
     var _sel3 = resolveSelection(view, tr.doc, parse.sel);
-    if (_sel3 && !(chrome && android && view.composing && _sel3.empty && (change.start != change.endB || view.input.lastAndroidDelete < Date.now() - 100) && (_sel3.head == chFrom || _sel3.head == tr.mapping.map(chTo) - 1) || ie && _sel3.empty && _sel3.head == chFrom)) tr.setSelection(_sel3);
+    if (_sel3 && !(chrome && view.composing && _sel3.empty && (change.start != change.endB || view.input.lastChromeDelete < Date.now() - 100) && (_sel3.head == chFrom || _sel3.head == tr.mapping.map(chTo) - 1) || ie && _sel3.empty && _sel3.head == chFrom)) tr.setSelection(_sel3);
   }
   if (storedMarks) tr.ensureMarks(storedMarks);
   if (compositionID) tr.setMeta("composition", compositionID);

package/dist/index.d.cts

@@ -238,6 +238,17 @@ declare global {
     }
 }
 /**
+A ViewMutationRecord represents a DOM
+[mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
+or a selection change happens within the view. When the change is
+a selection change, the record will have a `type` property of
+`"selection"` (which doesn't occur for native mutation records).
+*/
+type ViewMutationRecord = MutationRecord | {
+    type: "selection";
+    target: DOMNode;
+};
+/**
 By default, document nodes are rendered using the result of the
 [`toDOM`](https://prosemirror.net/docs/ref/#model.NodeSpec.toDOM) method of their spec, and managed
 entirely by the editor. For some use cases, such as embedded
@@ -308,16 +319,11 @@ interface NodeView {
     */
     stopEvent?: (event: Event) => boolean;
     /**
-    Called when a DOM
-    [mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
-    or a selection change happens within the view. When the change is
-    a selection change, the record will have a `type` property of
-    `"selection"` (which doesn't occur for native mutation records).
-    Return false if the editor should re-read the selection or
-    re-parse the range around the mutation, true if it can safely be
-    ignored.
+    Called when a [mutation](https://prosemirror.net/docs/ref/#view.ViewMutationRecord) happens within the
+    view. Return false if the editor should re-read the selection or re-parse
+    the range around the mutation, true if it can safely be ignored.
     */
-    ignoreMutation?: (mutation: MutationRecord) => boolean;
+    ignoreMutation?: (mutation: ViewMutationRecord) => boolean;
     /**
     Called when the node view is removed from the editor or the whole
     editor is destroyed.
@@ -344,6 +350,12 @@ interface MarkView {
     */
     contentDOM?: HTMLElement | null;
     /**
+    Called when a [mutation](https://prosemirror.net/docs/ref/#view.ViewMutationRecord) happens within the
+    view. Return false if the editor should re-read the selection or re-parse
+    the range around the mutation, true if it can safely be ignored.
+    */
+    ignoreMutation?: (mutation: ViewMutationRecord) => boolean;
+    /**
     Called when the mark view is removed from the editor or the whole
     editor is destroyed.
     */
@@ -391,8 +403,8 @@ declare class ViewDesc {
     };
     emptyChildAt(side: number): boolean;
     domAfterPos(pos: number): DOMNode;
-    setSelection(anchor: number, head: number, root: Document | ShadowRoot, force?: boolean): void;
-    ignoreMutation(mutation: MutationRecord): boolean;
+    setSelection(anchor: number, head: number, view: EditorView, force?: boolean): void;
+    ignoreMutation(mutation: ViewMutationRecord): boolean;
     get contentLost(): boolean | null;
     markDirty(from: number, to: number): void;
     markParentsDirty(): void;
@@ -441,7 +453,7 @@ declare class TextViewDesc extends NodeViewDesc {
         offset: number;
     };
     localPosFromDOM(dom: DOMNode, offset: number, bias: number): number;
-    ignoreMutation(mutation: MutationRecord): boolean;
+    ignoreMutation(mutation: ViewMutationRecord): boolean;
     slice(from: number, to: number, view: EditorView): TextViewDesc;
     markDirty(from: number, to: number): void;
     get domAtom(): boolean;
@@ -955,4 +967,4 @@ interface DirectEditorProps extends EditorProps {
     dispatchTransaction?: (tr: Transaction) => void;
 }
 
-export { type DOMEventMap, Decoration, type DecorationAttrs, DecorationSet, type DecorationSource, type DirectEditorProps, type EditorProps, EditorView, type MarkView, type MarkViewConstructor, type NodeView, type NodeViewConstructor };
+export { type DOMEventMap, Decoration, type DecorationAttrs, DecorationSet, type DecorationSource, type DirectEditorProps, type EditorProps, EditorView, type MarkView, type MarkViewConstructor, type NodeView, type NodeViewConstructor, type ViewMutationRecord };

package/dist/index.d.ts

@@ -238,6 +238,17 @@ declare global {
     }
 }
 /**
+A ViewMutationRecord represents a DOM
+[mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
+or a selection change happens within the view. When the change is
+a selection change, the record will have a `type` property of
+`"selection"` (which doesn't occur for native mutation records).
+*/
+type ViewMutationRecord = MutationRecord | {
+    type: "selection";
+    target: DOMNode;
+};
+/**
 By default, document nodes are rendered using the result of the
 [`toDOM`](https://prosemirror.net/docs/ref/#model.NodeSpec.toDOM) method of their spec, and managed
 entirely by the editor. For some use cases, such as embedded
@@ -308,16 +319,11 @@ interface NodeView {
     */
     stopEvent?: (event: Event) => boolean;
     /**
-    Called when a DOM
-    [mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
-    or a selection change happens within the view. When the change is
-    a selection change, the record will have a `type` property of
-    `"selection"` (which doesn't occur for native mutation records).
-    Return false if the editor should re-read the selection or
-    re-parse the range around the mutation, true if it can safely be
-    ignored.
+    Called when a [mutation](https://prosemirror.net/docs/ref/#view.ViewMutationRecord) happens within the
+    view. Return false if the editor should re-read the selection or re-parse
+    the range around the mutation, true if it can safely be ignored.
     */
-    ignoreMutation?: (mutation: MutationRecord) => boolean;
+    ignoreMutation?: (mutation: ViewMutationRecord) => boolean;
     /**
     Called when the node view is removed from the editor or the whole
     editor is destroyed.
@@ -344,6 +350,12 @@ interface MarkView {
     */
     contentDOM?: HTMLElement | null;
     /**
+    Called when a [mutation](https://prosemirror.net/docs/ref/#view.ViewMutationRecord) happens within the
+    view. Return false if the editor should re-read the selection or re-parse
+    the range around the mutation, true if it can safely be ignored.
+    */
+    ignoreMutation?: (mutation: ViewMutationRecord) => boolean;
+    /**
     Called when the mark view is removed from the editor or the whole
     editor is destroyed.
     */
@@ -391,8 +403,8 @@ declare class ViewDesc {
     };
     emptyChildAt(side: number): boolean;
     domAfterPos(pos: number): DOMNode;
-    setSelection(anchor: number, head: number, root: Document | ShadowRoot, force?: boolean): void;
-    ignoreMutation(mutation: MutationRecord): boolean;
+    setSelection(anchor: number, head: number, view: EditorView, force?: boolean): void;
+    ignoreMutation(mutation: ViewMutationRecord): boolean;
     get contentLost(): boolean | null;
     markDirty(from: number, to: number): void;
     markParentsDirty(): void;
@@ -441,7 +453,7 @@ declare class TextViewDesc extends NodeViewDesc {
         offset: number;
     };
     localPosFromDOM(dom: DOMNode, offset: number, bias: number): number;
-    ignoreMutation(mutation: MutationRecord): boolean;
+    ignoreMutation(mutation: ViewMutationRecord): boolean;
     slice(from: number, to: number, view: EditorView): TextViewDesc;
     markDirty(from: number, to: number): void;
     get domAtom(): boolean;
@@ -955,4 +967,4 @@ interface DirectEditorProps extends EditorProps {
     dispatchTransaction?: (tr: Transaction) => void;
 }
 
-export { type DOMEventMap, Decoration, type DecorationAttrs, DecorationSet, type DecorationSource, type DirectEditorProps, type EditorProps, EditorView, type MarkView, type MarkViewConstructor, type NodeView, type NodeViewConstructor };
+export { type DOMEventMap, Decoration, type DecorationAttrs, DecorationSet, type DecorationSource, type DirectEditorProps, type EditorProps, EditorView, type MarkView, type MarkViewConstructor, type NodeView, type NodeViewConstructor, type ViewMutationRecord };

package/dist/index.js

@@ -396,11 +396,12 @@ function posFromCaret(view, node, offset, coords) {
     for (let cur = node, sawBlock = false;;) {
         if (cur == view.dom)
             break;
-        let desc = view.docView.nearestDesc(cur, true);
+        let desc = view.docView.nearestDesc(cur, true), rect;
         if (!desc)
             return null;
-        if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM)) {
-            let rect = desc.dom.getBoundingClientRect();
+        if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM) &&
+            // Ignore elements with zero-size bounding rectangles
+            ((rect = desc.dom.getBoundingClientRect()).width || rect.height)) {
             if (desc.node.isBlock && desc.parent) {
                 // Only apply the horizontal test to the innermost block. Vertical for any parent.
                 if (!sawBlock && rect.left > coords.left || rect.top > coords.top)
@@ -996,18 +997,19 @@ class ViewDesc {
     // custom things with the selection. Note that this falls apart when
     // a selection starts in such a node and ends in another, in which
     // case we just use whatever domFromPos produces as a best effort.
-    setSelection(anchor, head, root, force = false) {
+    setSelection(anchor, head, view, force = false) {
         // If the selection falls entirely in a child, give it to that child
         let from = Math.min(anchor, head), to = Math.max(anchor, head);
         for (let i = 0, offset = 0; i < this.children.length; i++) {
             let child = this.children[i], end = offset + child.size;
             if (from > offset && to < end)
-                return child.setSelection(anchor - offset - child.border, head - offset - child.border, root, force);
+                return child.setSelection(anchor - offset - child.border, head - offset - child.border, view, force);
             offset = end;
         }
         let anchorDOM = this.domFromPos(anchor, anchor ? -1 : 1);
         let headDOM = head == anchor ? anchorDOM : this.domFromPos(head, head ? -1 : 1);
-        let domSel = root.getSelection();
+        let domSel = view.root.getSelection();
+        let selRange = view.domSelectionRange();
         let brKludge = false;
         // On Firefox, using Selection.collapse to put the cursor after a
         // BR node for some reason doesn't always work (#1073). On Safari,
@@ -1038,14 +1040,14 @@ class ViewDesc {
         }
         // Firefox can act strangely when the selection is in front of an
         // uneditable node. See #1163 and https://bugzilla.mozilla.org/show_bug.cgi?id=1709536
-        if (gecko && domSel.focusNode && domSel.focusNode != headDOM.node && domSel.focusNode.nodeType == 1) {
-            let after = domSel.focusNode.childNodes[domSel.focusOffset];
+        if (gecko && selRange.focusNode && selRange.focusNode != headDOM.node && selRange.focusNode.nodeType == 1) {
+            let after = selRange.focusNode.childNodes[selRange.focusOffset];
             if (after && after.contentEditable == "false")
                 force = true;
         }
         if (!(force || brKludge && safari) &&
-            isEquivalentPosition(anchorDOM.node, anchorDOM.offset, domSel.anchorNode, domSel.anchorOffset) &&
-            isEquivalentPosition(headDOM.node, headDOM.offset, domSel.focusNode, domSel.focusOffset))
+            isEquivalentPosition(anchorDOM.node, anchorDOM.offset, selRange.anchorNode, selRange.anchorOffset) &&
+            isEquivalentPosition(headDOM.node, headDOM.offset, selRange.focusNode, selRange.focusOffset))
             return;
         // Selection.extend can be used to create an 'inverted' selection
         // (one where the focus is before the anchor), but not all
@@ -1234,6 +1236,9 @@ class MarkViewDesc extends ViewDesc {
         copy.children = nodes;
         return copy;
     }
+    ignoreMutation(mutation) {
+        return this.spec.ignoreMutation ? this.spec.ignoreMutation(mutation) : super.ignoreMutation(mutation);
+    }
     destroy() {
         if (this.spec.destroy)
             this.spec.destroy();
@@ -1577,9 +1582,9 @@ class CustomNodeViewDesc extends NodeViewDesc {
     deselectNode() {
         this.spec.deselectNode ? this.spec.deselectNode() : super.deselectNode();
     }
-    setSelection(anchor, head, root, force) {
-        this.spec.setSelection ? this.spec.setSelection(anchor, head, root)
-            : super.setSelection(anchor, head, root, force);
+    setSelection(anchor, head, view, force) {
+        this.spec.setSelection ? this.spec.setSelection(anchor, head, view.root)
+            : super.setSelection(anchor, head, view, force);
     }
     destroy() {
         if (this.spec.destroy)
@@ -2239,7 +2244,7 @@ function selectionToDOM(view, force = false) {
             if (!sel.empty && !sel.$from.parent.inlineContent)
                 resetEditableTo = temporarilyEditableNear(view, sel.to);
         }
-        view.docView.setSelection(anchor, head, view.root, force);
+        view.docView.setSelection(anchor, head, view, force);
         if (brokenSelectBetweenUneditable) {
             if (resetEditableFrom)
                 resetEditable(resetEditableFrom);
@@ -3038,7 +3043,7 @@ class InputState {
         this.lastIOSEnterFallbackTimeout = -1;
         this.lastFocus = 0;
         this.lastTouch = 0;
-        this.lastAndroidDelete = 0;
+        this.lastChromeDelete = 0;
         this.composing = false;
         this.compositionNode = null;
         this.composingTimeout = -1;
@@ -5016,11 +5021,11 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
             view.domObserver.suppressSelectionUpdates(); // #820
         return;
     }
-    // Chrome Android will occasionally, during composition, delete the
+    // Chrome will occasionally, during composition, delete the
     // entire composition and then immediately insert it again. This is
     // used to detect that situation.
-    if (chrome && android && change.endB == change.start)
-        view.input.lastAndroidDelete = Date.now();
+    if (chrome && change.endB == change.start)
+        view.input.lastChromeDelete = Date.now();
     // This tries to detect Android virtual keyboard
     // enter-and-pick-suggestion action. That sometimes (see issue
     // #1059) first fires a DOM mutation, before moving the selection to
@@ -5071,13 +5076,13 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
         tr = view.state.tr.replace(chFrom, chTo, parse.doc.slice(change.start - parse.from, change.endB - parse.from));
     if (parse.sel) {
         let sel = resolveSelection(view, tr.doc, parse.sel);
-        // Chrome Android will sometimes, during composition, report the
+        // Chrome will sometimes, during composition, report the
         // selection in the wrong place. If it looks like that is
         // happening, don't update the selection.
         // Edge just doesn't move the cursor forward when you start typing
         // in an empty block or between br nodes.
-        if (sel && !(chrome && android && view.composing && sel.empty &&
-            (change.start != change.endB || view.input.lastAndroidDelete < Date.now() - 100) &&
+        if (sel && !(chrome && view.composing && sel.empty &&
+            (change.start != change.endB || view.input.lastChromeDelete < Date.now() - 100) &&
             (sel.head == chFrom || sel.head == tr.mapping.map(chTo) - 1) ||
             ie && sel.empty && sel.head == chFrom))
             tr.setSelection(sel);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.36.0",
+  "version": "1.37.1",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",

package/src/README.md

@@ -20,6 +20,8 @@ this module.
 
 @MarkView
 
+@ViewMutationRecord
+
 @DOMEventMap
 
 ### Decorations

package/src/domchange.ts

@@ -196,11 +196,11 @@ export function readDOMChange(view: EditorView, from: number, to: number, typeOv
     return
   }
 
-  // Chrome Android will occasionally, during composition, delete the
+  // Chrome will occasionally, during composition, delete the
   // entire composition and then immediately insert it again. This is
   // used to detect that situation.
-  if (browser.chrome && browser.android && change.endB == change.start)
-    view.input.lastAndroidDelete = Date.now()
+  if (browser.chrome && change.endB == change.start)
+    view.input.lastChromeDelete = Date.now()
 
   // This tries to detect Android virtual keyboard
   // enter-and-pick-suggestion action. That sometimes (see issue
@@ -252,13 +252,13 @@ export function readDOMChange(view: EditorView, from: number, to: number, typeOv
     tr = view.state.tr.replace(chFrom, chTo, parse.doc.slice(change.start - parse.from, change.endB - parse.from))
   if (parse.sel) {
     let sel = resolveSelection(view, tr.doc, parse.sel)
-    // Chrome Android will sometimes, during composition, report the
+    // Chrome will sometimes, during composition, report the
     // selection in the wrong place. If it looks like that is
     // happening, don't update the selection.
     // Edge just doesn't move the cursor forward when you start typing
     // in an empty block or between br nodes.
-    if (sel && !(browser.chrome && browser.android && view.composing && sel.empty &&
-                 (change.start != change.endB || view.input.lastAndroidDelete < Date.now() - 100) &&
+    if (sel && !(browser.chrome && view.composing && sel.empty &&
+                 (change.start != change.endB || view.input.lastChromeDelete < Date.now() - 100) &&
                  (sel.head == chFrom || sel.head == tr.mapping.map(chTo) - 1) ||
                  browser.ie && sel.empty && sel.head == chFrom))
       tr.setSelection(sel)

package/src/domcoords.ts

@@ -225,10 +225,11 @@ function posFromCaret(view: EditorView, node: Node, offset: number, coords: {top
   let outsideBlock = -1
   for (let cur = node, sawBlock = false;;) {
     if (cur == view.dom) break
-    let desc = view.docView.nearestDesc(cur, true)
+    let desc = view.docView.nearestDesc(cur, true), rect
     if (!desc) return null
-    if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM)) {
-      let rect = (desc.dom as HTMLElement).getBoundingClientRect()
+    if (desc.dom.nodeType == 1 && (desc.node.isBlock && desc.parent || !desc.contentDOM) &&
+        // Ignore elements with zero-size bounding rectangles
+        ((rect = (desc.dom as HTMLElement).getBoundingClientRect()).width || rect.height)) {
       if (desc.node.isBlock && desc.parent) {
         // Only apply the horizontal test to the innermost block. Vertical for any parent.
         if (!sawBlock && rect.left > coords.left || rect.top > coords.top) outsideBlock = desc.posBefore

package/src/domobserver.ts

@@ -151,8 +151,8 @@ export class DOMObserver {
     let desc = container && this.view.docView.nearestDesc(container)
     if (desc && desc.ignoreMutation({
       type: "selection",
-      target: container!.nodeType == 3 ? container!.parentNode : container
-    } as any)) {
+      target: container!.nodeType == 3 ? container!.parentNode! : container!
+    })) {
       this.setCurSelection()
       return true
     }

package/src/index.ts

@@ -14,7 +14,7 @@ import {DOMSelection, DOMNode, DOMSelectionRange, deepActiveElement, clearReused
 import * as browser from "./browser"
 
 export {Decoration, DecorationSet, DecorationAttrs, DecorationSource} from "./decoration"
-export {NodeView, MarkView} from "./viewdesc"
+export {NodeView, MarkView, ViewMutationRecord} from "./viewdesc"
 
 // Exported for testing
 import {serializeForClipboard, parseFromClipboard} from "./clipboard"

package/src/input.ts

@@ -28,7 +28,7 @@ export class InputState {
   lastIOSEnterFallbackTimeout = -1
   lastFocus = 0
   lastTouch = 0
-  lastAndroidDelete = 0
+  lastChromeDelete = 0
   composing = false
   compositionNode: Text | null = null
   composingTimeout = -1

package/src/selection.ts

@@ -84,7 +84,7 @@ export function selectionToDOM(view: EditorView, force = false) {
       if (!sel.empty && !sel.$from.parent.inlineContent)
         resetEditableTo = temporarilyEditableNear(view, sel.to)
     }
-    view.docView.setSelection(anchor, head, view.root, force)
+    view.docView.setSelection(anchor, head, view, force)
     if (brokenSelectBetweenUneditable) {
       if (resetEditableFrom) resetEditable(resetEditableFrom)
       if (resetEditableTo) resetEditable(resetEditableTo)

package/src/viewdesc.ts

@@ -10,6 +10,13 @@ declare global {
   interface Node { pmViewDesc?: ViewDesc }
 }
 
+/// A ViewMutationRecord represents a DOM
+/// [mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
+/// or a selection change happens within the view. When the change is
+/// a selection change, the record will have a `type` property of
+/// `"selection"` (which doesn't occur for native mutation records).
+export type ViewMutationRecord = MutationRecord | { type: "selection", target: DOMNode }
+
 /// By default, document nodes are rendered using the result of the
 /// [`toDOM`](#model.NodeSpec.toDOM) method of their spec, and managed
 /// entirely by the editor. For some use cases, such as embedded
@@ -70,15 +77,10 @@ export interface NodeView {
   /// which this returns true are not handled by the editor.
   stopEvent?: (event: Event) => boolean
 
-  /// Called when a DOM
-  /// [mutation](https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver)
-  /// or a selection change happens within the view. When the change is
-  /// a selection change, the record will have a `type` property of
-  /// `"selection"` (which doesn't occur for native mutation records).
-  /// Return false if the editor should re-read the selection or
-  /// re-parse the range around the mutation, true if it can safely be
-  /// ignored.
-  ignoreMutation?: (mutation: MutationRecord) => boolean
+  /// Called when a [mutation](#view.ViewMutationRecord) happens within the
+  /// view. Return false if the editor should re-read the selection or re-parse
+  /// the range around the mutation, true if it can safely be ignored.
+  ignoreMutation?: (mutation: ViewMutationRecord) => boolean
 
   /// Called when the node view is removed from the editor or the whole
   /// editor is destroyed.
@@ -99,6 +101,12 @@ export interface MarkView {
   /// The DOM node that should hold the mark's content. When this is not
   /// present, the `dom` property is used as the content DOM.
   contentDOM?: HTMLElement | null
+
+  /// Called when a [mutation](#view.ViewMutationRecord) happens within the
+  /// view. Return false if the editor should re-read the selection or re-parse
+  /// the range around the mutation, true if it can safely be ignored.
+  ignoreMutation?: (mutation: ViewMutationRecord) => boolean
+
   
   /// Called when the mark view is removed from the editor or the whole
   /// editor is destroyed.
@@ -387,19 +395,20 @@ export class ViewDesc {
   // custom things with the selection. Note that this falls apart when
   // a selection starts in such a node and ends in another, in which
   // case we just use whatever domFromPos produces as a best effort.
-  setSelection(anchor: number, head: number, root: Document | ShadowRoot, force = false): void {
+  setSelection(anchor: number, head: number, view: EditorView, force = false): void {
     // If the selection falls entirely in a child, give it to that child
     let from = Math.min(anchor, head), to = Math.max(anchor, head)
     for (let i = 0, offset = 0; i < this.children.length; i++) {
       let child = this.children[i], end = offset + child.size
       if (from > offset && to < end)
-        return child.setSelection(anchor - offset - child.border, head - offset - child.border, root, force)
+        return child.setSelection(anchor - offset - child.border, head - offset - child.border, view, force)
       offset = end
     }
 
     let anchorDOM = this.domFromPos(anchor, anchor ? -1 : 1)
     let headDOM = head == anchor ? anchorDOM : this.domFromPos(head, head ? -1 : 1)
-    let domSel = (root as Document).getSelection()!
+    let domSel = (view.root as Document).getSelection()!
+    let selRange = view.domSelectionRange()
 
     let brKludge = false
     // On Firefox, using Selection.collapse to put the cursor after a
@@ -429,14 +438,14 @@ export class ViewDesc {
     }
     // Firefox can act strangely when the selection is in front of an
     // uneditable node. See #1163 and https://bugzilla.mozilla.org/show_bug.cgi?id=1709536
-    if (browser.gecko && domSel.focusNode && domSel.focusNode != headDOM.node && domSel.focusNode.nodeType == 1) {
-      let after = domSel.focusNode.childNodes[domSel.focusOffset]
+    if (browser.gecko && selRange.focusNode && selRange.focusNode != headDOM.node && selRange.focusNode.nodeType == 1) {
+      let after = selRange.focusNode.childNodes[selRange.focusOffset]
       if (after && (after as HTMLElement).contentEditable == "false") force = true
     }
 
     if (!(force || brKludge && browser.safari) &&
-        isEquivalentPosition(anchorDOM.node, anchorDOM.offset, domSel.anchorNode!, domSel.anchorOffset) &&
-        isEquivalentPosition(headDOM.node, headDOM.offset, domSel.focusNode!, domSel.focusOffset))
+        isEquivalentPosition(anchorDOM.node, anchorDOM.offset, selRange.anchorNode!, selRange.anchorOffset) &&
+        isEquivalentPosition(headDOM.node, headDOM.offset, selRange.focusNode!, selRange.focusOffset))
       return
 
     // Selection.extend can be used to create an 'inverted' selection
@@ -468,8 +477,8 @@ export class ViewDesc {
     }
   }
 
-  ignoreMutation(mutation: MutationRecord): boolean {
-    return !this.contentDOM && (mutation.type as any) != "selection"
+  ignoreMutation(mutation: ViewMutationRecord): boolean {
+    return !this.contentDOM && mutation.type != "selection"
   }
 
   get contentLost() {
@@ -548,8 +557,8 @@ class WidgetViewDesc extends ViewDesc {
     return stop ? stop(event) : false
   }
 
-  ignoreMutation(mutation: MutationRecord) {
-    return (mutation.type as any) != "selection" || this.widget.spec.ignoreSelection
+  ignoreMutation(mutation: ViewMutationRecord) {
+    return mutation.type != "selection" || this.widget.spec.ignoreSelection
   }
 
   destroy() {
@@ -578,7 +587,7 @@ class CompositionViewDesc extends ViewDesc {
     return {node: this.textDOM, offset: pos}
   }
 
-  ignoreMutation(mut: MutationRecord) {
+  ignoreMutation(mut: ViewMutationRecord) {
     return mut.type === 'characterData' && mut.target.nodeValue == mut.oldValue
    }
 }
@@ -629,6 +638,10 @@ class MarkViewDesc extends ViewDesc {
     return copy
   }
 
+  ignoreMutation(mutation: ViewMutationRecord) {
+    return this.spec.ignoreMutation ? this.spec.ignoreMutation(mutation) : super.ignoreMutation(mutation)
+  }
+
   destroy() {
     if (this.spec.destroy) this.spec.destroy()
     super.destroy()
@@ -924,8 +937,8 @@ class TextViewDesc extends NodeViewDesc {
     return super.localPosFromDOM(dom, offset, bias)
   }
 
-  ignoreMutation(mutation: MutationRecord) {
-    return mutation.type != "characterData" && (mutation.type as any) != "selection"
+  ignoreMutation(mutation: ViewMutationRecord) {
+    return mutation.type != "characterData" && mutation.type != "selection"
   }
 
   slice(from: number, to: number, view: EditorView) {
@@ -987,9 +1000,9 @@ class CustomNodeViewDesc extends NodeViewDesc {
     this.spec.deselectNode ? this.spec.deselectNode() : super.deselectNode()
   }
 
-  setSelection(anchor: number, head: number, root: Document | ShadowRoot, force: boolean) {
-    this.spec.setSelection ? this.spec.setSelection(anchor, head, root)
-      : super.setSelection(anchor, head, root, force)
+  setSelection(anchor: number, head: number, view: EditorView, force: boolean) {
+    this.spec.setSelection ? this.spec.setSelection(anchor, head, view.root)
+      : super.setSelection(anchor, head, view, force)
   }
 
   destroy() {
@@ -1001,7 +1014,7 @@ class CustomNodeViewDesc extends NodeViewDesc {
     return this.spec.stopEvent ? this.spec.stopEvent(event) : false
   }
 
-  ignoreMutation(mutation: MutationRecord) {
+  ignoreMutation(mutation: ViewMutationRecord) {
     return this.spec.ignoreMutation ? this.spec.ignoreMutation(mutation) : super.ignoreMutation(mutation)
   }
 }