prosemirror-view 1.31.3 → 1.31.5

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 1.31.5 (2023-06-19)
+
+### Bug fixes
+
+Fix a bug where the editor accidentally blocked shift-delete when the whole document is selected.
+
+Bring back workaround for an issue where Firefox draws the cursor in the wrong place in a code block.
+
+Fix an issue where Shift-Insert pastes pasted plain text (because Shift was being held).
+
+Fix an issue where selecting across paragraph and starting a composition would update the state as if Enter was pressed and disrupt the composition.
+
+## 1.31.4 (2023-05-31)
+
+### Bug fixes
+
+Make sure `destroy` is called on node views that are replaced by changing a node's markup.
+
 ## 1.31.3 (2023-05-17)
 
 ### Bug fixes

package/dist/index.cjs

@@ -1134,6 +1134,21 @@ var ViewDesc = function () {
 
         if (node.nodeType == 3) {
           brKludge = !!(_offset && node.nodeValue[_offset - 1] == "\n");
+
+          if (brKludge && _offset == node.nodeValue.length) {
+            for (var scan = node, after; scan; scan = scan.parentNode) {
+              if (after = scan.nextSibling) {
+                if (after.nodeName == "BR") anchorDOM = headDOM = {
+                  node: after.parentNode,
+                  offset: domIndex(after) + 1
+                };
+                break;
+              }
+
+              var desc = scan.pmViewDesc;
+              if (desc && desc.node && desc.node.isBlock) break;
+            }
+          }
         } else {
           var prev = node.childNodes[_offset - 1];
           brKludge = prev && (prev.nodeName == "BR" || prev.contentEditable == "false");
@@ -1141,8 +1156,8 @@ var ViewDesc = function () {
       }
 
       if (gecko && domSel.focusNode && domSel.focusNode != headDOM.node && domSel.focusNode.nodeType == 1) {
-        var after = domSel.focusNode.childNodes[domSel.focusOffset];
-        if (after && after.contentEditable == "false") force = true;
+        var _after2 = domSel.focusNode.childNodes[domSel.focusOffset];
+        if (_after2 && _after2.contentEditable == "false") force = true;
       }
 
       if (!(force || brKludge && safari) && isEquivalentPosition(anchorDOM.node, anchorDOM.offset, domSel.anchorNode, domSel.anchorOffset) && isEquivalentPosition(headDOM.node, headDOM.offset, domSel.focusNode, domSel.focusOffset)) return;
@@ -2197,6 +2212,7 @@ var ViewTreeUpdater = function () {
       if (!wrapper.contentDOM) return null;
       wrapper.children = next.children;
       next.children = [];
+      next.destroy();
 
       var _iterator = _createForOfIteratorHelper(wrapper.children),
           _step;
@@ -2990,7 +3006,7 @@ function captureKeyDown(view, event) {
 
   if (code == 8 || mac && code == 72 && mods == "c") {
     return stopNativeHorizontalDelete(view, -1) || skipIgnoredNodes(view, -1);
-  } else if (code == 46 || mac && code == 68 && mods == "c") {
+  } else if (code == 46 && !event.shiftKey || mac && code == 68 && mods == "c") {
     return stopNativeHorizontalDelete(view, 1) || skipIgnoredNodes(view, 1);
   } else if (code == 13 || code == 27) {
     return true;
@@ -3894,10 +3910,11 @@ function capturePaste(view, event) {
   if (!plainText) target.contentEditable = "true";
   target.style.cssText = "position: fixed; left: -10000px; top: 10px";
   target.focus();
+  var plain = view.input.shiftKey && view.input.lastKeyCode != 45;
   setTimeout(function () {
     view.focus();
     if (target.parentNode) target.parentNode.removeChild(target);
-    if (plainText) doPaste(view, target.value, null, view.input.shiftKey, event);else doPaste(view, target.textContent, target.innerHTML, view.input.shiftKey, event);
+    if (plainText) doPaste(view, target.value, null, plain, event);else doPaste(view, target.textContent, target.innerHTML, plain, event);
   }, 50);
 }
 
@@ -3908,7 +3925,7 @@ function doPaste(view, text, html, preferPlain, event) {
   })) return true;
   if (!slice) return false;
   var singleNode = sliceSingleNode(slice);
-  var tr = singleNode ? view.state.tr.replaceSelectionWith(singleNode, view.input.shiftKey) : view.state.tr.replaceSelection(slice);
+  var tr = singleNode ? view.state.tr.replaceSelectionWith(singleNode, preferPlain) : view.state.tr.replaceSelection(slice);
   view.dispatch(tr.scrollIntoView().setMeta("paste", true).setMeta("uiEvent", "paste"));
   return true;
 }
@@ -3917,7 +3934,8 @@ editHandlers.paste = function (view, _event) {
   var event = _event;
   if (view.composing && !android) return;
   var data = brokenClipboardAPI ? null : event.clipboardData;
-  if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), view.input.shiftKey, event)) event.preventDefault();else capturePaste(view, event);
+  var plain = view.input.shiftKey && view.input.lastKeyCode != 45;
+  if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), plain, event)) event.preventDefault();else capturePaste(view, event);
 };
 
 var Dragging = _createClass(function Dragging(slice, move) {
@@ -5371,7 +5389,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
 
   if ((ios && view.input.lastIOSEnter > Date.now() - 225 && (!inlineChange || addedNodes.some(function (n) {
     return n.nodeName == "DIV" || n.nodeName == "P";
-  })) || !inlineChange && $from.pos < parse.doc.content.size && (nextSel = prosemirrorState.Selection.findFrom(parse.doc.resolve($from.pos + 1), 1, true)) && nextSel.head == $to.pos) && view.someProp("handleKeyDown", function (f) {
+  })) || !inlineChange && $from.pos < parse.doc.content.size && !$from.sameParent($to) && (nextSel = prosemirrorState.Selection.findFrom(parse.doc.resolve($from.pos + 1), 1, true)) && nextSel.head == $to.pos) && view.someProp("handleKeyDown", function (f) {
     return f(view, keyEvent(13, "Enter"));
   })) {
     view.input.lastIOSEnter = 0;

package/dist/index.js

@@ -957,6 +957,19 @@ class ViewDesc {
             let { node, offset } = anchorDOM;
             if (node.nodeType == 3) {
                 brKludge = !!(offset && node.nodeValue[offset - 1] == "\n");
+                // Issue #1128
+                if (brKludge && offset == node.nodeValue.length) {
+                    for (let scan = node, after; scan; scan = scan.parentNode) {
+                        if (after = scan.nextSibling) {
+                            if (after.nodeName == "BR")
+                                anchorDOM = headDOM = { node: after.parentNode, offset: domIndex(after) + 1 };
+                            break;
+                        }
+                        let desc = scan.pmViewDesc;
+                        if (desc && desc.node && desc.node.isBlock)
+                            break;
+                    }
+                }
             }
             else {
                 let prev = node.childNodes[offset - 1];
@@ -1818,6 +1831,7 @@ class ViewTreeUpdater {
             return null;
         wrapper.children = next.children;
         next.children = [];
+        next.destroy();
         for (let ch of wrapper.children)
             ch.parent = wrapper;
         return wrapper;
@@ -2585,7 +2599,7 @@ function captureKeyDown(view, event) {
     if (code == 8 || (mac && code == 72 && mods == "c")) { // Backspace, Ctrl-h on Mac
         return stopNativeHorizontalDelete(view, -1) || skipIgnoredNodes(view, -1);
     }
-    else if (code == 46 || (mac && code == 68 && mods == "c")) { // Delete, Ctrl-d on Mac
+    else if ((code == 46 && !event.shiftKey) || (mac && code == 68 && mods == "c")) { // Delete, Ctrl-d on Mac
         return stopNativeHorizontalDelete(view, 1) || skipIgnoredNodes(view, 1);
     }
     else if (code == 13 || code == 27) { // Enter, Esc
@@ -3413,14 +3427,15 @@ function capturePaste(view, event) {
         target.contentEditable = "true";
     target.style.cssText = "position: fixed; left: -10000px; top: 10px";
     target.focus();
+    let plain = view.input.shiftKey && view.input.lastKeyCode != 45;
     setTimeout(() => {
         view.focus();
         if (target.parentNode)
             target.parentNode.removeChild(target);
         if (plainText)
-            doPaste(view, target.value, null, view.input.shiftKey, event);
+            doPaste(view, target.value, null, plain, event);
         else
-            doPaste(view, target.textContent, target.innerHTML, view.input.shiftKey, event);
+            doPaste(view, target.textContent, target.innerHTML, plain, event);
     }, 50);
 }
 function doPaste(view, text, html, preferPlain, event) {
@@ -3431,7 +3446,7 @@ function doPaste(view, text, html, preferPlain, event) {
         return false;
     let singleNode = sliceSingleNode(slice);
     let tr = singleNode
-        ? view.state.tr.replaceSelectionWith(singleNode, view.input.shiftKey)
+        ? view.state.tr.replaceSelectionWith(singleNode, preferPlain)
         : view.state.tr.replaceSelection(slice);
     view.dispatch(tr.scrollIntoView().setMeta("paste", true).setMeta("uiEvent", "paste"));
     return true;
@@ -3445,7 +3460,8 @@ editHandlers.paste = (view, _event) => {
     if (view.composing && !android)
         return;
     let data = brokenClipboardAPI ? null : event.clipboardData;
-    if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), view.input.shiftKey, event))
+    let plain = view.input.shiftKey && view.input.lastKeyCode != 45;
+    if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), plain, event))
         event.preventDefault();
     else
         capturePaste(view, event);
@@ -4751,7 +4767,7 @@ function readDOMChange(view, from, to, typeOver, addedNodes) {
     // as being an iOS enter press), just dispatch an Enter key instead.
     if (((ios && view.input.lastIOSEnter > Date.now() - 225 &&
         (!inlineChange || addedNodes.some(n => n.nodeName == "DIV" || n.nodeName == "P"))) ||
-        (!inlineChange && $from.pos < parse.doc.content.size &&
+        (!inlineChange && $from.pos < parse.doc.content.size && !$from.sameParent($to) &&
             (nextSel = Selection.findFrom(parse.doc.resolve($from.pos + 1), 1, true)) &&
             nextSel.head == $to.pos)) &&
         view.someProp("handleKeyDown", f => f(view, keyEvent(13, "Enter")))) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.31.3",
+  "version": "1.31.5",
   "description": "ProseMirror's view component",
   "type": "module",
   "main": "dist/index.cjs",

package/src/capturekeys.ts

@@ -278,7 +278,7 @@ export function captureKeyDown(view: EditorView, event: KeyboardEvent) {
   let code = event.keyCode, mods = getMods(event)
   if (code == 8 || (browser.mac && code == 72 && mods == "c")) { // Backspace, Ctrl-h on Mac
     return stopNativeHorizontalDelete(view, -1) || skipIgnoredNodes(view, -1)
-  } else if (code == 46 || (browser.mac && code == 68 && mods == "c")) { // Delete, Ctrl-d on Mac
+  } else if ((code == 46 && !event.shiftKey) || (browser.mac && code == 68 && mods == "c")) { // Delete, Ctrl-d on Mac
     return stopNativeHorizontalDelete(view, 1) || skipIgnoredNodes(view, 1)
   } else if (code == 13 || code == 27) { // Enter, Esc
     return true

package/src/domchange.ts

@@ -185,7 +185,7 @@ export function readDOMChange(view: EditorView, from: number, to: number, typeOv
   // as being an iOS enter press), just dispatch an Enter key instead.
   if (((browser.ios && view.input.lastIOSEnter > Date.now() - 225 &&
         (!inlineChange || addedNodes.some(n => n.nodeName == "DIV" || n.nodeName == "P"))) ||
-       (!inlineChange && $from.pos < parse.doc.content.size &&
+       (!inlineChange && $from.pos < parse.doc.content.size && !$from.sameParent($to) &&
         (nextSel = Selection.findFrom(parse.doc.resolve($from.pos + 1), 1, true)) &&
         nextSel.head == $to.pos)) &&
       view.someProp("handleKeyDown", f => f(view, keyEvent(13, "Enter")))) {

package/src/input.ts

@@ -582,11 +582,12 @@ function capturePaste(view: EditorView, event: ClipboardEvent) {
   if (!plainText) target.contentEditable = "true"
   target.style.cssText = "position: fixed; left: -10000px; top: 10px"
   target.focus()
+  let plain = view.input.shiftKey && view.input.lastKeyCode != 45
   setTimeout(() => {
     view.focus()
     if (target.parentNode) target.parentNode.removeChild(target)
-    if (plainText) doPaste(view, (target as HTMLTextAreaElement).value, null, view.input.shiftKey, event)
-    else doPaste(view, target.textContent!, target.innerHTML, view.input.shiftKey, event)
+    if (plainText) doPaste(view, (target as HTMLTextAreaElement).value, null, plain, event)
+    else doPaste(view, target.textContent!, target.innerHTML, plain, event)
   }, 50)
 }
 
@@ -597,7 +598,7 @@ export function doPaste(view: EditorView, text: string, html: string | null, pre
 
   let singleNode = sliceSingleNode(slice)
   let tr = singleNode
-    ? view.state.tr.replaceSelectionWith(singleNode, view.input.shiftKey)
+    ? view.state.tr.replaceSelectionWith(singleNode, preferPlain)
     : view.state.tr.replaceSelection(slice)
   view.dispatch(tr.scrollIntoView().setMeta("paste", true).setMeta("uiEvent", "paste"))
   return true
@@ -611,7 +612,8 @@ editHandlers.paste = (view, _event) => {
   // where the editor is almost always composing.
   if (view.composing && !browser.android) return
   let data = brokenClipboardAPI ? null : event.clipboardData
-  if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), view.input.shiftKey, event))
+  let plain = view.input.shiftKey && view.input.lastKeyCode != 45
+  if (data && doPaste(view, data.getData("text/plain"), data.getData("text/html"), plain, event))
     event.preventDefault()
   else
     capturePaste(view, event)

package/src/viewdesc.ts

@@ -385,6 +385,18 @@ export class ViewDesc {
       let {node, offset} = anchorDOM
       if (node.nodeType == 3) {
         brKludge = !!(offset && node.nodeValue![offset - 1] == "\n")
+        // Issue #1128
+        if (brKludge && offset == node.nodeValue!.length) {
+          for (let scan: DOMNode | null = node, after; scan; scan = scan.parentNode) {
+            if (after = scan.nextSibling) {
+              if (after.nodeName == "BR")
+                anchorDOM = headDOM = {node: after.parentNode!, offset: domIndex(after) + 1}
+              break
+            }
+            let desc = scan.pmViewDesc
+            if (desc && desc.node && desc.node.isBlock) break
+          }
+        }
       } else {
         let prev = node.childNodes[offset - 1]
         brKludge = prev && (prev.nodeName == "BR" || (prev as HTMLElement).contentEditable == "false")
@@ -1255,6 +1267,7 @@ class ViewTreeUpdater {
     if (!wrapper.contentDOM) return null
     wrapper.children = next.children
     next.children = []
+    next.destroy()
     for (let ch of wrapper.children) ch.parent = wrapper
    
     return wrapper