prosemirror-view 1.23.4 → 1.23.7

package/CHANGELOG.md

@@ -1,3 +1,27 @@
+## 1.23.7 (2022-02-25)
+
+### Bug fixes
+
+Fix a crash when a view was being destroyed during input reading.
+
+Fix a crash on Firefox when replacing text in some specific types of document structure.
+
+## 1.23.6 (2022-01-13)
+
+### Bug fixes
+
+Fix an issue that could cause pieces of DOM to not be synchronized with the document after some kind of changes around marks.
+
+Fix a bug where marks rendered with nested elements would in some situations suppress new input.
+
+Disable Chrome-specific drag-selection workaround in non-Chrome browsers because it affected table cell selection in Safari.
+
+## 1.23.5 (2021-12-27)
+
+### Bug fixes
+
+Use the `whitespace` node prop where appropriate.
+
 ## 1.23.4 (2021-12-22)
 
 ### Bug fixes

package/dist/index.es.js

@@ -64,7 +64,8 @@ function scanFor(node, off, targetNode, targetOff, dir) {
     if (node == targetNode && off == targetOff) { return true }
     if (off == (dir < 0 ? 0 : nodeSize(node))) {
       var parent = node.parentNode;
-      if (parent.nodeType != 1 || hasBlockDesc(node) || atomElements.test(node.nodeName) || node.contentEditable == "false")
+      if (!parent || parent.nodeType != 1 || hasBlockDesc(node) || atomElements.test(node.nodeName) ||
+          node.contentEditable == "false")
         { return false }
       off = domIndex(node) + (dir < 0 ? 0 : 1);
       node = parent;
@@ -1051,7 +1052,8 @@ ViewDesc.prototype.markDirty = function markDirty (from, to) {
         else { child.markDirty(from - startInside, to - startInside); }
         return
       } else {
-        child.dirty = child.dom == child.contentDOM && child.dom.parentNode == this.contentDOM ? CONTENT_DIRTY : NODE_DIRTY;
+        child.dirty = child.dom == child.contentDOM && child.dom.parentNode == this.contentDOM && !child.children.length
+          ? CONTENT_DIRTY : NODE_DIRTY;
       }
     }
     offset = end;
@@ -1189,7 +1191,10 @@ var MarkViewDesc = /*@__PURE__*/(function (ViewDesc) {
     return new MarkViewDesc(parent, mark, spec.dom, spec.contentDOM || spec.dom)
   };
 
-  MarkViewDesc.prototype.parseRule = function parseRule () { return {mark: this.mark.type.name, attrs: this.mark.attrs, contentElement: this.contentDOM} };
+  MarkViewDesc.prototype.parseRule = function parseRule () {
+    if ((this.dirty & NODE_DIRTY) || this.mark.type.spec.reparseInView) { return null }
+    return {mark: this.mark.type.name, attrs: this.mark.attrs, contentElement: this.contentDOM}
+  };
 
   MarkViewDesc.prototype.matchesMark = function matchesMark (mark) { return this.dirty != NODE_DIRTY && this.mark.eq(mark) };
 
@@ -1290,7 +1295,7 @@ var NodeViewDesc = /*@__PURE__*/(function (ViewDesc) {
     // attrs in the dom, that won't be picked up. Not entirely sure
     // whether this is a problem
     var rule = {node: this.node.type.name, attrs: this.node.attrs};
-    if (this.node.type.spec.code) { rule.preserveWhitespace = "full"; }
+    if (this.node.type.whitespace == "pre") { rule.preserveWhitespace = "full"; }
     if (this.contentDOM && !this.contentLost) { rule.contentElement = this.contentDOM; }
     else { rule.getContent = function () { return this$1.contentDOM ? Fragment.empty : this$1.node.content; }; }
     return rule
@@ -2148,7 +2153,10 @@ function selectionToDOM(view, force) {
 
   if (!editorOwnsSelection(view)) { return }
 
-  if (!force && view.mouseDown && view.mouseDown.allowDefault) {
+  // The delayed drag selection causes issues with Cell Selections
+  // in Safari. And the drag selection delay is to workarond issues
+  // which only present in Chrome.
+  if (!force && view.mouseDown && view.mouseDown.allowDefault && result.chrome) {
     var domSel = view.root.getSelection(), curSel = view.domObserver.currentSelection;
     if (domSel.anchorNode && isEquivalentPosition(domSel.anchorNode, domSel.anchorOffset,
                                                   curSel.anchorNode, curSel.anchorOffset)) {
@@ -2620,7 +2628,7 @@ function parseBetween(view, from_, to_) {
     topOpen: true,
     from: fromOffset,
     to: toOffset,
-    preserveWhitespace: $from.parent.type.spec.code ? "full" : true,
+    preserveWhitespace: $from.parent.type.whitespace == "pre" ? "full" : true,
     editableContent: true,
     findPositions: find,
     ruleFromNode: ruleFromNode,
@@ -3351,7 +3359,7 @@ DOMObserver.prototype.flush = function flush () {
       checkCSS(this.view);
     }
     this.handleDOMChange(from, to, typeOver, added);
-    if (this.view.docView.dirty) { this.view.updateState(this.view.state); }
+    if (this.view.docView && this.view.docView.dirty) { this.view.updateState(this.view.state); }
     else if (!this.currentSelection.eq(sel)) { selectionToDOM(this.view); }
     this.currentSelection.set(sel);
   }
@@ -3902,7 +3910,7 @@ function endComposition(view, forceUpdate) {
   if (result.android && view.domObserver.flushingSoon >= 0) { return }
   view.domObserver.forceFlush();
   clearComposition(view);
-  if (forceUpdate || view.docView.dirty) {
+  if (forceUpdate || view.docView && view.docView.dirty) {
     var sel = selectionFromDOM(view);
     if (sel && !sel.eq(view.state.selection)) { view.dispatch(view.state.tr.setSelection(sel)); }
     else { view.updateState(view.state); }
@@ -5444,7 +5452,10 @@ function checkStateComponent(plugin) {
 //   The DOM serializer to use when putting content onto the
 //   clipboard. If not given, the result of
 //   [`DOMSerializer.fromSchema`](#model.DOMSerializer^fromSchema)
-//   will be used.
+//   will be used. This object will only have its
+//   [`serializeFragment`](#model.DOMSerializer.serializeFragment)
+//   method called, and you may provide an alternative object type
+//   implementing a compatible method.
 //
 //   clipboardTextSerializer:: ?(Slice) → string
 //   A function that will be called to get the text for the current