prosemirror-view 1.21.0 → 1.23.2

package/CHANGELOG.md

@@ -1,3 +1,35 @@
+## 1.23.2 (2021-11-19)
+
+### Bug fixes
+
+Avoid some unnecessary node redraws when marks are present in sibling nodes.
+
+## 1.23.1 (2021-11-15)
+
+### Bug fixes
+
+Restore accidentally reduced lookahead distance in view updating algorithm.
+
+## 1.23.0 (2021-11-11)
+
+### Bug fixes
+
+When parsing clipboard content, ignore trailing BR nodes that look like they might be there as a contenteditable kludge.
+
+### New features
+
+`EditorView` now exposes an `isDestroyed` property that can be used to test if the view has been destroyed.
+
+## 1.22.0 (2021-11-08)
+
+### Bug fixes
+
+Fix an issue where some types of node decoration changes could cause an unnecessary cascade of node redraws.
+
+### New features
+
+Widget decorations now accept a `destroy` option, which will be called when the widget is removed from the view.
+
 ## 1.21.0 (2021-10-29)
 
 ### Bug fixes

package/dist/index.es.js

@@ -1121,6 +1121,11 @@ var WidgetViewDesc = /*@__PURE__*/(function (ViewDesc) {
     return mutation.type != "selection" || this.widget.spec.ignoreSelection
   };
 
+  WidgetViewDesc.prototype.destroy = function destroy () {
+    this.widget.type.destroy(this.dom);
+    ViewDesc.prototype.destroy.call(this);
+  };
+
   prototypeAccessors$1.domAtom.get = function () { return true };
 
   Object.defineProperties( WidgetViewDesc.prototype, prototypeAccessors$1 );
@@ -1696,6 +1701,8 @@ function patchAttributes(dom, prev, cur) {
       { dom.classList.remove(prevList[i]); } }
     for (var i$1 = 0; i$1 < curList.length; i$1++) { if (prevList.indexOf(curList[i$1]) == -1)
       { dom.classList.add(curList[i$1]); } }
+    if (dom.classList.length == 0)
+      { dom.removeAttribute("class"); }
   }
   if (prev.style != cur.style) {
     if (prev.style) {
@@ -1740,7 +1747,7 @@ var ViewTreeUpdater = function ViewTreeUpdater(top, lockedNode) {
   // Tracks whether anything was changed
   this.changed = false;
 
-  this.preMatch = preMatch(top.node.content, top.children);
+  this.preMatch = preMatch(top.node.content, top);
 };
 
 // Destroy and remove the children between the given indices in
@@ -1801,17 +1808,16 @@ ViewTreeUpdater.prototype.syncToMarks = function syncToMarks (marks, inline, vie
 // Try to find a node desc matching the given data. Skip over it and
 // return true when successful.
 ViewTreeUpdater.prototype.findNodeMatch = function findNodeMatch (node, outerDeco, innerDeco, index) {
-  var children = this.top.children, found = -1;
-  if (index >= this.preMatch.index) {
-    for (var i = this.index; i < children.length; i++) { if (children[i].matchesNode(node, outerDeco, innerDeco)) {
-      found = i;
-      break
-    } }
+  var found = -1, targetDesc;
+  if (index >= this.preMatch.index &&
+      (targetDesc = this.preMatch.matches[index - this.preMatch.index]).parent == this.top &&
+      targetDesc.matchesNode(node, outerDeco, innerDeco)) {
+    found = this.top.children.indexOf(targetDesc, this.index);
   } else {
-    for (var i$1 = this.index, e = Math.min(children.length, i$1 + 1); i$1 < e; i$1++) {
-      var child = children[i$1];
+    for (var i = this.index, e = Math.min(this.top.children.length, i + 5); i < e; i++) {
+      var child = this.top.children[i];
       if (child.matchesNode(node, outerDeco, innerDeco) && !this.preMatch.matched.has(child)) {
-        found = i$1;
+        found = i;
         break
       }
     }
@@ -1920,22 +1926,44 @@ ViewTreeUpdater.prototype.addHackNode = function addHackNode (nodeName) {
   }
 };
 
-// : (Fragment, [ViewDesc]) → {index: number, matched: Map<ViewDesc, number>}
+// : (Fragment, [ViewDesc]) → {index: number, matched: Map<ViewDesc, number>, matches: ViewDesc[]}
 // Iterate from the end of the fragment and array of descs to find
 // directly matching ones, in order to avoid overeagerly reusing those
 // for other nodes. Returns the fragment index of the first node that
 // is part of the sequence of matched nodes at the end of the
 // fragment.
-function preMatch(frag, descs) {
-  var fI = frag.childCount, dI = descs.length, matched = new Map;
-  for (; fI > 0 && dI > 0; dI--) {
-    var desc = descs[dI - 1], node = desc.node;
+function preMatch(frag, parentDesc) {
+  var curDesc = parentDesc, descI = curDesc.children.length;
+  var fI = frag.childCount, matched = new Map, matches = [];
+  outer: while (fI > 0) {
+    var desc = (void 0);
+    for (;;) {
+      if (descI) {
+        var next = curDesc.children[descI - 1];
+        if (next instanceof MarkViewDesc) {
+          curDesc = next;
+          descI = next.children.length;
+        } else {
+          desc = next;
+          descI--;
+          break
+        }
+      } else if (curDesc == parentDesc) {
+        break outer
+      } else {
+        // FIXME
+        descI = curDesc.parent.children.indexOf(curDesc);
+        curDesc = curDesc.parent;
+      }
+    }
+    var node = desc.node;
     if (!node) { continue }
     if (node != frag.child(fI - 1)) { break }
     --fI;
     matched.set(desc, fI);
+    matches.push(desc);
   }
-  return {index: fI, matched: matched}
+  return {index: fI, matched: matched, matches: matches.reverse()}
 }
 
 function compareSide(a, b) { return a.type.side - b.type.side }
@@ -2966,7 +2994,13 @@ function parseFromClipboard(view, text, html, plainText, $context) {
   var sliceData = contextNode && /^(\d+) (\d+) (.*)/.exec(contextNode.getAttribute("data-pm-slice"));
   if (!slice) {
     var parser = view.someProp("clipboardParser") || view.someProp("domParser") || DOMParser.fromSchema(view.state.schema);
-    slice = parser.parseSlice(dom, {preserveWhitespace: !!(asText || sliceData), context: $context});
+    slice = parser.parseSlice(dom, {
+      preserveWhitespace: !!(asText || sliceData),
+      context: $context,
+      ruleFromNode: function ruleFromNode(dom) {
+        if (dom.nodeName == "BR" && !dom.nextSibling) { return {ignore: true} }
+      }
+    });
   }
   if (sliceData) {
     slice = addContext(closeSlice(slice, +sliceData[1], +sliceData[2]), sliceData[3]);
@@ -4121,6 +4155,10 @@ WidgetType.prototype.eq = function eq (other) {
       this.toDOM == other.toDOM && compareObjs(this.spec, other.spec)))
 };
 
+WidgetType.prototype.destroy = function destroy (node) {
+  if (this.spec.destroy) { this.spec.destroy(node); }
+};
+
 var InlineType = function InlineType(attrs, spec) {
   this.spec = spec || noSpec;
   this.attrs = attrs;
@@ -4248,6 +4286,10 @@ Decoration.prototype.map = function map (mapping, offset, oldOffset) {
 //   key are interchangeable—if widgets differ in, for example,
 //   the behavior of some event handler, they should get
 //   different keys.
+//
+//   destroy:: ?(node: dom.Node)
+//   Called when the widget decoration is removed as a result of
+//   mapping
 Decoration.widget = function widget (pos, toDOM, spec) {
   return new Decoration(pos, pos, new WidgetType(toDOM, spec))
 };
@@ -4843,7 +4885,7 @@ var EditorView = function EditorView(place, props) {
   this.updatePluginViews();
 };
 
-var prototypeAccessors$2 = { props: { configurable: true },root: { configurable: true } };
+var prototypeAccessors$2 = { props: { configurable: true },root: { configurable: true },isDestroyed: { configurable: true } };
 
 // composing:: boolean
 // Holds `true` when a
@@ -5153,6 +5195,14 @@ EditorView.prototype.destroy = function destroy () {
   this.docView = null;
 };
 
+// :: boolean
+// This is true when the view has been
+// [destroyed](#view.EditorView.destroy) (and thus should not be
+// used anymore).
+prototypeAccessors$2.isDestroyed.get = function () {
+  return this.docView == null
+};
+
 // Used for testing.
 EditorView.prototype.dispatchEvent = function dispatchEvent$1 (event) {
   return dispatchEvent(this, event)
@@ -5423,7 +5473,7 @@ function checkStateComponent(plugin) {
 //   view](#state.PluginSpec.view) and
 //   [props](#state.PluginSpec.props). Passing plugins with a state
 //   component (a [state field](#state.PluginSpec.state) field or a
-//   [transaction)[#state.PluginSpec.filterTransaction] filter or
+//   [transaction](#state.PluginSpec.filterTransaction) filter or
 //   appender) will result in an error, since such plugins must be
 //   present in the state to work.
 //