prosemirror-view 1.20.1 → 1.22.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-view",
-  "version": "1.20.1",
+  "version": "1.22.0",
   "description": "ProseMirror's view component",
   "main": "dist/index.js",
   "module": "dist/index.es.js",
@@ -24,7 +24,7 @@
   },
   "devDependencies": {
     "ist": "^1.0.0",
-    "mocha": "^3.0.2",
+    "mocha": "^9.1.2",
     "moduleserve": "^0.7.0",
     "prosemirror-test-builder": "^1.0.0",
     "rollup": "^2.26.3",

package/src/browser.js

@@ -6,7 +6,6 @@ if (typeof navigator != "undefined" && typeof document != "undefined") {
   const ie_upto10 = /MSIE \d/.test(navigator.userAgent)
   const ie_11up = /Trident\/(?:[7-9]|\d{2,})\..*rv:(\d+)/.exec(navigator.userAgent)
 
-  result.mac = /Mac/.test(navigator.platform)
   let ie = result.ie = !!(ie_upto10 || ie_11up || ie_edge)
   result.ie_version = ie_upto10 ? document.documentMode || 6 : ie_11up ? +ie_11up[1] : ie_edge ? +ie_edge[1] : null
   result.gecko = !ie && /gecko\/(\d+)/i.test(navigator.userAgent)
@@ -17,6 +16,7 @@ if (typeof navigator != "undefined" && typeof document != "undefined") {
   // Is true for both iOS and iPadOS for convenience
   result.safari = !ie && /Apple Computer/.test(navigator.vendor)
   result.ios = result.safari && (/Mobile\/\w+/.test(navigator.userAgent) || navigator.maxTouchPoints > 2)
+  result.mac = result.ios || /Mac/.test(navigator.platform)
   result.android = /Android \d/.test(navigator.userAgent)
   result.webkit = "webkitFontSmoothing" in document.documentElement.style
   result.webkit_version = result.webkit && +(/\bAppleWebKit\/(\d+)/.exec(navigator.userAgent) || [0, 0])[1]

package/src/clipboard.js

@@ -46,7 +46,7 @@ export function parseFromClipboard(view, text, html, plainText, $context) {
   let asText = text && (plainText || inCode || !html)
   if (asText) {
     view.someProp("transformPastedText", f => { text = f(text, inCode || plainText) })
-    if (inCode) return new Slice(Fragment.from(view.state.schema.text(text.replace(/\r\n?/g, "\n"))), 0, 0)
+    if (inCode) return text ? new Slice(Fragment.from(view.state.schema.text(text.replace(/\r\n?/g, "\n"))), 0, 0) : Slice.empty
     let parsed = view.someProp("clipboardTextParser", f => f(text, $context, plainText))
     if (parsed) {
       slice = parsed
@@ -54,8 +54,9 @@ export function parseFromClipboard(view, text, html, plainText, $context) {
       let marks = $context.marks()
       let {schema} = view.state, serializer = DOMSerializer.fromSchema(schema)
       dom = document.createElement("div")
-      text.trim().split(/(?:\r\n?|\n)+/).forEach(block => {
-        dom.appendChild(document.createElement("p")).appendChild(serializer.serializeNode(schema.text(block, marks)))
+      text.split(/(?:\r\n?|\n)+/).forEach(block => {
+        let p = dom.appendChild(document.createElement("p"))
+        if (block) p.appendChild(serializer.serializeNode(schema.text(block, marks)))
       })
     }
   } else {
@@ -70,10 +71,19 @@ export function parseFromClipboard(view, text, html, plainText, $context) {
     let parser = view.someProp("clipboardParser") || view.someProp("domParser") || DOMParser.fromSchema(view.state.schema)
     slice = parser.parseSlice(dom, {preserveWhitespace: !!(asText || sliceData), context: $context})
   }
-  if (sliceData)
+  if (sliceData) {
     slice = addContext(closeSlice(slice, +sliceData[1], +sliceData[2]), sliceData[3])
-  else // HTML wasn't created by ProseMirror. Make sure top-level siblings are coherent
-    slice = Slice.maxOpen(normalizeSiblings(slice.content, $context), false)
+  } else { // HTML wasn't created by ProseMirror. Make sure top-level siblings are coherent
+    slice = Slice.maxOpen(normalizeSiblings(slice.content, $context), true)
+    if (slice.openStart || slice.openEnd) {
+      let openStart = 0, openEnd = 0
+      for (let node = slice.content.firstChild; openStart < slice.openStart && !node.type.spec.isolating;
+           openStart++, node = node.firstChild) {}
+      for (let node = slice.content.lastChild; openEnd < slice.openEnd && !node.type.spec.isolating;
+           openEnd++, node = node.lastChild) {}
+      slice = closeSlice(slice, openStart, openEnd)
+    }
+  }
 
   view.someProp("transformPasted", f => { slice = f(slice) })
   return slice

package/src/decoration.js

@@ -25,6 +25,10 @@ class WidgetType {
        (this.spec.key && this.spec.key == other.spec.key ||
         this.toDOM == other.toDOM && compareObjs(this.spec, other.spec)))
   }
+
+  destroy(node) {
+    if (this.spec.destroy) this.spec.destroy(node)
+  }
 }
 
 class InlineType {
@@ -152,6 +156,10 @@ export class Decoration {
   //     key are interchangeable—if widgets differ in, for example,
   //     the behavior of some event handler, they should get
   //     different keys.
+  //    
+  //     destroy:: ?(node: dom.Node)
+  //     Called when the widget decoration is removed as a result of
+  //     mapping
   static widget(pos, toDOM, spec) {
     return new Decoration(pos, pos, new WidgetType(toDOM, spec))
   }

package/src/domcoords.js

@@ -230,19 +230,19 @@ function elementFromPoint(element, coords, box) {
 
 // Given an x,y position on the editor, get the position in the document.
 export function posAtCoords(view, coords) {
-  let root = view.root, node, offset
-  if (root.caretPositionFromPoint) {
+  let doc = view.dom.ownerDocument, node, offset
+  if (doc.caretPositionFromPoint) {
     try { // Firefox throws for this call in hard-to-predict circumstances (#994)
-      let pos = root.caretPositionFromPoint(coords.left, coords.top)
+      let pos = doc.caretPositionFromPoint(coords.left, coords.top)
       if (pos) ({offsetNode: node, offset} = pos)
     } catch (_) {}
   }
-  if (!node && root.caretRangeFromPoint) {
-    let range = root.caretRangeFromPoint(coords.left, coords.top)
+  if (!node && doc.caretRangeFromPoint) {
+    let range = doc.caretRangeFromPoint(coords.left, coords.top)
     if (range) ({startContainer: node, startOffset: offset} = range)
   }
 
-  let elt = root.elementFromPoint(coords.left, coords.top + 1), pos
+  let elt = (view.root.elementFromPoint ? view.root : doc).elementFromPoint(coords.left, coords.top + 1), pos
   if (!elt || !view.dom.contains(elt.nodeType != 1 ? elt.parentNode : elt)) {
     let box = view.dom.getBoundingClientRect()
     if (!inRect(coords, box)) return null

package/src/index.js

@@ -404,6 +404,9 @@ function computeDocDeco(view) {
     if (value) for (let attr in value) {
       if (attr == "class")
         attrs.class += " " + value[attr]
+      if (attr == "style") {
+        attrs.style = (attrs.style ? attrs.style + ";" : "") + value[attr]
+      }
       else if (!attrs[attr] && attr != "contenteditable" && attr != "nodeName")
         attrs[attr] = String(value[attr])
     }
@@ -639,7 +642,7 @@ function checkStateComponent(plugin) {
 //   view](#state.PluginSpec.view) and
 //   [props](#state.PluginSpec.props). Passing plugins with a state
 //   component (a [state field](#state.PluginSpec.state) field or a
-//   [transaction)[#state.PluginSpec.filterTransaction] filter or
+//   [transaction](#state.PluginSpec.filterTransaction) filter or
 //   appender) will result in an error, since such plugins must be
 //   present in the state to work.
 //

package/src/viewdesc.js

@@ -526,6 +526,11 @@ class WidgetViewDesc extends ViewDesc {
     return mutation.type != "selection" || this.widget.spec.ignoreSelection
   }
 
+  destroy() {
+    this.widget.type.destroy(this.dom)
+    super.destroy()
+  }
+
   get domAtom() { return true }
 }
 
@@ -1038,6 +1043,8 @@ function patchAttributes(dom, prev, cur) {
       dom.classList.remove(prevList[i])
     for (let i = 0; i < curList.length; i++) if (prevList.indexOf(curList[i]) == -1)
       dom.classList.add(curList[i])
+    if (dom.classList.length == 0)
+      dom.removeAttribute("class")
   }
   if (prev.style != cur.style) {
     if (prev.style) {
@@ -1147,9 +1154,11 @@ class ViewTreeUpdater {
   findNodeMatch(node, outerDeco, innerDeco, index) {
     let children = this.top.children, found = -1
     if (index >= this.preMatch.index) {
-      for (let i = this.index; i < children.length; i++) if (children[i].matchesNode(node, outerDeco, innerDeco)) {
-        found = i
-        break
+      for (let i = this.index; i < children.length; i++) {
+        if (this.preMatch.matched.get(children[i]) == index) {
+          if (children[i].matchesNode(node, outerDeco, innerDeco)) found = i
+          break
+        }
       }
     } else {
       for (let i = this.index, e = Math.min(children.length, i + 1); i < e; i++) {
@@ -1258,6 +1267,7 @@ class ViewTreeUpdater {
     } else {
       let dom = document.createElement(nodeName)
       if (nodeName == "IMG") dom.className = "ProseMirror-separator"
+      if (nodeName == "BR") dom.className = "ProseMirror-trailingBreak"
       this.top.children.splice(this.index++, 0, new TrailingHackViewDesc(this.top, nothing, dom, null))
       this.changed = true
     }