prosemirror-transform 1.3.3 → 1.4.1

package/CHANGELOG.md

@@ -1,3 +1,21 @@
+## 1.4.1 (2022-03-31)
+
+### Bug fixes
+
+`replaceRange` will now close multiple defining parent nodes when appropriate.
+
+## 1.4.0 (2022-03-21)
+
+### New features
+
+Node specs can now use the `definingForContent` and `definingAsContext` properties to opt in to specific parts of the existing `defining` behavior.
+
+## 1.3.4 (2022-02-04)
+
+### Bug fixes
+
+Make sure that constructing an empty `StepMap` returns `StepMap.empty`.
+
 ## 1.3.3 (2021-09-29)
 
 ### Bug fixes

package/dist/index.es.js

@@ -57,6 +57,7 @@ var MapResult = function MapResult(pos, deleted, recover) {
 var StepMap = function StepMap(ranges, inverted) {
   if ( inverted === void 0 ) inverted = false;
 
+  if (!ranges.length && StepMap.empty) { return StepMap.empty }
   this.ranges = ranges;
   this.inverted = inverted;
 };
@@ -141,6 +142,8 @@ StepMap.offset = function offset (n) {
   return n == 0 ? StepMap.empty : new StepMap(n < 0 ? [0, -n, 0] : [0, 0, n])
 };
 
+// :: StepMap
+// A StepMap that contains no changed ranges.
 StepMap.empty = new StepMap([]);
 
 // :: class extends Mappable
@@ -720,8 +723,14 @@ function findWrappingInside(range, type) {
 // probably be computed with [`findWrapping`](#transform.findWrapping).
 Transform.prototype.wrap = function(range, wrappers) {
   var content = Fragment.empty;
-  for (var i = wrappers.length - 1; i >= 0; i--)
-    { content = Fragment.from(wrappers[i].type.create(wrappers[i].attrs, content)); }
+  for (var i = wrappers.length - 1; i >= 0; i--) {
+    if (content.size) {
+      var match = wrappers[i].type.contentMatch.matchFragment(content);
+      if (!match || !match.validEnd)
+        { throw new RangeError("Wrapper type given to Transform.wrap does not form valid content of its parent wrapper") }
+    }
+    content = Fragment.from(wrappers[i].type.create(wrappers[i].attrs, content));
+  }
 
   var start = range.start, end = range.end;
   return this.step(new ReplaceAroundStep(start, end, start, end, new Slice(content, 0, 0), wrappers.length, true))
@@ -1529,6 +1538,10 @@ function invalidMarks(type, fragment, start) {
   return false
 }
 
+function definesContent(type) {
+  return type.spec.defining || type.spec.definingForContent
+}
+
 // :: (number, number, Slice) → this
 // Replace a range of the document with a given slice, using `from`,
 // `to`, and the slice's [`openStart`](#model.Slice.openStart) property
@@ -1536,9 +1549,9 @@ function invalidMarks(type, fragment, start) {
 // grow the replaced area or close open nodes in the slice in order to
 // get a fit that is more in line with WYSIWYG expectations, by
 // dropping fully covered parent nodes of the replaced region when
-// they are marked [non-defining](#model.NodeSpec.defining), or
+// they are marked [non-defining as context](#model.NodeSpec.definingAsContext), or
 // including an open parent node from the slice that _is_ marked as
-// [defining](#model.NodeSpec.defining).
+// [defining its content](#model.NodeSpec.definingForContent).
 //
 // This is the method, for example, to handle paste. The similar
 // [`replace`](#transform.Transform.replace) method is a more
@@ -1565,7 +1578,7 @@ Transform.prototype.replaceRange = function(from, to, slice) {
   // cross a defining node.
   for (var d = $from.depth, pos = $from.pos - 1; d > 0; d--, pos--) {
     var spec = $from.node(d).type.spec;
-    if (spec.defining || spec.isolating) { break }
+    if (spec.defining || spec.definingAsContext || spec.isolating) { break }
     if (targetDepths.indexOf(d) > -1) { preferredTarget = d; }
     else if ($from.before(d) == pos) { targetDepths.splice(1, 0, -d); }
   }
@@ -1580,14 +1593,14 @@ Transform.prototype.replaceRange = function(from, to, slice) {
     if (i == slice.openStart) { break }
     content = node.content;
   }
-  // Back up if the node directly above openStart, or the node above
-  // that separated only by a non-defining textblock node, is defining.
-  if (preferredDepth > 0 && leftNodes[preferredDepth - 1].type.spec.defining &&
-      $from.node(preferredTargetIndex).type != leftNodes[preferredDepth - 1].type)
-    { preferredDepth -= 1; }
-  else if (preferredDepth >= 2 && leftNodes[preferredDepth - 1].isTextblock && leftNodes[preferredDepth - 2].type.spec.defining &&
-           $from.node(preferredTargetIndex).type != leftNodes[preferredDepth - 2].type)
-    { preferredDepth -= 2; }
+
+  // Back up preferredDepth to cover defining textblocks directly
+  // above it, possibly skipping a non-defining textblock.
+  for (var d$1 = preferredDepth - 1; d$1 >= 0; d$1--) {
+    var type = leftNodes[d$1].type, def = definesContent(type);
+    if (def && $from.node(preferredTargetIndex).type != type) { preferredDepth = d$1; }
+    else if (def || !type.isTextblock) { break }
+  }
 
   for (var j = slice.openStart; j >= 0; j--) {
     var openDepth = (j + preferredDepth + 1) % (slice.openStart + 1);