prosemirror-transform 1.10.4 → 1.10.5

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.10.5 (2025-11-11)
+
+### Bug fixes
+
+Fix a bug in `liftTarget` that caused it to fail to properly check content constraints when a lift would split a node.
+
 ## 1.10.4 (2025-04-22)
 
 ### Bug fixes

package/dist/index.cjs

@@ -853,12 +853,14 @@ function canCut(node, start, end) {
 function liftTarget(range) {
   var parent = range.parent;
   var content = parent.content.cutByIndex(range.startIndex, range.endIndex);
-  for (var depth = range.depth;; --depth) {
+  for (var depth = range.depth, contentBefore = 0, contentAfter = 0;; --depth) {
     var node = range.$from.node(depth);
-    var index = range.$from.index(depth),
-      endIndex = range.$to.indexAfter(depth);
+    var index = range.$from.index(depth) + contentBefore,
+      endIndex = range.$to.indexAfter(depth) - contentAfter;
     if (depth < range.depth && node.canReplace(index, endIndex, content)) return depth;
     if (depth == 0 || node.type.spec.isolating || !canCut(node, index, endIndex)) break;
+    if (index) contentBefore = 1;
+    if (endIndex < node.childCount) contentAfter = 1;
   }
   return null;
 }
@@ -1434,7 +1436,7 @@ function _replaceRange(tr, from, to, slice) {
   var $from = tr.doc.resolve(from),
     $to = tr.doc.resolve(to);
   if (fitsTrivially($from, $to, slice)) return tr.step(new ReplaceStep(from, to, slice));
-  var targetDepths = coveredDepths($from, tr.doc.resolve(to));
+  var targetDepths = coveredDepths($from, $to);
   if (targetDepths[targetDepths.length - 1] == 0) targetDepths.pop();
   var preferredTarget = -($from.depth + 1);
   targetDepths.unshift(preferredTarget);

package/dist/index.js

@@ -982,13 +982,17 @@ can be lifted. Will not go across
 function liftTarget(range) {
     let parent = range.parent;
     let content = parent.content.cutByIndex(range.startIndex, range.endIndex);
-    for (let depth = range.depth;; --depth) {
+    for (let depth = range.depth, contentBefore = 0, contentAfter = 0;; --depth) {
         let node = range.$from.node(depth);
-        let index = range.$from.index(depth), endIndex = range.$to.indexAfter(depth);
+        let index = range.$from.index(depth) + contentBefore, endIndex = range.$to.indexAfter(depth) - contentAfter;
         if (depth < range.depth && node.canReplace(index, endIndex, content))
             return depth;
         if (depth == 0 || node.type.spec.isolating || !canCut(node, index, endIndex))
             break;
+        if (index)
+            contentBefore = 1;
+        if (endIndex < node.childCount)
+            contentAfter = 1;
     }
     return null;
 }
@@ -1639,7 +1643,7 @@ function replaceRange(tr, from, to, slice) {
     let $from = tr.doc.resolve(from), $to = tr.doc.resolve(to);
     if (fitsTrivially($from, $to, slice))
         return tr.step(new ReplaceStep(from, to, slice));
-    let targetDepths = coveredDepths($from, tr.doc.resolve(to));
+    let targetDepths = coveredDepths($from, $to);
     // Can't replace the whole document, so remove 0 if it's present
     if (targetDepths[targetDepths.length - 1] == 0)
         targetDepths.pop();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-transform",
-  "version": "1.10.4",
+  "version": "1.10.5",
   "description": "ProseMirror document transformations",
   "type": "module",
   "main": "dist/index.cjs",

package/src/replace.ts

@@ -338,7 +338,7 @@ export function replaceRange(tr: Transform, from: number, to: number, slice: Sli
   if (fitsTrivially($from, $to, slice))
     return tr.step(new ReplaceStep(from, to, slice))
 
-  let targetDepths = coveredDepths($from, tr.doc.resolve(to))
+  let targetDepths = coveredDepths($from, $to)
   // Can't replace the whole document, so remove 0 if it's present
   if (targetDepths[targetDepths.length - 1] == 0) targetDepths.pop()
   // Negative numbers represent not expansion over the whole node at

package/src/structure.ts

@@ -15,12 +15,14 @@ function canCut(node: Node, start: number, end: number) {
 export function liftTarget(range: NodeRange): number | null {
   let parent = range.parent
   let content = parent.content.cutByIndex(range.startIndex, range.endIndex)
-  for (let depth = range.depth;; --depth) {
+  for (let depth = range.depth, contentBefore = 0, contentAfter = 0;; --depth) {
     let node = range.$from.node(depth)
-    let index = range.$from.index(depth), endIndex = range.$to.indexAfter(depth)
+    let index = range.$from.index(depth) + contentBefore, endIndex = range.$to.indexAfter(depth) - contentAfter
     if (depth < range.depth && node.canReplace(index, endIndex, content))
       return depth
     if (depth == 0 || node.type.spec.isolating || !canCut(node, index, endIndex)) break
+    if (index) contentBefore = 1
+    if (endIndex < node.childCount) contentAfter = 1
   }
   return null
 }