promptgraph-mcp 1.5.4 → 1.5.5

package/indexer.js

@@ -43,23 +43,30 @@ async function indexBatch(db, skills) {
   const texts = allChunks.map(c => c.text);
   const embeddings = await embedBatch(texts);
 
-  const txn = db.transaction(() => {
+  // pass 1: upsert all skills + chunks (no edges yet)
+  db.transaction(() => {
     for (const skill of skills) {
       const id = skillId(skill.source, skill.name);
       upsertSkill.run({ id, name: skill.name, description: skill.description, path: skill.path, source: skill.source, content: skill.content, hash: skill.hash || null });
       deleteChunks.run(id);
       deleteEdges.run(id);
-      for (const calledName of skill.calls) {
-        const resolved = db.prepare("SELECT id FROM skills WHERE name = ? ORDER BY id LIMIT 1").get(calledName);
-        upsertEdge.run(id, resolved ? resolved.id : calledName);
-      }
     }
     for (let i = 0; i < allChunks.length; i++) {
       const { id, chunkIndex, text } = allChunks[i];
       upsertChunk.run(id, chunkIndex, text, JSON.stringify(embeddings[i]));
     }
-  });
-  txn();
+  })();
+
+  // pass 2: resolve edges after all skills in batch are committed
+  db.transaction(() => {
+    for (const skill of skills) {
+      const id = skillId(skill.source, skill.name);
+      for (const calledName of skill.calls) {
+        const resolved = db.prepare("SELECT id FROM skills WHERE name = ? ORDER BY id LIMIT 1").get(calledName);
+        upsertEdge.run(id, resolved ? resolved.id : calledName);
+      }
+    }
+  })();
 }
 
 export async function indexAll() {
@@ -75,12 +82,24 @@ export async function indexAll() {
   const total = allFiles.length;
   info(`Found ${chalk.white.bold(total)} files`);
 
-  // reconcile: remove skills whose files no longer exist
-  const allIds = db.prepare('SELECT id, path FROM skills').all();
+  // reconcile: remove skills whose files no longer exist OR whose name changed
+  const allDbSkills = db.prepare('SELECT id, path, name, source FROM skills').all();
   const existingPaths = new Set(allFiles.map(f => f.file));
   let removed = 0;
-  for (const row of allIds) {
-    if (!existingPaths.has(row.path)) {
+
+  // build expected id map from disk
+  const expectedIds = new Map();
+  for (const { file, source } of allFiles) {
+    try {
+      const parsed = parseSkillFile(file, source);
+      expectedIds.set(file, skillId(source, parsed.name));
+    } catch {}
+  }
+
+  for (const row of allDbSkills) {
+    const pathGone = !existingPaths.has(row.path);
+    const idChanged = expectedIds.has(row.path) && expectedIds.get(row.path) !== row.id;
+    if (pathGone || idChanged) {
       db.prepare('DELETE FROM skills WHERE id = ?').run(row.id);
       db.prepare('DELETE FROM chunks WHERE skill_id = ?').run(row.id);
       db.prepare('DELETE FROM edges WHERE from_skill = ? OR to_skill = ?').run(row.id, row.id);
@@ -88,7 +107,7 @@ export async function indexAll() {
       removed++;
     }
   }
-  if (removed > 0) info(`Removed ${chalk.yellow(removed)} deleted skills`);
+  if (removed > 0) info(`Removed ${chalk.yellow(removed)} stale/deleted skills`);
 
   let count = 0;
   let errors = 0;

package/marketplace.js

@@ -1,7 +1,7 @@
 import fs from 'fs';
 import path from 'path';
 import os from 'os';
-import { execSync } from 'child_process';
+import { spawnSync } from 'child_process';
 import { getDb } from './db.js';
 
 const REGISTRY_URL = 'https://raw.githubusercontent.com/NeiP4n/promptgraph-registry/main/registry.json';
@@ -10,26 +10,31 @@ const SKILLS_DIR = path.join(os.homedir(), '.claude', 'skills-store', 'marketpla
 export async function browseMarketplace(topK = 20) {
   try {
     const res = await fetch(REGISTRY_URL);
+    if (!res.ok) return { error: `Registry returned ${res.status}. Check https://github.com/NeiP4n/promptgraph-registry` };
     const registry = await res.json();
+    if (!Array.isArray(registry.skills)) return { error: 'Invalid registry format' };
     return registry.skills
       .sort((a, b) => (b.stars || 0) - (a.stars || 0))
       .slice(0, topK);
-  } catch {
-    return { error: 'Registry unavailable. Check https://github.com/NeiP4n/promptgraph-registry' };
+  } catch (e) {
+    return { error: `Registry unavailable: ${e.message}` };
   }
 }
 
 export async function installSkill(skillId) {
   try {
     const res = await fetch(REGISTRY_URL);
+    if (!res.ok) return { error: `Registry returned ${res.status}` };
     const registry = await res.json();
-    const skill = registry.skills.find(s => s.id === skillId);
+    const skill = registry.skills?.find(s => s.id === skillId);
     if (!skill) return { error: `Skill "${skillId}" not found in registry` };
+    if (!skill.raw_url) return { error: `Skill "${skillId}" has no download URL` };
 
     fs.mkdirSync(SKILLS_DIR, { recursive: true });
     const dest = path.join(SKILLS_DIR, `${skillId}.md`);
 
     const content = await fetch(skill.raw_url);
+    if (!content.ok) return { error: `Failed to download skill: ${content.status}` };
     const text = await content.text();
     fs.writeFileSync(dest, text);
 
@@ -46,17 +51,21 @@ export async function publishSkill(filePath) {
   const name = path.basename(filePath, '.md');
 
   try {
-    const result = execSync(
-      `gh gist create "${filePath}" --desc "PromptGraph skill: ${name}" --public`,
+    const result = spawnSync(
+      'gh',
+      ['gist', 'create', filePath, '--desc', `PromptGraph skill: ${name}`, '--public'],
       { encoding: 'utf8' }
-    ).trim();
+    );
+    if (result.status !== 0) {
+      return { error: result.stderr?.trim() || 'gh CLI error. Run: gh auth login' };
+    }
     return {
       success: true,
-      url: result,
+      url: result.stdout.trim(),
       message: `Published! Submit to registry: https://github.com/NeiP4n/promptgraph-registry/issues/new`,
     };
   } catch {
-    return { error: 'gh CLI not found or not authenticated. Run: gh auth login' };
+    return { error: 'gh CLI not found. Install from: https://cli.github.com' };
   }
 }
 
@@ -70,7 +79,7 @@ export function getTopRated(topK = 10) {
                 ELSE NULL END as rating
     FROM skills s
     LEFT JOIN ratings r ON s.id = r.skill_id
-    WHERE r.uses > 0
+    WHERE (r.success + r.fail) >= 3
     ORDER BY rating DESC, r.uses DESC
     LIMIT ?
   `).all(topK);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "promptgraph-mcp",
-  "version": "1.5.4",
+  "version": "1.5.5",
   "main": "index.js",
   "type": "module",
   "bin": {

package/search.js

@@ -65,28 +65,31 @@ export function getContext(id) {
 }
 
 function resolveId(db, nameOrId) {
-  // try exact id match first, then name match
   const byId = db.prepare('SELECT id FROM skills WHERE id = ?').get(nameOrId);
   if (byId) return byId.id;
   const byName = db.prepare('SELECT id FROM skills WHERE name = ? ORDER BY id LIMIT 1').get(nameOrId);
-  return byName ? byName.id : nameOrId;
+  if (byName) return byName.id;
+  return null;
 }
 
 export function getCallers(nameOrId) {
   const db = getDb();
   const id = resolveId(db, nameOrId);
+  if (!id) return { error: `Skill not found: ${nameOrId}` };
   return db.prepare('SELECT from_skill FROM edges WHERE to_skill = ?').all(id).map(r => r.from_skill);
 }
 
 export function getCallees(nameOrId) {
   const db = getDb();
   const id = resolveId(db, nameOrId);
+  if (!id) return { error: `Skill not found: ${nameOrId}` };
   return db.prepare('SELECT to_skill FROM edges WHERE from_skill = ?').all(id).map(r => r.to_skill);
 }
 
 export function getImpact(nameOrId) {
   const db = getDb();
   const id = resolveId(db, nameOrId);
+  if (!id) return { error: `Skill not found: ${nameOrId}` };
   const visited = new Set();
   const queue = [id];
   while (queue.length) {

package/watcher.js

@@ -1,16 +1,13 @@
 import chokidar from 'chokidar';
 import path from 'path';
-import os from 'os';
 import fs from 'fs';
 import { indexFile } from './indexer.js';
-import { getDb, skillId } from './db.js';
+import { getDb } from './db.js';
 import { loadConfig } from './config.js';
-import matter from 'gray-matter';
 
 export function startWatcher() {
   const config = loadConfig();
   const paths = config.sources.map(s => s.dir).filter(d => fs.existsSync(d));
-
   if (paths.length === 0) return;
 
   const watcher = chokidar.watch(paths, {
@@ -22,7 +19,7 @@ export function startWatcher() {
 
   watcher.on('add', filePath => reindex(filePath, config));
   watcher.on('change', filePath => reindex(filePath, config));
-  watcher.on('unlink', filePath => remove(filePath, config));
+  watcher.on('unlink', filePath => remove(filePath));
 
   console.error('[PromptGraph] Watcher started');
 }
@@ -34,28 +31,24 @@ function getSource(filePath, config) {
   return 'unknown';
 }
 
-function readName(filePath) {
-  try {
-    const raw = fs.readFileSync(filePath, 'utf8');
-    const { data } = matter(raw);
-    return (data.name && String(data.name).trim()) || path.basename(filePath, '.md');
-  } catch {
-    return path.basename(filePath, '.md');
-  }
+function deleteById(id) {
+  const db = getDb();
+  db.prepare('DELETE FROM skills WHERE id = ?').run(id);
+  db.prepare('DELETE FROM chunks WHERE skill_id = ?').run(id);
+  db.prepare('DELETE FROM edges WHERE from_skill = ? OR to_skill = ?').run(id, id);
+  db.prepare('DELETE FROM ratings WHERE skill_id = ?').run(id);
 }
 
-function remove(filePath, config) {
+function remove(filePath) {
   if (!filePath.endsWith('.md')) return;
   try {
-    const source = getSource(filePath, config);
-    const name = readName(filePath);
-    const id = skillId(source, name);
     const db = getDb();
-    db.prepare('DELETE FROM skills WHERE id = ?').run(id);
-    db.prepare('DELETE FROM chunks WHERE skill_id = ?').run(id);
-    db.prepare('DELETE FROM edges WHERE from_skill = ? OR to_skill = ?').run(id, id);
-    db.prepare('DELETE FROM ratings WHERE skill_id = ?').run(id);
-    console.error(`[PromptGraph] Removed: ${id}`);
+    // find by path — file is already deleted, can't read frontmatter
+    const row = db.prepare('SELECT id FROM skills WHERE path = ?').get(filePath);
+    if (row) {
+      deleteById(row.id);
+      console.error(`[PromptGraph] Removed: ${row.id}`);
+    }
   } catch (e) {
     console.error(`[PromptGraph] Error removing ${filePath}: ${e.message}`);
   }
@@ -64,7 +57,23 @@ function remove(filePath, config) {
 async function reindex(filePath, config) {
   if (!filePath.endsWith('.md')) return;
   try {
-    await indexFile(filePath, getSource(filePath, config));
+    const db = getDb();
+    const source = getSource(filePath, config);
+
+    // check if path had a different id before (rename case)
+    const existing = db.prepare('SELECT id FROM skills WHERE path = ?').get(filePath);
+
+    await indexFile(filePath, source);
+
+    // if new id differs from old id — delete old record
+    if (existing) {
+      const updated = db.prepare('SELECT id FROM skills WHERE path = ?').get(filePath);
+      if (updated && updated.id !== existing.id) {
+        deleteById(existing.id);
+        console.error(`[PromptGraph] Renamed: ${existing.id} → ${updated.id}`);
+      }
+    }
+
     console.error(`[PromptGraph] Reindexed: ${path.basename(filePath)}`);
   } catch (e) {
     console.error(`[PromptGraph] Error reindexing ${filePath}: ${e.message}`);