prolog-notebook 0.7.0 → 0.7.1

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # Changelog
 
+## [0.7.1] — 2026-08-31
+
+### Fixed
+
+- **`build` could not find the engine when the tool was installed.** It looked for swipl-wasm at
+  `<this package>/node_modules/swipl-wasm/…`, and npm **hoists** — the dependency is installed as
+  a *sibling* of `prolog-notebook`, not inside it. Nesting is what npm falls back to on a version
+  conflict, so the one layout that path assumed is the one npm avoids:
+
+  ```
+  Error: ENOENT: no such file or directory, copyfile
+    '.../node_modules/prolog-notebook/node_modules/swipl-wasm/dist/swipl/swipl-bundle.js'
+  ```
+
+  This was never a 0.7.0 regression — 0.6.5 fails identically from a real install. `build` has
+  only ever worked from a checkout, where that path happens to exist, which is the only way we
+  had ever run it. The engine is now located through Node's own resolution, which finds the
+  package wherever it was put: hoisted, nested, in pnpm's store, or in a workspace.
+
+### Added
+
+- **A test that uses the package the way somebody else receives it** — `npm run test:packaged`
+  packs the tarball, installs it elsewhere, and builds and runs a chapter with it, asserting
+  first that swipl-wasm really was hoisted so the test cannot pass vacuously. Every other test
+  runs against the checkout, where `node_modules` sits exactly where a relative path expects it,
+  which is precisely why this class of bug was invisible twice. CI runs it on every push and
+  before every publish.
+
+### Fixed
+
+- **A chapter with no saved answers no longer offers a disabled *Restore outputs*.** Run a cell in
+  such a chapter, clear it, and the panel offered to put back answers that never existed — greyed
+  out, because there was nothing to put back. A disabled control says *this could happen, but not
+  now*, and there was no now. The button now reads *Clear all outputs*, disabled, which is the
+  page's opening state and the truth: nothing on screen, nothing to clear. The count still says
+  *1 output cleared*, because that part was never a lie — it is why the page looks empty.
+
+  Most chapters ship without saved answers, since `hold` is how an author keeps them from
+  students, so this was the common chapter's common path rather than an edge case.
+
 ## [0.7.0] — 2026-08-31
 
 A site of notebooks, rather than a folder of unrelated pages.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prolog-notebook",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Jupyter-style notebooks for Prolog. Runs in the browser, installs nothing.",
   "type": "module",
   "main": "./src/node.js",
@@ -30,7 +30,8 @@
   "scripts": {
     "test": "node --test test/*.test.mjs",
     "dev": "python3 -m http.server 8777",
-    "prepublishOnly": "npm test"
+    "prepublishOnly": "npm test",
+    "test:packaged": "node --test test/packaged.mjs"
   },
   "keywords": [
     "prolog",

package/src/browser.js

@@ -8,6 +8,17 @@ import { ConsultLog, defaultCellName, unconsult } from './session.js';
 export * from './engine.js';
 export { ConsultLog } from './session.js';
 
+/**
+ * WHERE A PAGE SERVED OUT OF THIS REPO FINDS THE ENGINE — and only such a page.
+ *
+ * The same-looking literal in build.js was a bug: it guessed at a node_modules
+ * layout npm does not use, so `build` could not find the engine when the tool was
+ * installed (869erzf1j). This one is NOT that bug, and must not be "fixed" into a
+ * new one. There is no module resolution in a browser to ask instead, and every
+ * caller that ships — the app.js of a built page — passes `swiplUrl` outright. So
+ * this default is reached in exactly one situation: a page served from the repo
+ * root by `npm run dev`, where `../node_modules/…` from `/src/` is the truth.
+ */
 const DEFAULT_SWIPL_URL = new URL(
   '../node_modules/swipl-wasm/dist/swipl/swipl-bundle.js',
   import.meta.url

package/src/build-info.json

@@ -1,4 +1,4 @@
 {
-  "commit": "7e40763",
-  "built": "2026-08-31 10:59:41 UTC"
+  "commit": "b988a61",
+  "built": "2026-08-31 11:22:28 UTC"
 }

package/src/build.js

@@ -16,6 +16,7 @@
 // `view` can serve it, and a test can read it, without any of the three
 // disagreeing about what a page is.
 import { createRequire } from 'node:module';
+import { pathToFileURL } from 'node:url';
 import { parse } from './format.js';
 import { renderNotebook } from './render.js';
 
@@ -31,6 +32,25 @@ import { renderNotebook } from './render.js';
 const require = createRequire(import.meta.url);
 export const ENGINE_VERSION = require('swipl-wasm/package.json').version;
 
+/**
+ * WHERE THE ENGINE ACTUALLY IS — asked for, never guessed (869erzf1j).
+ *
+ * This was `new URL('../node_modules/swipl-wasm/dist/swipl/', import.meta.url)`,
+ * which is true in a checkout and false in every install: npm HOISTS, so
+ * swipl-wasm lands as a SIBLING of this package rather than inside it, and
+ * `build` died on a missing file for anybody who had installed the tool rather
+ * than cloned it. Nested is the exception npm resorts to on a version conflict —
+ * the one layout that literal assumed was the one npm avoids.
+ *
+ * Node's own resolution finds the package wherever it was put: hoisted, nested,
+ * inside pnpm's store, or in a workspace. The line above already asked properly
+ * for the version; this one now asks properly for the bytes.
+ */
+export const ENGINE_HOME = new URL(
+  'dist/swipl/',
+  pathToFileURL(require.resolve('swipl-wasm/package.json')),
+);
+
 /** The runtime a page needs. Copied side by side, so their relative imports hold. */
 export const RUNTIME = [
   'notebook.js', 'browser.js', 'session.js', 'engine.js', 'worker.js',
@@ -86,7 +106,7 @@ export function buildFiles(notebook, source, options = {}) {
   const {
     filename = 'notebook.prolog.md',
     src = new URL('./', import.meta.url),
-    engine = new URL('../node_modules/swipl-wasm/dist/swipl/', import.meta.url),
+    engine = ENGINE_HOME,
     prefix = './',
     engineVersion = ENGINE_VERSION,
   } = options;

package/src/notebook.js

@@ -502,14 +502,25 @@ function mountPageBar(root, options, bus, programs, queries) {
     refreshOutputs = () => {
       const gone = queries.filter((q) => q.isCleared());
       const left = queries.filter((q) => q.hasOutput());
-      // Restore only once there is nothing left to clear, which is the rule the
-      // hide/show button already follows: in a half-cleared page the useful move
-      // is to finish, and one vocabulary is cheaper to learn than two.
-      const back = left.length === 0 && gone.length > 0;
       // A cleared cell that never had saved answers has nothing of the chapter's
-      // to give back, so a page of only those leaves restore with no work.
+      // to give back: restore is the way back to the FILE, and the file is empty.
       const restorable = gone.filter((q) => q.hasSaved).length;
-      wipe.disabled = back ? restorable === 0 : left.length === 0;
+      // Restore only once there is nothing left to clear — the rule the hide/show
+      // button already follows, since in a half-cleared page the useful move is to
+      // finish — AND only when there is something to put back.
+      //
+      // That second half was missing (869erzhe7): a chapter published without
+      // answers, run by the reader and then cleared, offered them a DISABLED
+      // "Restore outputs". The Captain: "it shows the incorrect 'Restore output' -
+      // disabled … dont show restore when there's nothing to restore."
+      //
+      // He is right, and it is the doctrine rather than a detail. A disabled
+      // control says "this could happen, but not now"; there is no now in which
+      // that chapter's answers come back, because it never had any. The true
+      // reading of that state is the one the page started in — no outputs, nothing
+      // to clear — so the button says so.
+      const back = left.length === 0 && restorable > 0;
+      wipe.disabled = !back && left.length === 0;
       // COUNTED FROM THE PAGE, which is the only count that stays true for both
       // kinds of chapter: one published with its answers in it, and one still
       // being written where every output on screen is the reader's own.

package/src/version.js

@@ -10,7 +10,7 @@
 export const NAME = 'Prolog Notebook';
 
 /** Must equal package.json's `version` — test/run.test.mjs enforces it. */
-export const VERSION = '0.7.0';
+export const VERSION = '0.7.1';
 
 /** The two facts a licence notice is actually made of. */
 export const YEAR = '2026';