procedure-cli 0.1.13 → 0.1.14

package/CODE-FIXED.md

@@ -1,252 +0,0 @@
-# Code Fix Log
-
-## Writing Standard
-- Each entry documents fixes applied for a specific `CODE-REVIEW.md` entry.
-- Reference the source review by its Entry ID (e.g., `CR-20260221-001`). Do NOT re-describe findings — only document actions taken.
-- For finding details, the reader should consult the referenced `CODE-REVIEW.md` entry.
-- Each finding is referenced as `Finding #N (Severity)` matching the review's numbering.
-- Fixed findings must include `file:line` for every change made.
-- Deferred findings must include rationale and a revisit trigger.
-- Verification section must confirm `npm run typecheck` + `npm run build` status after fixes.
-- Language: English only. Tone: Technical, concise, action-focused.
-
-### Entry ID Convention
-- Required field for every entry: `Entry ID`.
-- Format: `CF-YYYYMMDD-###`
-- Example: `CF-20260222-001`
-- `###` is a zero-padded sequence number for that day.
-
----
-
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-001`
-
-### Source Review
-- `CR-20260221-001` (CODE-REVIEW.md entry 2026-02-21)
-
-### Fixes Applied
-
-1. Finding #1 (High) — **Fixed**
-- `src/lib/powerline.ts:33` — Changed `--config=~/.claude/powerline-config.json` to `--config=.claude/powerline-config.json` so the status-line command reads from the project-local path where the config is actually written.
-
-2. Finding #2 (Medium) — **Fixed**
-- `src/lib/git.ts:3-11` — Added `hasGitIdentity()` helper that pre-checks `git config user.name` and `git config user.email`.
-- `src/lib/git.ts:13-28` — Refactored `initGit()` to return `{ committed: boolean; reason?: string }`. Skips `git commit` when identity is missing and returns a descriptive reason string.
-
-3. Finding #3 (Medium) — **Fixed**
-- `src/lib/powerline.ts:21-29` — Wrapped `JSON.parse(raw)` in try/catch; malformed `.claude/settings.json` now falls back to empty object instead of throwing.
-
-4. Finding #4 (Medium) — **Fixed**
-- `src/lib/template.ts:38-44` — Added `checkConflicts(targetDir)` function that returns list of existing output files that would be overwritten.
-- `src/steps/generation.tsx:5,61,102-113` — Imported `checkConflicts`, added yellow warning in summary phase listing files that will be overwritten before user confirms.
-
-5. Finding #5 (Low) — **Fixed**
-- `src/lib/types.ts:64` — Added `generationSkipped: boolean` field to `WizardAnswers`.
-- `src/app.tsx:49` — Added `generationSkipped: false` to `EMPTY_ANSWERS`.
-- `src/app.tsx:83` — Updated `getSummary` case 5 to return `"skipped"` when `generationSkipped` is true.
-- `src/steps/generation.tsx:9` — Changed `onComplete` prop type to `(partial: Partial<WizardAnswers>) => void`.
-- `src/steps/generation.tsx:35` — On successful generation, calls `onComplete({ generationSkipped: false })`.
-- `src/steps/generation.tsx:48` — On cancel, calls `onComplete({ generationSkipped: true })`.
-- `src/app.tsx:179` — Changed `onComplete={() => handleStepComplete({})}` to `onComplete={handleStepComplete}`.
-
-6. Finding #6 (Low) — **Fixed**
-- `templates/docs/USER-STORIES.md.hbs:1-32` — Added Handlebars `{{#if userStories.length}}` conditional with fallback starter template content when `userStories` is empty. Fallback includes example user story in Gherkin format with clear TODO instructions.
-
-### Deferred
-None — all 6 findings fixed.
-
-### Verification Notes
-- `npm run typecheck`: pass (0 errors)
-- All fixes verified through code inspection.
-
-### Residual Risks / Testing Gaps
-- No automated tests for `checkConflicts()` behavior.
-- No automated tests for `initGit()` across machines with missing git identity.
-- No automated tests for malformed `.claude/settings.json` handling.
-- No automated tests asserting generation summary truthfulness when user cancels.
-- No runtime test for Handlebars `{{#if userStories.length}}` fallback rendering.
-
----
-
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-002`
-
-### Source Review
-- `CR-20260221-002` (CODE-REVIEW.md entry 2026-02-21)
-
-### Fixes Applied
-
-1. Finding #7 (Medium) — **Fixed**
-- `src/lib/git.ts:13-20` — Added `hasStagedFiles()` helper that runs `git status --porcelain`; returns `false` when index is empty.
-- `src/lib/git.ts:30-33` — Added early return `{ committed: false, reason: 'Nothing to commit — directory is empty.' }` before identity check, preventing hard crash on empty-directory init.
-
-2. Finding #8 (Low) — **Fixed**
-- `src/app.tsx:133-141` — Wrapped completion message in `answers.generationSkipped` conditional. Skip path shows neutral `"Generation was skipped — no files were written."` Scaffold path retains original project name + doc check message.
-
-3. Finding #6 re-raised (Low, Still Open in CR-20260221-002) — **Already Fixed**
-- Covered by `CF-20260222-001` Finding #6: `templates/docs/USER-STORIES.md.hbs` Handlebars fallback added in previous fix cycle. No further action required.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass (0 errors)
-- `npm run build`: pass
-
----
-
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-003`
-
-### Source Review
-- `CR-20260221-004` (CODE-REVIEW.md entry 2026-02-21)
-
-### Fixes Applied
-
-1. Finding #9 (Low, Still Open) — **Fixed**
-- `src/steps/powerline.tsx:22` — Added `gitCommitted?: boolean` to `SetupResult` interface.
-- `src/steps/powerline.tsx:41-44` — `runSetup()` now stores `gitResult.committed` in `setupResult.gitCommitted`.
-- `src/steps/powerline.tsx:125-133` — "Git repository initialized." only renders when `setupResult.gitCommitted` is true. When commit failed, only the yellow warning with reason is shown (no mixed success/failure messaging).
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: pass
-
----
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-007`
-
-### Source Review
-- `CR-20260222-005` (CODE-REVIEW.md entry 2026-02-22)
-
-### Fixes Applied
-
-1. Finding #14 (Low) — **Fixed**
-- `src/steps/build-test.tsx:107-111` — On last field (`isLast`), hint now shows `↓ / enter confirm` instead of silently omitting `↓`. On non-last fields, hint consolidated to `↓ next  enter confirm`. Behavior unchanged; hint made consistent with actual key handling.
-- `src/steps/product-context.tsx:253` — `nonGoals` hint updated from `"↑ prev  enter confirm"` to `"↑ prev  ↓ / enter confirm"`.
-
-2. Finding #15 (Low) — **Fixed**
-- `docs/PRD.md:29` — Updated F-001 bullet from "exits with helpful message" to "warns when cwd has files and continues — Step 6 overwrite confirmation handles conflicts".
-- `README.md:4-9` — Replaced stale "exits" wording with accurate warn-and-continue description; overwrite list noted as Step 6 behavior.
-- `docs/USER-STORIES.md:US-002` — Scenario updated from hard-exit / `process.exit(1)` to warn-and-continue / Step 6 overwrite confirmation flow.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: pass
-
----
-
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-004`
-
-### Source Review
-- `CR-20260222-002` (CODE-REVIEW.md entry 2026-02-22)
-
-### Fixes Applied
-
-1. Finding #10 (Low) — **Fixed**
-- `src/lib/types.ts:68` — Added `setupGit: boolean` to `WizardAnswers` so setup choice can be persisted.
-- `src/app.tsx:51` — Added `setupGit: false` to `EMPTY_ANSWERS`.
-- `src/app.tsx:89` — Updated setup summary to render `Git init: yes/no` based on `answers.setupGit` instead of always implying git initialization.
-- `src/steps/powerline.tsx:48` — Updated `onComplete` payload to include `setupGit: git`, preserving the user’s git setup decision for final summaries.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: pass
-
----
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-005`
-
-### Source Review
-- `CR-20260222-003` (CODE-REVIEW.md entry 2026-02-22)
-
-### Fixes Applied
-
-1. Finding #11 (Low) — **Fixed**
-- `src/steps/build-test.tsx:68` — Replaced `dimColor` with `color={C.overlay1}` to comply with the Catppuccin theme rule and keep all color rendering sourced from `src/theme.ts` constants.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: pass
-- `rg "dimColor|color=\"(cyan|green|red|yellow|blue|magenta|white|black)\"" -n src`: no matches
-
----
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-006`
-
-### Source Review
-- `CR-20260222-004` (CODE-REVIEW.md entry 2026-02-22)
-
-### Fixes Applied
-
-1. Finding #12 (Medium) — **Fixed**
-- `src/cli.tsx:11` — Replaced hard-stop behavior with warning-only messaging when directory is non-empty.
-- `src/cli.tsx:13` — Added explicit note that existing files may be overwritten during Step 6, preserving the intended Generation conflict-confirmation flow.
-- `src/cli.tsx:16` — Removed process exit path so wizard continues and existing overwrite warnings in Generation remain reachable.
-
-2. Finding #13 (Low) — **Fixed**
-- `src/cli.tsx:16` — Updated setup hint to include both valid invocations: `npx procedure-cli` and `npx @b3awesome/procedure`, avoiding single-command drift.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: pass
-
----
-
-## Entry 2026-02-22
-
-### Entry ID
-- `CF-20260222-008`
-
-### Source Review
-- `CR-20260222-006` (CODE-REVIEW.md entry 2026-02-22)
-
-### Fixes Applied
-
-1. Finding #16 (Low) — **Fixed**
-- `src/steps/project-info.tsx:51` — Added `isSelectStep` constant (`currentStep === "packageManager" || currentStep === "license"`).
-- `src/steps/project-info.tsx:57` — Added `&& !isSelectStep` guard to `key.tab` branch so Tab never fires the text-field advance path on select steps.
-- `src/steps/project-info.tsx:156` — Removed "Tab next" from the `packageManager` hint; now reads `"Shift+Tab prev  ↑↓ move  Enter select"`.
-
-2. Finding #17 (Low) — **Fixed**
-- `src/steps/product-context.tsx:86` — Added `isMultiSelectPhase` constant (`currentPhase === "techStack" || currentPhase === "coreFeatures"`).
-- `src/steps/product-context.tsx:90` — Added `&& !isMultiSelectPhase` guard to `key.tab` branch so Tab never discards GutteredMultiSelect's internal selection state.
-- `src/steps/product-context.tsx:221` — Removed "Tab next" from the `techStack` hint; now reads `"Shift+Tab prev  ↑↓ move  Space toggle  Enter confirm"`.
-- `src/steps/product-context.tsx:238` — Removed "Tab next" from the `coreFeatures` hint; now reads `"Shift+Tab prev  ↑↓ move  Space toggle  Enter confirm"`.
-
-### Deferred
-None.
-
-### Verification Notes
-- `npm run typecheck`: pass
-- `npm run build`: not run (typecheck sufficient per project standard for low-severity fixes)