probing 2.0.6 → 3.0.1

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Versions
 
+## Version 3.0.1
+
+- Node.js 14 or higher is now required
+
 ## Version 2.0.6
 
 Node.js 12.20.0 or higher is now required

package/liquidity/find_max_payable.js

@@ -172,6 +172,47 @@ module.exports = (args, cbk) => {
           return cbk(null, {route, maximum: res.maximum});
         });
       }],
+
+      // Get channels again to confirm policies are consistent
+      refetchChannels: ['findMax', ({}, cbk) => {
+        const {channels} = channelsFromHints({request, routes});
+
+        return getPoliciesForChannels({channels, hops, lnd}, cbk);
+      }],
+
+      // Check that policies remained consistent
+      checkPolicies: [
+        'getChannels',
+        'refetchChannels',
+        ({getChannels, refetchChannels}, cbk) =>
+      {
+        const {channels} = getChannels;
+
+        // Find a channel where the fee increased from the start
+        const feeIncrease = refetchChannels.channels.find(channel => {
+          const [currentA, currentB] = channel.policies;
+          const {policies} = channels.find(n => n.id === channel.id);
+
+          const [initialA, initialB] = policies;
+
+          if (currentA.fee_rate > initialA.fee_rate) {
+            return true;
+          }
+
+          if (currentB.fee_rate > initialB.fee_rate) {
+            return true;
+          }
+
+          return false;
+        });
+
+        // Exit with error when there was a fee increase on a channel
+        if (!!feeIncrease) {
+          return cbk([503, 'FeeIncreasedOnChannel', {id: feeIncrease.id}]);
+        }
+
+        return cbk();
+      }],
     },
     returnResult({reject, resolve, of: 'findMax'}, cbk));
   });

package/package.json

@@ -7,17 +7,17 @@
     "url": "https://github.com/alexbosworth/probing/issues"
   },
   "dependencies": {
-    "async": "3.2.3",
-    "asyncjs-util": "1.2.9",
-    "bolt07": "1.8.2",
-    "ln-service": "53.17.1"
+    "async": "3.2.4",
+    "asyncjs-util": "1.2.11",
+    "bolt07": "1.8.3",
+    "ln-service": "54.9.0"
   },
   "description": "Lightning Network probing utilities",
   "devDependencies": {
-    "@alexbosworth/tap": "15.0.11"
+    "@alexbosworth/tap": "15.0.12"
   },
   "engines": {
-    "node": ">=12.20"
+    "node": ">=14"
   },
   "keywords": [
     "lightning",
@@ -34,5 +34,5 @@
   "scripts": {
     "test": "tap --branches=1 --functions=1 --lines=1 --statements=1 test/graph/*.js test/liquidity/*.js test/payments/*.js test/routing/*.js"
   },
-  "version": "2.0.6"
+  "version": "3.0.1"
 }

package/test/liquidity/test_get_synthetic_out_ignores.js

@@ -13,6 +13,7 @@ const makeArgs = overrides => {
         listChannels: ({}, cbk) => cbk(null, {
           channels: [{
             active: true,
+            alias_scids: [],
             capacity: 1,
             chan_id: '1',
             channel_point: '00:1',

package/test/liquidity/test_subscribe_to_find_path.js

@@ -44,6 +44,7 @@ const makeLnd = overrides => {
       listChannels: ({}, cbk) => cbk(null, {
         channels: [{
           active: true,
+          alias_scids: [],
           capacity: 1,
           chan_id: '1',
           channel_point: '00:1',
@@ -197,6 +198,7 @@ const tests = [
           listChannels: ({}, cbk) => cbk(null, {
             channels: [{
               active: true,
+              alias_scids: [],
               capacity: 1,
               chan_id: '1',
               channel_point: '00:1',
@@ -311,6 +313,7 @@ const tests = [
           listChannels: ({}, cbk) => cbk(null, {
             channels: [{
               active: true,
+              alias_scids: [],
               capacity: 1,
               chan_id: '1',
               channel_point: '00:1',

package/test/liquidity/test_subscribe_to_multi_path_probe.js

@@ -158,6 +158,7 @@ const tests = [
           listChannels: ({}, cbk) => cbk(null, {
             channels: [{
               active: true,
+              alias_scids: [],
               capacity: 1,
               chan_id: '1',
               channel_point: '00:1',

package/test/payments/test_subscribe_to_multi_path_pay.js

@@ -20,6 +20,7 @@ const makeLnd = overrides => {
       listChannels: ({}, cbk) => cbk(null, {
         channels: [{
           active: true,
+          alias_scids: [],
           capacity: 1,
           chan_id: '1',
           channel_point: '00:1',