proagents 1.6.20 → 1.6.22
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude/settings.local.json +3 -1
- package/.proagents/.cursorrules +1 -1
- package/.proagents/.windsurfrules +1 -1
- package/.proagents/AGENTS.md +1 -1
- package/.proagents/AI_INSTRUCTIONS.md +29 -1
- package/.proagents/BOLT.md +1 -1
- package/.proagents/CLAUDE.md +1 -1
- package/.proagents/GEMINI.md +1 -1
- package/.proagents/KIRO.md +1 -1
- package/.proagents/LOVABLE.md +1 -1
- package/.proagents/REPLIT.md +1 -1
- package/.proagents/custom-commands.yaml +1 -2
- package/.proagents/docs/command-details.md +1 -2
- package/.proagents/getting-started/ai-training-setup.md +0 -1
- package/.proagents/performance/README.md +59 -0
- package/.proagents/performance/bundle-analysis.md +375 -0
- package/.proagents/performance/load-testing.md +563 -0
- package/.proagents/performance/runtime-metrics.md +489 -0
- package/.proagents/performance/web-vitals.md +425 -0
- package/.proagents/proagents.config.yaml +55 -1
- package/.proagents/prompts/11-session-tracking.md +100 -0
- package/.proagents/prompts/13-commit.md +426 -0
- package/.proagents/workflow-modes/entry-modes.md +1 -6
- package/COMMANDS.md +19 -0
- package/lib/commands/init.js +62 -11
- package/package.json +1 -1
- package/.proagents/api-versioning/README.md +0 -257
- package/.proagents/api-versioning/changelog-template.md +0 -225
- package/.proagents/api-versioning/deprecation-workflow.md +0 -470
- package/.proagents/api-versioning/versioning-strategy.md +0 -291
- package/.proagents/automation/README.md +0 -38
- package/.proagents/automation/ai-behavior-rules.md +0 -339
- package/.proagents/automation/ai-prompt-injection.md +0 -331
- package/.proagents/automation/auto-decisions.md +0 -535
- package/.proagents/automation/decision-defaults.yaml +0 -317
- package/.proagents/cache/README.md +0 -110
- package/.proagents/cache/analysis-metadata.json +0 -76
- package/.proagents/cache/conventions.json +0 -125
- package/.proagents/cache/dependencies.json +0 -85
- package/.proagents/cache/features.json +0 -115
- package/.proagents/cache/patterns.json +0 -105
- package/.proagents/cache/schemas/conventions-schema.json +0 -138
- package/.proagents/cache/schemas/dependencies-schema.json +0 -95
- package/.proagents/cache/schemas/features-schema.json +0 -104
- package/.proagents/cache/schemas/metadata-schema.json +0 -83
- package/.proagents/cache/schemas/patterns-schema.json +0 -136
- package/.proagents/cache/schemas/structure-schema.json +0 -72
- package/.proagents/cache/structure.json +0 -109
- package/.proagents/checklists/README.md +0 -261
- package/.proagents/checklists/code-quality.md +0 -137
- package/.proagents/checklists/code-review.md +0 -148
- package/.proagents/checklists/pr-checklist.md +0 -78
- package/.proagents/checklists/pre-deployment.md +0 -132
- package/.proagents/checklists/pre-implementation.md +0 -80
- package/.proagents/checklists/testing.md +0 -120
- package/.proagents/checkpoints.json +0 -13
- package/.proagents/cicd/README.md +0 -338
- package/.proagents/cicd/azure-devops.md +0 -267
- package/.proagents/cicd/github-actions.md +0 -375
- package/.proagents/cicd/gitlab-ci.md +0 -278
- package/.proagents/cicd/jenkins.md +0 -317
- package/.proagents/collaboration/README.md +0 -143
- package/.proagents/collaboration/roles.md +0 -248
- package/.proagents/collaboration/sessions.md +0 -390
- package/.proagents/collaboration/sync.md +0 -358
- package/.proagents/cost/README.md +0 -48
- package/.proagents/cost/cost-template.md +0 -283
- package/.proagents/cost/estimation-framework.md +0 -287
- package/.proagents/database/README.md +0 -72
- package/.proagents/database/examples/001-create-users.sql +0 -129
- package/.proagents/database/examples/002-add-preferences.sql +0 -94
- package/.proagents/database/examples/003-add-index.sql +0 -105
- package/.proagents/database/examples/004-rename-column.sql +0 -122
- package/.proagents/database/examples/005-add-foreign-key.sql +0 -142
- package/.proagents/database/examples/006-data-migration.sql +0 -196
- package/.proagents/database/examples/007-drop-column.sql +0 -163
- package/.proagents/database/examples/README.md +0 -89
- package/.proagents/database/migration-workflow.md +0 -478
- package/.proagents/database/rollback-scripts.md +0 -487
- package/.proagents/database/safety-checks.md +0 -447
- package/.proagents/git/README.md +0 -68
- package/.proagents/git/branch-strategy.md +0 -164
- package/.proagents/git/commit-conventions.md +0 -241
- package/.proagents/git/pr-workflow.md +0 -286
- package/.proagents/git/rollback-procedures.md +0 -416
- package/.proagents/ide-integration/README.md +0 -124
- package/.proagents/ide-integration/cline-config.md +0 -429
- package/.proagents/ide-integration/continue-config.md +0 -380
- package/.proagents/ide-integration/cursor-rules.md +0 -280
- package/.proagents/ide-integration/github-copilot.md +0 -384
- package/.proagents/ide-integration/windsurf-rules.md +0 -314
- package/.proagents/integrations/README.md +0 -97
- package/.proagents/integrations/pm/README.md +0 -344
- package/.proagents/learning/README.md +0 -136
- package/.proagents/learning/adaptation.md +0 -305
- package/.proagents/learning/data-collection.md +0 -283
- package/.proagents/learning/implementation-guide.md +0 -865
- package/.proagents/learning/reports.md +0 -306
- package/.proagents/mcp/README.md +0 -133
- package/.proagents/mcp/context-providers.md +0 -442
- package/.proagents/mcp/server-config.md +0 -306
- package/.proagents/mcp/tools-definition.md +0 -513
- package/.proagents/pm-integration/README.md +0 -151
- package/.proagents/pm-integration/asana.md +0 -346
- package/.proagents/pm-integration/github-issues.md +0 -308
- package/.proagents/pm-integration/gitlab-issues.md +0 -482
- package/.proagents/pm-integration/jira.md +0 -364
- package/.proagents/pm-integration/linear.md +0 -409
- package/.proagents/pm-integration/notion.md +0 -275
- package/.proagents/pm-integration/sync-config.md +0 -533
- package/.proagents/pm-integration/trello.md +0 -159
- package/.proagents/rules/README.md +0 -179
- package/.proagents/rules/custom-rules-template.yaml +0 -286
- package/.proagents/rules/custom-rules.md +0 -754
- package/.proagents/rules/validation-rules-template.yaml +0 -517
- package/.proagents/runbooks/README.md +0 -219
- package/.proagents/runbooks/dependency-vulnerability.md +0 -505
- package/.proagents/runbooks/incident-response.md +0 -451
- package/.proagents/runbooks/performance-degradation.md +0 -584
- package/.proagents/runbooks/production-debugging.md +0 -489
- package/.proagents/sessions/README.md +0 -5
- package/.proagents/sprints/README.md +0 -58
- package/.proagents/team/README.md +0 -256
- package/.proagents/team/code-ownership.md +0 -306
- package/.proagents/team/communication-templates.md +0 -441
- package/.proagents/team/handoff-protocol.md +0 -380
- package/.proagents/team/ide-setup/README.md +0 -103
- package/.proagents/team/ide-setup/cursor.md +0 -276
- package/.proagents/team/ide-setup/jetbrains.md +0 -330
- package/.proagents/team/ide-setup/neovim.md +0 -640
- package/.proagents/team/ide-setup/vscode.md +0 -348
- package/.proagents/team/onboarding.md +0 -278
- package/.proagents/time-tracking.json +0 -19
- package/.proagents/troubleshooting/README.md +0 -730
- package/.proagents/troubleshooting/ai-issues.md +0 -601
- package/.proagents/troubleshooting/workflow-issues.md +0 -571
|
@@ -1,241 +0,0 @@
|
|
|
1
|
-
# Git Commit Conventions
|
|
2
|
-
|
|
3
|
-
Standard commit message format for ProAgents projects.
|
|
4
|
-
|
|
5
|
-
---
|
|
6
|
-
|
|
7
|
-
## Conventional Commits
|
|
8
|
-
|
|
9
|
-
Format:
|
|
10
|
-
```
|
|
11
|
-
<type>(<scope>): <description>
|
|
12
|
-
|
|
13
|
-
[optional body]
|
|
14
|
-
|
|
15
|
-
[optional footer(s)]
|
|
16
|
-
```
|
|
17
|
-
|
|
18
|
-
---
|
|
19
|
-
|
|
20
|
-
## Commit Types
|
|
21
|
-
|
|
22
|
-
| Type | Description | Example |
|
|
23
|
-
|------|-------------|---------|
|
|
24
|
-
| `feat` | New feature | `feat(auth): add login form` |
|
|
25
|
-
| `fix` | Bug fix | `fix(api): handle null response` |
|
|
26
|
-
| `docs` | Documentation | `docs(readme): update install steps` |
|
|
27
|
-
| `style` | Formatting (no code change) | `style: format with prettier` |
|
|
28
|
-
| `refactor` | Code change (no new feature/fix) | `refactor(user): simplify validation` |
|
|
29
|
-
| `perf` | Performance improvement | `perf(list): virtualize long lists` |
|
|
30
|
-
| `test` | Adding tests | `test(auth): add login tests` |
|
|
31
|
-
| `build` | Build system changes | `build: update webpack config` |
|
|
32
|
-
| `ci` | CI configuration | `ci: add github actions` |
|
|
33
|
-
| `chore` | Maintenance tasks | `chore: update dependencies` |
|
|
34
|
-
| `revert` | Revert previous commit | `revert: revert "feat(auth)..."` |
|
|
35
|
-
|
|
36
|
-
---
|
|
37
|
-
|
|
38
|
-
## Scope
|
|
39
|
-
|
|
40
|
-
Scope indicates the affected area:
|
|
41
|
-
- Feature name: `auth`, `users`, `payments`
|
|
42
|
-
- Component: `button`, `modal`, `form`
|
|
43
|
-
- Module: `api`, `store`, `utils`
|
|
44
|
-
|
|
45
|
-
```
|
|
46
|
-
feat(auth): add password reset
|
|
47
|
-
fix(button): fix hover state
|
|
48
|
-
refactor(api): extract common headers
|
|
49
|
-
```
|
|
50
|
-
|
|
51
|
-
---
|
|
52
|
-
|
|
53
|
-
## Description
|
|
54
|
-
|
|
55
|
-
- Use imperative mood: "add" not "added"
|
|
56
|
-
- Don't capitalize first letter
|
|
57
|
-
- No period at the end
|
|
58
|
-
- Keep under 50 characters
|
|
59
|
-
|
|
60
|
-
```
|
|
61
|
-
✅ Good:
|
|
62
|
-
feat(auth): add login form validation
|
|
63
|
-
fix(api): handle timeout errors
|
|
64
|
-
docs: update contributing guide
|
|
65
|
-
|
|
66
|
-
❌ Bad:
|
|
67
|
-
feat(auth): Added login form validation. (past tense, period)
|
|
68
|
-
fix: Fix bug (not descriptive)
|
|
69
|
-
FEAT: Add feature (caps)
|
|
70
|
-
```
|
|
71
|
-
|
|
72
|
-
---
|
|
73
|
-
|
|
74
|
-
## Body
|
|
75
|
-
|
|
76
|
-
Use for additional context:
|
|
77
|
-
- What changes were made
|
|
78
|
-
- Why the change was necessary
|
|
79
|
-
- Any implications
|
|
80
|
-
|
|
81
|
-
```
|
|
82
|
-
feat(cart): add quantity limit
|
|
83
|
-
|
|
84
|
-
Add maximum quantity limit of 99 items per product
|
|
85
|
-
to prevent inventory issues and improve UX.
|
|
86
|
-
|
|
87
|
-
Previously users could add unlimited quantities
|
|
88
|
-
which caused checkout failures.
|
|
89
|
-
```
|
|
90
|
-
|
|
91
|
-
---
|
|
92
|
-
|
|
93
|
-
## Footer
|
|
94
|
-
|
|
95
|
-
### Breaking Changes
|
|
96
|
-
|
|
97
|
-
```
|
|
98
|
-
feat(api): change response format
|
|
99
|
-
|
|
100
|
-
BREAKING CHANGE: API now returns data wrapped in `data` field.
|
|
101
|
-
Previously: { id, name }
|
|
102
|
-
Now: { data: { id, name } }
|
|
103
|
-
```
|
|
104
|
-
|
|
105
|
-
### Issue References
|
|
106
|
-
|
|
107
|
-
```
|
|
108
|
-
fix(login): prevent double submission
|
|
109
|
-
|
|
110
|
-
Fixes #123
|
|
111
|
-
Closes #456
|
|
112
|
-
Related to #789
|
|
113
|
-
```
|
|
114
|
-
|
|
115
|
-
### Co-authors
|
|
116
|
-
|
|
117
|
-
```
|
|
118
|
-
feat(dashboard): add analytics widget
|
|
119
|
-
|
|
120
|
-
Co-authored-by: Name <email@example.com>
|
|
121
|
-
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
|
|
122
|
-
```
|
|
123
|
-
|
|
124
|
-
---
|
|
125
|
-
|
|
126
|
-
## Examples
|
|
127
|
-
|
|
128
|
-
### Simple Commit
|
|
129
|
-
```
|
|
130
|
-
feat(auth): add password strength indicator
|
|
131
|
-
```
|
|
132
|
-
|
|
133
|
-
### Commit with Body
|
|
134
|
-
```
|
|
135
|
-
fix(api): handle network timeout gracefully
|
|
136
|
-
|
|
137
|
-
Previously, network timeouts would cause the app to crash.
|
|
138
|
-
Now we catch timeout errors and show a user-friendly message
|
|
139
|
-
with a retry option.
|
|
140
|
-
```
|
|
141
|
-
|
|
142
|
-
### Breaking Change
|
|
143
|
-
```
|
|
144
|
-
refactor(api)!: update authentication endpoint
|
|
145
|
-
|
|
146
|
-
BREAKING CHANGE: Auth endpoint moved from /auth to /api/v2/auth.
|
|
147
|
-
Update all client configurations to use new endpoint.
|
|
148
|
-
|
|
149
|
-
Migration guide: docs/migration/auth-v2.md
|
|
150
|
-
```
|
|
151
|
-
|
|
152
|
-
### Full Commit
|
|
153
|
-
```
|
|
154
|
-
feat(payments): add stripe integration
|
|
155
|
-
|
|
156
|
-
Implement Stripe payment processing for checkout flow:
|
|
157
|
-
- Add Stripe SDK integration
|
|
158
|
-
- Create payment intent on server
|
|
159
|
-
- Handle payment confirmation
|
|
160
|
-
- Add webhook for payment events
|
|
161
|
-
|
|
162
|
-
Requires STRIPE_SECRET_KEY environment variable.
|
|
163
|
-
|
|
164
|
-
Closes #234
|
|
165
|
-
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
|
|
166
|
-
```
|
|
167
|
-
|
|
168
|
-
---
|
|
169
|
-
|
|
170
|
-
## Commit Size
|
|
171
|
-
|
|
172
|
-
### Good Commits
|
|
173
|
-
- Single logical change
|
|
174
|
-
- Can be reverted independently
|
|
175
|
-
- Tests pass at each commit
|
|
176
|
-
- Clear purpose
|
|
177
|
-
|
|
178
|
-
### Avoid
|
|
179
|
-
- Multiple unrelated changes
|
|
180
|
-
- "WIP" commits in main branch
|
|
181
|
-
- Broken intermediate states
|
|
182
|
-
- Huge commits (> 500 lines)
|
|
183
|
-
|
|
184
|
-
---
|
|
185
|
-
|
|
186
|
-
## Commit Message Template
|
|
187
|
-
|
|
188
|
-
Create `.gitmessage`:
|
|
189
|
-
```
|
|
190
|
-
# <type>(<scope>): <description>
|
|
191
|
-
#
|
|
192
|
-
# Types: feat, fix, docs, style, refactor, perf, test, build, ci, chore
|
|
193
|
-
#
|
|
194
|
-
# Body: Explain what and why (not how)
|
|
195
|
-
#
|
|
196
|
-
# Footer: Breaking changes, issue references, co-authors
|
|
197
|
-
```
|
|
198
|
-
|
|
199
|
-
Configure git:
|
|
200
|
-
```bash
|
|
201
|
-
git config --global commit.template ~/.gitmessage
|
|
202
|
-
```
|
|
203
|
-
|
|
204
|
-
---
|
|
205
|
-
|
|
206
|
-
## Automation
|
|
207
|
-
|
|
208
|
-
### commitlint
|
|
209
|
-
|
|
210
|
-
```javascript
|
|
211
|
-
// commitlint.config.js
|
|
212
|
-
module.exports = {
|
|
213
|
-
extends: ['@commitlint/config-conventional'],
|
|
214
|
-
rules: {
|
|
215
|
-
'type-enum': [2, 'always', [
|
|
216
|
-
'feat', 'fix', 'docs', 'style', 'refactor',
|
|
217
|
-
'perf', 'test', 'build', 'ci', 'chore', 'revert'
|
|
218
|
-
]],
|
|
219
|
-
'scope-case': [2, 'always', 'kebab-case'],
|
|
220
|
-
'subject-case': [2, 'always', 'lower-case'],
|
|
221
|
-
'subject-max-length': [2, 'always', 72],
|
|
222
|
-
},
|
|
223
|
-
};
|
|
224
|
-
```
|
|
225
|
-
|
|
226
|
-
### Husky Pre-commit
|
|
227
|
-
|
|
228
|
-
```bash
|
|
229
|
-
npx husky add .husky/commit-msg 'npx commitlint --edit $1'
|
|
230
|
-
```
|
|
231
|
-
|
|
232
|
-
---
|
|
233
|
-
|
|
234
|
-
## Commands
|
|
235
|
-
|
|
236
|
-
| Command | Description |
|
|
237
|
-
|---------|-------------|
|
|
238
|
-
| `pa:commit-feat` | Create feature commit |
|
|
239
|
-
| `pa:commit-fix` | Create fix commit |
|
|
240
|
-
| `pa:commit-docs` | Create docs commit |
|
|
241
|
-
| `pa:commit-refactor` | Create refactor commit |
|
|
@@ -1,286 +0,0 @@
|
|
|
1
|
-
# Pull Request Workflow
|
|
2
|
-
|
|
3
|
-
Standard workflow for creating and reviewing pull requests.
|
|
4
|
-
|
|
5
|
-
---
|
|
6
|
-
|
|
7
|
-
## Creating a Pull Request
|
|
8
|
-
|
|
9
|
-
### Step 1: Prepare Branch
|
|
10
|
-
|
|
11
|
-
```bash
|
|
12
|
-
# Ensure branch is up to date
|
|
13
|
-
git fetch origin
|
|
14
|
-
git rebase origin/develop
|
|
15
|
-
|
|
16
|
-
# Push branch
|
|
17
|
-
git push origin feature/my-feature -u
|
|
18
|
-
```
|
|
19
|
-
|
|
20
|
-
### Step 2: Create PR
|
|
21
|
-
|
|
22
|
-
Using GitHub CLI:
|
|
23
|
-
```bash
|
|
24
|
-
gh pr create --title "feat(scope): description" --body "$(cat <<'EOF'
|
|
25
|
-
## Summary
|
|
26
|
-
Brief description of changes.
|
|
27
|
-
|
|
28
|
-
## Changes
|
|
29
|
-
- Change 1
|
|
30
|
-
- Change 2
|
|
31
|
-
|
|
32
|
-
## Test Plan
|
|
33
|
-
- [ ] Unit tests added
|
|
34
|
-
- [ ] Manual testing completed
|
|
35
|
-
|
|
36
|
-
## Screenshots
|
|
37
|
-
(if applicable)
|
|
38
|
-
|
|
39
|
-
---
|
|
40
|
-
🤖 Generated with [Claude Code](https://claude.com/claude-code)
|
|
41
|
-
EOF
|
|
42
|
-
)"
|
|
43
|
-
```
|
|
44
|
-
|
|
45
|
-
---
|
|
46
|
-
|
|
47
|
-
## PR Title Format
|
|
48
|
-
|
|
49
|
-
Follow commit conventions:
|
|
50
|
-
```
|
|
51
|
-
<type>(<scope>): <description>
|
|
52
|
-
|
|
53
|
-
Examples:
|
|
54
|
-
feat(auth): add password reset flow
|
|
55
|
-
fix(api): handle null response in user service
|
|
56
|
-
docs(readme): update installation instructions
|
|
57
|
-
```
|
|
58
|
-
|
|
59
|
-
---
|
|
60
|
-
|
|
61
|
-
## PR Description Template
|
|
62
|
-
|
|
63
|
-
```markdown
|
|
64
|
-
## Summary
|
|
65
|
-
[Brief description of what this PR does]
|
|
66
|
-
|
|
67
|
-
## Related Issue
|
|
68
|
-
Fixes #[issue number]
|
|
69
|
-
|
|
70
|
-
## Changes
|
|
71
|
-
- [Change 1]
|
|
72
|
-
- [Change 2]
|
|
73
|
-
- [Change 3]
|
|
74
|
-
|
|
75
|
-
## Type of Change
|
|
76
|
-
- [ ] Bug fix (non-breaking change that fixes an issue)
|
|
77
|
-
- [ ] New feature (non-breaking change that adds functionality)
|
|
78
|
-
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
|
|
79
|
-
- [ ] Documentation update
|
|
80
|
-
|
|
81
|
-
## Test Plan
|
|
82
|
-
- [ ] Unit tests added/updated
|
|
83
|
-
- [ ] Integration tests added/updated
|
|
84
|
-
- [ ] Manual testing completed
|
|
85
|
-
|
|
86
|
-
## Screenshots
|
|
87
|
-
[If applicable, add screenshots]
|
|
88
|
-
|
|
89
|
-
## Checklist
|
|
90
|
-
- [ ] Code follows project conventions
|
|
91
|
-
- [ ] Self-review completed
|
|
92
|
-
- [ ] Documentation updated
|
|
93
|
-
- [ ] Tests pass locally
|
|
94
|
-
- [ ] No new warnings
|
|
95
|
-
|
|
96
|
-
## Notes for Reviewers
|
|
97
|
-
[Any additional context for reviewers]
|
|
98
|
-
```
|
|
99
|
-
|
|
100
|
-
---
|
|
101
|
-
|
|
102
|
-
## Review Process
|
|
103
|
-
|
|
104
|
-
### For Authors
|
|
105
|
-
|
|
106
|
-
1. **Self-Review First**
|
|
107
|
-
- Review your own diff
|
|
108
|
-
- Check for obvious issues
|
|
109
|
-
- Ensure tests pass
|
|
110
|
-
|
|
111
|
-
2. **Request Reviews**
|
|
112
|
-
- Add appropriate reviewers
|
|
113
|
-
- CODEOWNERS auto-assigns owners
|
|
114
|
-
|
|
115
|
-
3. **Respond to Feedback**
|
|
116
|
-
- Address all comments
|
|
117
|
-
- Explain decisions if disagreeing
|
|
118
|
-
- Mark resolved when addressed
|
|
119
|
-
|
|
120
|
-
4. **Keep Updated**
|
|
121
|
-
- Rebase if base branch updated
|
|
122
|
-
- Resolve merge conflicts promptly
|
|
123
|
-
|
|
124
|
-
### For Reviewers
|
|
125
|
-
|
|
126
|
-
1. **Timely Review**
|
|
127
|
-
- Review within SLA (see code-ownership.md)
|
|
128
|
-
- Don't let PRs go stale
|
|
129
|
-
|
|
130
|
-
2. **Review Checklist**
|
|
131
|
-
- Code correctness
|
|
132
|
-
- Code style
|
|
133
|
-
- Test coverage
|
|
134
|
-
- Documentation
|
|
135
|
-
- Security
|
|
136
|
-
- Performance
|
|
137
|
-
|
|
138
|
-
3. **Provide Constructive Feedback**
|
|
139
|
-
- Be specific
|
|
140
|
-
- Explain why
|
|
141
|
-
- Suggest alternatives
|
|
142
|
-
- Distinguish blocking vs non-blocking
|
|
143
|
-
|
|
144
|
-
4. **Approve or Request Changes**
|
|
145
|
-
- Approve if ready
|
|
146
|
-
- Request changes with clear items
|
|
147
|
-
- Comment if just suggestions
|
|
148
|
-
|
|
149
|
-
---
|
|
150
|
-
|
|
151
|
-
## Review Comment Conventions
|
|
152
|
-
|
|
153
|
-
### Blocking (Must Fix)
|
|
154
|
-
```
|
|
155
|
-
🔴 **Blocking:** This could cause [issue].
|
|
156
|
-
Suggested fix: [suggestion]
|
|
157
|
-
```
|
|
158
|
-
|
|
159
|
-
### Should Fix (Important)
|
|
160
|
-
```
|
|
161
|
-
🟡 **Important:** Consider [change].
|
|
162
|
-
Reason: [explanation]
|
|
163
|
-
```
|
|
164
|
-
|
|
165
|
-
### Suggestion (Optional)
|
|
166
|
-
```
|
|
167
|
-
💡 **Suggestion:** You might want to [improvement].
|
|
168
|
-
```
|
|
169
|
-
|
|
170
|
-
### Question
|
|
171
|
-
```
|
|
172
|
-
❓ **Question:** Why did you choose [approach]?
|
|
173
|
-
```
|
|
174
|
-
|
|
175
|
-
### Praise
|
|
176
|
-
```
|
|
177
|
-
✅ **Nice!** This is a clean solution.
|
|
178
|
-
```
|
|
179
|
-
|
|
180
|
-
---
|
|
181
|
-
|
|
182
|
-
## Merge Requirements
|
|
183
|
-
|
|
184
|
-
### Required Checks
|
|
185
|
-
- [ ] CI passes (tests, lint, build)
|
|
186
|
-
- [ ] Required reviewers approved
|
|
187
|
-
- [ ] No merge conflicts
|
|
188
|
-
- [ ] Branch up to date
|
|
189
|
-
|
|
190
|
-
### Merge Strategies
|
|
191
|
-
|
|
192
|
-
**Squash and Merge (Recommended)**
|
|
193
|
-
- For feature branches
|
|
194
|
-
- Creates clean history
|
|
195
|
-
- Single commit per feature
|
|
196
|
-
|
|
197
|
-
**Rebase and Merge**
|
|
198
|
-
- For clean commit history
|
|
199
|
-
- Preserves individual commits
|
|
200
|
-
- Use when commits are atomic
|
|
201
|
-
|
|
202
|
-
**Merge Commit**
|
|
203
|
-
- For long-running branches
|
|
204
|
-
- Preserves full history
|
|
205
|
-
- Shows merge point
|
|
206
|
-
|
|
207
|
-
---
|
|
208
|
-
|
|
209
|
-
## After Merge
|
|
210
|
-
|
|
211
|
-
1. **Delete Branch**
|
|
212
|
-
```bash
|
|
213
|
-
git branch -d feature/my-feature
|
|
214
|
-
git push origin --delete feature/my-feature
|
|
215
|
-
```
|
|
216
|
-
|
|
217
|
-
2. **Update Local**
|
|
218
|
-
```bash
|
|
219
|
-
git checkout develop
|
|
220
|
-
git pull origin develop
|
|
221
|
-
```
|
|
222
|
-
|
|
223
|
-
3. **Verify Deployment**
|
|
224
|
-
- Check CI/CD pipeline
|
|
225
|
-
- Verify staging deployment
|
|
226
|
-
- Monitor for issues
|
|
227
|
-
|
|
228
|
-
---
|
|
229
|
-
|
|
230
|
-
## Handling Feedback
|
|
231
|
-
|
|
232
|
-
### If Changes Requested
|
|
233
|
-
|
|
234
|
-
```bash
|
|
235
|
-
# Make changes
|
|
236
|
-
git add .
|
|
237
|
-
git commit -m "address review feedback"
|
|
238
|
-
git push origin feature/my-feature
|
|
239
|
-
|
|
240
|
-
# Or amend if single change
|
|
241
|
-
git add .
|
|
242
|
-
git commit --amend
|
|
243
|
-
git push --force-with-lease
|
|
244
|
-
```
|
|
245
|
-
|
|
246
|
-
### If Conflicts Arise
|
|
247
|
-
|
|
248
|
-
```bash
|
|
249
|
-
# Update from base
|
|
250
|
-
git fetch origin
|
|
251
|
-
git rebase origin/develop
|
|
252
|
-
|
|
253
|
-
# Resolve conflicts
|
|
254
|
-
# ... resolve in editor ...
|
|
255
|
-
|
|
256
|
-
git add .
|
|
257
|
-
git rebase --continue
|
|
258
|
-
git push --force-with-lease
|
|
259
|
-
```
|
|
260
|
-
|
|
261
|
-
---
|
|
262
|
-
|
|
263
|
-
## PR Size Guidelines
|
|
264
|
-
|
|
265
|
-
| Size | Lines Changed | Review Time |
|
|
266
|
-
|------|---------------|-------------|
|
|
267
|
-
| Small | < 100 | < 30 min |
|
|
268
|
-
| Medium | 100-500 | 1-2 hours |
|
|
269
|
-
| Large | > 500 | Consider splitting |
|
|
270
|
-
|
|
271
|
-
### Tips for Smaller PRs
|
|
272
|
-
- Break features into increments
|
|
273
|
-
- Separate refactoring from features
|
|
274
|
-
- Use feature flags for partial work
|
|
275
|
-
- Create dependent PRs
|
|
276
|
-
|
|
277
|
-
---
|
|
278
|
-
|
|
279
|
-
## Commands
|
|
280
|
-
|
|
281
|
-
| Command | Description |
|
|
282
|
-
|---------|-------------|
|
|
283
|
-
| `pa:pr-create` | Create pull request |
|
|
284
|
-
| `pa:pr-update` | Update PR description |
|
|
285
|
-
| `pa:pr-merge` | Merge pull request |
|
|
286
|
-
| `pa:pr-review` | Request review |
|