pro-editor-schema 1.2.1 → 1.2.3

package/dist/index.js

@@ -2902,13 +2902,20 @@ var validateRequiredChildren = (element, schema, childElements) => {
       return childSchema?.code === allowedChild.code;
     });
     if (!hasChild) {
-      const requiredChildrenTag = findSchemaByCode(allowedChild.code).tag;
+      const requiredChild = findSchemaByCode(allowedChild.code);
+      const elementLabel = ElementLabel[requiredChild.code];
+      const parentLabel = ElementLabel[schema.code];
+      const extraInstruction = getExtraInstruction(schema, requiredChild);
+      const description = [
+        `Please provide at least one ${elementLabel} in this ${parentLabel}.`,
+        extraInstruction
+      ].filter(Boolean).join(" ");
       addValidationIssue(errors, {
         store: getStore(element),
-        title: `Missing required child element ${requiredChildrenTag}`,
+        title: `${elementLabel} missing`,
         level: "warning",
         kind: "missing",
-        description: `The child element ${requiredChildrenTag} is required but not present.`
+        description
       });
     }
   }
@@ -2965,6 +2972,12 @@ var validateChildren = (element, schema) => {
   errors.push(...validateRequiredChildren(element, schema, childElements));
   return errors;
 };
+var getExtraInstruction = (schema, childSchema) => {
+  if (schema.code === "dialogue" && childSchema.code === "speaker") {
+    return "Select the speaker and tag using right click.";
+  }
+  return "";
+};
 
 // src/validation/validateReferences.ts
 var findElementLinkedTo2 = (xmlid, linkElements) => {
@@ -3115,8 +3128,10 @@ var validateOlink = (element) => {
   if (isDeletedElement(element)) {
     return errors;
   }
-  const text = retrieveTextIgnoringNodesWithSelector(element).trim();
-  if (ORCID_PATTERN.test(text)) {
+  const text = retrieveTextIgnoringNodesWithSelector(element);
+  const isEmpty = text.length === 0;
+  const isValidOrcid = ORCID_PATTERN.test(text);
+  if (isEmpty || isValidOrcid) {
     return errors;
   }
   addValidationIssue(errors, {

package/dist/index.mjs

@@ -2822,13 +2822,20 @@ var validateRequiredChildren = (element, schema, childElements) => {
       return childSchema?.code === allowedChild.code;
     });
     if (!hasChild) {
-      const requiredChildrenTag = findSchemaByCode(allowedChild.code).tag;
+      const requiredChild = findSchemaByCode(allowedChild.code);
+      const elementLabel = ElementLabel[requiredChild.code];
+      const parentLabel = ElementLabel[schema.code];
+      const extraInstruction = getExtraInstruction(schema, requiredChild);
+      const description = [
+        `Please provide at least one ${elementLabel} in this ${parentLabel}.`,
+        extraInstruction
+      ].filter(Boolean).join(" ");
       addValidationIssue(errors, {
         store: getStore(element),
-        title: `Missing required child element ${requiredChildrenTag}`,
+        title: `${elementLabel} missing`,
         level: "warning",
         kind: "missing",
-        description: `The child element ${requiredChildrenTag} is required but not present.`
+        description
       });
     }
   }
@@ -2885,6 +2892,12 @@ var validateChildren = (element, schema) => {
   errors.push(...validateRequiredChildren(element, schema, childElements));
   return errors;
 };
+var getExtraInstruction = (schema, childSchema) => {
+  if (schema.code === "dialogue" && childSchema.code === "speaker") {
+    return "Select the speaker and tag using right click.";
+  }
+  return "";
+};
 
 // src/validation/validateReferences.ts
 var findElementLinkedTo2 = (xmlid, linkElements) => {
@@ -3035,8 +3048,10 @@ var validateOlink = (element) => {
   if (isDeletedElement(element)) {
     return errors;
   }
-  const text = retrieveTextIgnoringNodesWithSelector(element).trim();
-  if (ORCID_PATTERN.test(text)) {
+  const text = retrieveTextIgnoringNodesWithSelector(element);
+  const isEmpty = text.length === 0;
+  const isValidOrcid = ORCID_PATTERN.test(text);
+  if (isEmpty || isValidOrcid) {
     return errors;
   }
   addValidationIssue(errors, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pro-editor-schema",
-  "version": "1.2.1",
+  "version": "1.2.3",
   "description": "Pro Editor XML schemas",
   "main": "dist/index.js",
   "module": "dist/index.mjs",