prjct-cli 0.59.0 → 0.60.1

package/core/__tests__/services/nested-context-resolver.test.ts

@@ -0,0 +1,443 @@
+/**
+ * Tests for NestedContextResolver - AGENTS.md discovery and resolution
+ * PRJ-101: Hierarchical scope system
+ */
+
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test'
+import fs from 'node:fs/promises'
+import os from 'node:os'
+import path from 'node:path'
+import NestedContextResolver from '../../services/nested-context-resolver'
+
+// Test directory setup
+let testDir: string
+let resolver: NestedContextResolver
+
+beforeEach(async () => {
+  // Create temp directory for tests
+  testDir = path.join(os.tmpdir(), `prjct-test-${Date.now()}`)
+  await fs.mkdir(testDir, { recursive: true })
+  resolver = new NestedContextResolver(testDir)
+})
+
+afterEach(async () => {
+  // Cleanup temp directory
+  try {
+    await fs.rm(testDir, { recursive: true, force: true })
+  } catch {
+    // Ignore cleanup errors
+  }
+})
+
+// =============================================================================
+// PRJCT.md Discovery Tests (existing functionality)
+// =============================================================================
+
+describe('NestedContextResolver - PRJCT.md', () => {
+  test('discovers root PRJCT.md', async () => {
+    await fs.writeFile(path.join(testDir, 'PRJCT.md'), '## Rules\n\n- Rule 1\n- Rule 2')
+
+    const contexts = await resolver.discoverContextFiles()
+
+    expect(contexts).toHaveLength(1)
+    expect(contexts[0].depth).toBe(0)
+    expect(contexts[0].sections).toHaveLength(1)
+    expect(contexts[0].sections[0].name).toBe('Rules')
+  })
+
+  test('parses sections with override marker', async () => {
+    await fs.writeFile(path.join(testDir, 'PRJCT.md'), '## Rules @override\n\n- Override rule')
+
+    const contexts = await resolver.discoverContextFiles()
+
+    expect(contexts[0].sections[0].override).toBe(true)
+    expect(contexts[0].sections[0].name).toBe('Rules')
+  })
+
+  test('handles empty project (no PRJCT.md)', async () => {
+    const contexts = await resolver.discoverContextFiles()
+    expect(contexts).toHaveLength(0)
+  })
+})
+
+// =============================================================================
+// AGENTS.md Discovery Tests (new functionality)
+// =============================================================================
+
+describe('NestedContextResolver - AGENTS.md Discovery', () => {
+  test('discovers root AGENTS.md', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Backend
+
+Handles backend development.
+
+### Triggers
+- api
+- endpoint
+
+### Rules
+- Use async/await
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles).toHaveLength(1)
+    expect(agentFiles[0].depth).toBe(0)
+    expect(agentFiles[0].agents).toHaveLength(1)
+    expect(agentFiles[0].agents[0].name).toBe('Backend')
+  })
+
+  test('parses multiple agents from single file', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Frontend
+
+Frontend specialist.
+
+### Triggers
+- component
+- ui
+
+## Backend
+
+Backend specialist.
+
+### Triggers
+- api
+- database
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles[0].agents).toHaveLength(2)
+    expect(agentFiles[0].agents[0].name).toBe('Frontend')
+    expect(agentFiles[0].agents[1].name).toBe('Backend')
+  })
+
+  test('parses agent triggers as array', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Testing
+
+Testing specialist.
+
+### Triggers
+- write test
+- add test
+- unit test
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+    const agent = agentFiles[0].agents[0]
+
+    expect(agent.triggers).toEqual(['write test', 'add test', 'unit test'])
+  })
+
+  test('parses agent rules as array', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Backend
+
+Backend specialist.
+
+### Rules
+- Use TypeScript
+- Validate inputs
+- Log errors
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+    const agent = agentFiles[0].agents[0]
+
+    expect(agent.rules).toEqual(['Use TypeScript', 'Validate inputs', 'Log errors'])
+  })
+
+  test('parses code patterns from code blocks', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Backend
+
+Backend specialist.
+
+### Patterns
+\`\`\`typescript
+async function handler(req: Request) {
+  return new Response('ok')
+}
+\`\`\`
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+    const agent = agentFiles[0].agents[0]
+
+    expect(agent.patterns).toHaveLength(1)
+    expect(agent.patterns![0]).toContain('async function handler')
+  })
+
+  test('detects @override marker on agent', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Frontend @override
+
+Overrides parent frontend agent.
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+    const agent = agentFiles[0].agents[0]
+
+    expect(agent.name).toBe('Frontend')
+    expect(agent.override).toBe(true)
+  })
+
+  test('handles empty AGENTS.md', async () => {
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '# AGENTS.md\n\nNo agents defined.')
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles).toHaveLength(1)
+    expect(agentFiles[0].agents).toHaveLength(0)
+  })
+
+  test('handles missing AGENTS.md', async () => {
+    const agentFiles = await resolver.discoverAgentFiles()
+    expect(agentFiles).toHaveLength(0)
+  })
+})
+
+// =============================================================================
+// AGENTS.md Hierarchy Tests
+// =============================================================================
+
+describe('NestedContextResolver - AGENTS.md Hierarchy', () => {
+  test('discovers nested AGENTS.md in subdirectories', async () => {
+    // Create root AGENTS.md
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## GlobalAgent
+
+Global agent for all.
+`
+    )
+
+    // Create subdirectory with AGENTS.md
+    const subDir = path.join(testDir, 'packages', 'web')
+    await fs.mkdir(subDir, { recursive: true })
+    await fs.writeFile(
+      path.join(subDir, 'AGENTS.md'),
+      `## WebAgent
+
+Web-specific agent.
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles).toHaveLength(2)
+    expect(agentFiles.find((af) => af.depth === 0)?.agents[0].name).toBe('GlobalAgent')
+  })
+
+  test('builds parent-child relationships', async () => {
+    // Create root AGENTS.md
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '## Root\n\nRoot agent.')
+
+    // Create child AGENTS.md
+    const childDir = path.join(testDir, 'src')
+    await fs.mkdir(childDir, { recursive: true })
+    await fs.writeFile(path.join(childDir, 'AGENTS.md'), '## Child\n\nChild agent.')
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    const root = agentFiles.find((af) => af.depth === 0)
+    const child = agentFiles.find((af) => af.depth > 0)
+
+    expect(root).toBeDefined()
+    expect(child).toBeDefined()
+    expect(child?.parent).toBe(root)
+    expect(root?.children).toContain(child)
+  })
+
+  test('resolves agents for path with inheritance', async () => {
+    // Root defines base agents
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Shared
+
+Shared rules for all.
+
+### Rules
+- Rule from root
+`
+    )
+
+    // Child adds more rules
+    const childDir = path.join(testDir, 'packages', 'api')
+    await fs.mkdir(childDir, { recursive: true })
+    await fs.writeFile(
+      path.join(childDir, 'AGENTS.md'),
+      `## Shared
+
+Extended in child.
+
+### Rules
+- Rule from child
+`
+    )
+
+    const resolved = await resolver.resolveAgentsForPath(childDir)
+
+    expect(resolved.agents).toHaveLength(1)
+    expect(resolved.agents[0].name).toBe('Shared')
+    // Rules should be merged
+    expect(resolved.agents[0].rules).toContain('Rule from root')
+    expect(resolved.agents[0].rules).toContain('Rule from child')
+  })
+
+  test('override replaces parent agent entirely', async () => {
+    // Root defines agent
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `## Frontend
+
+Root frontend agent.
+
+### Rules
+- Root rule 1
+- Root rule 2
+`
+    )
+
+    // Child overrides
+    const childDir = path.join(testDir, 'web')
+    await fs.mkdir(childDir, { recursive: true })
+    await fs.writeFile(
+      path.join(childDir, 'AGENTS.md'),
+      `## Frontend @override
+
+Completely new frontend agent.
+
+### Rules
+- Child rule only
+`
+    )
+
+    const resolved = await resolver.resolveAgentsForPath(childDir)
+
+    expect(resolved.agents).toHaveLength(1)
+    expect(resolved.agents[0].rules).toHaveLength(1)
+    expect(resolved.agents[0].rules).toContain('Child rule only')
+    expect(resolved.overrides).toContain(`web/AGENTS.md:Frontend`)
+  })
+
+  test('adds new agents from child without affecting parent agents', async () => {
+    // Root has one agent
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '## Backend\n\nBackend agent.')
+
+    // Child adds different agent
+    const childDir = path.join(testDir, 'mobile')
+    await fs.mkdir(childDir, { recursive: true })
+    await fs.writeFile(path.join(childDir, 'AGENTS.md'), '## Mobile\n\nMobile agent.')
+
+    const resolved = await resolver.resolveAgentsForPath(childDir)
+
+    expect(resolved.agents).toHaveLength(2)
+    expect(resolved.agents.map((a) => a.name).sort()).toEqual(['Backend', 'Mobile'])
+  })
+
+  test('tracks sources in resolution', async () => {
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '## Agent\n\nRoot.')
+
+    const level1 = path.join(testDir, 'level1')
+    await fs.mkdir(level1)
+    await fs.writeFile(path.join(level1, 'AGENTS.md'), '## Agent\n\nLevel 1.')
+
+    const level2 = path.join(level1, 'level2')
+    await fs.mkdir(level2)
+    await fs.writeFile(path.join(level2, 'AGENTS.md'), '## Agent\n\nLevel 2.')
+
+    const resolved = await resolver.resolveAgentsForPath(level2)
+
+    expect(resolved.sources).toHaveLength(3)
+    expect(resolved.sources[0]).toBe('AGENTS.md')
+    expect(resolved.sources[1]).toBe('level1/AGENTS.md')
+    expect(resolved.sources[2]).toBe('level1/level2/AGENTS.md')
+  })
+})
+
+// =============================================================================
+// Edge Cases
+// =============================================================================
+
+describe('NestedContextResolver - Edge Cases', () => {
+  test('ignores node_modules directories', async () => {
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '## Root\n\nRoot.')
+
+    // Create AGENTS.md in node_modules (should be ignored)
+    const nmDir = path.join(testDir, 'node_modules', 'some-package')
+    await fs.mkdir(nmDir, { recursive: true })
+    await fs.writeFile(path.join(nmDir, 'AGENTS.md'), '## ShouldIgnore\n\nIgnored.')
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles).toHaveLength(1)
+    expect(agentFiles[0].agents[0].name).toBe('Root')
+  })
+
+  test('ignores dot directories', async () => {
+    await fs.writeFile(path.join(testDir, 'AGENTS.md'), '## Root\n\nRoot.')
+
+    // Create AGENTS.md in .git (should be ignored)
+    const gitDir = path.join(testDir, '.git', 'hooks')
+    await fs.mkdir(gitDir, { recursive: true })
+    await fs.writeFile(path.join(gitDir, 'AGENTS.md'), '## ShouldIgnore\n\nIgnored.')
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    expect(agentFiles).toHaveLength(1)
+  })
+
+  test('handles malformed AGENTS.md gracefully', async () => {
+    await fs.writeFile(
+      path.join(testDir, 'AGENTS.md'),
+      `# Not a proper agent header
+
+Some text here
+
+### Rules without agent
+- orphan rule
+
+## Proper Agent
+
+This one is valid.
+`
+    )
+
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    // Should only find the valid agent
+    expect(agentFiles[0].agents).toHaveLength(1)
+    expect(agentFiles[0].agents[0].name).toBe('Proper Agent')
+  })
+
+  test('limits scanning depth to prevent infinite recursion', async () => {
+    // Create deeply nested directory structure
+    let currentDir = testDir
+    for (let i = 0; i < 10; i++) {
+      currentDir = path.join(currentDir, `level${i}`)
+      await fs.mkdir(currentDir, { recursive: true })
+      await fs.writeFile(path.join(currentDir, 'AGENTS.md'), `## Level${i}\n\nLevel ${i} agent.`)
+    }
+
+    // Should complete without hanging (depth limit is 5)
+    const agentFiles = await resolver.discoverAgentFiles()
+
+    // Should find root + up to 5 levels deep
+    expect(agentFiles.length).toBeLessThanOrEqual(6)
+  })
+})

package/core/commands/analysis.ts

@@ -455,89 +455,97 @@ export class AnalysisCommands extends PrjctCommandsBase {
 
   /**
    * Display sync results (extracted to avoid duplication)
+   *
+   * UX Design (PRJ-100):
+   * - Summary first: success + key metrics on first lines
+   * - Scannable: single-line metrics, minimal vertical space
+   * - Changes focused: show what changed, not everything that exists
+   * - Next steps prominent: clear call to action at bottom
    */
   private async showSyncResult(
     result: Awaited<ReturnType<typeof syncService.sync>>,
     startTime: number
   ): Promise<CommandResult> {
-    // Update global config
-    const globalConfigResult = await commandInstaller.installGlobalConfig()
-    if (globalConfigResult.success) {
-      console.log(`📝 Updated ${pathManager.getDisplayPath(globalConfigResult.path!)}`)
+    const elapsed = Date.now() - startTime
+    const contextFilesCount =
+      result.contextFiles.length + (result.aiTools?.filter((t) => t.success).length || 0)
+    const agentCount = result.agents.length
+    const domainAgentCount = result.agents.filter((a) => a.type === 'domain').length
+
+    // Update global config (silent - don't clutter output)
+    await commandInstaller.installGlobalConfig()
+
+    // ═══════════════════════════════════════════════════════════════════════
+    // SUCCESS LINE - Immediate confirmation with timing
+    // ═══════════════════════════════════════════════════════════════════════
+    console.log(`✅ Synced ${result.stats.name || 'project'} (${(elapsed / 1000).toFixed(1)}s)\n`)
+
+    // ═══════════════════════════════════════════════════════════════════════
+    // KEY METRICS - Single scannable line
+    // ═══════════════════════════════════════════════════════════════════════
+    // Only show compression rate if meaningful (> 10%)
+    const compressionPct = result.syncMetrics?.compressionRate
+      ? Math.round(result.syncMetrics.compressionRate * 100)
+      : 0
+    const metricsLine = [
+      `${result.stats.fileCount} files → ${contextFilesCount} context`,
+      `${agentCount} agents`,
+      compressionPct > 10 ? `${compressionPct}% reduction` : null,
+    ]
+      .filter(Boolean)
+      .join(' | ')
+    console.log(metricsLine)
+
+    // Stack and branch info
+    const framework = result.stats.frameworks.length > 0 ? ` (${result.stats.frameworks[0]})` : ''
+    console.log(`Stack: ${result.stats.ecosystem}${framework} | Branch: ${result.git.branch}\n`)
+
+    // ═══════════════════════════════════════════════════════════════════════
+    // CHANGES SECTION - What was generated/updated
+    // ═══════════════════════════════════════════════════════════════════════
+    console.log('Generated:')
+
+    // Context files (condensed)
+    if (result.contextFiles.length > 0) {
+      console.log(`  ✓ ${result.contextFiles.length} context files`)
     }
 
-    // Format output
-    console.log(`🔄 Project synced to prjct v${result.cliVersion}\n`)
-
-    console.log('📊 Project Stats')
-    console.log(`├── Files: ~${result.stats.fileCount}`)
-    console.log(`├── Commits: ${result.git.commits}`)
-    console.log(`├── Version: ${result.stats.version}`)
-    console.log(`└── Stack: ${result.stats.ecosystem}\n`)
-
-    console.log('🌿 Git Status')
-    console.log(`├── Branch: ${result.git.branch}`)
-    console.log(`├── Uncommitted: ${result.git.hasChanges ? 'Yes' : 'Clean'}`)
-    console.log(`└── Recent: ${result.git.weeklyCommits} commits this week\n`)
-
-    console.log('📁 Context Updated')
-    for (const file of result.contextFiles) {
-      console.log(`├── ${file}`)
+    // AI tools
+    const successTools = result.aiTools?.filter((t) => t.success) || []
+    if (successTools.length > 0) {
+      const toolNames = successTools.map((t) => t.toolId).join(', ')
+      console.log(`  ✓ AI tools: ${toolNames}`)
     }
-    console.log('')
 
-    // Show AI Tools generated (multi-agent output)
-    if (result.aiTools && result.aiTools.length > 0) {
-      const successTools = result.aiTools.filter((t) => t.success)
-      console.log(`🤖 AI Tools Context (${successTools.length})`)
-      for (const tool of result.aiTools) {
-        const status = tool.success ? '✓' : '✗'
-        console.log(`├── ${status} ${tool.outputFile} (${tool.toolId})`)
-      }
-      console.log('')
+    // Agents (show count with breakdown)
+    if (agentCount > 0) {
+      const agentSummary =
+        domainAgentCount > 0
+          ? `${agentCount} agents (${domainAgentCount} domain)`
+          : `${agentCount} agents`
+      console.log(`  ✓ ${agentSummary}`)
     }
 
-    const workflowAgents = result.agents.filter((a) => a.type === 'workflow').map((a) => a.name)
-    const domainAgents = result.agents.filter((a) => a.type === 'domain').map((a) => a.name)
-
-    console.log(`🤖 Agents Regenerated (${result.agents.length})`)
-    console.log(`├── Workflow: ${workflowAgents.join(', ')}`)
-    console.log(`└── Domain: ${domainAgents.join(', ') || 'none'}\n`)
-
+    // Skills
     if (result.skills.length > 0) {
-      console.log('📦 Skills Configured')
-      for (const skill of result.skills) {
-        console.log(`├── ${skill.agent}.md → ${skill.skill}`)
-      }
-      console.log('')
+      const skillWord = result.skills.length === 1 ? 'skill' : 'skills'
+      console.log(`  ✓ ${result.skills.length} ${skillWord}`)
     }
 
+    console.log('')
+
+    // ═══════════════════════════════════════════════════════════════════════
+    // STATUS INDICATOR - Repository state
+    // ═══════════════════════════════════════════════════════════════════════
     if (result.git.hasChanges) {
-      console.log('⚠️  You have uncommitted changes\n')
-    } else {
-      console.log('✨ Repository is clean!\n')
+      console.log('⚠️  Uncommitted changes detected\n')
     }
 
+    // ═══════════════════════════════════════════════════════════════════════
+    // NEXT STEPS - Clear call to action
+    // ═══════════════════════════════════════════════════════════════════════
     showNextSteps('sync')
 
-    // Summary metrics
-    const elapsed = Date.now() - startTime
-    const contextFilesCount =
-      result.contextFiles.length + (result.aiTools?.filter((t) => t.success).length || 0)
-    const agentCount = result.agents.length
-
-    console.log('─'.repeat(45))
-    console.log('📊 Sync Summary')
-    console.log(
-      `   Stack: ${result.stats.ecosystem} (${result.stats.frameworks.join(', ') || 'no frameworks'})`
-    )
-    console.log(`   Files: ${result.stats.fileCount} analyzed → ${contextFilesCount} context files`)
-    console.log(
-      `   Agents: ${agentCount} (${result.agents.filter((a) => a.type === 'domain').length} domain)`
-    )
-    console.log(`   Time: ${(elapsed / 1000).toFixed(1)}s`)
-    console.log('')
-
     return {
       success: true,
       data: result,