prjct-cli 0.10.0 → 0.10.3

package/core/agentic/validation-rules.js

@@ -0,0 +1,380 @@
+/**
+ * Validation Rules
+ * Explicit pre-flight checks for each command
+ * Returns SPECIFIC error messages, never generic failures
+ *
+ * OPTIMIZATION (P0.2): Anti-Hallucination Pattern
+ * - Ground truth verification before actions
+ * - Specific error messages for each failure mode
+ * - Actionable suggestions in every error
+ *
+ * Source: Claude Code, Devin, Augment Code patterns
+ */
+
+const contextBuilder = require('./context-builder')
+
+/**
+ * Validation result structure
+ * @typedef {Object} ValidationResult
+ * @property {boolean} valid - Whether validation passed
+ * @property {string|null} error - Specific error message if invalid
+ * @property {string|null} suggestion - Actionable next step
+ * @property {Object} state - Pre-loaded state for command execution
+ */
+
+/**
+ * Command-specific validation rules
+ * Each rule returns { valid, error, suggestion, state }
+ */
+const validationRules = {
+  /**
+   * /p:done - Complete current task
+   */
+  async done(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'done')
+
+    // Check 1: now.md exists and has content
+    if (!state.now || state.now.trim() === '') {
+      return {
+        valid: false,
+        error: 'No active task to complete',
+        suggestion: 'Start a task first with /p:now "task description"',
+        state
+      }
+    }
+
+    // Check 2: Task is not a placeholder/comment
+    const content = state.now.trim()
+    if (content.startsWith('#') && content.split('\n').length === 1) {
+      return {
+        valid: false,
+        error: 'now.md contains only a header, no task description',
+        suggestion: 'Add task details or start fresh with /p:now "task"',
+        state
+      }
+    }
+
+    // Check 3: Task is not blocked
+    if (content.toLowerCase().includes('blocked') ||
+        content.toLowerCase().includes('waiting for')) {
+      return {
+        valid: false,
+        error: 'Task appears to be blocked',
+        suggestion: 'Resolve the blocker first or use /p:pause to save progress',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:ship - Ship a feature
+   */
+  async ship(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'ship')
+
+    // Check 1: Has something to ship (now.md or recent shipped items)
+    const hasCurrentTask = state.now && state.now.trim() !== ''
+    const hasRecentShips = state.shipped && state.shipped.trim() !== ''
+
+    if (!hasCurrentTask && !hasRecentShips) {
+      return {
+        valid: false,
+        error: 'Nothing to ship yet',
+        suggestion: 'Build something first with /p:now "feature name"',
+        state
+      }
+    }
+
+    // Check 2: Feature name provided (from params)
+    if (!context.params.feature && !context.params.description) {
+      // Try to extract from now.md
+      if (hasCurrentTask) {
+        // Auto-extract feature name - this is OK
+        return { valid: true, error: null, suggestion: null, state }
+      }
+      return {
+        valid: false,
+        error: 'No feature name specified',
+        suggestion: 'Specify what to ship: /p:ship "feature name"',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:now - Set or show current task
+   */
+  async now(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'now')
+
+    // If no task param, this is a "show" request - always valid
+    if (!context.params.task && !context.params.description) {
+      return { valid: true, error: null, suggestion: null, state }
+    }
+
+    // Check: If setting new task, warn if one exists
+    if (state.now && state.now.trim() !== '') {
+      return {
+        valid: true, // Still valid, but with warning
+        error: null,
+        suggestion: `Note: Replacing current task. Use /p:done first to track completion.`,
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:next - Show priority queue
+   */
+  async next(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'next')
+
+    if (!state.next || state.next.trim() === '' ||
+        !state.next.includes('- [')) {
+      return {
+        valid: true, // Valid but empty
+        error: null,
+        suggestion: 'Queue is empty. Add tasks with /p:feature or /p:idea',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:idea - Capture an idea
+   */
+  async idea(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'idea')
+
+    // Check: Idea text provided
+    if (!context.params.text && !context.params.description) {
+      return {
+        valid: false,
+        error: 'No idea text provided',
+        suggestion: 'Provide your idea: /p:idea "your idea here"',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:feature - Add a new feature
+   */
+  async feature(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'feature')
+
+    // If no description, show interactive template - valid
+    if (!context.params.description && !context.params.feature) {
+      return { valid: true, error: null, suggestion: null, state }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:pause - Pause current task
+   */
+  async pause(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'now')
+
+    if (!state.now || state.now.trim() === '') {
+      return {
+        valid: false,
+        error: 'No active task to pause',
+        suggestion: 'Start a task first with /p:now "task"',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:resume - Resume paused task
+   */
+  async resume(context) {
+    const state = await contextBuilder.loadState(context, ['now'])
+
+    // Check if there's a paused state to resume
+    // This would need to check a paused.md or similar
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:recap - Show project overview
+   */
+  async recap(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'recap')
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:progress - Show progress metrics
+   */
+  async progress(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'progress')
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:analyze - Analyze repository
+   */
+  async analyze(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'analyze')
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:sync - Sync project state
+   */
+  async sync(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'sync')
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:bug - Report a bug
+   */
+  async bug(context) {
+    const state = await contextBuilder.loadState(context, ['next'])
+
+    if (!context.params.description && !context.params.bug) {
+      return {
+        valid: false,
+        error: 'No bug description provided',
+        suggestion: 'Describe the bug: /p:bug "description of the issue"',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:help - Show help
+   */
+  async help(context) {
+    const state = await contextBuilder.loadStateForCommand(context, 'now')
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:ask - Intent translator
+   */
+  async ask(context) {
+    if (!context.params.query && !context.params.question) {
+      return {
+        valid: false,
+        error: 'No question provided',
+        suggestion: 'Ask what you want to do: /p:ask "how do I..."',
+        state: {}
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state: {} }
+  },
+
+  /**
+   * /p:suggest - Smart suggestions
+   */
+  async suggest(context) {
+    const state = await contextBuilder.loadState(context, ['now', 'next', 'shipped', 'metrics'])
+    return { valid: true, error: null, suggestion: null, state }
+  },
+
+  /**
+   * /p:spec - Spec-driven development
+   */
+  async spec(context) {
+    const state = await contextBuilder.loadState(context, ['roadmap', 'next'])
+
+    // If no feature name, this is a "show template" request - always valid
+    if (!context.params.feature && !context.params.name && !context.params.description) {
+      return {
+        valid: true,
+        error: null,
+        suggestion: 'Provide a feature name to create a spec',
+        state
+      }
+    }
+
+    // Check queue capacity for new tasks
+    const queueContent = state.next || ''
+    const taskCount = (queueContent.match(/- \[[ x]\]/g) || []).length
+    if (taskCount >= 95) {
+      return {
+        valid: false,
+        error: 'Queue almost full (95+ tasks)',
+        suggestion: 'Complete some tasks before creating a new spec. Use /p:done',
+        state
+      }
+    }
+
+    return { valid: true, error: null, suggestion: null, state }
+  }
+}
+
+/**
+ * Validate command before execution
+ *
+ * @param {string} commandName - Command to validate
+ * @param {Object} context - Built context from contextBuilder
+ * @returns {Promise<ValidationResult>}
+ */
+async function validate(commandName, context) {
+  const validator = validationRules[commandName]
+
+  if (!validator) {
+    // No specific validation - default to valid
+    return {
+      valid: true,
+      error: null,
+      suggestion: null,
+      state: await contextBuilder.loadState(context)
+    }
+  }
+
+  try {
+    return await validator(context)
+  } catch (error) {
+    return {
+      valid: false,
+      error: `Validation error: ${error.message}`,
+      suggestion: 'Check file permissions and project configuration',
+      state: {}
+    }
+  }
+}
+
+/**
+ * Format validation error for display
+ * Minimal, actionable output
+ *
+ * @param {ValidationResult} result - Validation result
+ * @returns {string} Formatted error message
+ */
+function formatError(result) {
+  if (result.valid) return null
+
+  let output = `❌ ${result.error}`
+  if (result.suggestion) {
+    output += `\n→ ${result.suggestion}`
+  }
+  return output
+}
+
+module.exports = {
+  validate,
+  formatError,
+  validationRules
+}

package/core/command-registry.js

@@ -88,6 +88,31 @@ const COMMANDS = [
     ],
   },
 
+  // 3.5. Spec-Driven Development (P1.2)
+  {
+    name: 'spec',
+    category: 'core',
+    description: 'Create detailed specifications for complex features',
+    usage: {
+      claude: '/p:spec "Dark Mode"',
+      terminal: 'prjct spec "Dark Mode"',
+    },
+    params: '[feature]',
+    implemented: true,
+    hasTemplate: true,
+    icon: 'FileText',
+    requiresInit: true,
+    blockingRules: null,
+    features: [
+      'Requirements documentation',
+      'Design decisions tracking',
+      'Tasks broken into 20-30min chunks',
+      'User approval workflow',
+      'Auto-add tasks to queue on approve',
+      'Integrates with /p:feature',
+    ],
+  },
+
   // 4. Work - Unified task management (replaces now + build)
   {
     name: 'work',
@@ -346,6 +371,29 @@ const COMMANDS = [
     blockingRules: null,
     isOptional: true,
   },
+  {
+    name: 'spec',
+    category: 'optional',
+    description: 'Spec-driven development for complex features',
+    usage: {
+      claude: '/p:spec "Dark Mode"',
+      terminal: 'prjct spec "Dark Mode"',
+    },
+    params: '[feature_name]',
+    implemented: true,
+    hasTemplate: true,
+    icon: 'FileText',
+    requiresInit: true,
+    blockingRules: null,
+    isOptional: true,
+    features: [
+      'Clear requirements before coding',
+      'Design decisions documented',
+      'Tasks broken into 20-30 min chunks',
+      'User approval before starting',
+      'Auto-adds tasks to queue on approval',
+    ],
+  },
   {
     name: 'cleanup',
     category: 'optional',

package/core/commands.js

@@ -21,6 +21,7 @@ const path = require('path')
 const commandExecutor = require('./agentic/command-executor')
 const contextBuilder = require('./agentic/context-builder')
 const toolRegistry = require('./agentic/tool-registry')
+const memorySystem = require('./agentic/memory-system')
 const pathManager = require('./infrastructure/path-manager')
 const configManager = require('./infrastructure/config-manager')
 const authorDetector = require('./infrastructure/author-detector')
@@ -306,6 +307,7 @@ class PrjctCommands {
       const globalPath = pathManager.getGlobalProjectPath(projectId)
 
       // Create base files
+      // P1.1: Added patterns.json for Layered Memory System
       const baseFiles = {
         'core/now.md': '# NOW\n\nNo current task. Use `/p:now` to set focus.\n',
         'core/next.md': '# NEXT\n\n## Priority Queue\n\n',
@@ -314,7 +316,15 @@ class PrjctCommands {
         'progress/metrics.md': '# METRICS\n\n',
         'planning/ideas.md': '# IDEAS 💡\n\n## Brain Dump\n\n',
         'planning/roadmap.md': '# ROADMAP\n\n',
+        'planning/specs/.gitkeep': '# Specs directory - created by /p:spec\n',
         'memory/context.jsonl': '',
+        'memory/patterns.json': JSON.stringify({
+          version: 1,
+          decisions: {},
+          preferences: {},
+          workflows: {},
+          counters: {}
+        }, null, 2),
       }
 
       for (const [filePath, content] of Object.entries(baseFiles)) {
@@ -379,9 +389,17 @@ class PrjctCommands {
         console.log('  Custom: Describe your preferred stack\n')
         console.log('Which option do you prefer? (Respond to continue setup)')
 
+        // Update global CLAUDE.md with latest instructions
+        const commandInstaller = require('./infrastructure/command-installer')
+        await commandInstaller.installGlobalConfig()
+
         return { success: true, mode: 'architect', projectId, idea }
       }
 
+      // Update global CLAUDE.md with latest instructions (fallback for any case)
+      const commandInstaller = require('./infrastructure/command-installer')
+      await commandInstaller.installGlobalConfig()
+
       return { success: true, projectId }
     } catch (error) {
       console.error('❌ Error:', error.message)
@@ -693,6 +711,27 @@ class PrjctCommands {
         timestamp: dateHelper.getTimestamp(),
       })
 
+      // P1.1: Learn patterns from this ship
+      const config = await configManager.getConfig(projectPath)
+      const projectId = config.projectId
+
+      // Record shipping workflow patterns
+      await memorySystem.learnDecision(projectId, 'commit_footer', 'prjct', 'ship')
+
+      // Track if tests were run (for quick_ship pattern learning)
+      if (testResult.success) {
+        await memorySystem.recordDecision(projectId, 'test_before_ship', 'true', 'ship')
+      }
+
+      // Record workflow if it's a quick ship (small changes)
+      const isQuickShip = !lintResult.success || !testResult.success
+      if (isQuickShip) {
+        await memorySystem.recordWorkflow(projectId, 'quick_ship', {
+          description: 'Ship without full checks',
+          feature_type: feature.toLowerCase().includes('doc') ? 'docs' : 'other'
+        })
+      }
+
       console.log('\n🎉 Feature shipped successfully!\n')
       console.log('💡 Recommendation: Compact conversation now')
       console.log('   (Keeps context clean for next feature)\n')
@@ -2316,8 +2355,21 @@ Agent: ${agent}
         gitCommits: analysisData.gitStats.totalCommits,
       })
 
+      // Generate dynamic context for Claude
+      const contextSync = require('./context-sync')
+      const projectId = await configManager.getProjectId(projectPath)
+      await contextSync.generateLocalContext(projectPath, projectId)
+
+      // Update global CLAUDE.md with latest instructions
+      const commandInstaller = require('./infrastructure/command-installer')
+      const globalConfigResult = await commandInstaller.installGlobalConfig()
+      if (globalConfigResult.success) {
+        console.log('📝 Updated ~/.claude/CLAUDE.md')
+      }
+
       console.log('✅ Analysis complete!\n')
-      console.log('📄 Full report: analysis/repo-summary.md\n')
+      console.log('📄 Full report: analysis/repo-summary.md')
+      console.log('📝 Context: ~/.prjct-cli/projects/' + projectId + '/CLAUDE.md\n')
       console.log('Next steps:')
       console.log('• /p:sync → Generate agents based on stack')
       console.log('• /p:feature → Add a new feature')
@@ -2482,11 +2534,23 @@ Agent: ${agent}
         count: generatedAgents.length,
       })
 
+      // Generate dynamic context for Claude
+      const contextSync = require('./context-sync')
+      await contextSync.generateLocalContext(projectPath, projectId)
+
+      // Update global CLAUDE.md with latest instructions
+      const commandInstaller = require('./infrastructure/command-installer')
+      const globalConfigResult = await commandInstaller.installGlobalConfig()
+      if (globalConfigResult.success) {
+        console.log('📝 Updated ~/.claude/CLAUDE.md')
+      }
+
       console.log('\n✅ Sync complete!\n')
       console.log(`🤖 Agents Generated: ${generatedAgents.length}`)
       generatedAgents.forEach((agent) => {
         console.log(`   • ${agent}`)
       })
+      console.log('📝 Context: ~/.prjct-cli/projects/' + projectId + '/CLAUDE.md')
       console.log('\n📋 Based on: analysis/repo-summary.md')
       console.log('💡 See templates/agents/AGENTS.md for reference\n')
       console.log('Next steps:')