prizmkit 1.1.87 → 1.1.89

package/bundled/dev-pipeline/templates/sections/phase-prizmkit-test.md

@@ -1,13 +1,12 @@
 ### Scoped Feature Test Gate — PrizmKit Test
 
-**Goal**: Generate and verify tests for this feature's changed scope before code review.
+**Goal**: Generate and verify tests for this feature's changed scope before code review without embedding the full gate implementation in this prompt.
 
 Create a start marker immediately before invoking the skill so the gate can reject stale reports from older sessions:
 
 ```bash
-mkdir -p .prizmkit/specs/{{FEATURE_SLUG}}/
-test_gate_marker=".prizmkit/specs/{{FEATURE_SLUG}}/.prizmkit-test-started"
-touch "$test_gate_marker"
+python3 "$PIPELINE_DIR/scripts/prizmkit-test-gate.py" start \
+  --feature-slug "{{FEATURE_SLUG}}"
 ```
 
 Run `/prizmkit-test` with the feature artifact directory:
@@ -24,237 +23,17 @@ Rules:
 - If failures are baseline or unrelated to this feature, document them in the report and continue only when no in-scope failure remains unexplained.
 
 **Gate Check — Test Report**:
-After `/prizmkit-test` returns, locate the newest test report created after the start marker and validate that it belongs to this feature scope, has a PASS verdict, and has passed the boundary completion/validation gates before writing the checkpoint pointer:
-```bash
-feature_artifact_dir=".prizmkit/specs/{{FEATURE_SLUG}}/"
-latest_test_report=$(python3 - "$test_gate_marker" <<'PY'
-import os
-import sys
-
-marker = sys.argv[1]
-try:
-    marker_mtime = os.path.getmtime(marker)
-except OSError:
-    sys.exit(0)
-
-matches = []
-for root, _dirs, files in os.walk(".prizmkit/test"):
-    if "test-report.md" not in files:
-        continue
-    path = os.path.join(root, "test-report.md")
-    try:
-        report_mtime = os.path.getmtime(path)
-    except OSError:
-        continue
-    if report_mtime >= marker_mtime:
-        matches.append((report_mtime, path))
-
-if matches:
-    print(sorted(matches)[-1][1])
-PY
-)
-if [ -n "$latest_test_report" ]; then
-  report_mode=$(awk '
-    /^## Scope[[:space:]]*$/ { in_scope=1; next }
-    /^## / && in_scope { exit }
-    in_scope && /^- Mode:/ { sub(/^- Mode:[[:space:]]*/, ""); print; exit }
-  ' "$latest_test_report")
-  report_artifact_dir=$(awk '
-    /^## Scope[[:space:]]*$/ { in_scope=1; next }
-    /^## / && in_scope { exit }
-    in_scope && /^- Artifact Dir:/ { sub(/^- Artifact Dir:[[:space:]]*/, ""); print; exit }
-  ' "$latest_test_report")
-  report_verdict=$(awk '
-    /^## Verdict[[:space:]]*$/ { in_verdict=1; next }
-    in_verdict && NF { gsub(/^[[:space:]]+|[[:space:]]+$/, ""); print; exit }
-  ' "$latest_test_report")
-  boundary_gate_passed=$(awk '
-    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
-    /^## / && in_gate { exit }
-    in_gate && /^-?[[:space:]]*Completion gate passed:[[:space:]]*yes[[:space:]]*$/ { print "yes"; exit }
-  ' "$latest_test_report")
-  boundary_missing=$(awk '
-    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
-    /^## / && in_gate { exit }
-    in_gate && /^-?[[:space:]]*Boundary-missing:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
-  ' "$latest_test_report")
-  happy_path_only=$(awk '
-    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
-    /^## / && in_gate { exit }
-    in_gate && /^-?[[:space:]]*Happy-path-only:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
-  ' "$latest_test_report")
-  boundary_columns_ok=$(awk '
-    /^## Boundary Matrix[[:space:]]*$/ { in_matrix=1; next }
-    /^## / && in_matrix { exit }
-    in_matrix && /^\|/ {
-      if ($0 ~ /\|[[:space:]]*Module[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Interface[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Service Type[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Happy Path[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Request Validation[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Auth \/ Permission \/ Ownership[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Domain Invariants[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Collection \/ Pagination[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Date \/ Time[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*State Transitions[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Dependency Failure[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Response Contract[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*N\/A Reasons[[:space:]]*\|/ &&
-          $0 ~ /\|[[:space:]]*Final Status[[:space:]]*\|/) { print "yes"; exit }
-    }
-  ' "$latest_test_report")
-  boundary_incomplete=$(awk '
-    /^## Boundary Matrix[[:space:]]*$/ { in_matrix=1; next }
-    /^## / && in_matrix { exit }
-    in_matrix && /boundary-missing|happy-path-only|unresolved/ { print "yes"; exit }
-  ' "$latest_test_report")
-  boundary_validation_result=$(awk '
-    /^## Boundary Validation[[:space:]]*$/ { in_validation=1; next }
-    /^## / && in_validation { exit }
-    in_validation && /^-?[[:space:]]*Validator result:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
-  ' "$latest_test_report" | tr '[:upper:]' '[:lower:]')
-  openapi_file=""
-  for openapi_candidate in \
-    openapi.yaml openapi.yml swagger.yaml swagger.yml \
-    docs/openapi.yaml docs/openapi.yml docs/swagger.yaml docs/swagger.yml \
-    api/openapi.yaml api/openapi.yml api/swagger.yaml api/swagger.yml
-  do
-    if [ -f "$openapi_candidate" ]; then
-      openapi_file="$openapi_candidate"
-      break
-    fi
-  done
-  boundary_validator_passed=0
-  for boundary_validator in \
-    .claude/command-assets/prizmkit-test/scripts/validate_boundary_report.py \
-    .codebuddy/skills/prizmkit-test/scripts/validate_boundary_report.py \
-    .agents/skills/prizmkit-test/scripts/validate_boundary_report.py
-  do
-    if [ -f "$boundary_validator" ]; then
-      boundary_validator_args=(--report "$latest_test_report")
-      if [ -n "$openapi_file" ]; then
-        boundary_validator_args+=(--openapi "$openapi_file")
-      fi
-      if python3 "$boundary_validator" "${boundary_validator_args[@]}" >/dev/null 2>&1; then
-        boundary_validator_passed=1
-        break
-      fi
-    fi
-  done
-
-  scope_fresh_ok=$(python3 - "$latest_test_report" "$test_gate_marker" <<'PY'
-import os
-import sys
-
-report_path, marker_path = sys.argv[1], sys.argv[2]
-try:
-    report_mtime = os.path.getmtime(report_path)
-    marker_mtime = os.path.getmtime(marker_path)
-except OSError:
-    print("0")
-    sys.exit(0)
-if report_mtime < marker_mtime:
-    print("0")
-    sys.exit(0)
-try:
-    with open(report_path, "r", encoding="utf-8") as report_file:
-        report_text = report_file.read()
-except OSError:
-    print("0")
-    sys.exit(0)
-
-def scope_list(name):
-    in_scope = False
-    in_list = False
-    marker = f"- {name}:"
-    values = []
-    for raw_line in report_text.splitlines():
-        line = raw_line.strip()
-        if line == "## Scope":
-            in_scope = True
-            continue
-        if in_scope and line.startswith("## "):
-            break
-        if not in_scope:
-            continue
-        if line == marker:
-            in_list = True
-            continue
-        if in_list:
-            if raw_line.startswith("  -") or raw_line.startswith("\t-"):
-                value = line[2:].strip().strip("`")
-                if value and value not in {"{...}", "..."}:
-                    values.append(value)
-                continue
-            if line.startswith("- "):
-                break
-    return values
-
-source_files = scope_list("In-Scope Source Files")
-test_files = scope_list("In-Scope Test Files")
-if not source_files or not test_files:
-    print("0")
-    sys.exit(0)
+After `/prizmkit-test` returns, run the gate script to locate the newest current-run report, validate scope/freshness/boundary coverage, write `test-report-path.txt`, and mark the `prizmkit-test` checkpoint completed only on `GATE:PASS`:
 
-project_root = os.path.realpath(os.getcwd())
-ignored = {"none", "n/a", "not applicable", "(none)", "{...}", "..."}
-for listed_file in source_files + test_files:
-    normalized = listed_file.strip().strip("`")
-    if not normalized or normalized.lower() in ignored:
-        print("0")
-        sys.exit(0)
-    candidate = normalized if os.path.isabs(normalized) else os.path.join(os.getcwd(), normalized)
-    candidate_real = os.path.realpath(candidate)
-    try:
-        if os.path.commonpath([project_root, candidate_real]) != project_root:
-            print("0")
-            sys.exit(0)
-    except ValueError:
-        print("0")
-        sys.exit(0)
-    if not os.path.isfile(candidate_real):
-        print("0")
-        sys.exit(0)
-    if os.path.getmtime(candidate_real) > report_mtime:
-        print("0")
-        sys.exit(0)
-print("1")
-PY
-)
-
-  artifact_ok=0
-  case "$report_artifact_dir" in
-    "$feature_artifact_dir"|"${feature_artifact_dir%/}") artifact_ok=1 ;;
-  esac
-
-  boundary_ok=0
-  if [ "$boundary_columns_ok" = "yes" ] && [ -z "$boundary_incomplete" ] && [ "$boundary_gate_passed" = "yes" ] && [ "$boundary_missing" = "0" ] && [ "$happy_path_only" = "0" ] && [ "$boundary_validator_passed" = "1" ] && [ "$scope_fresh_ok" = "1" ]; then
-    case "$boundary_validation_result" in
-      passed) boundary_ok=1 ;;
-    esac
-  fi
-
-  if [ "$report_mode" = "this-change" ] && [ "$artifact_ok" = "1" ] && [ "$report_verdict" = "PASS" ] && [ "$boundary_ok" = "1" ]; then
-    printf "%s\n" "$latest_test_report" > .prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt
-    echo "GATE:PASS $latest_test_report"
-  else
-    echo "GATE:FAIL verdict=$report_verdict mode=$report_mode artifact_dir=$report_artifact_dir boundary_gate=$boundary_gate_passed boundary_missing=$boundary_missing happy_path_only=$happy_path_only boundary_validation=$boundary_validation_result validator_passed=$boundary_validator_passed scope_fresh=$scope_fresh_ok openapi=$openapi_file report=$latest_test_report"
-  fi
-else
-  echo "GATE:MISSING"
-fi
+```bash
+python3 "$PIPELINE_DIR/scripts/prizmkit-test-gate.py" check \
+  --feature-slug "{{FEATURE_SLUG}}" \
+  --artifact-dir ".prizmkit/specs/{{FEATURE_SLUG}}/" \
+  --checkpoint-path "{{CHECKPOINT_PATH}}"
 ```
 
 Gate outcomes:
-- `GATE:PASS` → append the report path and a 3-5 bullet summary to `context-snapshot.md` under `## PrizmKit Test Gate`, then update the checkpoint.
+- `GATE:PASS` → append the report path and a 3-5 bullet summary to `context-snapshot.md` under `## PrizmKit Test Gate`, then proceed to the next checkpoint step. The gate script already wrote `test-report-path.txt` and marked `prizmkit-test` completed.
 - `GATE:FAIL` with `NEEDS_FIXES` → read the report's `In-Scope Failures`, fix the feature implementation or generated tests within this feature scope, rerun `/prizmkit-test`, and repeat the gate check. Do not proceed to code review while the verdict is not `PASS`.
-- `GATE:FAIL` with `BLOCKED`, wrong mode, wrong artifact dir, or unreadable report → write `.prizmkit/specs/{{FEATURE_SLUG}}/failure-log.md` with the scoped test failure and stop for recovery.
+- `GATE:FAIL` with `BLOCKED`, wrong mode, wrong artifact dir, unreadable report, stale scope, boundary failure, validator failure, or checkpoint update failure → write `.prizmkit/specs/{{FEATURE_SLUG}}/failure-log.md` with the scoped test failure and stop for recovery.
 - `GATE:MISSING` → perform one bounded status check: inspect `/prizmkit-test` output and `.prizmkit/test/` for a report directory. If no current-run report exists, write `failure-log.md` and stop for recovery.
-
-Only after `GATE:PASS`, run the update script to set step `prizmkit-test` to `"completed"`:
-```bash
-python3 $PIPELINE_DIR/scripts/update-checkpoint.py \
-  --checkpoint-path {{CHECKPOINT_PATH}} \
-  --step prizmkit-test \
-  --status completed
-```

package/bundled/dev-pipeline/tests/conftest.py

@@ -24,4 +24,5 @@ def _load_hyphenated_module(module_name, filename):
 # Register hyphenated script files so tests can import them with underscores.
 _load_hyphenated_module("generate_bootstrap_prompt", "generate-bootstrap-prompt.py")
 _load_hyphenated_module("generate_bugfix_prompt", "generate-bugfix-prompt.py")
+_load_hyphenated_module("prizmkit_test_gate", "prizmkit-test-gate.py")
 _load_hyphenated_module("update_feature_status", "update-feature-status.py")

package/bundled/dev-pipeline/tests/test_generate_bootstrap_prompt.py

@@ -315,9 +315,14 @@ class TestScopedFeatureTestGate:
         assert names.index("phase-implement") < names.index("phase-prizmkit-test") < names.index("phase-review")
 
         rendered = "\n".join(content for _, content in sections)
+        assert "prizmkit-test-gate.py" in rendered
+        assert "prizmkit-test-gate.py\" start" in rendered
+        assert "prizmkit-test-gate.py\" check" in rendered
         assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/" in rendered
         assert ".prizmkit/bugfix/" in rendered  # explicitly forbidden in the gate wording
         assert ".prizmkit/refactor/" in rendered  # explicitly forbidden in the gate wording
+        assert "latest_test_report=$(python3" not in rendered
+        assert "boundary_columns_ok=$(awk" not in rendered
 
     def test_lite_sections_include_prizmkit_test_before_commit(self):
         sections_dir = Path(__file__).resolve().parents[1] / "templates" / "sections"

package/bundled/dev-pipeline/tests/test_prizmkit_test_gate.py

@@ -0,0 +1,107 @@
+"""Tests for prizmkit-test-gate.py."""
+
+import json
+import os
+import time
+from pathlib import Path
+
+from prizmkit_test_gate import check_gate, start_gate
+
+
+def scoped_report_text():
+    return "\n".join([
+        "# Test Report",
+        "",
+        "## Scope",
+        "- Mode: this-change",
+        "- Artifact Dir: .prizmkit/specs/123-scope-test/",
+        "- In-Scope Source Files:",
+        "  - src/feature.js",
+        "- In-Scope Test Files:",
+        "  - tests/feature.test.js",
+        "",
+        "## Boundary Matrix",
+        "| Module | Interface | Service Type | Happy Path | Request Validation | Auth / Permission / Ownership | Domain Invariants | Collection / Pagination | Date / Time | State Transitions | Dependency Failure | Response Contract | N/A Reasons | Final Status |",
+        "|--------|-----------|--------------|------------|--------------------|-------------------------------|-------------------|-------------------------|-------------|-------------------|-------------------|-------------------|-------------|--------------|",
+        "| feature | POST /feature | API | covered | covered | covered | covered | covered | covered | covered | covered | covered | none | boundary-covered |",
+        "",
+        "## Boundary Completion Gate",
+        "- Interfaces total: 1",
+        "- Boundary-covered: 1",
+        "- Boundary-missing: 0",
+        "- Happy-path-only: 0",
+        "- Completion gate passed: yes",
+        "",
+        "## Boundary Validation",
+        "- Validator command: `python3 validate_boundary_report.py`",
+        "- Validator result: passed",
+        "- Validator output: Boundary report validation: PASS",
+        "",
+        "## Verdict",
+        "PASS",
+        "",
+    ])
+
+
+def prepare_project(tmp_path):
+    (tmp_path / "src").mkdir()
+    (tmp_path / "tests").mkdir()
+    (tmp_path / "src" / "feature.js").write_text("export const feature = true;\n", encoding="utf-8")
+    (tmp_path / "tests" / "feature.test.js").write_text("test('feature', () => {});\n", encoding="utf-8")
+
+    validator = tmp_path / ".claude" / "command-assets" / "prizmkit-test" / "scripts" / "validate_boundary_report.py"
+    validator.parent.mkdir(parents=True, exist_ok=True)
+    validator.write_text("import sys\nsys.exit(0)\n", encoding="utf-8")
+
+    checkpoint = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "workflow-checkpoint.json"
+    checkpoint.parent.mkdir(parents=True, exist_ok=True)
+    checkpoint.write_text(
+        json.dumps({"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending"}]}),
+        encoding="utf-8",
+    )
+    return checkpoint
+
+
+def write_report(tmp_path):
+    report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+    report.parent.mkdir(parents=True, exist_ok=True)
+    time.sleep(0.01)
+    report.write_text(scoped_report_text(), encoding="utf-8")
+    return report
+
+
+def test_gate_pass_writes_pointer_and_updates_checkpoint(tmp_path, monkeypatch):
+    monkeypatch.chdir(tmp_path)
+    checkpoint = prepare_project(tmp_path)
+    start = start_gate("123-scope-test")
+    report = write_report(tmp_path)
+
+    result = check_gate(
+        "123-scope-test",
+        ".prizmkit/specs/123-scope-test/",
+        str(checkpoint),
+    )
+
+    assert start["gate"] == "GATE:START"
+    assert result["status"] == "PASS"
+    assert result["report"] == os.path.join(".prizmkit", "test", "run", "test-report.md")
+    pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+    assert pointer.read_text(encoding="utf-8").strip() == str(report.relative_to(tmp_path))
+    checkpoint_data = json.loads(checkpoint.read_text(encoding="utf-8"))
+    assert checkpoint_data["steps"][0]["status"] == "completed"
+
+
+def test_gate_fails_when_in_scope_file_is_newer_than_report(tmp_path, monkeypatch):
+    monkeypatch.chdir(tmp_path)
+    prepare_project(tmp_path)
+    start_gate("123-scope-test")
+    report = write_report(tmp_path)
+    now = time.time()
+    os.utime(report, (now, now))
+    os.utime(tmp_path / "src" / "feature.js", (now + 10, now + 10))
+
+    result = check_gate("123-scope-test", ".prizmkit/specs/123-scope-test/", "")
+
+    assert result["status"] == "FAIL"
+    assert result["reason"] == "scope_not_fresh"
+    assert result["scope_fresh"] == "0"