prizmkit 1.1.86 → 1.1.87

package/bundled/dev-pipeline/tests/test_generate_bootstrap_prompt.py

@@ -1,6 +1,9 @@
 """Tests for generate-bootstrap-prompt.py core functions."""
 
+import os
 import re
+import time
+from pathlib import Path
 
 from generate_bootstrap_prompt import (
     compute_feature_slug,
@@ -12,9 +15,75 @@ from generate_bootstrap_prompt import (
     determine_pipeline_mode,
     process_conditional_blocks,
     process_mode_blocks,
+    assemble_sections,
+    generate_checkpoint_definition,
+    merge_checkpoint_state,
 )
 
 
+def scoped_report_text(verdict="PASS", boundary_missing=0,
+                       happy_path_only=0, completion_gate="yes",
+                       validator_result="passed"):
+    """Build a scoped report with a complete boundary contract."""
+    return "\n".join([
+        "# Test Report",
+        "",
+        "## Scope",
+        "- Mode: this-change",
+        "- Artifact Dir: .prizmkit/specs/123-scope-test/",
+        "- In-Scope Source Files:",
+        "  - src/feature.js",
+        "- In-Scope Test Files:",
+        "  - tests/feature.test.js",
+        "",
+        "## Boundary Matrix",
+        "| Module | Interface | Service Type | Happy Path | Request Validation | Auth / Permission / Ownership | Domain Invariants | Collection / Pagination | Date / Time | State Transitions | Dependency Failure | Response Contract | N/A Reasons | Final Status |",
+        "|--------|-----------|--------------|------------|--------------------|-------------------------------|-------------------|-------------------------|-------------|-------------------|-------------------|-------------------|-------------|--------------|",
+        "| feature | POST /feature | API | covered | covered | covered | covered | covered | covered | covered | covered | covered | none | boundary-covered |",
+        "",
+        "## Boundary Completion Gate",
+        "- Interfaces total: 1",
+        "- Boundary-covered: 1",
+        "- Generated-needs-review: 0",
+        "- Skipped-with-reason: 0",
+        f"- Boundary-missing: {boundary_missing}",
+        f"- Happy-path-only: {happy_path_only}",
+        f"- Completion gate passed: {completion_gate}",
+        "",
+        "## Boundary Validation",
+        "- Validator command: `python3 validate_boundary_report.py`",
+        f"- Validator result: {validator_result}",
+        "- Validator output: Boundary report validation: PASS",
+        "",
+        "## Verdict",
+        verdict,
+        "",
+        "## Final Status",
+        "- All tests passing: yes",
+        f"- Boundary completion gate passed: {completion_gate}",
+        "- Ready for commit: yes",
+        "- Needs human review: None",
+        "",
+    ])
+
+
+def write_fresh_scoped_report(project_root, report_path, report_text=None):
+    """Write marker, in-scope files, and a fresh scoped report."""
+    source = project_root / "src" / "feature.js"
+    test = project_root / "tests" / "feature.test.js"
+    marker = project_root / ".prizmkit" / "specs" / "123-scope-test" / ".prizmkit-test-started"
+    source.parent.mkdir(parents=True, exist_ok=True)
+    test.parent.mkdir(parents=True, exist_ok=True)
+    marker.parent.mkdir(parents=True, exist_ok=True)
+    report_path.parent.mkdir(parents=True, exist_ok=True)
+    source.write_text("export const feature = true;\n", encoding="utf-8")
+    test.write_text("test('feature', () => {});\n", encoding="utf-8")
+    marker.write_text("started\n", encoding="utf-8")
+    time.sleep(0.01)
+    report_path.write_text(report_text or scoped_report_text(), encoding="utf-8")
+    return source, test, marker
+
+
 # ---------------------------------------------------------------------------
 # compute_feature_slug
 # ---------------------------------------------------------------------------
@@ -222,3 +291,363 @@ class TestProcessModeBlocks:
         tpl = "{{IF_CRITIC_ENABLED}}critic{{END_IF_CRITIC_ENABLED}}"
         result = process_mode_blocks(tpl, "standard", init_done=True)
         assert "critic" not in result
+
+
+
+# ---------------------------------------------------------------------------
+# section assembly / checkpoint integration
+# ---------------------------------------------------------------------------
+
+class TestScopedFeatureTestGate:
+    def test_standard_sections_insert_prizmkit_test_between_implement_and_review(self):
+        sections_dir = Path(__file__).resolve().parents[1] / "templates" / "sections"
+        sections = assemble_sections(
+            "standard",
+            str(sections_dir),
+            init_done=True,
+            is_resume=False,
+            critic_enabled=False,
+            browser_enabled=False,
+        )
+        names = [name for name, _ in sections]
+
+        assert "phase-prizmkit-test" in names
+        assert names.index("phase-implement") < names.index("phase-prizmkit-test") < names.index("phase-review")
+
+        rendered = "\n".join(content for _, content in sections)
+        assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/" in rendered
+        assert ".prizmkit/bugfix/" in rendered  # explicitly forbidden in the gate wording
+        assert ".prizmkit/refactor/" in rendered  # explicitly forbidden in the gate wording
+
+    def test_lite_sections_include_prizmkit_test_before_commit(self):
+        sections_dir = Path(__file__).resolve().parents[1] / "templates" / "sections"
+        sections = assemble_sections(
+            "lite",
+            str(sections_dir),
+            init_done=True,
+            is_resume=False,
+            critic_enabled=False,
+            browser_enabled=False,
+        )
+        names = [name for name, _ in sections]
+
+        assert "phase-prizmkit-test" in names
+        assert "phase-review" not in names
+        assert names.index("phase-implement") < names.index("phase-prizmkit-test") < names.index("phase-commit")
+
+    def test_checkpoint_orders_prizmkit_test_between_implement_and_review(self):
+        sections_dir = Path(__file__).resolve().parents[1] / "templates" / "sections"
+        sections = assemble_sections(
+            "standard",
+            str(sections_dir),
+            init_done=True,
+            is_resume=False,
+            critic_enabled=False,
+            browser_enabled=False,
+        )
+        checkpoint = generate_checkpoint_definition(
+            sections,
+            pipeline_mode="standard",
+            workflow_type="feature-pipeline",
+            item_id="F-123",
+            item_slug="123-scope-test",
+            session_id="F-123-session",
+            init_done=True,
+        )
+        skills = [step["skill"] for step in checkpoint["steps"]]
+
+        assert skills.index("prizmkit-implement") < skills.index("prizmkit-test") < skills.index("prizmkit-code-review")
+        test_step = next(step for step in checkpoint["steps"] if step["skill"] == "prizmkit-test")
+        assert test_step["required_artifacts"] == [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]
+
+    def test_merge_resets_completed_prizmkit_test_without_report_artifact(self, tmp_path):
+        existing = {
+            "steps": [
+                {
+                    "id": "S01",
+                    "skill": "prizmkit-test",
+                    "status": "completed",
+                    "required_artifacts": [
+                        ".prizmkit/specs/123-scope-test/test-report-path.txt",
+                        ".prizmkit/test/*/test-report.md",
+                    ],
+                },
+                {"id": "S02", "skill": "prizmkit-code-review", "status": "completed", "required_artifacts": []},
+            ],
+        }
+        fresh = {
+            "steps": [
+                {"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+                    ".prizmkit/specs/123-scope-test/test-report-path.txt",
+                    ".prizmkit/test/*/test-report.md",
+                ]},
+                {"id": "S02", "skill": "prizmkit-code-review", "status": "pending", "required_artifacts": []},
+            ],
+        }
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.parent.mkdir(parents=True, exist_ok=True)
+        pointer.write_text(".prizmkit/test/missing/test-report.md\n", encoding="utf-8")
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert [step["status"] for step in merged["steps"]] == ["pending", "pending"]
+
+    def test_merge_keeps_completed_prizmkit_test_only_for_scoped_pass_report(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        write_fresh_scoped_report(tmp_path, report)
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.parent.mkdir(parents=True, exist_ok=True)
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {
+            "steps": [
+                {"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+                    ".prizmkit/specs/123-scope-test/test-report-path.txt",
+                    ".prizmkit/test/*/test-report.md",
+                ]},
+                {"id": "S02", "skill": "prizmkit-code-review", "status": "completed", "required_artifacts": []},
+            ],
+        }
+        fresh = {
+            "steps": [
+                {"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+                    ".prizmkit/specs/123-scope-test/test-report-path.txt",
+                    ".prizmkit/test/*/test-report.md",
+                ]},
+                {"id": "S02", "skill": "prizmkit-code-review", "status": "pending", "required_artifacts": []},
+            ],
+        }
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert [step["status"] for step in merged["steps"]] == ["completed", "completed"]
+
+    def test_merge_resets_completed_prizmkit_test_for_needs_fixes_report(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        report.parent.mkdir(parents=True)
+        report.write_text(scoped_report_text(verdict="NEEDS_FIXES"), encoding="utf-8")
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.parent.mkdir(parents=True, exist_ok=True)
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_for_absolute_report_outside_project(self, tmp_path):
+        project_root = tmp_path / "project"
+        external_root = tmp_path / "external"
+        in_project_report = project_root / ".prizmkit" / "test" / "run" / "test-report.md"
+        external_report = external_root / "report.md"
+        pointer = project_root / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        for path in (in_project_report.parent, external_report.parent, pointer.parent):
+            path.mkdir(parents=True, exist_ok=True)
+        report_text = "\n".join([
+            "# Test Report",
+            "",
+            "## Scope",
+            "- Mode: this-change",
+            "- Artifact Dir: .prizmkit/specs/123-scope-test/",
+            "",
+            "## Verdict",
+            "PASS",
+            "",
+        ])
+        in_project_report.write_text(report_text, encoding="utf-8")
+        external_report.write_text(report_text, encoding="utf-8")
+        pointer.write_text(f"{external_report}\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(project_root))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_for_sibling_workspace_report(self, tmp_path):
+        project_root = tmp_path / "project"
+        sibling_root = tmp_path / "project-sibling"
+        in_project_report = project_root / ".prizmkit" / "test" / "run" / "test-report.md"
+        sibling_report = sibling_root / ".prizmkit" / "test" / "run" / "test-report.md"
+        pointer = project_root / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        for path in (in_project_report.parent, sibling_report.parent, pointer.parent):
+            path.mkdir(parents=True, exist_ok=True)
+        report_text = scoped_report_text()
+        in_project_report.write_text(report_text, encoding="utf-8")
+        sibling_report.write_text(report_text, encoding="utf-8")
+        pointer.write_text(f"{sibling_report}\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(project_root))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_for_minimal_boundary_matrix(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        report.parent.mkdir(parents=True)
+        report.write_text(
+            "\n".join([
+                "# Test Report",
+                "",
+                "## Scope",
+                "- Mode: this-change",
+                "- Artifact Dir: .prizmkit/specs/123-scope-test/",
+                "",
+                "## Boundary Matrix",
+                "| Interface | Happy Path | N/A Reasons | Final Status |",
+                "|-----------|------------|-------------|--------------|",
+                "| POST /feature | covered | none | boundary-covered |",
+                "",
+                "## Boundary Completion Gate",
+                "- Interfaces total: 1",
+                "- Boundary-covered: 1",
+                "- Boundary-missing: 0",
+                "- Happy-path-only: 0",
+                "- Completion gate passed: yes",
+                "",
+                "## Boundary Validation",
+                "- Validator result: skipped",
+                "",
+                "## Verdict",
+                "PASS",
+                "",
+            ]),
+            encoding="utf-8",
+        )
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.parent.mkdir(parents=True, exist_ok=True)
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_for_missing_boundary_metrics(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        report_text = scoped_report_text().replace("- Boundary-missing: 0\n", "").replace("- Happy-path-only: 0\n", "")
+        write_fresh_scoped_report(tmp_path, report, report_text)
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.parent.mkdir(parents=True, exist_ok=True)
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_when_marker_newer_than_report(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        _source, _test, marker = write_fresh_scoped_report(tmp_path, report)
+        now = time.time()
+        os.utime(report, (now, now))
+        os.utime(marker, (now + 10, now + 10))
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_when_in_scope_file_newer_than_report(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        source, _test, _marker = write_fresh_scoped_report(tmp_path, report)
+        now = time.time()
+        os.utime(report, (now, now))
+        os.utime(source, (now + 10, now + 10))
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_without_in_scope_tests(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        report_text = scoped_report_text().replace("- In-Scope Test Files:\n  - tests/feature.test.js\n", "- In-Scope Test Files:\n")
+        write_fresh_scoped_report(tmp_path, report, report_text)
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"
+
+    def test_merge_resets_completed_prizmkit_test_without_in_scope_sources(self, tmp_path):
+        report = tmp_path / ".prizmkit" / "test" / "run" / "test-report.md"
+        report_text = scoped_report_text().replace("- In-Scope Source Files:\n  - src/feature.js\n", "- In-Scope Source Files:\n")
+        write_fresh_scoped_report(tmp_path, report, report_text)
+        pointer = tmp_path / ".prizmkit" / "specs" / "123-scope-test" / "test-report-path.txt"
+        pointer.write_text(".prizmkit/test/run/test-report.md\n", encoding="utf-8")
+        existing = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "completed", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+        fresh = {"steps": [{"id": "S01", "skill": "prizmkit-test", "status": "pending", "required_artifacts": [
+            ".prizmkit/specs/123-scope-test/test-report-path.txt",
+            ".prizmkit/test/*/test-report.md",
+        ]}]}
+
+        merged = merge_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["steps"][0]["status"] == "pending"