prizmkit 1.1.85 → 1.1.87

package/bundled/dev-pipeline/templates/sections/phase-prizmkit-test.md

@@ -0,0 +1,260 @@
+### Scoped Feature Test Gate — PrizmKit Test
+
+**Goal**: Generate and verify tests for this feature's changed scope before code review.
+
+Create a start marker immediately before invoking the skill so the gate can reject stale reports from older sessions:
+
+```bash
+mkdir -p .prizmkit/specs/{{FEATURE_SLUG}}/
+test_gate_marker=".prizmkit/specs/{{FEATURE_SLUG}}/.prizmkit-test-started"
+touch "$test_gate_marker"
+```
+
+Run `/prizmkit-test` with the feature artifact directory:
+
+```text
+/prizmkit-test scope=this-change artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/
+```
+
+Rules:
+- This gate is feature-pipeline only. Do NOT use `.prizmkit/bugfix/` or `.prizmkit/refactor/` artifact directories here.
+- Generate or update tests only for this feature's changed files, changed public interfaces, and acceptance criteria.
+- Record unrelated historical coverage gaps under `Out of Scope Gaps`; do not generate tests for them and do not fail this feature because of them.
+- If generated tests fail because implementation is wrong, fix implementation within this feature scope and rerun the affected tests.
+- If failures are baseline or unrelated to this feature, document them in the report and continue only when no in-scope failure remains unexplained.
+
+**Gate Check — Test Report**:
+After `/prizmkit-test` returns, locate the newest test report created after the start marker and validate that it belongs to this feature scope, has a PASS verdict, and has passed the boundary completion/validation gates before writing the checkpoint pointer:
+```bash
+feature_artifact_dir=".prizmkit/specs/{{FEATURE_SLUG}}/"
+latest_test_report=$(python3 - "$test_gate_marker" <<'PY'
+import os
+import sys
+
+marker = sys.argv[1]
+try:
+    marker_mtime = os.path.getmtime(marker)
+except OSError:
+    sys.exit(0)
+
+matches = []
+for root, _dirs, files in os.walk(".prizmkit/test"):
+    if "test-report.md" not in files:
+        continue
+    path = os.path.join(root, "test-report.md")
+    try:
+        report_mtime = os.path.getmtime(path)
+    except OSError:
+        continue
+    if report_mtime >= marker_mtime:
+        matches.append((report_mtime, path))
+
+if matches:
+    print(sorted(matches)[-1][1])
+PY
+)
+if [ -n "$latest_test_report" ]; then
+  report_mode=$(awk '
+    /^## Scope[[:space:]]*$/ { in_scope=1; next }
+    /^## / && in_scope { exit }
+    in_scope && /^- Mode:/ { sub(/^- Mode:[[:space:]]*/, ""); print; exit }
+  ' "$latest_test_report")
+  report_artifact_dir=$(awk '
+    /^## Scope[[:space:]]*$/ { in_scope=1; next }
+    /^## / && in_scope { exit }
+    in_scope && /^- Artifact Dir:/ { sub(/^- Artifact Dir:[[:space:]]*/, ""); print; exit }
+  ' "$latest_test_report")
+  report_verdict=$(awk '
+    /^## Verdict[[:space:]]*$/ { in_verdict=1; next }
+    in_verdict && NF { gsub(/^[[:space:]]+|[[:space:]]+$/, ""); print; exit }
+  ' "$latest_test_report")
+  boundary_gate_passed=$(awk '
+    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
+    /^## / && in_gate { exit }
+    in_gate && /^-?[[:space:]]*Completion gate passed:[[:space:]]*yes[[:space:]]*$/ { print "yes"; exit }
+  ' "$latest_test_report")
+  boundary_missing=$(awk '
+    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
+    /^## / && in_gate { exit }
+    in_gate && /^-?[[:space:]]*Boundary-missing:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
+  ' "$latest_test_report")
+  happy_path_only=$(awk '
+    /^## Boundary Completion Gate[[:space:]]*$/ { in_gate=1; next }
+    /^## / && in_gate { exit }
+    in_gate && /^-?[[:space:]]*Happy-path-only:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
+  ' "$latest_test_report")
+  boundary_columns_ok=$(awk '
+    /^## Boundary Matrix[[:space:]]*$/ { in_matrix=1; next }
+    /^## / && in_matrix { exit }
+    in_matrix && /^\|/ {
+      if ($0 ~ /\|[[:space:]]*Module[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Interface[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Service Type[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Happy Path[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Request Validation[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Auth \/ Permission \/ Ownership[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Domain Invariants[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Collection \/ Pagination[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Date \/ Time[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*State Transitions[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Dependency Failure[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Response Contract[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*N\/A Reasons[[:space:]]*\|/ &&
+          $0 ~ /\|[[:space:]]*Final Status[[:space:]]*\|/) { print "yes"; exit }
+    }
+  ' "$latest_test_report")
+  boundary_incomplete=$(awk '
+    /^## Boundary Matrix[[:space:]]*$/ { in_matrix=1; next }
+    /^## / && in_matrix { exit }
+    in_matrix && /boundary-missing|happy-path-only|unresolved/ { print "yes"; exit }
+  ' "$latest_test_report")
+  boundary_validation_result=$(awk '
+    /^## Boundary Validation[[:space:]]*$/ { in_validation=1; next }
+    /^## / && in_validation { exit }
+    in_validation && /^-?[[:space:]]*Validator result:/ { sub(/^.*:[[:space:]]*/, ""); print; exit }
+  ' "$latest_test_report" | tr '[:upper:]' '[:lower:]')
+  openapi_file=""
+  for openapi_candidate in \
+    openapi.yaml openapi.yml swagger.yaml swagger.yml \
+    docs/openapi.yaml docs/openapi.yml docs/swagger.yaml docs/swagger.yml \
+    api/openapi.yaml api/openapi.yml api/swagger.yaml api/swagger.yml
+  do
+    if [ -f "$openapi_candidate" ]; then
+      openapi_file="$openapi_candidate"
+      break
+    fi
+  done
+  boundary_validator_passed=0
+  for boundary_validator in \
+    .claude/command-assets/prizmkit-test/scripts/validate_boundary_report.py \
+    .codebuddy/skills/prizmkit-test/scripts/validate_boundary_report.py \
+    .agents/skills/prizmkit-test/scripts/validate_boundary_report.py
+  do
+    if [ -f "$boundary_validator" ]; then
+      boundary_validator_args=(--report "$latest_test_report")
+      if [ -n "$openapi_file" ]; then
+        boundary_validator_args+=(--openapi "$openapi_file")
+      fi
+      if python3 "$boundary_validator" "${boundary_validator_args[@]}" >/dev/null 2>&1; then
+        boundary_validator_passed=1
+        break
+      fi
+    fi
+  done
+
+  scope_fresh_ok=$(python3 - "$latest_test_report" "$test_gate_marker" <<'PY'
+import os
+import sys
+
+report_path, marker_path = sys.argv[1], sys.argv[2]
+try:
+    report_mtime = os.path.getmtime(report_path)
+    marker_mtime = os.path.getmtime(marker_path)
+except OSError:
+    print("0")
+    sys.exit(0)
+if report_mtime < marker_mtime:
+    print("0")
+    sys.exit(0)
+try:
+    with open(report_path, "r", encoding="utf-8") as report_file:
+        report_text = report_file.read()
+except OSError:
+    print("0")
+    sys.exit(0)
+
+def scope_list(name):
+    in_scope = False
+    in_list = False
+    marker = f"- {name}:"
+    values = []
+    for raw_line in report_text.splitlines():
+        line = raw_line.strip()
+        if line == "## Scope":
+            in_scope = True
+            continue
+        if in_scope and line.startswith("## "):
+            break
+        if not in_scope:
+            continue
+        if line == marker:
+            in_list = True
+            continue
+        if in_list:
+            if raw_line.startswith("  -") or raw_line.startswith("\t-"):
+                value = line[2:].strip().strip("`")
+                if value and value not in {"{...}", "..."}:
+                    values.append(value)
+                continue
+            if line.startswith("- "):
+                break
+    return values
+
+source_files = scope_list("In-Scope Source Files")
+test_files = scope_list("In-Scope Test Files")
+if not source_files or not test_files:
+    print("0")
+    sys.exit(0)
+
+project_root = os.path.realpath(os.getcwd())
+ignored = {"none", "n/a", "not applicable", "(none)", "{...}", "..."}
+for listed_file in source_files + test_files:
+    normalized = listed_file.strip().strip("`")
+    if not normalized or normalized.lower() in ignored:
+        print("0")
+        sys.exit(0)
+    candidate = normalized if os.path.isabs(normalized) else os.path.join(os.getcwd(), normalized)
+    candidate_real = os.path.realpath(candidate)
+    try:
+        if os.path.commonpath([project_root, candidate_real]) != project_root:
+            print("0")
+            sys.exit(0)
+    except ValueError:
+        print("0")
+        sys.exit(0)
+    if not os.path.isfile(candidate_real):
+        print("0")
+        sys.exit(0)
+    if os.path.getmtime(candidate_real) > report_mtime:
+        print("0")
+        sys.exit(0)
+print("1")
+PY
+)
+
+  artifact_ok=0
+  case "$report_artifact_dir" in
+    "$feature_artifact_dir"|"${feature_artifact_dir%/}") artifact_ok=1 ;;
+  esac
+
+  boundary_ok=0
+  if [ "$boundary_columns_ok" = "yes" ] && [ -z "$boundary_incomplete" ] && [ "$boundary_gate_passed" = "yes" ] && [ "$boundary_missing" = "0" ] && [ "$happy_path_only" = "0" ] && [ "$boundary_validator_passed" = "1" ] && [ "$scope_fresh_ok" = "1" ]; then
+    case "$boundary_validation_result" in
+      passed) boundary_ok=1 ;;
+    esac
+  fi
+
+  if [ "$report_mode" = "this-change" ] && [ "$artifact_ok" = "1" ] && [ "$report_verdict" = "PASS" ] && [ "$boundary_ok" = "1" ]; then
+    printf "%s\n" "$latest_test_report" > .prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt
+    echo "GATE:PASS $latest_test_report"
+  else
+    echo "GATE:FAIL verdict=$report_verdict mode=$report_mode artifact_dir=$report_artifact_dir boundary_gate=$boundary_gate_passed boundary_missing=$boundary_missing happy_path_only=$happy_path_only boundary_validation=$boundary_validation_result validator_passed=$boundary_validator_passed scope_fresh=$scope_fresh_ok openapi=$openapi_file report=$latest_test_report"
+  fi
+else
+  echo "GATE:MISSING"
+fi
+```
+
+Gate outcomes:
+- `GATE:PASS` → append the report path and a 3-5 bullet summary to `context-snapshot.md` under `## PrizmKit Test Gate`, then update the checkpoint.
+- `GATE:FAIL` with `NEEDS_FIXES` → read the report's `In-Scope Failures`, fix the feature implementation or generated tests within this feature scope, rerun `/prizmkit-test`, and repeat the gate check. Do not proceed to code review while the verdict is not `PASS`.
+- `GATE:FAIL` with `BLOCKED`, wrong mode, wrong artifact dir, or unreadable report → write `.prizmkit/specs/{{FEATURE_SLUG}}/failure-log.md` with the scoped test failure and stop for recovery.
+- `GATE:MISSING` → perform one bounded status check: inspect `/prizmkit-test` output and `.prizmkit/test/` for a report directory. If no current-run report exists, write `failure-log.md` and stop for recovery.
+
+Only after `GATE:PASS`, run the update script to set step `prizmkit-test` to `"completed"`:
+```bash
+python3 $PIPELINE_DIR/scripts/update-checkpoint.py \
+  --checkpoint-path {{CHECKPOINT_PATH}} \
+  --step prizmkit-test \
+  --status completed
+```

package/bundled/dev-pipeline/templates/sections/phase-review-agent.md

@@ -1,4 +1,8 @@
-### Review + Test — Code Review
+### Review — Code Review
+
+Precondition: the `prizmkit-test` checkpoint is completed and `.prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt` points to the scoped test report.
+
+Before invoking review, read `.prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt`, read the referenced `/prizmkit-test` report, and confirm the summary in `context-snapshot.md` under `## PrizmKit Test Gate` matches it. The code-review skill must receive this context through `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/` and the Reviewer must assess generated/updated test quality, `In-Scope Failures`, `Baseline Failures`, `Out of Scope Gaps`, boundary coverage if present, and the scoped report verdict.
 
 Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`.
 

package/bundled/dev-pipeline/templates/sections/phase-review-full.md

@@ -1,4 +1,8 @@
-### Review + Test — Code Review
+### Review — Code Review
+
+Precondition: the `prizmkit-test` checkpoint is completed and `.prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt` points to the scoped test report.
+
+Before invoking review, read `.prizmkit/specs/{{FEATURE_SLUG}}/test-report-path.txt`, read the referenced `/prizmkit-test` report, and confirm the summary in `context-snapshot.md` under `## PrizmKit Test Gate` matches it. The code-review skill must receive this context through `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/` and the Reviewer must assess generated/updated test quality, `In-Scope Failures`, `Baseline Failures`, `Out of Scope Gaps`, boundary coverage if present, and the scoped report verdict.
 
 Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`.