prizmkit 1.1.70 → 1.1.74

package/bundled/dev-pipeline-windows/lib/pipeline.ps1

@@ -335,6 +335,242 @@ function Invoke-PrizmPipeline {
     return $LASTEXITCODE -eq 0
   }
 
+  function Get-PrizmFeatureSlugFromList {
+    param([string]$ListPath, [string]$FeatureId)
+    if (-not (Test-Path $ListPath)) { return '' }
+    try { $data = Get-Content $ListPath -Raw | ConvertFrom-Json } catch { return '' }
+    foreach ($feature in @($data.features)) {
+      if ($feature.id -eq $FeatureId) {
+        $number = ([string]$feature.id).Replace('F-', '').Replace('f-', '').PadLeft(3, '0')
+        $title = ([string]$feature.title).ToLowerInvariant()
+        $title = [regex]::Replace($title, '[^a-z0-9\s-]', '')
+        $title = [regex]::Replace($title.Trim(), '[\s]+', '-')
+        $title = [regex]::Replace($title, '-+', '-').Trim('-')
+        if ($title) { return "$number-$title" }
+        return $number
+      }
+    }
+    return ''
+  }
+
+  function Test-PrizmCheckpointComplete {
+    param([string]$CheckpointPath)
+    if (-not (Test-Path $CheckpointPath)) { return $false }
+    try { $checkpoint = Get-Content $CheckpointPath -Raw | ConvertFrom-Json } catch { return $false }
+    if (-not $checkpoint.steps) { return $false }
+    foreach ($step in @($checkpoint.steps)) {
+      if ($step.status -notin @('completed', 'skipped')) { return $false }
+    }
+    return $true
+  }
+
+  function Get-PrizmFeatureTitleFromList {
+    param([string]$ListPath, [string]$FeatureId)
+    if (-not (Test-Path $ListPath)) { return '' }
+    try { $data = Get-Content $ListPath -Raw | ConvertFrom-Json } catch { return '' }
+    foreach ($feature in @($data.features)) {
+      if ($feature.id -eq $FeatureId) { return [string]$feature.title }
+    }
+    return ''
+  }
+
+  function Get-PrizmTitleWords {
+    param([string]$Text)
+    $matches = [regex]::Matches(([string]$Text).ToLowerInvariant(), '[a-z0-9]{3,}')
+    $words = @()
+    foreach ($match in $matches) { $words += [string]$match.Value }
+    return @($words)
+  }
+
+  function Test-PrizmCommitMatchesFeatureTitle {
+    param([string]$Subject, [string]$FeatureTitle)
+    $titleWords = @(Get-PrizmTitleWords $FeatureTitle)
+    if ($titleWords.Count -eq 0) { return $false }
+    $subjectWords = @(Get-PrizmTitleWords $Subject)
+    $subjectSet = @{}
+    foreach ($word in $subjectWords) { $subjectSet[$word] = $true }
+    $required = if ($titleWords.Count -le 3) { $titleWords.Count } else { [Math]::Max(3, [int][Math]::Ceiling($titleWords.Count * 0.75)) }
+    $matched = 0
+    foreach ($word in $titleWords) {
+      if ($subjectSet.ContainsKey($word)) { $matched++ }
+    }
+    return $matched -ge $required
+  }
+
+  function Get-PrizmFeatureCommit {
+    param([string]$ProjectRoot, [string]$BaseCommit, [string]$FeatureId, [bool]$AllowFallback = $false, [string]$FeatureTitle = '')
+    $range = if ($BaseCommit) { "$BaseCommit..HEAD" } else { 'HEAD' }
+    $lines = & git -C $ProjectRoot log $range '--format=%H%x09%s' 2>$null
+    if ($LASTEXITCODE -ne 0) { return '' }
+    foreach ($line in @($lines)) {
+      $parts = ([string]$line).Split("`t", 2)
+      if ($parts.Count -lt 2) { continue }
+      $subject = $parts[1]
+      if ($subject.Contains($FeatureId) -and $subject -notmatch '^wip(\(|:)') { return $parts[0] }
+    }
+    if ($AllowFallback -and $FeatureTitle) {
+      foreach ($line in @($lines)) {
+        $parts = ([string]$line).Split("`t", 2)
+        if ($parts.Count -lt 2) { continue }
+        $subject = $parts[1]
+        if ($subject -notmatch '^wip(\(|:)' -and (Test-PrizmCommitMatchesFeatureTitle $subject $FeatureTitle)) { return $parts[0] }
+      }
+    }
+    return ''
+  }
+
+  function Get-PrizmFeatureSemanticCompletion {
+    param([string]$ProjectRoot, [string]$ListPath, [string]$FeatureId, [string]$BaseCommit, [string]$PrizmkitDir)
+    $slug = Get-PrizmFeatureSlugFromList $ListPath $FeatureId
+    if (-not $slug) { return $null }
+    $checkpointPath = Join-Path $PrizmkitDir "specs\$slug\workflow-checkpoint.json"
+    if (-not (Test-PrizmCheckpointComplete $checkpointPath)) { return $null }
+    $featureTitle = Get-PrizmFeatureTitleFromList $ListPath $FeatureId
+    $commitSha = Get-PrizmFeatureCommit $ProjectRoot $BaseCommit $FeatureId $true $featureTitle
+    if (-not $commitSha) { return $null }
+    return [pscustomobject]@{ Slug = $slug; CommitSha = $commitSha; CheckpointPath = $checkpointPath }
+  }
+
+  function Save-PrizmPostCompletionDirtyArtifacts {
+    param([string]$ProjectRoot, [string]$ArtifactDir, [string]$ItemId, [string]$SessionId)
+    $status = & git -C $ProjectRoot status --porcelain --untracked-files=all 2>$null
+    if ([string]::IsNullOrWhiteSpace(($status -join "`n"))) { return $true }
+
+    New-Item -ItemType Directory -Force -Path $ArtifactDir | Out-Null
+    ($status -join "`n") | Set-Content -Path (Join-Path $ArtifactDir 'post-completion-status.txt') -Encoding UTF8
+    & git -C $ProjectRoot diff --binary | Set-Content -Path (Join-Path $ArtifactDir 'post-completion-dirty.patch') -Encoding UTF8
+    if ($LASTEXITCODE -ne 0) { return $false }
+    & git -C $ProjectRoot diff --cached --binary | Set-Content -Path (Join-Path $ArtifactDir 'post-completion-staged.patch') -Encoding UTF8
+    if ($LASTEXITCODE -ne 0) { return $false }
+
+    $untracked = & git -C $ProjectRoot ls-files --others --exclude-standard 2>$null
+    $manifest = Join-Path $ArtifactDir 'post-completion-untracked.txt'
+    @($untracked) | Set-Content -Path $manifest -Encoding UTF8
+    $untrackedDir = Join-Path $ArtifactDir 'untracked'
+    foreach ($rel in @($untracked)) {
+      if (-not $rel) { continue }
+      $source = Join-Path $ProjectRoot $rel
+      $dest = Join-Path $untrackedDir $rel
+      $destParent = Split-Path $dest -Parent
+      if ($destParent) { New-Item -ItemType Directory -Force -Path $destParent | Out-Null }
+      if (Test-Path $source -PathType Leaf) { Copy-Item -LiteralPath $source -Destination $dest -Force }
+      elseif (Test-Path $source -PathType Container) { New-Item -ItemType Directory -Force -Path $dest | Out-Null }
+    }
+
+    @(
+      '# Post-completion dirty changes preserved',
+      '',
+      "- Feature: $ItemId",
+      "- Session: $SessionId",
+      '- Reason: workflow checkpoint and feature commit were already complete, but delayed post-commit activity left the working tree dirty.',
+      '',
+      '## Recovery guidance',
+      '',
+      'The finalized feature commit was kept unchanged for merge. Review these follow-up artifacts separately; do not assume they were merged:',
+      '',
+      '- `post-completion-status.txt` — original dirty working tree status',
+      '- `post-completion-dirty.patch` — unstaged tracked changes',
+      '- `post-completion-staged.patch` — staged changes',
+      '- `post-completion-untracked.txt` and `untracked/` — untracked files copied before cleanup'
+    ) | Set-Content -Path (Join-Path $ArtifactDir 'post-completion-findings.md') -Encoding UTF8
+
+    & git -C $ProjectRoot reset --hard *> $null
+    if ($LASTEXITCODE -ne 0) { return $false }
+    foreach ($rel in @($untracked)) {
+      if (-not $rel -or $rel -like '.prizmkit/*') { continue }
+      $target = Join-Path $ProjectRoot $rel
+      if (Test-Path $target) { Remove-Item -LiteralPath $target -Recurse -Force -ErrorAction SilentlyContinue }
+    }
+    $remaining = & git -C $ProjectRoot status --porcelain --untracked-files=all 2>$null | Where-Object { $_ -notmatch '^\?\? \.prizmkit/' }
+    return [string]::IsNullOrWhiteSpace(($remaining -join "`n"))
+  }
+
+  function Write-PrizmRuntimeFailureLog {
+    param(
+      [string]$FailureLog,
+      [string]$FeatureId,
+      [string]$SessionId,
+      [string]$SessionStatus,
+      [int]$ExitCode,
+      [string]$StaleKillMarker,
+      [string]$ProgressJson,
+      [string]$CheckpointPath,
+      [string]$ProjectRoot,
+      [string]$BaseCommit
+    )
+    if (-not $FailureLog -or (Test-Path $FailureLog)) { return }
+    $dir = Split-Path $FailureLog -Parent
+    if ($dir) { New-Item -ItemType Directory -Force -Path $dir | Out-Null }
+    $stale = if (Test-Path $StaleKillMarker) { Get-Content $StaleKillMarker -Raw } else { 'No stale-kill marker.' }
+    $progressLines = @('Progress data unavailable.')
+    if (Test-Path $ProgressJson) {
+      try {
+        $progress = Get-Content $ProgressJson -Raw | ConvertFrom-Json
+        $progressLines = @()
+        foreach ($key in @('fatal_error_code','api_error_status','api_error_code','current_phase','current_tool','last_text_snippet','terminal_result_text')) {
+          if ($progress.PSObject.Properties[$key] -and $progress.$key) { $progressLines += "- ${key}: $($progress.$key)" }
+        }
+        if ($progressLines.Count -eq 0) { $progressLines = @('Progress data contained no terminal fields.') }
+      } catch { $progressLines = @("Progress parse error: $($_.Exception.Message)") }
+    }
+    $checkpointLines = @('No checkpoint file found.')
+    if (Test-Path $CheckpointPath) {
+      try {
+        $checkpoint = Get-Content $CheckpointPath -Raw | ConvertFrom-Json
+        $steps = @($checkpoint.steps)
+        $complete = @($steps | Where-Object { $_.status -in @('completed','skipped') }).Count
+        $checkpointLines = @("$complete/$($steps.Count) steps completed_or_skipped")
+        foreach ($step in $steps) {
+          if ($step.status -notin @('completed','skipped')) { $checkpointLines += "- incomplete: $($step.id) $($step.skill) = $($step.status)" }
+        }
+      } catch { $checkpointLines = @("Checkpoint parse error: $($_.Exception.Message)") }
+    }
+    $latestCommit = (& git -C $ProjectRoot rev-parse --short HEAD 2>$null | Select-Object -First 1)
+    if (-not $latestCommit) { $latestCommit = 'unavailable' }
+    $featureCommit = if (Get-PrizmFeatureCommit $ProjectRoot $BaseCommit $FeatureId $false) { 'yes' } else { 'no' }
+    $dirty = & git -C $ProjectRoot status --short 2>$null
+    if ([string]::IsNullOrWhiteSpace(($dirty -join "`n"))) { $dirty = @('clean') }
+    @(
+      '# Runtime-synthesized failure log',
+      '',
+      '## Session',
+      '',
+      "- feature_id: $FeatureId",
+      "- session_id: $SessionId",
+      "- session_status: $SessionStatus",
+      "- exit_code: $ExitCode",
+      '',
+      '## Stale kill marker',
+      '',
+      '```json',
+      $stale,
+      '```',
+      '',
+      '## Progress',
+      '',
+      $progressLines,
+      '',
+      '## Checkpoint',
+      '',
+      $checkpointLines,
+      '',
+      '## Git state',
+      '',
+      "- feature_commit_exists: $featureCommit",
+      "- latest_commit: $latestCommit",
+      '',
+      '```text',
+      $dirty,
+      '```',
+      '',
+      '## Recommended recovery action',
+      '',
+      '- If this is an AI runtime/provider error before checkpoint completion, retry the session with a fresh context.',
+      '- If checkpoint completion and a feature commit both exist, inspect post-completion artifacts and finalize manually rather than rebuilding from scratch.',
+      '- If the working tree is dirty, preserve or review those changes before any reset or merge.'
+    ) | Set-Content -Path $FailureLog -Encoding UTF8
+  }
+
   function New-PrizmDefaultDevBranchName {
     param([string]$Kind, [string]$CurrentItemId)
     $timestamp = Get-Date -Format 'yyyyMMddHHmm'
@@ -575,7 +811,32 @@ function Invoke-PrizmPipeline {
       $childAdvanced = ($childSignature -and $childSignature -ne $previousChildActivitySignature)
       $previousChildActivitySignature = $childSignature
 
-      if ($growth -gt 0 -or $childAdvanced) {
+      $effectiveStaleKillThreshold = Get-PrizmEffectiveStaleKillThreshold -ProgressFile $progressJson -BaseThreshold $staleKillThreshold
+
+      # Check for error-loop: agent is actively producing output but results are
+      # all read-offset errors or wasted calls.
+      $errorLoopDetected = $false
+      if ($effectiveStaleKillThreshold -gt 0 -and $growth -gt 0 -and (Test-Path $progressJson)) {
+        try {
+          $progress = Get-Content $progressJson -Raw | ConvertFrom-Json
+          $errors = $progress.errors
+          if ($errors -is [array] -and $errors.Count -ge 5) {
+            $recent = $errors[-5..-1]
+            $allBad = ($recent | Where-Object {
+              $_.type -in @("read_offset_overflow", "wasted_call")
+            }).Count -eq 5
+            if ($allBad) {
+              $errorLoopDetected = $true
+            }
+          }
+        } catch {
+          # Ignore JSON parse errors — progress file may be incomplete or malformed
+        }
+      }
+
+      if ($errorLoopDetected) {
+        $staleSeconds = $effectiveStaleKillThreshold
+      } elseif ($growth -gt 0 -or $childAdvanced) {
         $staleSeconds = 0
       } else {
         $staleSeconds += $waitSeconds
@@ -587,7 +848,17 @@ function Invoke-PrizmPipeline {
         break
       }
 
-      $effectiveStaleKillThreshold = Get-PrizmEffectiveStaleKillThreshold -ProgressFile $progressJson -BaseThreshold $staleKillThreshold
+      $fatalErrorCode = Get-PrizmProgressFatalErrorCode -ProgressFile $progressJson
+      if ($fatalErrorCode) {
+        $wasStaleKilled = $true
+        Write-PrizmWarn "Session hit fatal AI runtime error: $fatalErrorCode"
+        $fatalErrorMarker = Join-Path $logsDir 'fatal-error.json'
+        Write-PrizmFatalErrorMarker $fatalErrorMarker $fatalErrorCode $staleSeconds $effectiveStaleKillThreshold
+        Write-PrizmFatalErrorMarker $staleKillMarker $fatalErrorCode $staleSeconds $effectiveStaleKillThreshold
+        Stop-PrizmSessionProcess $pidPath
+        if ($staleKillGraceSeconds -gt 0) { Start-Sleep -Seconds $staleKillGraceSeconds }
+        break
+      }
       if ($effectiveStaleKillThreshold -gt 0 -and $staleSeconds -ge $effectiveStaleKillThreshold) {
         $wasStaleKilled = $true
         Write-PrizmWarn "Session stale-killed (no progress for ${effectiveStaleKillThreshold}s)"
@@ -619,9 +890,23 @@ function Invoke-PrizmPipeline {
     Stop-PrizmProgressParser $parserProcess
 
     $wasInfraError = ($exitCode -ne 0 -and (Test-PrizmInfraError -SessionLog $sessionLog -ProgressJson $progressJson))
+    $wasAiRuntimeError = Test-PrizmAiRuntimeError -SessionLog $sessionLog -ProgressJson $progressJson
+    $semanticCompletion = if ($Kind -eq 'feature' -and $isGitRepository) {
+      Get-PrizmFeatureSemanticCompletion $paths.ProjectRoot $listPath $CurrentItemId $baseCommit $paths.PrizmkitDir
+    } else { $null }
 
     $status = 'crashed'
-    if ($wasTimedOut) {
+    if ($semanticCompletion) {
+      $status = 'success'
+      if ($exitCode -ne 0 -or $wasStaleKilled -or $wasTimedOut -or $wasAiRuntimeError) {
+        Write-PrizmWarn "Session ended with a failure signal after semantic completion; treating as finalized success"
+        Write-PrizmWarn "Semantic completion commit: $($semanticCompletion.CommitSha)"
+      }
+    } elseif ($wasAiRuntimeError) {
+      $status = 'infra_error'
+      Write-PrizmWarn "AI session failed due to structured AI runtime/context error"
+      Write-PrizmWarn "AI runtime errors are retried without consuming code retry budget"
+    } elseif ($wasTimedOut) {
       $status = 'timed_out'
       Write-PrizmWarn "AI session timed out after $timeoutSeconds seconds"
     } elseif ($wasInfraError) {
@@ -653,13 +938,17 @@ function Invoke-PrizmPipeline {
     $mergeSucceeded = $true
     $itemListStatus = ''
     if ($status -eq 'success') {
-      $updateResult = Invoke-PrizmPythonJson $python (@((Join-Path $paths.ScriptsDir $updateScript), $listOption, $listPath, '--state-dir', $stateDir, '--action', 'update', $idOption, $CurrentItemId, '--session-id', $sessionId, '--session-status', $status) + $maxRetryArgs)
-      if ($updateResult -and $updateResult.PSObject.Properties['new_status']) {
-        $itemListStatus = [string]$updateResult.new_status
-      }
-
       if (Test-PrizmGitDirty $paths.ProjectRoot) {
-        if ($hadDirtyBaseline) {
+        if ($semanticCompletion) {
+          $artifactDir = Join-Path $paths.PrizmkitDir "specs\$($semanticCompletion.Slug)"
+          if (Save-PrizmPostCompletionDirtyArtifacts $paths.ProjectRoot $artifactDir $CurrentItemId $sessionId) {
+            Write-PrizmWarn "Post-completion dirty changes preserved under $artifactDir"
+            Write-PrizmWarn "They were not included in the finalized feature commit."
+          } else {
+            Write-PrizmWarn "Could not safely preserve post-completion dirty changes; preserving dev branch for manual finalization"
+            $status = 'finalization_needed'
+          }
+        } elseif ($hadDirtyBaseline) {
           Write-PrizmInfo "Auto-committing pipeline bookkeeping artifacts only."
           Invoke-PrizmGitIncludeBookkeepingArtifacts $paths.ProjectRoot $stateDir $listPath
         } else {
@@ -668,13 +957,20 @@ function Invoke-PrizmPipeline {
         }
       }
 
-      if ($isGitRepository -and $devBranchName) {
-        if (Merge-PrizmDevBranch $paths.ProjectRoot $devBranchName $originalBranch $autoPush) {
-          $devBranchName = ''
-        } else {
-          $mergeSucceeded = $false
-          $status = 'merge_conflict'
-          Write-PrizmWarn "Auto-merge failed - dev branch preserved for inspection"
+      if ($status -eq 'success') {
+        $updateResult = Invoke-PrizmPythonJson $python (@((Join-Path $paths.ScriptsDir $updateScript), $listOption, $listPath, '--state-dir', $stateDir, '--action', 'update', $idOption, $CurrentItemId, '--session-id', $sessionId, '--session-status', $status) + $maxRetryArgs)
+        if ($updateResult -and $updateResult.PSObject.Properties['new_status']) {
+          $itemListStatus = [string]$updateResult.new_status
+        }
+
+        if ($isGitRepository -and $devBranchName) {
+          if (Merge-PrizmDevBranch $paths.ProjectRoot $devBranchName $originalBranch $autoPush) {
+            $devBranchName = ''
+          } else {
+            $mergeSucceeded = $false
+            $status = 'merge_conflict'
+            Write-PrizmWarn "Auto-merge failed - dev branch preserved for inspection"
+          }
         }
       }
     } elseif ($isGitRepository -and $devBranchName) {
@@ -685,7 +981,20 @@ function Invoke-PrizmPipeline {
       Restore-PrizmOriginalBranch $paths.ProjectRoot $originalBranch $devBranchName | Out-Null
     }
 
+    if ($status -eq 'success' -and $mergeSucceeded -and $isGitRepository) {
+      Invoke-PrizmGitCommitPath $paths.ProjectRoot $listPath "chore($CurrentItemId): update $idName status" | Out-Null
+    }
+
     if ($status -ne 'success') {
+      if ($Kind -eq 'feature') {
+        $failureSlug = if ($semanticCompletion) { [string]$semanticCompletion.Slug } else { Get-PrizmFeatureSlugFromList $listPath $CurrentItemId }
+        if ($failureSlug) {
+          $featureArtifactDir = Join-Path $paths.PrizmkitDir "specs\$failureSlug"
+          $failureLog = Join-Path $featureArtifactDir 'failure-log.md'
+          $checkpointPath = Join-Path $featureArtifactDir 'workflow-checkpoint.json'
+          Write-PrizmRuntimeFailureLog $failureLog $CurrentItemId $sessionId $status $exitCode $staleKillMarker $progressJson $checkpointPath $paths.ProjectRoot $baseCommit
+        }
+      }
       $updateResult = Invoke-PrizmPythonJson $python (@((Join-Path $paths.ScriptsDir $updateScript), $listOption, $listPath, '--state-dir', $stateDir, '--action', 'update', $idOption, $CurrentItemId, '--session-id', $sessionId, '--session-status', $status) + $maxRetryArgs)
       if ($updateResult -and $updateResult.PSObject.Properties['new_status']) {
         $itemListStatus = [string]$updateResult.new_status