prizmkit 1.1.40 → 1.1.42

package/bundled/dev-pipeline/tests/test-deploy-safety.sh

@@ -0,0 +1,223 @@
+#!/usr/bin/env bash
+# Test deploy safety check logic across different task status scenarios
+# Run: bash dev-pipeline/tests/test-deploy-safety.sh
+set -euo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+REPO_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
+
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+YELLOW='\033[1;33m'
+NC='\033[0m'
+
+PASS=0
+FAIL=0
+TOTAL=0
+
+pass() { echo -e "  ${GREEN}PASS${NC} $1"; PASS=$((PASS + 1)); TOTAL=$((TOTAL + 1)); }
+fail() { echo -e "  ${RED}FAIL${NC} $1 — $2"; FAIL=$((FAIL + 1)); TOTAL=$((TOTAL + 1)); }
+
+echo "================================="
+echo " Deploy Safety Check Tests"
+echo "================================="
+echo ""
+
+# --- Test 1: All tasks completed -> deploy should proceed ---
+echo "[Test 1] All 'completed': incomplete_count should be 0"
+cat > /tmp/test-deploy-all-completed.json << 'JSON'
+{"features": [{"id": "F-A", "status": "completed"}, {"id": "F-B", "status": "completed"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-all-completed.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "0" ]]; then
+    pass "incomplete_count=0, deploy proceeds"
+else
+    fail "incomplete_count=$count, expected 0"
+fi
+
+# --- Test 2: One failed, one completed -> deploy blocked ---
+echo "[Test 2] Mixed 'completed' + 'failed': incomplete_count should be 1"
+cat > /tmp/test-deploy-mixed.json << 'JSON'
+{"features": [{"id": "F-A", "status": "completed"}, {"id": "F-B", "status": "failed"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-mixed.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "1" ]]; then
+    pass "incomplete_count=1, deploy blocked"
+else
+    fail "incomplete_count=$count, expected 1"
+fi
+
+# --- Test 3: All skipped -> deploy proceeds (skipped is non-blocking) ---
+echo "[Test 3] All 'skipped': incomplete_count should be 0"
+cat > /tmp/test-deploy-all-skipped.json << 'JSON'
+{"features": [{"id": "F-A", "status": "skipped"}, {"id": "F-B", "status": "skipped"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-all-skipped.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "0" ]]; then
+    pass "incomplete_count=0, deploy proceeds (skipped is non-blocking)"
+else
+    fail "incomplete_count=$count, expected 0"
+fi
+
+# --- Test 4: Timed-out status -> deploy blocked ---
+echo "[Test 4] 'timed_out' status: incomplete_count should be 1"
+cat > /tmp/test-deploy-timeout.json << 'JSON'
+{"features": [{"id": "F-A", "status": "completed"}, {"id": "F-B", "status": "timed_out"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-timeout.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "1" ]]; then
+    pass "incomplete_count=1, deploy blocked"
+else
+    fail "incomplete_count=$count, expected 1"
+fi
+
+# --- Test 5: tee /dev/stderr | tail -1 pattern extracts only count ---
+echo "[Test 5] Multi-line output extraction: only last line (integer) captured"
+cat > /tmp/test-deploy-tee.json << 'JSON'
+{"features": [{"id": "F-001", "status": "failed", "title": "Broken feature"}, {"id": "F-002", "status": "crashed", "title": "Also broken"}]}
+JSON
+result=$({ python3 -c "
+import json
+with open('/tmp/test-deploy-tee.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+for f in bad:
+    print(f\"  {f['id']}: {f.get('status', 'unknown')} — {f.get('title', '')}\")
+print(len(bad))
+" /tmp/test-deploy-tee.json 2>/dev/null || echo "0"; } | tail -1)
+if [[ "$result" =~ ^[0-9]+$ ]]; then
+    pass "extracted count is integer: $result"
+else
+    fail "extracted count is not a clean integer: '$result'"
+fi
+
+# --- Test 6: Empty feature list -> deploy proceeds ---
+echo "[Test 6] Empty list: incomplete_count should be 0"
+cat > /tmp/test-deploy-empty.json << 'JSON'
+{"features": []}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-empty.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "0" ]]; then
+    pass "incomplete_count=0, deploy proceeds"
+else
+    fail "incomplete_count=$count, expected 0"
+fi
+
+# --- Test 7: Bugfix variant with needs_info (non-blocking) ---
+echo "[Test 7] Bugfix: 'needs_info' should NOT block deploy"
+cat > /tmp/test-deploy-bugfix.json << 'JSON'
+{"bugs": [{"id": "B-001", "status": "completed"}, {"id": "B-002", "status": "needs_info"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-bugfix.json') as f:
+    data = json.load(f)
+bad = [b for b in data.get('bugs', [])
+       if b.get('status') not in ('completed', 'skipped', 'needs_info')]
+print(len(bad))
+")
+if [[ "$count" == "0" ]]; then
+    pass "incomplete_count=0, deploy proceeds (needs_info non-blocking)"
+else
+    fail "incomplete_count=$count, expected 0"
+fi
+
+# --- Test 8: Refactor variant ---
+echo "[Test 8] Refactor: completed + skipped -> deploy proceeds"
+cat > /tmp/test-deploy-refactor.json << 'JSON'
+{"refactors": [{"id": "R-001", "status": "completed"}, {"id": "R-002", "status": "skipped"}]}
+JSON
+count=$(python3 -c "
+import json
+with open('/tmp/test-deploy-refactor.json') as f:
+    data = json.load(f)
+bad = [r for r in data.get('refactors', [])
+       if r.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+if [[ "$count" == "0" ]]; then
+    pass "incomplete_count=0, deploy proceeds"
+else
+    fail "incomplete_count=$count, expected 0"
+fi
+
+# --- Test 9: Real feature-list.json ---
+echo "[Test 9] Real feature-list.json: both completed -> deploy proceeds"
+if [[ -f "$REPO_ROOT/.prizmkit/plans/feature-list.json" ]]; then
+    count=$(python3 -c "
+import json
+with open('$REPO_ROOT/.prizmkit/plans/feature-list.json') as f:
+    data = json.load(f)
+bad = [f for f in data.get('features', [])
+       if f.get('status') not in ('completed', 'skipped')]
+print(len(bad))
+")
+    if [[ "$count" == "0" ]]; then
+        pass "real list: incomplete_count=0"
+    else
+        fail "real list: incomplete_count=$count, expected 0"
+    fi
+else
+    echo "  ${YELLOW}SKIP${NC} No real feature-list.json found"
+fi
+
+# --- Test 10: ENABLE_DEPLOY=0 skips the entire block ---
+echo "[Test 10] ENABLE_DEPLOY=0: deploy block should be skipped entirely"
+ENABLE_DEPLOY=0
+executed=false
+if [[ "$ENABLE_DEPLOY" == "1" ]]; then
+    executed=true
+fi
+if [[ "$executed" == "false" ]]; then
+    pass "ENABLE_DEPLOY=0: deploy block skipped"
+else
+    fail "ENABLE_DEPLOY=0: deploy block should NOT execute"
+fi
+
+# --- Cleanup ---
+rm -f /tmp/test-deploy-*.json
+
+echo ""
+echo "================================="
+echo " Results: $PASS passed, $FAIL failed ($TOTAL total)"
+echo "================================="
+
+if [[ $FAIL -gt 0 ]]; then
+    exit 1
+fi

package/bundled/skills/_metadata.json

@@ -1,5 +1,5 @@
 {
-  "version": "1.1.40",
+  "version": "1.1.42",
   "skills": {
     "prizm-kit": {
       "description": "Full-lifecycle dev toolkit. Covers spec-driven development, Prizm context docs, code quality, debugging, deployment, and knowledge management.",
@@ -58,10 +58,10 @@
       "hasScripts": false
     },
     "prizmkit-deploy": {
-      "description": "Generate or update deployment documentation (.prizmkit/deploy.md) by scanning project state and deploy strategy. On-demand skill.",
+      "description": "Universal deployment gateway: auto-discovers project type and target, routes to SSH automation (PM2 + Nginx + blue/green), guided cloud/Docker deployment, or documentation fallback. Also operates existing deployments (status/logs/restart/rollback).",
       "tier": "1",
       "category": "prizmkit-skill",
-      "hasAssets": true,
+      "hasAssets": false,
       "hasScripts": false
     },
     "feature-workflow": {

package/bundled/skills/app-planner/SKILL.md

@@ -37,7 +37,6 @@ If you believe the task is better suited for a different workflow, you MUST:
 1. `.prizmkit/plans/project-brief.md` (`.prizmkit/plans/` — accumulated project context brief)
 2. Project conventions and architecture decisions appended to `CLAUDE.md` / `CODEBUDDY.md` (with user consent)
 3. Infrastructure configuration (database conventions + deployment config) appended to `CLAUDE.md` / `CODEBUDDY.md` `### Infrastructure` section
-4. `.prizmkit/deploy.md` — deployment documentation (created or updated with infrastructure config)
 
 **After planning is complete**, you MUST:
 1. Present the summary of captured project-level context (vision, conventions, architecture decisions, project brief)
@@ -199,7 +198,6 @@ Do NOT use this skill when:
      #### Deployment Credentials Reference
      - [platform]: [token/auth method description]
      ```
-   - Update `.prizmkit/deploy.md` if it exists — append deployment details to relevant sections (Prerequisites, Production Deployment, Environment Variables). If it does not exist, create it from the `prizmkit-deploy` template with known information filled in.
    - Items still marked "Skip — decide later" remain as `<!-- [topic]: deferred -->` in CLAUDE.md for `prizmkit-deploy` to pick up later.
 
 4. **Project brief accumulation** — throughout all interactive phases:
@@ -443,7 +441,6 @@ After all checkpoints pass, present a summary and end the session:
    - Infrastructure config → `CLAUDE.md` / `CODEBUDDY.md` `### Infrastructure` (database conventions + deployment config)
    - Tech stack → `.prizmkit/config.json`
    - Architecture decisions (if any) → `CLAUDE.md` / `CODEBUDDY.md` `### Architecture Decisions`
-   - Deployment docs → `.prizmkit/deploy.md` (if created/updated)
    - Project brief → `.prizmkit/plans/project-brief.md`
 
 2. **Suggest possible next steps** (as text, NOT auto-invoked):

package/bundled/skills/bugfix-pipeline-launcher/SKILL.md

@@ -121,6 +121,13 @@ Detect user intent from their message, then follow the corresponding workflow:
 
 5. **Ask configuration options** ⚠️ MANDATORY INTERACTIVE STEP — applies to ALL execution modes (Foreground, Background, AND Manual). You MUST ask the user to configure options and WAIT for their response BEFORE proceeding to step 6. Do NOT skip this step or merge it with step 6.
 
+   ⛔ **HARD STOP**: You MUST call `AskUserQuestion` with the questions below and WAIT for the user's response. You MUST NOT:
+   - Skip this step and jump to the next step
+   - Merge this step and the next step into one response
+   - Assume default values and show the command without asking
+   - Show the command as text and ask "ready?" without presenting the options
+   If you find yourself writing the final command before the user has answered these questions, STOP — you are violating this rule.
+
    Use `AskUserQuestion` to present the following configuration choices. Each question is a separate selectable option:
 
    **Question 1 — Verbose logging** (multiSelect: false):
@@ -154,6 +161,10 @@ Detect user intent from their message, then follow the corresponding workflow:
    - Off (default) — Pipeline continues to next task after failure
    - On — Pipeline halts immediately when a task exhausts all retries (`STOP_ON_FAILURE=1`)
 
+   **Question 3 — Deploy after completion?** (multiSelect: false):
+   - No (default) — Skip deployment after pipeline completes
+   - Yes — Run /prizmkit-deploy automatically after all bugs fixed successfully (`ENABLE_DEPLOY=1`). Deployment is blocked if any bug was not fixed (status not 'completed', 'skipped', or 'needs_info').
+
    **Environment variable mapping** (for translating user responses → env vars):
 
    | Config choice | Environment variable |
@@ -164,6 +175,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    | Critic: On | `ENABLE_CRITIC=true` |
    | Timeout: value | `SESSION_TIMEOUT=<seconds>` |
    | Stop on failure: On | `STOP_ON_FAILURE=1` |
+   | Deploy: Yes | `ENABLE_DEPLOY=1` |
 
    **Advanced environment variables** (not exposed in interactive menu, pass via `--env`):
 
@@ -188,7 +200,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    ```
    With all options:
    ```bash
-   VERBOSE=1 MAX_RETRIES=5 SESSION_TIMEOUT=3600 \
+   VERBOSE=1 MAX_RETRIES=5 SESSION_TIMEOUT=3600 ENABLE_DEPLOY=1 \
      dev-pipeline/run-bugfix.sh run .prizmkit/plans/bug-fix-list.json
    ```
 
@@ -199,7 +211,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    With all options:
    ```bash
    dev-pipeline/launch-bugfix-daemon.sh start .prizmkit/plans/bug-fix-list.json \
-     --env "VERBOSE=1 MAX_RETRIES=5"
+     --env "VERBOSE=1 MAX_RETRIES=5 ENABLE_DEPLOY=1"
    ```
 
    **Manual mode**: Print the assembled command(s) and **stop here**. Do not execute anything. Do not proceed to step 7.
@@ -334,6 +346,7 @@ dev-pipeline/reset-bug.sh B-001 --clean --run .prizmkit/plans/bug-fix-list.json
 | All bugs blocked/failed/needs-info | Show status, suggest retrying or providing more info |
 | `playwright-cli` not installed | Browser verification skipped for playwright bugs (non-blocking). Suggest: `npm install -g @playwright/cli@latest && playwright-cli install --skills` |
 | `opencli` not installed | Browser verification skipped for opencli bugs (non-blocking). Install opencli for Chrome session-based browser verification |
+| Deploy session failed | Pipeline completed but deploy session exited non-zero. Check `.prizmkit/state/bugfix/deploy/<session_id>/logs/session.log`. Retry manually: `/prizmkit-deploy`. |
 | Permission denied on script | Run `chmod +x dev-pipeline/launch-bugfix-daemon.sh dev-pipeline/run-bugfix.sh` |
 
 ### Integration Notes

package/bundled/skills/feature-pipeline-launcher/SKILL.md

@@ -138,6 +138,13 @@ Detect user intent from their message, then follow the corresponding workflow:
 
 6. **Ask configuration options** ⚠️ MANDATORY INTERACTIVE STEP — applies to ALL execution modes (Foreground, Background, AND Manual). You MUST ask the user to configure options and WAIT for their response BEFORE proceeding to step 7. Do NOT skip this step or merge it with step 7.
 
+   ⛔ **HARD STOP**: You MUST call `AskUserQuestion` with the 4 questions below and WAIT for the user's response. You MUST NOT:
+   - Skip this step and jump to step 7
+   - Merge step 6 and step 7 into one response
+   - Assume default values and show the command without asking
+   - Show the command as text and ask "ready?" without presenting the options
+   If you find yourself writing the final command before the user has answered these questions, STOP — you are violating this rule.
+
    Use `AskUserQuestion` to present the following configuration choices. Each question is a separate selectable option:
 
    **Question 1 — Critic review** (multiSelect: false):
@@ -173,6 +180,10 @@ Detect user intent from their message, then follow the corresponding workflow:
    - Off (default) — Pipeline continues to next task after failure
    - On — Pipeline halts immediately when a task exhausts all retries (`STOP_ON_FAILURE=1`)
 
+   **Question 3 — Deploy after completion?** (multiSelect: false):
+   - No (default) — Skip deployment after pipeline completes
+   - Yes — Run /prizmkit-deploy automatically after all features complete successfully (`ENABLE_DEPLOY=1`). Deployment is blocked if any feature did not complete successfully (status not 'completed' or manually 'skipped').
+
    **Environment variable mapping** (for translating user responses → env vars):
 
    | Config choice | Environment variable |
@@ -183,6 +194,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    | Max retries: N | `MAX_RETRIES=N` |
    | Timeout: value | `SESSION_TIMEOUT=<seconds>` |
    | Stop on failure: On | `STOP_ON_FAILURE=1` |
+   | Deploy: Yes | `ENABLE_DEPLOY=1` |
 
    **Advanced environment variables** (not exposed in interactive menu, pass via `--env`):
 
@@ -208,7 +220,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    ```
    With all options:
    ```bash
-   VERBOSE=1 ENABLE_CRITIC=true MAX_RETRIES=5 SESSION_TIMEOUT=3600 \
+   VERBOSE=1 ENABLE_CRITIC=true MAX_RETRIES=5 SESSION_TIMEOUT=3600 ENABLE_DEPLOY=1 \
      dev-pipeline/run-feature.sh run .prizmkit/plans/feature-list.json --features F-001:F-005
    ```
 
@@ -219,7 +231,7 @@ Detect user intent from their message, then follow the corresponding workflow:
    With all options:
    ```bash
    dev-pipeline/launch-feature-daemon.sh start .prizmkit/plans/feature-list.json --features F-001:F-005 \
-     --env "VERBOSE=1 ENABLE_CRITIC=true MAX_RETRIES=5"
+     --env "VERBOSE=1 ENABLE_CRITIC=true MAX_RETRIES=5 ENABLE_DEPLOY=1"
    ```
 
    **Manual mode**: Print the assembled command(s) and **stop here**. Do not execute anything. Do not proceed to step 8.
@@ -399,6 +411,7 @@ After pipeline completion, if features have `browser_interaction` fields and the
 | `opencli` not installed | Browser verification skipped for opencli features (non-blocking). Install opencli for Chrome session-based browser verification |
 | Permission denied on script | Run `chmod +x dev-pipeline/launch-feature-daemon.sh dev-pipeline/run-feature.sh` |
 | Pipeline stop failed (process won't die) | Process may be stuck in I/O wait. Try `kill -9 <PID>` manually. Check for orphaned child processes with `ps aux \| grep claude` |
+| Deploy session failed | Pipeline completed but deploy session exited non-zero. Check `.prizmkit/state/features/deploy/<session_id>/logs/session.log`. Retry manually: `/prizmkit-deploy`. |
 | `.env.local` missing or incomplete | Warn: database connection variables not found. Suggest creating env file with required connection variables for the project's database |
 | Database unreachable | Warn: database features will produce mock-only tests. Suggest checking database service status and connection credentials |
 | Migrations not applied | Warn: tables or schema referenced in migration files not found in database. Suggest applying pending migrations |

package/bundled/skills/prizmkit-committer/SKILL.md

@@ -17,7 +17,6 @@ description: "Pure git commit workflow with safety checks. Stages files, generat
 | Uncommitted changes exist | `git status` shows modified/added/untracked files | Inform user "nothing to commit" and stop |
 | `.prizm-docs/` synced (feature/refactor) | `/prizmkit-retrospective` has run | Run `/prizmkit-retrospective` first |
 | Code review passed (pipeline mode) | `review-report.md` in artifact directory has `## Verdict: PASS` | Run `/prizmkit-code-review` first |
-| `.prizmkit/deploy.md` updated (if applicable) | If `/prizmkit-deploy` ran, `.prizmkit/deploy.md` is staged | Run `/prizmkit-deploy` or skip if no infrastructure changes |
 
 ### Workflow
 
@@ -67,6 +66,8 @@ Ask user: "Push to remote?"
 - Yes: `git push`
 - No: Stop
 
+**Headless mode**: If the skill was invoked with `--headless` in the args (e.g., `/prizmkit-committer --headless feat(F-001): ...`), **SKIP this step entirely**. Do NOT ask the question. Do NOT push. Stop after Step 5 verification. Headless mode is used by autonomous pipeline sessions where there is no human to answer interactive prompts.
+
 ## Example
 
 **Feature commit:**