prizmkit 1.1.38 → 1.1.40

package/bundled/skills/refactor-pipeline-launcher/SKILL.md

@@ -49,10 +49,14 @@ Before any action, validate:
 2. **For start**: `.prizmkit/plans/refactor-list.json` must exist in `.prizmkit/plans/` (or user-specified path)
 3. **Dependencies**: `jq`, `python3`, AI CLI (`cbc` or `claude`) must be in PATH
 4. **Python version**: Requires Python 3.8+ for dev-pipeline scripts
+5. **Browser tools** (optional): If any refactor has `browser_interaction` field, check the corresponding tool is available. Refactors may specify `tool: "playwright-cli"`, `tool: "opencli"`, or `tool: "auto"` (AI chooses at runtime).
 
 Quick check:
 ```bash
 command -v jq && command -v python3 && (command -v cbc || command -v claude) && echo "All dependencies OK"
+# Optional: browser interaction support (check both tools — refactors may use either)
+command -v playwright-cli && echo "playwright-cli OK" || echo "playwright-cli not found (playwright browser verification will be skipped)"
+command -v opencli && echo "opencli OK" || echo "opencli not found (opencli browser verification will be skipped)"
 ```
 
 If `.prizmkit/plans/refactor-list.json` is missing, inform user:
@@ -66,6 +70,8 @@ Detect user intent from their message, then follow the corresponding workflow:
 
 #### Intent A: Start Pipeline
 
+> **Execution model**: The pipeline processes refactor tasks **sequentially** (one at a time, in priority order). The `dependencies` field in refactor-list.json is reserved for future parallel execution support and does NOT affect current execution order.
+
 1. **Check prerequisites**:
    ```bash
    ls .prizmkit/plans/refactor-list.json 2>/dev/null && echo "Found" || echo "Missing"
@@ -144,17 +150,33 @@ Detect user intent from their message, then follow the corresponding workflow:
    - 1
    - 5
 
-   **Question 3 — Session timeout** (multiSelect: false):
+   **Question 3 — Strict behavior check** (multiSelect: false):
+   - On (default) — Run full test suite after each refactor task to verify behavior preservation
+   - Off — Skip post-task test verification (faster but riskier)
+
+   **Question 4 — Advanced config?** (multiSelect: false):
+   - No (default) — Use defaults for critic review, session timeout, and failure behavior
+   - Yes — Configure critic review, session timeout, and stop-on-failure options
+
+   Note: Refactor filter defaults to all refactor items (by priority order). If the user selects "Other" on any option, handle their custom input.
+
+   **If user chose "Yes" to Advanced config**, ask a second round of `AskUserQuestion`:
+
+   **Question 1 — Session timeout** (multiSelect: false):
    - None (default) — No timeout
    - 30 min — `SESSION_TIMEOUT=1800`
    - 1 hour — `SESSION_TIMEOUT=3600`
    - 2 hours — `SESSION_TIMEOUT=7200`
 
-   **Question 4 — Strict behavior check** (multiSelect: false):
-   - On (default) — Run full test suite after each refactor task to verify behavior preservation
-   - Off — Skip post-task test verification (faster but riskier)
+   **Question 2 — Stop on failure** (multiSelect: false):
+   - Off (default) — Pipeline continues to next task after failure
+   - On — Pipeline halts immediately when a task exhausts all retries (`STOP_ON_FAILURE=1`)
 
-   Note: Refactor filter defaults to all refactor items (by priority order). If the user selects "Other" on any option, handle their custom input.
+   **Question 3 — Critic review** (multiSelect: false):
+   - Off (default) — Skip adversarial review
+   - On — Enable adversarial critic review: an independent AI agent reviews the refactor plan for completeness and the implementation for regressions, missed edge cases, and behavior violations. Adds ~5-10 min per refactor task.
+
+   Default Critic to Off unless refactor items have `priority: "critical"` (in which case default to On).
 
    **Environment variable mapping** (for translating user responses → env vars):
 
@@ -163,9 +185,11 @@ Detect user intent from their message, then follow the corresponding workflow:
    | Verbose: On | `VERBOSE=1` |
    | Verbose: Off | `VERBOSE=0` |
    | Max retries: N | `MAX_RETRIES=N` |
-   | Timeout: value | `SESSION_TIMEOUT=<seconds>` |
    | Strict behavior: On | `STRICT_BEHAVIOR_CHECK=1` |
    | Strict behavior: Off | `STRICT_BEHAVIOR_CHECK=0` |
+   | Critic: On | `ENABLE_CRITIC=true` |
+   | Timeout: value | `SESSION_TIMEOUT=<seconds>` |
+   | Stop on failure: On | `STOP_ON_FAILURE=1` |
 
    **Advanced environment variables** (not exposed in interactive menu, pass via `--env`):
 
@@ -179,7 +203,6 @@ Detect user intent from their message, then follow the corresponding workflow:
    | `LOG_CLEANUP_ENABLED` | `1` | Run periodic log cleanup (`0` to disable) |
    | `LOG_RETENTION_DAYS` | `14` | Delete logs older than N days |
    | `LOG_MAX_TOTAL_MB` | `1024` | Keep total logs under N MB via oldest-first cleanup |
-   | `STOP_ON_FAILURE` | `0` | Stop pipeline when a task exhausts all retries (`1` to stop immediately) |
 
    ⚠️ STOP HERE and wait for user response before continuing to step 7.
 
@@ -342,6 +365,8 @@ Notes:
 | Launch failed (process died immediately) | Show last 20 lines of log: `tail -20 .prizmkit/state/refactor/pipeline-daemon.log` |
 | Refactor stuck/blocked | Use `reset-refactor.sh <R-XXX> --clean --run` for a fresh retry |
 | All refactors blocked/failed | Show status, suggest recovery: `dev-pipeline/reset-refactor.sh <R-XXX> --clean --run .prizmkit/plans/refactor-list.json` |
+| `playwright-cli` not installed | Browser verification skipped for playwright refactors (non-blocking). Suggest: `npm install -g @playwright/cli@latest && playwright-cli install --skills` |
+| `opencli` not installed | Browser verification skipped for opencli refactors (non-blocking). Install opencli for Chrome session-based browser verification |
 | Permission denied on script | Run `chmod +x dev-pipeline/launch-refactor-daemon.sh dev-pipeline/run-refactor.sh` |
 
 ### Integration Notes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prizmkit",
-  "version": "1.1.38",
+  "version": "1.1.40",
   "description": "Create a new PrizmKit-powered project with clean initialization — no framework dev files, just what you need.",
   "type": "module",
   "bin": {

package/bundled/dev-pipeline/templates/agent-prompts/critic-code-challenge.md

@@ -1,13 +0,0 @@
-"Read {{CRITIC_SUBAGENT_PATH}}. For feature {{FEATURE_ID}} (slug: {{FEATURE_SLUG}}):
-**MODE: Code Challenge**
-1. Read `.prizmkit/specs/{{FEATURE_SLUG}}/context-snapshot.md` — Implementation Log section shows what Dev changed.
-2. Read `.prizm-docs/root.prizm` and relevant module docs for RULES/PATTERNS.
-3. Read the actual source files changed (from Implementation Log).
-4. Read comparable existing source files in the same module for style comparison.
-5. Read test files created/modified (from Implementation Log) — evaluate test quality:
-   - Coverage adequacy: Do tests cover all code paths modified? Target: {{COVERAGE_TARGET}}%
-   - Test brittleness: Do tests pass consistently (not flaky)? Check Implementation Log for test re-runs
-   - Edge case handling: Are boundary conditions tested? Are error paths tested?
-6. Challenge code integration quality: style fit, robustness, existing code cohesion, hidden impact.
-7. Challenge test quality: coverage, brittleness, edge case handling.
-Write `.prizmkit/specs/{{FEATURE_SLUG}}/challenge-report.md` (overwrite) with findings (or 'No significant challenges')."

package/bundled/dev-pipeline/templates/sections/phase-critic-code.md

@@ -1,25 +0,0 @@
-### Code Challenge — Critic Agent
-
-**Guard**: Verify critic agent file exists before spawning:
-```bash
-ls {{CRITIC_SUBAGENT_PATH}} 2>/dev/null && echo "CRITIC:READY" || echo "CRITIC:MISSING"
-```
-If CRITIC:MISSING — skip this phase entirely and proceed. Log: "Critic agent not installed — skipping Code Challenge."
-
-**Spawn Agent**:
-| Parameter | Value |
-|-----------|-------|
-| subagent_type | prizm-dev-team-critic |
-| mode | plan |
-| run_in_background | false |
-
-**Prompt**:
-> {{AGENT_PROMPT_CRITIC_CODE_CHALLENGE}}
-
-Wait for Critic to return.
-- Read challenge-report.md. For items marked CRITICAL/HIGH: spawn Dev to fix, then proceed to Review.
-
-**CP-3.5**: Code challenges reviewed and resolved.
-
-
-**Checkpoint update**: Update `workflow-checkpoint.json` — set step `critic-code-review` to `"completed"`.