prizmkit 1.1.38 → 1.1.39

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1,5 +1,5 @@
1
1
  {
2
- "frameworkVersion": "1.1.38",
3
- "bundledAt": "2026-04-19T13:50:39.931Z",
4
- "bundledFrom": "487e85a"
2
+ "frameworkVersion": "1.1.39",
3
+ "bundledAt": "2026-04-19T14:24:30.167Z",
4
+ "bundledFrom": "5d52f7f"
5
5
  }
@@ -1,6 +1,6 @@
1
1
  ---
2
2
  name: prizm-dev-team-critic
3
- description: Adversarial challenger that questions plan fitness and code integration quality. Evaluates whether plans and implementations truly fit the project's existing architecture, style, and patterns. Does NOT verify correctness (that's Reviewer's job) — instead challenges strategic decisions and integration quality. Use when performing adversarial plan or code challenge.
3
+ description: Adversarial challenger that questions plan fitness against the project's existing architecture, style, and patterns. Evaluates whether plans truly fit the project before implementation begins. Does NOT verify correctness (that's Reviewer's job) — instead challenges strategic decisions and integration planning. Use when performing adversarial plan challenge.
4
4
  tools: Read, Glob, Grep, Bash
5
5
  disallowedTools: Agent, Write, Edit
6
6
  model: inherit
@@ -13,9 +13,7 @@ You are the **Critic Agent**, the adversarial challenger of the PrizmKit-integra
13
13
 
14
14
  You are the team's "devil's advocate" — you challenge decisions, question assumptions, and find hidden risks that others miss. You do NOT verify correctness (that is Reviewer's job) and you do NOT check document consistency (that is Analyze's job). Your unique value is asking: **"Does this BELONG in this project? Is this the RIGHT approach? What are you NOT seeing?"**
15
15
 
16
- You operate in two modes, determined by the `MODE` field in your prompt:
17
- 1. **Plan Challenge**: Before implementation, challenge the plan's fitness for the project
18
- 2. **Code Challenge**: After implementation, challenge the code's integration quality
16
+ You operate in **Plan Challenge** mode: before implementation, you challenge the plan's fitness for the project. Code-level review is handled by the Code Review skill's built-in review-fix loop (Reviewer Agent → filter → Dev Agent).
19
17
 
20
18
  ### Project Context
21
19
 
@@ -33,7 +31,7 @@ Before any challenge, you MUST understand the project:
33
31
  3. Ground every challenge in specific evidence (file paths, code patterns, existing conventions)
34
32
  4. Write `challenge-report.md` with structured findings
35
33
  5. Keep the report ≤50 lines — focus on HIGH and CRITICAL only, skip LOW
36
- 6. Clearly state the MODE you are operating in (Plan Challenge or Code Challenge)
34
+ 6. Clearly state you are operating in Plan Challenge mode
37
35
 
38
36
  ### Never Do (NEVER)
39
37
 
@@ -52,7 +50,7 @@ CRIT-01: Always read .prizm-docs/ and existing source before challenging
52
50
  CRIT-02: Every challenge must reference a specific file path or code pattern as evidence
53
51
  CRIT-03: Maximum 10 challenges per report (focus on highest impact)
54
52
  CRIT-04: Severity levels: CRITICAL (architecture mismatch), HIGH (style/robustness gap), MEDIUM (minor inconsistency)
55
- CRIT-05: If no significant challenges found, write "No significant challenges — plan/code fits the project well" and exit
53
+ CRIT-05: If no significant challenges found, write "No significant challenges — plan fits the project well" and exit
56
54
  CRIT-06: Do NOT re-raise issues already covered by Analyze (document consistency) or Reviewer (correctness)
57
55
  CRIT-07: Read comparable existing code in the same module for style baseline before flagging style issues
58
56
  CRIT-08: When challenging a decision, always suggest a concrete alternative
@@ -87,40 +85,14 @@ CRIT-10: In voting mode, write to your assigned report file (challenge-report-{A
87
85
 
88
86
  ---
89
87
 
90
- ## Mode 2: Code Challenge
91
-
92
- **Precondition**: Dev has completed implementation. All tasks `[x]`, tests pass. Implementation Log exists in `context-snapshot.md`.
93
-
94
- **Goal**: Challenge whether the implemented code integrates well with the existing project — not whether it's correct (that's Reviewer's job).
95
-
96
- ### Challenge Dimensions
97
-
98
- | Dimension | What to Challenge | Evidence Source |
99
- |-----------|------------------|----------------|
100
- | **Style Consistency** | Do naming conventions, code structure, and patterns match existing code in the same module? | Read existing files in the same directory/module |
101
- | **Robustness** | Are edge cases handled? Error paths? Data validation? What happens with unexpected input not covered by the spec? | Read the new code, compare error handling patterns with existing code |
102
- | **Integration Cohesion** | Does the new code interact naturally with existing code? Are abstractions consistent? Are import patterns standard? | Read call sites, compare with existing integrations |
103
- | **Hidden Impact** | Could the new code have side effects on existing functionality? Shared state, global config, database constraints, event handlers? | Read shared modules, config files, database schemas |
104
-
105
- ### Workflow
106
-
107
- 1. Read `context-snapshot.md` — Implementation Log section for what changed
108
- 2. Read `.prizm-docs/root.prizm` and affected module docs (RULES, PATTERNS)
109
- 3. Read the actual source files changed (from Implementation Log)
110
- 4. Read comparable existing files in the same module for style baseline
111
- 5. For each dimension, compare new code against existing code patterns
112
- 6. Write `challenge-report.md` to `.prizmkit/specs/<feature-slug>/` (overwrite any existing report)
113
-
114
- ---
115
-
116
88
  ## Output Format
117
89
 
118
90
  Write `challenge-report.md` (or `challenge-report-{A,B,C}.md` in voting mode):
119
91
 
120
92
  ```markdown
121
- ## Challenge Report — [Plan Challenge | Code Challenge]
93
+ ## Challenge Report — Plan Challenge
122
94
  Feature: <FEATURE_ID> — <FEATURE_TITLE>
123
- Mode: [Plan Challenge | Code Challenge]
95
+ Mode: Plan Challenge
124
96
  Challenges Found: N (X critical, Y high, Z medium)
125
97
 
126
98
  ### CHALLENGE-1: [CRITICAL] Title
@@ -307,7 +307,7 @@ pending, in_progress, completed, failed, skipped
307
307
  | Phase Implementation | `phase-implement-lite.md`, `phase-implement-full.md`, `phase-implement-agent.md` | Three execution modes |
308
308
  | Phase Review | `phase-review-full.md`, `phase-review-agent.md` | Full & Agent variants |
309
309
  | Phase Plan | `phase-plan-lite.md`, `phase-plan-agent.md` | Lite & Agent variants |
310
- | Phase Critic | `phase-critic-plan.md`, `phase-critic-plan-full.md`, `phase-critic-code.md` | Plan vs Code review, single vs multi |
310
+ | Phase Critic | `phase-critic-plan.md`, `phase-critic-plan-full.md` | Plan review (single and multi) |
311
311
  | Phase Commit | `phase-commit.md`, `phase-commit-full.md` | Standard & Full variants |
312
312
 
313
313
  ### Singleton Sections
@@ -623,7 +623,6 @@ SECTION_TO_SKILL = {
623
623
  [".prizmkit/specs/{slug}/plan.md"]),
624
624
  "phase-critic-plan": ("critic-plan-review", "Critic: Plan Review", []),
625
625
  "phase-implement": ("prizmkit-implement", "Implement + Test", []),
626
- "phase-critic-code": ("critic-code-review", "Critic: Code Review", []),
627
626
  "phase-review": ("prizmkit-code-review", "Code Review", []),
628
627
  "phase-browser": ("browser-verification", "Browser Verification", []),
629
628
  "phase-deploy": ("deploy-verification", "Deploy Verification", []),
@@ -1043,12 +1042,6 @@ def assemble_sections(pipeline_mode, sections_dir, init_done, is_resume,
1043
1042
  load_section(sections_dir,
1044
1043
  "test-failure-recovery-agent.md")))
1045
1044
 
1046
- # --- Critic: Code Challenge (only if critic enabled, agent tiers) ---
1047
- if critic_enabled and pipeline_mode in ("standard", "full"):
1048
- sections.append(("phase-critic-code",
1049
- load_section(sections_dir,
1050
- "phase-critic-code.md")))
1051
-
1052
1045
  # --- AC Verification Checklist (all tiers) ---
1053
1046
  ac_checklist_path = os.path.join(sections_dir, "ac-verification-checklist.md")
1054
1047
  if os.path.isfile(ac_checklist_path):
@@ -228,33 +228,6 @@ grep -q "## Implementation Log" .prizmkit/specs/{{FEATURE_SLUG}}/context-snapsho
228
228
  ```
229
229
  If GATE:MISSING — send message to Dev (re-spawn if needed): "Write the '## Implementation Log' section to context-snapshot.md before I can proceed to review. Include: files changed/created, key decisions, deviations from plan, notable discoveries."
230
230
 
231
- {{IF_CRITIC_ENABLED}}
232
- ### Phase 4.5: Code Challenge — Critic Agent
233
-
234
- **Guard**: Verify critic agent file exists before spawning:
235
- ```bash
236
- ls {{CRITIC_SUBAGENT_PATH}} 2>/dev/null && echo "CRITIC:READY" || echo "CRITIC:MISSING"
237
- ```
238
- If CRITIC:MISSING — skip Phase 4.5 entirely and proceed to Phase 5. Log: "Critic agent not installed — skipping Code Challenge."
239
-
240
- Spawn Critic agent (Agent tool, subagent_type="prizm-dev-team-critic", mode="plan", run_in_background=false).
241
-
242
- Prompt:
243
- > "Read {{CRITIC_SUBAGENT_PATH}}. For feature {{FEATURE_ID}} (slug: {{FEATURE_SLUG}}):
244
- > **MODE: Code Challenge**
245
- > 1. Read `.prizmkit/specs/{{FEATURE_SLUG}}/context-snapshot.md` — Implementation Log section shows what Dev changed.
246
- > 2. Read `.prizm-docs/root.prizm` and relevant module docs for RULES/PATTERNS.
247
- > 3. Read the actual source files changed (from Implementation Log).
248
- > 4. Read comparable existing source files in the same module for style comparison.
249
- > 5. Challenge code integration quality: style fit, robustness, existing code cohesion, hidden impact.
250
- > Write `.prizmkit/specs/{{FEATURE_SLUG}}/challenge-report.md` (overwrite) with findings (or 'No significant challenges')."
251
-
252
- Wait for Critic to return.
253
- - Read challenge-report.md. For items marked CRITICAL/HIGH: spawn Dev to fix, then proceed to Review.
254
-
255
- **CP-3.5**: Code challenges reviewed and resolved.
256
- {{END_IF_CRITIC_ENABLED}}
257
-
258
231
  ### Phase 5: Review + Test — Reviewer Subagent
259
232
 
260
233
  Spawn Reviewer subagent (Agent tool, subagent_type="prizm-dev-team-reviewer", run_in_background=false).
@@ -293,33 +293,6 @@ Wait for Dev to return. **If Dev times out before all tasks are `[x]`**:
293
293
 
294
294
  All tasks `[x]`, tests pass.
295
295
 
296
- {{IF_CRITIC_ENABLED}}
297
- ### Phase 4.5: Code Challenge — Critic Agent
298
-
299
- **Guard**: Verify critic agent file exists before spawning:
300
- ```bash
301
- ls {{CRITIC_SUBAGENT_PATH}} 2>/dev/null && echo "CRITIC:READY" || echo "CRITIC:MISSING"
302
- ```
303
- If CRITIC:MISSING — skip Phase 4.5 entirely and proceed to Phase 5. Log: "Critic agent not installed — skipping Code Challenge."
304
-
305
- Spawn Critic agent (Agent tool, subagent_type="prizm-dev-team-critic", mode="plan", run_in_background=false).
306
-
307
- Prompt:
308
- > "Read {{CRITIC_SUBAGENT_PATH}}. For feature {{FEATURE_ID}} (slug: {{FEATURE_SLUG}}):
309
- > **MODE: Code Challenge**
310
- > 1. Read `.prizmkit/specs/{{FEATURE_SLUG}}/context-snapshot.md` — Implementation Log section shows what Dev changed.
311
- > 2. Read `.prizm-docs/root.prizm` and relevant module docs for RULES/PATTERNS.
312
- > 3. Read the actual source files changed (from Implementation Log).
313
- > 4. Read comparable existing source files in the same module for style comparison.
314
- > 5. Challenge code integration quality: style fit, robustness, existing code cohesion, hidden impact.
315
- > Write `.prizmkit/specs/{{FEATURE_SLUG}}/challenge-report.md` (overwrite) with findings (or 'No significant challenges')."
316
-
317
- Wait for Critic to return.
318
- - Read challenge-report.md. For items marked CRITICAL/HIGH: spawn Dev to fix, then proceed to Review.
319
-
320
- **CP-3.5**: Code challenges reviewed and resolved.
321
- {{END_IF_CRITIC_ENABLED}}
322
-
323
296
  ### Phase 5: Review + Test — Reviewer Agent
324
297
 
325
298
  Spawn Reviewer agent (Agent tool, subagent_type="prizm-dev-team-reviewer", run_in_background=false).
@@ -175,7 +175,7 @@
175
175
  },
176
176
  "critic": {
177
177
  "type": "boolean",
178
- "description": "Enable adversarial critic review for this bug fix. Default: true for high severity bugs, false for others.",
178
+ "description": "Enable adversarial plan challenge before implementation. Default: true for high severity bugs, false for others.",
179
179
  "default": false
180
180
  },
181
181
  "critic_count": {
@@ -147,7 +147,7 @@
147
147
  },
148
148
  "critic": {
149
149
  "type": "boolean",
150
- "description": "Enable adversarial critic review for this feature. Default: false.",
150
+ "description": "Enable adversarial plan challenge before implementation. Default: false.",
151
151
  "default": false
152
152
  },
153
153
  "critic_count": {
@@ -191,7 +191,7 @@
191
191
  },
192
192
  "critic": {
193
193
  "type": "boolean",
194
- "description": "Enable adversarial critic review for this refactor. Default: true for critical/high priority refactors, false for others.",
194
+ "description": "Enable adversarial plan challenge before implementation. Default: true for critical/high priority refactors, false for others.",
195
195
  "default": false
196
196
  },
197
197
  "critic_count": {
@@ -1,5 +1,5 @@
1
1
  {
2
- "version": "1.1.38",
2
+ "version": "1.1.39",
3
3
  "skills": {
4
4
  "prizm-kit": {
5
5
  "description": "Full-lifecycle dev toolkit. Covers spec-driven development, Prizm context docs, code quality, debugging, deployment, and knowledge management.",
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "prizmkit",
3
- "version": "1.1.38",
3
+ "version": "1.1.39",
4
4
  "description": "Create a new PrizmKit-powered project with clean initialization — no framework dev files, just what you need.",
5
5
  "type": "module",
6
6
  "bin": {
@@ -1,13 +0,0 @@
1
- "Read {{CRITIC_SUBAGENT_PATH}}. For feature {{FEATURE_ID}} (slug: {{FEATURE_SLUG}}):
2
- **MODE: Code Challenge**
3
- 1. Read `.prizmkit/specs/{{FEATURE_SLUG}}/context-snapshot.md` — Implementation Log section shows what Dev changed.
4
- 2. Read `.prizm-docs/root.prizm` and relevant module docs for RULES/PATTERNS.
5
- 3. Read the actual source files changed (from Implementation Log).
6
- 4. Read comparable existing source files in the same module for style comparison.
7
- 5. Read test files created/modified (from Implementation Log) — evaluate test quality:
8
- - Coverage adequacy: Do tests cover all code paths modified? Target: {{COVERAGE_TARGET}}%
9
- - Test brittleness: Do tests pass consistently (not flaky)? Check Implementation Log for test re-runs
10
- - Edge case handling: Are boundary conditions tested? Are error paths tested?
11
- 6. Challenge code integration quality: style fit, robustness, existing code cohesion, hidden impact.
12
- 7. Challenge test quality: coverage, brittleness, edge case handling.
13
- Write `.prizmkit/specs/{{FEATURE_SLUG}}/challenge-report.md` (overwrite) with findings (or 'No significant challenges')."
@@ -1,25 +0,0 @@
1
- ### Code Challenge — Critic Agent
2
-
3
- **Guard**: Verify critic agent file exists before spawning:
4
- ```bash
5
- ls {{CRITIC_SUBAGENT_PATH}} 2>/dev/null && echo "CRITIC:READY" || echo "CRITIC:MISSING"
6
- ```
7
- If CRITIC:MISSING — skip this phase entirely and proceed. Log: "Critic agent not installed — skipping Code Challenge."
8
-
9
- **Spawn Agent**:
10
- | Parameter | Value |
11
- |-----------|-------|
12
- | subagent_type | prizm-dev-team-critic |
13
- | mode | plan |
14
- | run_in_background | false |
15
-
16
- **Prompt**:
17
- > {{AGENT_PROMPT_CRITIC_CODE_CHALLENGE}}
18
-
19
- Wait for Critic to return.
20
- - Read challenge-report.md. For items marked CRITICAL/HIGH: spawn Dev to fix, then proceed to Review.
21
-
22
- **CP-3.5**: Code challenges reviewed and resolved.
23
-
24
-
25
- **Checkpoint update**: Update `workflow-checkpoint.json` — set step `critic-code-review` to `"completed"`.