prizmkit 1.1.191 → 1.1.193

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (165) hide show
  1. package/bundled/VERSION.json +3 -3
  2. package/bundled/adapters/antigravity/skill-adapter.js +13 -4
  3. package/bundled/adapters/codex/skill-adapter.js +28 -8
  4. package/bundled/adapters/cursor/skill-adapter.js +13 -4
  5. package/bundled/adapters/pi/skill-adapter.js +28 -7
  6. package/bundled/dev-pipeline/.env.example +4 -12
  7. package/bundled/dev-pipeline/README.md +28 -44
  8. package/bundled/dev-pipeline/assets/feature-list-example.json +0 -1
  9. package/bundled/dev-pipeline/assets/skill-subagent-integration.md +6 -6
  10. package/bundled/dev-pipeline/prizmkit_runtime/atomic_io.py +48 -0
  11. package/bundled/dev-pipeline/prizmkit_runtime/checkpoint_state.py +66 -23
  12. package/bundled/dev-pipeline/prizmkit_runtime/cli.py +10 -7
  13. package/bundled/dev-pipeline/prizmkit_runtime/commands.py +2 -21
  14. package/bundled/dev-pipeline/prizmkit_runtime/config.py +48 -78
  15. package/bundled/dev-pipeline/prizmkit_runtime/daemon.py +127 -67
  16. package/bundled/dev-pipeline/prizmkit_runtime/gitops.py +158 -462
  17. package/bundled/dev-pipeline/prizmkit_runtime/heartbeat.py +102 -50
  18. package/bundled/dev-pipeline/prizmkit_runtime/interoperability.py +1 -25
  19. package/bundled/dev-pipeline/prizmkit_runtime/paths.py +0 -6
  20. package/bundled/dev-pipeline/prizmkit_runtime/platform_detection.py +47 -21
  21. package/bundled/dev-pipeline/prizmkit_runtime/processes.py +217 -156
  22. package/bundled/dev-pipeline/prizmkit_runtime/reset.py +39 -27
  23. package/bundled/dev-pipeline/prizmkit_runtime/reset_preserve.py +34 -174
  24. package/bundled/dev-pipeline/prizmkit_runtime/results.py +25 -0
  25. package/bundled/dev-pipeline/prizmkit_runtime/runner_bookkeeping.py +133 -110
  26. package/bundled/dev-pipeline/prizmkit_runtime/runner_classification.py +15 -5
  27. package/bundled/dev-pipeline/prizmkit_runtime/runner_models.py +1 -95
  28. package/bundled/dev-pipeline/prizmkit_runtime/runner_prompts.py +0 -2
  29. package/bundled/dev-pipeline/prizmkit_runtime/runner_status.py +7 -2
  30. package/bundled/dev-pipeline/prizmkit_runtime/runners.py +540 -262
  31. package/bundled/dev-pipeline/prizmkit_runtime/runtime_commit.py +175 -135
  32. package/bundled/dev-pipeline/prizmkit_runtime/runtime_helper.py +90 -9
  33. package/bundled/dev-pipeline/prizmkit_runtime/sessions.py +214 -133
  34. package/bundled/dev-pipeline/prizmkit_runtime/status.py +1 -3
  35. package/bundled/dev-pipeline/prizmkit_runtime/stream_progress.py +2783 -0
  36. package/bundled/dev-pipeline/prizmkit_runtime/task_checkout.py +27 -102
  37. package/bundled/dev-pipeline/prizmkit_runtime/test_result.py +58 -4
  38. package/bundled/dev-pipeline/scripts/check-session-status.py +56 -20
  39. package/bundled/dev-pipeline/scripts/continuation.py +8 -7
  40. package/bundled/dev-pipeline/scripts/detect-stuck.py +47 -33
  41. package/bundled/dev-pipeline/scripts/generate-bootstrap-prompt.py +13 -16
  42. package/bundled/dev-pipeline/scripts/generate-bugfix-prompt.py +20 -10
  43. package/bundled/dev-pipeline/scripts/init-bugfix-pipeline.py +10 -7
  44. package/bundled/dev-pipeline/scripts/init-change-artifact.py +25 -4
  45. package/bundled/dev-pipeline/scripts/init-pipeline.py +14 -69
  46. package/bundled/dev-pipeline/scripts/parse-stream-progress.py +31 -2616
  47. package/bundled/dev-pipeline/scripts/patch-completion-notes.py +4 -24
  48. package/bundled/dev-pipeline/scripts/prompt_framework.py +85 -20
  49. package/bundled/dev-pipeline/scripts/status_common.py +591 -0
  50. package/bundled/dev-pipeline/scripts/update-bug-status.py +85 -463
  51. package/bundled/dev-pipeline/scripts/update-checkpoint.py +254 -65
  52. package/bundled/dev-pipeline/scripts/update-feature-status.py +76 -509
  53. package/bundled/dev-pipeline/scripts/utils.py +5 -12
  54. package/bundled/dev-pipeline/templates/bootstrap-tier3.md +5 -5
  55. package/bundled/dev-pipeline/templates/bug-fix-list-schema.json +7 -0
  56. package/bundled/dev-pipeline/templates/bugfix-bootstrap-prompt.md +7 -7
  57. package/bundled/dev-pipeline/templates/sections/artifact-manifest.md +1 -1
  58. package/bundled/dev-pipeline/templates/sections/bugfix-phase-manual-verification.md +1 -1
  59. package/bundled/dev-pipeline/templates/sections/bugfix-phase-review.md +1 -1
  60. package/bundled/dev-pipeline/templates/sections/bugfix-phase-test.md +2 -1
  61. package/bundled/dev-pipeline/templates/sections/checkpoint-system.md +1 -1
  62. package/bundled/dev-pipeline/templates/sections/phase-browser-verification-auto.md +1 -1
  63. package/bundled/dev-pipeline/templates/sections/phase-browser-verification-opencli.md +2 -2
  64. package/bundled/dev-pipeline/templates/sections/phase-browser-verification.md +2 -2
  65. package/bundled/dev-pipeline/templates/sections/phase-prizmkit-test.md +2 -1
  66. package/bundled/dev-pipeline/templates/sections/phase-review-full.md +1 -1
  67. package/bundled/dev-pipeline/templates/sections/phase-specify-plan-full.md +3 -6
  68. package/bundled/dev-pipeline/templates/session-status-schema.json +2 -5
  69. package/bundled/skills/_metadata.json +9 -63
  70. package/bundled/skills/app-planner/SKILL.md +32 -303
  71. package/bundled/skills/app-planner/references/app-design-guide.md +0 -4
  72. package/bundled/skills/app-planner/references/generated-plan-review.md +2 -1
  73. package/bundled/skills/app-planner/references/project-brief-guide.md +14 -0
  74. package/bundled/skills/app-planner/references/project-conventions-discovery.md +4 -6
  75. package/bundled/skills/app-planner/references/project-state-detection.md +2 -3
  76. package/bundled/skills/bug-fix-workflow/SKILL.md +1 -2
  77. package/bundled/skills/bug-fix-workflow/references/bug-diagnosis.md +4 -7
  78. package/bundled/skills/bug-planner/SKILL.md +54 -435
  79. package/bundled/skills/bug-planner/references/generated-plan-review.md +3 -2
  80. package/bundled/skills/bug-planner/references/input-formats.md +32 -0
  81. package/bundled/skills/bugfix-pipeline-launcher/SKILL.md +4 -6
  82. package/bundled/skills/bugfix-pipeline-launcher/references/configuration.md +4 -28
  83. package/bundled/skills/feature-pipeline-launcher/SKILL.md +4 -6
  84. package/bundled/skills/feature-pipeline-launcher/references/configuration.md +4 -28
  85. package/bundled/skills/feature-planner/SKILL.md +60 -439
  86. package/bundled/skills/feature-planner/assets/planning-guide.md +1 -1
  87. package/bundled/skills/feature-planner/references/completeness-review.md +34 -0
  88. package/bundled/skills/feature-planner/references/decomposition-patterns.md +2 -2
  89. package/bundled/skills/feature-planner/references/error-recovery.md +1 -1
  90. package/bundled/skills/feature-planner/references/generated-plan-review.md +3 -2
  91. package/bundled/skills/feature-planner/references/incremental-feature-planning.md +3 -1
  92. package/bundled/skills/feature-workflow/SKILL.md +1 -2
  93. package/bundled/skills/prizmkit/SKILL.md +7 -1
  94. package/bundled/skills/prizmkit-code-review/SKILL.md +14 -6
  95. package/bundled/skills/prizmkit-code-review/references/independent-code-review.md +7 -4
  96. package/bundled/skills/prizmkit-code-review/references/review-report-template.md +16 -0
  97. package/bundled/skills/prizmkit-code-review/scripts/render_review_report.py +58 -20
  98. package/bundled/skills/prizmkit-implement/SKILL.md +1 -1
  99. package/bundled/skills/prizmkit-init/SKILL.md +24 -127
  100. package/bundled/skills/prizmkit-init/assets/project-brief-template.md +3 -3
  101. package/bundled/skills/prizmkit-plan/SKILL.md +6 -8
  102. package/bundled/skills/prizmkit-plan/references/clarify-guide.md +1 -1
  103. package/bundled/skills/prizmkit-plan/references/independent-plan-review.md +5 -2
  104. package/bundled/skills/prizmkit-plan/references/review-plan-spec-loop.md +6 -5
  105. package/bundled/skills/prizmkit-prizm-docs/SKILL.md +1 -13
  106. package/bundled/skills/prizmkit-prizm-docs/references/op-update.md +1 -1
  107. package/bundled/skills/prizmkit-retrospective/SKILL.md +6 -4
  108. package/bundled/skills/prizmkit-test/SKILL.md +25 -133
  109. package/bundled/skills/prizmkit-test/references/independent-test-review.md +5 -2
  110. package/bundled/skills/prizmkit-test/references/test-coverage-model.md +6 -0
  111. package/bundled/skills/prizmkit-workflow/SKILL.md +2 -3
  112. package/bundled/skills/prizmkit-workflow/references/workflow-state-protocol.md +4 -3
  113. package/bundled/skills/recovery-workflow/SKILL.md +7 -7
  114. package/bundled/skills/recovery-workflow/evals/evals.json +1 -1
  115. package/bundled/skills/recovery-workflow/references/detection.md +1 -3
  116. package/bundled/skills/recovery-workflow/scripts/detect-recovery-state.py +0 -6
  117. package/bundled/templates/project-memory-template.md +1 -2
  118. package/package.json +1 -1
  119. package/src/scaffold.js +28 -7
  120. package/bundled/dev-pipeline/SCHEMA_ANALYSIS.md +0 -53
  121. package/bundled/dev-pipeline/scripts/generate-refactor-prompt.py +0 -649
  122. package/bundled/dev-pipeline/scripts/init-refactor-pipeline.py +0 -463
  123. package/bundled/dev-pipeline/scripts/update-refactor-status.py +0 -1512
  124. package/bundled/dev-pipeline/templates/refactor-bootstrap-prompt.md +0 -240
  125. package/bundled/dev-pipeline/templates/refactor-list-schema.json +0 -266
  126. package/bundled/dev-pipeline/templates/sections/refactor-critical-paths.md +0 -15
  127. package/bundled/dev-pipeline/templates/sections/refactor-mission.md +0 -9
  128. package/bundled/dev-pipeline/templates/sections/refactor-phase-commit-report.md +0 -24
  129. package/bundled/dev-pipeline/templates/sections/refactor-phase-implement.md +0 -16
  130. package/bundled/dev-pipeline/templates/sections/refactor-phase-init.md +0 -9
  131. package/bundled/dev-pipeline/templates/sections/refactor-phase-plan.md +0 -22
  132. package/bundled/dev-pipeline/templates/sections/refactor-phase-review.md +0 -19
  133. package/bundled/dev-pipeline/templates/sections/refactor-phase-test.md +0 -24
  134. package/bundled/dev-pipeline/templates/sections/refactor-reminders.md +0 -12
  135. package/bundled/dev-pipeline/templates/sections/refactor-session-context.md +0 -6
  136. package/bundled/dev-pipeline/templates/sections/refactor-task-contract.md +0 -52
  137. package/bundled/dev-pipeline/tests/conftest.py +0 -29
  138. package/bundled/dev-pipeline/tests/live_ai_cli_log_smoke.py +0 -208
  139. package/bundled/dev-pipeline/tests/test_auto_skip.py +0 -1871
  140. package/bundled/dev-pipeline/tests/test_checkpoint_state.py +0 -1314
  141. package/bundled/dev-pipeline/tests/test_generate_bootstrap_prompt.py +0 -1712
  142. package/bundled/dev-pipeline/tests/test_generate_bugfix_prompt.py +0 -627
  143. package/bundled/dev-pipeline/tests/test_generate_refactor_prompt.py +0 -478
  144. package/bundled/dev-pipeline/tests/test_python_runner_parity.py +0 -5641
  145. package/bundled/dev-pipeline/tests/test_recovery_workflow.py +0 -322
  146. package/bundled/dev-pipeline/tests/test_repository_bootstrap.py +0 -252
  147. package/bundled/dev-pipeline/tests/test_reset_modes.py +0 -1208
  148. package/bundled/dev-pipeline/tests/test_reset_preserve.py +0 -957
  149. package/bundled/dev-pipeline/tests/test_runtime_commit.py +0 -1113
  150. package/bundled/dev-pipeline/tests/test_runtime_helper.py +0 -303
  151. package/bundled/dev-pipeline/tests/test_unified_cli.py +0 -5504
  152. package/bundled/dev-pipeline/tests/test_utils.py +0 -170
  153. package/bundled/skills/feature-planner/assets/evaluation-guide.md +0 -44
  154. package/bundled/skills/refactor-pipeline-launcher/SKILL.md +0 -219
  155. package/bundled/skills/refactor-pipeline-launcher/references/configuration.md +0 -78
  156. package/bundled/skills/refactor-planner/SKILL.md +0 -467
  157. package/bundled/skills/refactor-planner/assets/planning-guide.md +0 -291
  158. package/bundled/skills/refactor-planner/references/behavior-preservation.md +0 -187
  159. package/bundled/skills/refactor-planner/references/error-recovery.md +0 -45
  160. package/bundled/skills/refactor-planner/references/fast-path.md +0 -59
  161. package/bundled/skills/refactor-planner/references/generated-plan-review.md +0 -107
  162. package/bundled/skills/refactor-planner/references/planning-phases.md +0 -172
  163. package/bundled/skills/refactor-planner/references/refactor-scoping-guide.md +0 -230
  164. package/bundled/skills/refactor-planner/scripts/validate-and-generate-refactor.py +0 -1120
  165. package/bundled/skills/refactor-workflow/SKILL.md +0 -205
@@ -24,7 +24,7 @@ import os
24
24
  import re
25
25
  import sys
26
26
 
27
- from utils import enrich_global_context, helper_replacements, load_json_file, resolve_prompt_platform, setup_logging
27
+ from utils import enrich_global_context, helper_replacements, load_json_file, resolve_prompt_platform, setup_logging, write_json_file
28
28
  from continuation import add_continuation_args, append_continuation_handoff, is_continuation
29
29
  from prompt_framework import (
30
30
  artifact_exists,
@@ -268,19 +268,15 @@ def extract_baseline_failures(test_cmd, project_root):
268
268
 
269
269
  try:
270
270
  import subprocess
271
- original_cwd = os.getcwd()
272
- os.chdir(project_root)
273
-
274
271
  result = subprocess.run(
275
272
  test_cmd,
276
273
  shell=True,
274
+ cwd=project_root,
277
275
  capture_output=True,
278
276
  text=True,
279
- timeout=120
277
+ timeout=120,
280
278
  )
281
279
 
282
- os.chdir(original_cwd)
283
-
284
280
  output = result.stdout + result.stderr
285
281
  failures = []
286
282
 
@@ -296,11 +292,6 @@ def extract_baseline_failures(test_cmd, project_root):
296
292
 
297
293
  except Exception as e:
298
294
  return f"(error: {str(e)})"
299
- finally:
300
- try:
301
- os.chdir(original_cwd)
302
- except Exception:
303
- pass
304
295
 
305
296
 
306
297
  def format_ac_checklist(acceptance_criteria):
@@ -664,9 +655,14 @@ def _resolve_artifacts(artifact_templates, slug):
664
655
  return [a.replace("{slug}", slug) for a in artifact_templates]
665
656
 
666
657
 
667
- def route_feature_repair(stage_result, repair_scope=None, repair_round=0):
658
+ def route_feature_repair(stage_result, repair_scope=None, repair_round=0, *, production_changed=False):
668
659
  """Map Feature review/test outcomes to the shared safe route contract."""
669
- return route_pipeline_repair(stage_result, repair_scope, repair_round)
660
+ return route_pipeline_repair(
661
+ stage_result,
662
+ repair_scope,
663
+ repair_round,
664
+ production_changed=production_changed,
665
+ )
670
666
 
671
667
 
672
668
  def feature_checkpoint_metadata(artifact_dir, stage="plan",
@@ -1268,8 +1264,9 @@ def main():
1268
1264
  )
1269
1265
 
1270
1266
  if not args.no_checkpoint_write:
1271
- with open(checkpoint_path, "w", encoding="utf-8") as f:
1272
- json.dump(checkpoint, f, indent=2, ensure_ascii=False)
1267
+ err = write_json_file(checkpoint_path, checkpoint)
1268
+ if err:
1269
+ emit_failure(err)
1273
1270
  LOGGER.info("Wrote checkpoint to %s", checkpoint_path)
1274
1271
 
1275
1272
  if is_continuation(args):
@@ -27,15 +27,28 @@ from prompt_framework import (
27
27
  validate_rendered,
28
28
  write_output,
29
29
  )
30
- from utils import enrich_global_context, helper_replacements, load_json_file, read_checkpoint_system_section, resolve_prompt_platform, setup_logging
30
+ from utils import (
31
+ enrich_global_context,
32
+ helper_replacements,
33
+ load_json_file,
34
+ read_checkpoint_system_section,
35
+ resolve_prompt_platform,
36
+ setup_logging,
37
+ write_json_file,
38
+ )
31
39
 
32
40
 
33
41
  LOGGER = setup_logging("generate-bugfix-prompt")
34
42
 
35
43
 
36
- def route_bugfix_repair(stage_result, repair_scope=None, repair_round=0):
44
+ def route_bugfix_repair(stage_result, repair_scope=None, repair_round=0, *, production_changed=False):
37
45
  """Map Bugfix review/test outcomes to the shared safe route contract."""
38
- return route_pipeline_repair(stage_result, repair_scope, repair_round)
46
+ return route_pipeline_repair(
47
+ stage_result,
48
+ repair_scope,
49
+ repair_round,
50
+ production_changed=production_changed,
51
+ )
39
52
 
40
53
 
41
54
  def bugfix_checkpoint_metadata(artifact_dir, stage="plan",
@@ -459,11 +472,7 @@ def generate_bugfix_checkpoint(
459
472
 
460
473
  def merge_bugfix_checkpoint_state(existing, fresh, project_root):
461
474
  """Merge existing bugfix checkpoint state into fresh definition."""
462
- merged = merge_checkpoint_state(existing, fresh, project_root, logger=LOGGER)
463
- existing_state = existing.get("bugfix_state")
464
- if isinstance(existing_state, dict):
465
- merged["bugfix_state"] = existing_state
466
- return merged
475
+ return merge_checkpoint_state(existing, fresh, project_root, logger=LOGGER)
467
476
 
468
477
 
469
478
  def emit_failure(message):
@@ -566,8 +575,9 @@ def main():
566
575
  LOGGER.warning("Existing bugfix checkpoint corrupted (%s) — generating fresh", exc)
567
576
 
568
577
  if not args.no_checkpoint_write:
569
- with open(checkpoint_path, "w", encoding="utf-8") as f:
570
- json.dump(checkpoint, f, indent=2, ensure_ascii=False)
578
+ err = write_json_file(checkpoint_path, checkpoint)
579
+ if err:
580
+ emit_failure(err)
571
581
  LOGGER.info("Wrote bugfix checkpoint to %s", checkpoint_path)
572
582
 
573
583
  if is_continuation(args):
@@ -15,7 +15,7 @@ import re
15
15
  import sys
16
16
  from datetime import datetime, timezone
17
17
 
18
- from utils import stable_topological_order
18
+ from utils import stable_topological_order, write_json_file
19
19
 
20
20
 
21
21
  EXPECTED_SCHEMA = "dev-pipeline-bug-fix-list-v1"
@@ -48,6 +48,7 @@ ALLOWED_BUG_FIELDS = set(REQUIRED_BUG_FIELDS) | {
48
48
  "user_context",
49
49
  "browser_interaction",
50
50
  "model",
51
+ "completion_notes",
51
52
  }
52
53
 
53
54
  VALID_SEVERITIES = ["critical", "high", "medium", "low"]
@@ -310,9 +311,9 @@ def create_state_directory(state_dir, bug_list_path, bugs):
310
311
  "completed_bugs": completed_count,
311
312
  }
312
313
  pipeline_path = os.path.join(abs_state_dir, "pipeline.json")
313
- with open(pipeline_path, "w", encoding="utf-8") as f:
314
- json.dump(pipeline_state, f, indent=2, ensure_ascii=False)
315
- f.write("\n")
314
+ err = write_json_file(pipeline_path, pipeline_state)
315
+ if err:
316
+ raise OSError(err)
316
317
 
317
318
  # Write per-bug status.json and create sessions directory
318
319
  for bug in bugs:
@@ -337,9 +338,11 @@ def create_state_directory(state_dir, bug_list_path, bugs):
337
338
  "updated_at": now,
338
339
  }
339
340
  status_path = os.path.join(bug_dir, "status.json")
340
- with open(status_path, "w", encoding="utf-8") as f:
341
- json.dump(bug_status, f, indent=2, ensure_ascii=False)
342
- f.write("\n")
341
+ if os.path.exists(status_path):
342
+ continue
343
+ err = write_json_file(status_path, bug_status)
344
+ if err:
345
+ raise OSError(err)
343
346
 
344
347
  return abs_state_dir
345
348
 
@@ -14,6 +14,12 @@ import os
14
14
  import sys
15
15
  from datetime import datetime, timezone
16
16
 
17
+ _PIPELINE_ROOT = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
18
+ if _PIPELINE_ROOT not in sys.path:
19
+ sys.path.insert(0, _PIPELINE_ROOT)
20
+
21
+ from prizmkit_runtime.atomic_io import write_json_atomic # noqa: E402
22
+
17
23
 
18
24
  def parse_args():
19
25
  parser = argparse.ArgumentParser(
@@ -42,6 +48,17 @@ def create_directories(project_root, feature_slug=None):
42
48
  dirs_to_create = []
43
49
 
44
50
  if feature_slug:
51
+ if (
52
+ os.path.isabs(feature_slug)
53
+ or "/" in feature_slug
54
+ or "\\" in feature_slug
55
+ or feature_slug in {".", ".."}
56
+ ):
57
+ raise ValueError(f"Invalid feature_slug '{feature_slug}'")
58
+ specs_root = os.path.realpath(os.path.join(project_root, ".prizmkit", "specs"))
59
+ target_dir = os.path.realpath(os.path.join(specs_root, feature_slug))
60
+ if os.path.commonpath([specs_root, target_dir]) != specs_root or target_dir == specs_root:
61
+ raise ValueError(f"feature_slug escapes .prizmkit/specs: '{feature_slug}'")
45
62
  dirs_to_create.extend([
46
63
  ".prizmkit/specs/{}".format(feature_slug),
47
64
  ])
@@ -65,8 +82,12 @@ def init_prizmkit_config(project_root, feature_id):
65
82
  config_path = os.path.join(project_root, ".prizmkit", "config.json")
66
83
 
67
84
  if os.path.exists(config_path):
68
- with open(config_path, "r", encoding="utf-8") as f:
69
- config = json.load(f)
85
+ try:
86
+ with open(config_path, "r", encoding="utf-8") as f:
87
+ loaded = json.load(f)
88
+ config = loaded if isinstance(loaded, dict) else {}
89
+ except (json.JSONDecodeError, IOError):
90
+ config = {}
70
91
  config["current_feature"] = feature_id
71
92
  config["updated_at"] = datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
72
93
  else:
@@ -89,8 +110,8 @@ def init_prizmkit_config(project_root, feature_id):
89
110
  "current_feature": feature_id,
90
111
  }
91
112
 
92
- with open(config_path, "w", encoding="utf-8") as f:
93
- json.dump(config, f, indent=2)
113
+ os.makedirs(os.path.dirname(config_path), exist_ok=True)
114
+ write_json_atomic(config_path, config)
94
115
 
95
116
  return config_path
96
117
 
@@ -13,10 +13,9 @@ import json
13
13
  import os
14
14
  import re
15
15
  import sys
16
- from collections import deque
17
16
  from datetime import datetime, timezone
18
17
 
19
- from utils import stable_topological_order
18
+ from utils import stable_topological_order, write_json_file
20
19
 
21
20
 
22
21
  EXPECTED_SCHEMA = "dev-pipeline-feature-list-v1"
@@ -237,67 +236,13 @@ def validate_features(features):
237
236
 
238
237
 
239
238
  def check_dag(features):
240
- """Check that feature dependencies form a DAG (no cycles) using topological sort.
241
-
242
- Uses Kahn's algorithm. Returns a list of errors if cycles are detected.
243
- """
244
- # Build adjacency list and in-degree count
245
- adj = {} # feature_id -> list of features that depend on it
246
- in_degree = {}
247
- feature_map = {}
248
-
249
- for feature in features:
250
- if not isinstance(feature, dict):
251
- continue
252
- fid = feature.get("id")
253
- if fid is None:
254
- continue
255
- feature_map[fid] = feature
256
- if fid not in adj:
257
- adj[fid] = []
258
- if fid not in in_degree:
259
- in_degree[fid] = 0
260
-
261
- for feature in features:
262
- if not isinstance(feature, dict):
263
- continue
264
- fid = feature.get("id")
265
- deps = feature.get("dependencies", [])
266
- if not isinstance(deps, list) or fid is None:
267
- continue
268
- for dep in deps:
269
- if dep in adj:
270
- # dep -> fid (fid depends on dep, so dep must come first)
271
- adj[dep].append(fid)
272
- in_degree[fid] = in_degree.get(fid, 0) + 1
273
-
274
- # Kahn's algorithm
275
- queue = deque()
276
- for fid in in_degree:
277
- if in_degree[fid] == 0:
278
- queue.append(fid)
279
-
280
- sorted_count = 0
281
- while queue:
282
- node = queue.popleft()
283
- sorted_count += 1
284
- for neighbor in adj.get(node, []):
285
- in_degree[neighbor] -= 1
286
- if in_degree[neighbor] == 0:
287
- queue.append(neighbor)
288
-
289
- if sorted_count != len(feature_map):
290
- # Find which features are part of cycles
291
- cycle_members = [
292
- fid for fid, deg in in_degree.items() if deg > 0
293
- ]
294
- return [
295
- "Dependency cycle detected involving features: {}".format(
296
- ", ".join(sorted(cycle_members))
297
- )
298
- ]
299
-
300
- return []
239
+ """Check that feature dependencies form a DAG (no cycles)."""
240
+ return stable_topological_order(
241
+ features,
242
+ id_key="id",
243
+ dependencies_key="dependencies",
244
+ item_label="Feature",
245
+ )[1]
301
246
 
302
247
 
303
248
  def create_state_directory(state_dir, feature_list_path, features):
@@ -331,9 +276,9 @@ def create_state_directory(state_dir, feature_list_path, features):
331
276
  "completed_features": completed_count,
332
277
  }
333
278
  pipeline_path = os.path.join(abs_state_dir, "pipeline.json")
334
- with open(pipeline_path, "w", encoding="utf-8") as f:
335
- json.dump(pipeline_state, f, indent=2, ensure_ascii=False)
336
- f.write("\n")
279
+ err = write_json_file(pipeline_path, pipeline_state)
280
+ if err:
281
+ raise OSError(err)
337
282
 
338
283
  # Write per-feature status.json and create sessions directory
339
284
  for feature in features:
@@ -360,9 +305,9 @@ def create_state_directory(state_dir, feature_list_path, features):
360
305
  status_path = os.path.join(feature_dir, "status.json")
361
306
  if os.path.exists(status_path):
362
307
  continue
363
- with open(status_path, "w", encoding="utf-8") as f:
364
- json.dump(feature_status, f, indent=2, ensure_ascii=False)
365
- f.write("\n")
308
+ err = write_json_file(status_path, feature_status)
309
+ if err:
310
+ raise OSError(err)
366
311
 
367
312
  return abs_state_dir
368
313