prizmkit 1.1.130 → 1.1.134

package/bundled/dev-pipeline/tests/test_generate_bugfix_prompt.py

@@ -13,8 +13,12 @@ from generate_bugfix_prompt import (
     format_error_source_details,
     format_environment,
     generate_bugfix_checkpoint,
+    bugfix_checkpoint_metadata,
+    merge_bugfix_checkpoint_state,
+    route_bugfix_repair,
     process_conditional_blocks,
     render_template,
+    assemble_bugfix_sections,
 )
 from continuation import append_continuation_handoff
 
@@ -312,6 +316,11 @@ def test_template_source_is_clean_for_headless_prompt_contract():
     content = Path("dev-pipeline/templates/bugfix-bootstrap-prompt.md").read_text(encoding="utf-8")
     for forbidden in HEADLESS_FORBIDDEN_PROMPT_STRINGS:
         assert forbidden not in content
+    assert "FAST_PATH=true" not in content
+    assert "prizmkit-workflow" not in content
+    assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/bugfix/{{BUG_ID}}/" in content
+    assert "local_commit_authorized=true" in content
+    assert "push_authorized" not in content
 
 
 def test_bugfix_prompt_keeps_fine_grained_phases_out_of_external_status_contract():
@@ -455,6 +464,126 @@ class TestBugfixBootstrapShellExtraction:
 
 
 class TestBugfixCheckpointGeneration:
+    def test_checkpoint_merge_preserves_family_handoff_state(self, tmp_path):
+        fresh = generate_bugfix_checkpoint("B-001", "new")
+        existing = generate_bugfix_checkpoint("B-001", "old")
+        existing["bugfix_state"] = bugfix_checkpoint_metadata(
+            ".prizmkit/bugfix/B-001",
+            stage="test",
+            status="TEST_BLOCKED",
+            stage_result="TEST_BLOCKED",
+            repair_round=2,
+            next_stage="prizmkit-test",
+            resume_from="prizmkit-test",
+        )
+
+        merged = merge_bugfix_checkpoint_state(existing, fresh, str(tmp_path))
+
+        assert merged["bugfix_state"]["stage_result"] == "TEST_BLOCKED"
+        assert merged["bugfix_state"]["resume_from"] == "prizmkit-test"
+
+    def test_default_checkpoint_has_all_atomic_gates_in_order(self):
+        checkpoint = generate_bugfix_checkpoint("B-001", "session-1")
+
+        assert [step["skill"] for step in checkpoint["steps"]] == [
+            "prizmkit-init",
+            "bug-diagnosis-and-plan",
+            "prizmkit-implement",
+            "prizmkit-code-review",
+            "prizmkit-test",
+            "prizmkit-retrospective",
+            "prizmkit-committer",
+            "bug-report",
+        ]
+        test_step = checkpoint["steps"][4]
+        assert test_step["depends_on"] == "S04"
+        assert test_step["required_artifacts"] == [
+            ".prizmkit/test/evidence/*/manifest.json",
+            ".prizmkit/test/evidence/*/verdict.json",
+            ".prizmkit/test/evidence/*/validation.json",
+        ]
+        assert checkpoint["steps"][5]["depends_on"] == "S05"
+
+    def test_bugfix_repair_routing_preserves_review_and_test_boundaries(self):
+        review = route_bugfix_repair("REVIEW_NEEDS_FIXES", repair_round=0)
+        test_infra = route_bugfix_repair(
+            "TEST_FAIL", "test-infrastructure", repair_round=1,
+        )
+        production = route_bugfix_repair("TEST_FAIL", "public-interface", repair_round=2)
+
+        assert review["route"] == [
+            "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
+        ]
+        assert test_infra["route"] == ["prizmkit-implement", "prizmkit-test"]
+        assert production["route"] == [
+            "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
+        ]
+        assert production["repair_round"] == 3
+
+    def test_bugfix_repair_routing_blocks_unsafe_blocked_and_exhausted_results(self):
+        unknown = route_bugfix_repair("TEST_FAIL", "unknown", repair_round=1)
+        blocked = route_bugfix_repair("TEST_BLOCKED", "production", repair_round=1)
+        exhausted = route_bugfix_repair("TEST_FAIL", "production", repair_round=3)
+
+        assert unknown["blocked"] is True
+        assert unknown["route"] == []
+        assert blocked["blocked"] is True
+        assert blocked["resumable"] is False
+        assert blocked["next_stage"] is None
+        assert blocked["terminal_status"] == "WORKFLOW_BLOCKED"
+        assert blocked["blocked_reason"] == "test_blocked"
+        assert blocked["route"] == []
+        assert "cannot safely edit production" in blocked["reason"]
+        assert exhausted["blocked"] is True
+        assert exhausted["repair_round"] == 3
+
+    def test_bugfix_checkpoint_metadata_preserves_artifact_and_evidence_handoff(self):
+        metadata = bugfix_checkpoint_metadata(
+            ".prizmkit/bugfix/B-001",
+            evidence={
+                "manifest_path": ".prizmkit/test/evidence/id/manifest.json",
+                "verdict_path": ".prizmkit/test/evidence/id/verdict.json",
+                "validation_path": ".prizmkit/test/evidence/id/validation.json",
+            },
+            stage="test",
+            status="TEST_FAIL",
+            stage_result="TEST_FAIL",
+            repair_scope="test-infrastructure",
+            repair_round=2,
+        )
+
+        assert metadata["artifact_dir"] == ".prizmkit/bugfix/B-001"
+        assert metadata["authoritative_evidence_paths"]["validation"].endswith(
+            "/validation.json"
+        )
+        assert metadata["repair_round"] == 2
+        assert metadata["resume_from"] == "prizmkit-implement"
+
+    def test_manual_bugfix_uses_automatic_verification_and_keeps_commit_gate(self):
+        sections = assemble_bugfix_sections(
+            "standard", "dev-pipeline/templates/sections", False, True,
+        )
+        names = [name for name, _ in sections]
+
+        assert "bugfix-manual-gate" in names
+        assert "headless-commit-authorization" in names
+        assert "bugfix-phase-commit-report" in names
+
+    def test_rendered_bugfix_prompt_is_atomic_headless_and_local_commit_only(self, tmp_path):
+        prompt = _render_bugfix_prompt(tmp_path)
+
+        assert prompt.index("/prizmkit-code-review") < prompt.index(
+            "/prizmkit-test scope=this-change artifact_dir=.prizmkit/bugfix/B-001/"
+        ) < prompt.index("### Headless Commit Authorization")
+        assert "FAST_PATH=true" not in prompt
+        assert "prizmkit-workflow" not in prompt
+        assert '"local_commit_authorized": true' in prompt
+        assert "push_authorized" not in prompt
+        assert "Do not ask questions, wait for user input" in prompt
+        assert "Remote publication is controlled by the runtime" in prompt
+        assert "push_authorized\": true" not in prompt
+        assert ".prizmkit/bugfix/B-001/" in prompt
+
     def test_setup_section_skips_and_finalization_group_expands(self):
         checkpoint = generate_bugfix_checkpoint(
             "B-001",

package/bundled/dev-pipeline/tests/test_generate_refactor_prompt.py

@@ -10,6 +10,8 @@ from generate_refactor_prompt import (
     build_replacements,
     generate_refactor_checkpoint,
     merge_refactor_checkpoint_state,
+    refactor_checkpoint_metadata,
+    route_refactor_repair,
 )
 
 REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
@@ -54,12 +56,24 @@ class TestRefactorCheckpointMerge:
     def test_preserves_skipped_without_artifacts(self, tmp_path):
         fresh = generate_refactor_checkpoint("R-008", "R-008-new")
         existing = generate_refactor_checkpoint("R-008", "R-008-old")
+        existing["refactor_state"] = refactor_checkpoint_metadata(
+            ".prizmkit/refactor/R-008",
+            stage="test",
+            status="TEST_FAIL",
+            stage_result="TEST_FAIL",
+            repair_scope="public-interface",
+            repair_round=2,
+            next_stage="prizmkit-implement",
+            resume_from="prizmkit-implement",
+        )
         existing["steps"][0]["status"] = "skipped"
 
         merged = merge_refactor_checkpoint_state(existing, fresh, str(tmp_path))
 
         assert merged["steps"][0]["status"] == "skipped"
         assert merged["steps"][1]["status"] == "pending"
+        assert merged["refactor_state"]["repair_scope"] == "public-interface"
+        assert merged["refactor_state"]["repair_round"] == 2
 
 
 class TestExplicitProjectRoot:
@@ -197,6 +211,11 @@ def test_template_source_is_clean_for_headless_prompt_contract():
     content = Path("dev-pipeline/templates/refactor-bootstrap-prompt.md").read_text(encoding="utf-8")
     for forbidden in HEADLESS_FORBIDDEN_PROMPT_STRINGS:
         assert forbidden not in content
+    assert "prizmkit-workflow" not in content
+    assert "/prizmkit-test scope=this-change artifact_dir=.prizmkit/refactor/{{REFACTOR_ID}}/" in content
+    assert "local_commit_authorized=true" in content
+    assert "push_authorized" not in content
+    assert "Behavior-preservation checks remain supporting evidence" in content
 
 
 # ---------------------------------------------------------------------------
@@ -315,6 +334,78 @@ class TestRefactorBootstrapShellExtraction:
 
 
 class TestRefactorCheckpointGeneration:
+    def test_default_checkpoint_has_all_atomic_gates_in_order(self):
+        checkpoint = generate_refactor_checkpoint("R-001", "session-1")
+
+        assert [step["skill"] for step in checkpoint["steps"]] == [
+            "prizmkit-init",
+            "prizmkit-plan",
+            "prizmkit-implement",
+            "prizmkit-code-review",
+            "prizmkit-test",
+            "prizmkit-retrospective",
+            "prizmkit-committer",
+            "refactor-report",
+            "completion-summary",
+        ]
+        assert checkpoint["steps"][4]["depends_on"] == "S04"
+        assert checkpoint["steps"][5]["depends_on"] == "S05"
+
+    def test_refactor_repair_routing_preserves_behavior_review_and_test(self):
+        test_infra = route_refactor_repair(
+            "TEST_FAIL", "test-infrastructure", repair_round=1,
+        )
+        production = route_refactor_repair("TEST_FAIL", "public-interface", repair_round=1)
+        blocked = route_refactor_repair("TEST_BLOCKED", "production", repair_round=1)
+
+        assert test_infra["route"] == ["prizmkit-implement", "prizmkit-test"]
+        assert production["route"] == [
+            "prizmkit-implement", "prizmkit-code-review", "prizmkit-test",
+        ]
+        unknown = route_refactor_repair("TEST_FAIL", "contract", repair_round=1)
+        exhausted = route_refactor_repair("TEST_FAIL", "production", repair_round=3)
+        assert unknown["blocked"] is True
+        assert unknown["route"] == []
+        assert exhausted["blocked"] is True
+        assert exhausted["repair_round"] == 3
+        assert blocked["blocked"] is True
+        assert blocked["route"] == []
+        assert blocked["next_stage"] is None
+        assert blocked["terminal_status"] == "WORKFLOW_BLOCKED"
+        assert blocked["blocked_reason"] == "test_blocked"
+
+    def test_refactor_checkpoint_metadata_preserves_artifact_and_evidence_handoff(self):
+        metadata = refactor_checkpoint_metadata(
+            ".prizmkit/refactor/R-001",
+            evidence={"manifest_path": "manifest.json"},
+            stage="test",
+            status="TEST_PASS",
+            stage_result="TEST_PASS",
+            next_stage="prizmkit-retrospective",
+            resume_from="prizmkit-retrospective",
+        )
+
+        assert metadata["artifact_dir"] == ".prizmkit/refactor/R-001"
+        assert metadata["authoritative_evidence_paths"]["manifest"] == "manifest.json"
+        assert metadata["next_stage"] == "prizmkit-retrospective"
+        assert metadata["resume_from"] == "prizmkit-retrospective"
+
+    def test_rendered_refactor_prompt_is_atomic_headless_and_local_commit_only(self, tmp_path):
+        prompt = _render_refactor_prompt_full(tmp_path)
+
+        assert prompt.index("/prizmkit-code-review") < prompt.index(
+            "/prizmkit-test scope=this-change artifact_dir=.prizmkit/refactor/R-001/"
+        ) < prompt.index("### Headless Commit Authorization")
+        assert "prizmkit-workflow" not in prompt
+        assert "Behavior-preservation checks collected during planning and implementation remain supporting evidence" in prompt
+        assert '"local_commit_authorized": true' in prompt
+        assert "push_authorized" not in prompt
+        assert "Remote publication is controlled by the runtime" in prompt
+        assert "automatic push" not in prompt.lower()
+        assert "push_authorized\": true" not in prompt
+
+
+class TestRefactorCheckpointGenerationLegacy:
     def test_setup_section_is_step_and_finalization_group_expands(self):
         checkpoint = generate_refactor_checkpoint(
             "R-001",