prizmkit 1.1.127 → 1.1.129

package/bundled/skills/prizmkit-code-review/references/review-report-template.md

@@ -16,17 +16,6 @@ Within that execution, append sections only. Never edit or replace an earlier pr
 
 ## Progress Sections
 
-### Risk Assessment
-
-```markdown
-## Risk Assessment
-
-- Risk: <low|medium|high>
-- Independent Reviewer Limit: <0|1|2>
-- Reasons:
-  - <concrete behavioral reason>
-```
-
 ### Main-Agent Review Round
 
 ```markdown
@@ -36,6 +25,7 @@ Within that execution, append sections only. Never edit or replace an earlier pr
 - Findings: <count>
 - Accepted: <count>
 - Rejected: <count>
+- Unresolved: <count>
 - Next: <next action>
 ```
 
@@ -44,34 +34,18 @@ Within that execution, append sections only. Never edit or replace an earlier pr
 ```markdown
 ## Repair Verification
 
-- Source: <main|reviewer-1|reviewer-2>
 - Fixed Findings: <count>
 - Verification: <evidence summary>
 - Next: <next action>
 ```
 
-### Independent Reviewer Running
-
-```markdown
-## Independent Reviewer <N>
-
-- Status: RUNNING
-- Risk Trigger: <medium|high>
-- Attempt: <1|2>
-```
-
-### Independent Reviewer Result
+### Final Verification
 
 ```markdown
-## Independent Reviewer <N> Result
+## Final Verification
 
-- Status: <COMPLETED|BLOCKED>
-- Result: <PASS|FINDINGS|BLOCKED>
-- Findings: <count>
-- Accepted: <count>
-- Rejected: <count>
-- Accepted High: <count>
-- Next: <next action>
+- Status: <COMPLETED|FAILED>
+- Evidence: <evidence summary>
 ```
 
 ## Final Result
@@ -81,10 +55,8 @@ Exactly one Final Result terminates a completed execution:
 ```markdown
 ## Final Result
 
-- Verdict: <PASS|NEEDS_FIXES|BLOCKED>
-- Risk: <low|medium|high>
+- Verdict: <PASS | NEEDS_FIXES>
 - Main Review Rounds: <count>
-- Independent Reviewers Started: <count>
 - Accepted Findings: <count>
 - Fixed Findings: <count>
 - Rejected Findings: <count>
@@ -96,8 +68,9 @@ Exactly one Final Result terminates a completed execution:
 
 - Start of a new execution removes stale progress and terminal results from prior executions.
 - A phase appends its result before the next phase starts.
-- Append RUNNING before each independent Reviewer launch or retry.
-- Do not modify a RUNNING section after completion; append its Result section.
+- Finding counts satisfy `accepted + rejected + unresolved = findings`.
+- `PASS` requires every accepted finding fixed and zero unresolved findings.
+- `NEEDS_FIXES` requires at least one unfixed accepted or unresolved finding.
 - An IN_PROGRESS report without Final Result is incomplete.
 - Generic or incidental verdict text outside the last Final Result does not prove completion.
 - Do not append any section after Final Result.

package/bundled/skills/prizmkit-code-review/scripts/render_review_report.py

@@ -9,15 +9,10 @@ import sys
 from pathlib import Path
 from typing import Any
 
-VERDICTS = {"PASS", "NEEDS_FIXES", "BLOCKED"}
-RISKS = {"low", "medium", "high"}
+VERDICTS = {"PASS", "NEEDS_FIXES"}
 EVENTS = {
-    "risk-assessment",
     "main-review-round",
     "repair-verification",
-    "reviewer-running",
-    "reviewer-result",
-    "infrastructure-failure",
     "final-verification",
 }
 FINAL_HEADING = "## Final Result"
@@ -49,13 +44,6 @@ def _require_count(data: dict[str, Any], name: str, *, maximum: int | None = Non
     return value
 
 
-def _require_risk(data: dict[str, Any]) -> str:
-    risk = data.get("risk")
-    if risk not in RISKS:
-        raise ReportStateError(f"risk has invalid value: {risk!r}")
-    return risk
-
-
 def _report_text(path: Path) -> str:
     try:
         return path.read_text(encoding="utf-8")
@@ -87,24 +75,6 @@ def _render_event(data: dict[str, Any]) -> str:
     if event not in EVENTS:
         raise ReportStateError(f"event has invalid value: {event!r}")
 
-    if event == "risk-assessment":
-        risk = _require_risk(data)
-        reasons = data.get("reasons")
-        if not isinstance(reasons, list) or not reasons or not all(
-            isinstance(reason, str) and reason.strip() for reason in reasons
-        ):
-            raise ReportStateError("reasons must be a non-empty string array")
-        limit = {"low": 0, "medium": 1, "high": 2}[risk]
-        lines = [
-            "## Risk Assessment",
-            "",
-            f"- Risk: {risk}",
-            f"- Independent Reviewer Limit: {limit}",
-            "- Reasons:",
-        ]
-        lines.extend(f"  - {reason.strip()}" for reason in reasons)
-        return "\n".join(lines)
-
     if event == "main-review-round":
         round_number = _require_count(data, "round", maximum=10)
         if round_number < 1:
@@ -112,8 +82,11 @@ def _render_event(data: dict[str, Any]) -> str:
         findings = _require_count(data, "findings")
         accepted = _require_count(data, "accepted")
         rejected = _require_count(data, "rejected")
-        if accepted + rejected != findings:
-            raise ReportStateError("accepted + rejected must equal findings")
+        unresolved = _require_count(data, "unresolved")
+        if accepted + rejected + unresolved != findings:
+            raise ReportStateError(
+                "accepted + rejected + unresolved must equal findings"
+            )
         return "\n".join(
             [
                 f"## Main Review Round {round_number}",
@@ -122,93 +95,30 @@ def _render_event(data: dict[str, Any]) -> str:
                 f"- Findings: {findings}",
                 f"- Accepted: {accepted}",
                 f"- Rejected: {rejected}",
+                f"- Unresolved: {unresolved}",
                 f"- Next: {_require_text(data, 'next')}",
             ]
         )
 
     if event == "repair-verification":
-        source = _require_text(data, "source")
-        if source not in {"main", "reviewer-1", "reviewer-2"}:
-            raise ReportStateError(f"source has invalid value: {source!r}")
         return "\n".join(
             [
                 "## Repair Verification",
                 "",
-                f"- Source: {source}",
                 f"- Fixed Findings: {_require_count(data, 'fixed_findings')}",
                 f"- Verification: {_require_text(data, 'verification')}",
                 f"- Next: {_require_text(data, 'next')}",
             ]
         )
 
-    if event == "reviewer-running":
-        reviewer = _require_count(data, "reviewer", maximum=2)
-        if reviewer < 1:
-            raise ReportStateError("reviewer must be 1 or 2")
-        risk = _require_risk(data)
-        if risk == "low" or (risk == "medium" and reviewer == 2):
-            raise ReportStateError("reviewer exceeds the semantic risk limit")
-        attempt = data.get("attempt", 1)
-        if attempt not in {1, 2}:
-            raise ReportStateError("attempt must be 1 or 2")
-        return "\n".join(
-            [
-                f"## Independent Reviewer {reviewer}",
-                "",
-                "- Status: RUNNING",
-                f"- Risk Trigger: {risk}",
-                f"- Attempt: {attempt}",
-            ]
-        )
-
-    if event == "reviewer-result":
-        reviewer = _require_count(data, "reviewer", maximum=2)
-        if reviewer < 1:
-            raise ReportStateError("reviewer must be 1 or 2")
-        result = data.get("result")
-        if result not in {"PASS", "FINDINGS", "BLOCKED"}:
-            raise ReportStateError(f"result has invalid value: {result!r}")
-        findings = _require_count(data, "findings")
-        accepted = _require_count(data, "accepted")
-        rejected = _require_count(data, "rejected")
-        accepted_high = _require_count(data, "accepted_high")
-        if accepted + rejected != findings or accepted_high > accepted:
-            raise ReportStateError("reviewer finding counts are inconsistent")
-        status = "BLOCKED" if result == "BLOCKED" else "COMPLETED"
-        return "\n".join(
-            [
-                f"## Independent Reviewer {reviewer} Result",
-                "",
-                f"- Status: {status}",
-                f"- Result: {result}",
-                f"- Findings: {findings}",
-                f"- Accepted: {accepted}",
-                f"- Rejected: {rejected}",
-                f"- Accepted High: {accepted_high}",
-                f"- Next: {_require_text(data, 'next')}",
-            ]
-        )
-
-    if event == "infrastructure-failure":
-        reviewer = _require_count(data, "reviewer", maximum=2)
-        attempt = _require_count(data, "attempt", maximum=2)
-        if reviewer < 1 or attempt < 1:
-            raise ReportStateError("reviewer and attempt must be at least 1")
-        return "\n".join(
-            [
-                f"## Independent Reviewer {reviewer} Infrastructure Failure",
-                "",
-                f"- Attempt: {attempt}",
-                f"- Evidence: {_require_text(data, 'evidence')}",
-                f"- Next: {_require_text(data, 'next')}",
-            ]
-        )
-
+    status = _require_text(data, "status")
+    if status not in {"COMPLETED", "FAILED"}:
+        raise ReportStateError(f"status has invalid value: {status!r}")
     return "\n".join(
         [
             "## Final Verification",
             "",
-            f"- Status: {_require_text(data, 'status')}",
+            f"- Status: {status}",
             f"- Evidence: {_require_text(data, 'evidence')}",
         ]
     )
@@ -227,28 +137,28 @@ def append_final_result(path: Path, data: Any) -> None:
     verdict = valid.get("verdict")
     if verdict not in VERDICTS:
         raise ReportStateError(f"verdict has invalid value: {verdict!r}")
-    risk = _require_risk(valid)
     main_rounds = _require_count(valid, "main_review_rounds", maximum=10)
-    reviewers = _require_count(valid, "independent_reviewers_started", maximum=2)
-    if reviewers > {"low": 0, "medium": 1, "high": 2}[risk]:
-        raise ReportStateError("independent_reviewers_started exceeds risk limit")
     accepted = _require_count(valid, "accepted_findings")
     fixed = _require_count(valid, "fixed_findings")
     rejected = _require_count(valid, "rejected_findings")
     unresolved = _require_count(valid, "unresolved_findings")
-    if verdict == "PASS" and unresolved:
-        raise ReportStateError("PASS cannot contain unresolved findings")
-    if verdict == "NEEDS_FIXES" and not unresolved:
-        raise ReportStateError("NEEDS_FIXES requires unresolved findings")
+    if fixed > accepted:
+        raise ReportStateError("fixed_findings cannot exceed accepted_findings")
+    if verdict == "PASS" and (unresolved or fixed != accepted):
+        raise ReportStateError(
+            "PASS requires every accepted finding fixed and no unresolved findings"
+        )
+    if verdict == "NEEDS_FIXES" and not unresolved and fixed == accepted:
+        raise ReportStateError(
+            "NEEDS_FIXES requires an unfixed accepted or unresolved finding"
+        )
 
     section = "\n".join(
         [
             FINAL_HEADING,
             "",
             f"- Verdict: {verdict}",
-            f"- Risk: {risk}",
             f"- Main Review Rounds: {main_rounds}",
-            f"- Independent Reviewers Started: {reviewers}",
             f"- Accepted Findings: {accepted}",
             f"- Fixed Findings: {fixed}",
             f"- Rejected Findings: {rejected}",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prizmkit",
-  "version": "1.1.127",
+  "version": "1.1.129",
   "description": "Create a new PrizmKit-powered project with clean initialization — no framework dev files, just what you need.",
   "type": "module",
   "bin": {

package/src/manifest.js

@@ -19,6 +19,7 @@ const MANIFEST_DIR = '.prizmkit';
  * Read the manifest from a project directory.
  * @param {string} projectRoot
  * @returns {Promise<Object|null>} parsed manifest or null if not found
+ * @throws {Error} when a present manifest cannot be read or parsed
  */
 export async function readManifest(projectRoot) {
   const manifestPath = path.join(projectRoot, MANIFEST_DIR, MANIFEST_FILE);
@@ -26,9 +27,13 @@ export async function readManifest(projectRoot) {
     return null;
   }
   try {
-    return await fs.readJSON(manifestPath);
-  } catch {
-    return null;
+    const manifest = await fs.readJSON(manifestPath);
+    if (manifest === null || Array.isArray(manifest) || typeof manifest !== 'object') {
+      throw new TypeError('manifest root must be a JSON object');
+    }
+    return manifest;
+  } catch (error) {
+    throw new Error(`Failed to read PrizmKit manifest at ${manifestPath}: ${error.message}`, { cause: error });
   }
 }
 

package/src/scaffold.js

@@ -81,6 +81,7 @@ const RETIRED_POWERSHELL_RUNTIME_FILES = new Set([
   'lib/heartbeat.ps1',
 ]);
 const LEGACY_TEAM_NAME = ['prizm', 'dev', 'team'].join('-');
+const RETIRED_CODE_REVIEW_AGENT_BASENAME = 'prizmkit-code-reviewer';
 const LEGACY_AGENT_BASENAMES = [
   `${LEGACY_TEAM_NAME}-dev`,
   `${LEGACY_TEAM_NAME}-reviewer`,
@@ -102,7 +103,10 @@ export async function removeRetiredAgentTeamArtifacts(platform, projectRoot, dry
       : path.join(projectRoot, '.codebuddy', 'agents');
   const agentExtensions = platform === 'codex' ? ['.toml', '.md'] : ['.md'];
 
-  for (const basename of LEGACY_AGENT_BASENAMES) {
+  const retiredBasenames = platform === 'claude'
+    ? [...LEGACY_AGENT_BASENAMES, RETIRED_CODE_REVIEW_AGENT_BASENAME]
+    : LEGACY_AGENT_BASENAMES;
+  for (const basename of retiredBasenames) {
     for (const extension of agentExtensions) {
       const filePath = path.join(agentDir, `${basename}${extension}`);
       if (!await fs.pathExists(filePath)) continue;
@@ -226,12 +230,10 @@ export async function installSkills(platform, skills, projectRoot, dryRun, runti
 
   // Load Claude command adapter for skill conversion
   let convertSkillToCommand;
-  let getClaudeSkillAgentDefinitions;
   let convertSkillToCodex;
   if (platform === 'claude') {
     const commandAdapter = await loadAdapter('claude', 'command-adapter.js');
     convertSkillToCommand = commandAdapter.convertSkillToCommand;
-    getClaudeSkillAgentDefinitions = commandAdapter.getClaudeSkillAgentDefinitions;
   } else if (platform === 'codex') {
     const codexSkillAdapter = await loadAdapter('codex', 'skill-adapter.js');
     convertSkillToCodex = codexSkillAdapter.convertSkill;
@@ -323,19 +325,6 @@ export async function installSkills(platform, skills, projectRoot, dryRun, runti
           await fs.copy(path.join(corePath, subdir), path.join(assetTargetDir, subdir));
         }
       }
-
-      const roleManifestPath = path.join(corePath, 'assets', 'reviewer-role.json');
-      const roleManifest = await fs.pathExists(roleManifestPath)
-        ? await fs.readJson(roleManifestPath)
-        : null;
-      const agentDefinitions = getClaudeSkillAgentDefinitions(skillName, roleManifest);
-      if (agentDefinitions.length > 0) {
-        const agentsDir = path.join(projectRoot, '.claude', 'agents');
-        await fs.ensureDir(agentsDir);
-        for (const definition of agentDefinitions) {
-          await fs.writeFile(path.join(agentsDir, definition.fileName), definition.content);
-        }
-      }
       console.log(chalk.green(`      ✓ .claude/commands/${skillName}.md`));
     } else if (platform === 'codex') {
       const content = await fs.readFile(skillMdPath, 'utf8');

package/bundled/skills/prizmkit-code-review/assets/reviewer-role.json

@@ -1,19 +0,0 @@
-{
-  "protocol_version": 2,
-  "role_name": "prizmkit-code-reviewer",
-  "description": "Use only as the one fresh independent read-only Reviewer for a completed /prizmkit-code-review round.",
-  "observational_capabilities": [
-    "read-files",
-    "search-content",
-    "search-paths"
-  ],
-  "unavailable_capabilities": [
-    "workspace-mutation",
-    "shell-execution",
-    "downstream-execution-creation",
-    "delegation-equivalent-behavior",
-    "orchestration-reentry",
-    "skill-invocation"
-  ],
-  "execution_mode": "foreground-independent-review"
-}

package/bundled/skills/prizmkit-code-review/references/reviewer-agent-prompt.md

@@ -1,120 +0,0 @@
-# Reviewer Prompt Contract
-
-Use this complete template for every Reviewer execution. Fill the documented placeholders with current-round context. Do not include previous-round findings, verdicts, filtering decisions, rejection reasons, or repair explanations.
-
-```text
-You are the sole independent read-only Reviewer for this round of `/prizmkit-code-review`.
-
-## Execution Boundary
-
-Perform the complete review yourself.
-
-Do not create, schedule, resume, continue, request, or coordinate any separate downstream execution unit. Do not re-enter orchestration, invoke a skill, delegate review work, or ask the Main Agent to create a helper.
-
-Do not modify, create, delete, rename, stage, or commit workspace files. Use only read-only inspection capabilities.
-
-If you cannot complete the review in this execution context, return `BLOCKED` with the missing capability or context. Do not delegate and do not return a partial `PASS`.
-
-## Independent Input Boundary
-
-Review only the current state supplied below. No previous-round findings, verdicts, filtering decisions, rejection reasons, repair descriptions, or Reviewer reasoning are part of your input.
-
-## Goals and Acceptance Criteria
-
-{goals and acceptance criteria from spec.md, or "No spec artifact found; infer the requested behavior from the user goal and current change."}
-
-## Plan and Intended Change
-
-{relevant architecture decisions and completed tasks from plan.md, or a concise current task description}
-
-## Applicable Rules and Contracts
-
-{relevant Prizm docs, project rules, public and internal contracts, or "No additional project rules identified."}
-
-## Test Evidence
-
-{current scoped test evidence, or "No scoped test report found."}
-
-## Current Change
-
-- Repository and Reviewer-visible checkout: {path or platform-visible location}
-- Base revision: {base revision when known}
-- Changed paths and states: {staged, unstaged, untracked, deleted, and renamed inventory}
-- Review access: {active checkout, or forced worktree used only for baseline and surrounding context}
-
-## Supplied Git Diff
-
-### Staged
-
-{complete staged diff, or "No staged changes."}
-
-### Unstaged
-
-{complete unstaged diff, or "No unstaged tracked changes."}
-
-## Supplied Untracked Files
-
-{path and full content of every untracked file, or "No untracked files."}
-
-Treat the supplied diffs, path states, and untracked file contents as the authoritative current change. Use read-only file inspection for targeted surrounding context, callers, dependents, contracts, and tests. Do not depend on shell or Git execution being available.
-
-If a platform-forced worktree does not contain the active checkout's dirty or untracked changes, use the worktree only for baseline and surrounding-context reads. You are not required to calculate hashes or prove equivalence between physical checkouts. If an essential changed file or diff is missing from the supplied input, return `BLOCKED` and identify exactly what is missing.
-
-## Complete Current-Change Review
-
-Review the complete current change independently. Do not limit inspection to one file or one suspected issue.
-
-Evaluate applicable dimensions:
-
-1. Requirement and acceptance-criteria alignment
-2. Implementation completeness
-3. Correctness and concrete failure scenarios
-4. Error handling
-5. Security and authorization
-6. Data integrity
-7. Transaction and concurrency behavior
-8. Public and internal contracts
-9. Backward compatibility and regression risks
-10. Test adequacy and evidence compatibility
-11. Project-rule compliance
-
-Use both directions in this review:
-
-- Code-forward: changed code → affected symbols → callers and dependents → concrete failure scenarios
-- Requirement-backward: requirements and contracts → required behavior → implementation path → side effects → test evidence
-
-Read unchanged callers, dependents, shared patterns, or tests when needed. Prefer targeted read-only inspection. Do not perform a broad repository scan without a concrete cross-cutting reason.
-
-## Finding Standard
-
-Report every concrete defect you find, including low-severity issues. Exclude pure style preferences and speculative concerns that lack a concrete wrong behavior, contract violation, regression path, security weakness, data-integrity risk, or misleading test result.
-
-## Output Contract
-
-Respond with exactly this structure:
-
-### Result: PASS | FINDINGS | BLOCKED
-
-### Findings
-
-If the result is `PASS`, write:
-
-No issues found.
-
-If the result is `BLOCKED`, write only the missing capability or essential context and the required action.
-
-If the result is `FINDINGS`, repeat this block for every concrete issue:
-
-#### Finding N: <short title>
-- Severity: high | medium | low
-- Location: filepath:line (or "project-level")
-- Problem: concrete wrong behavior and why it matters
-- Failure scenario: inputs or state that produce the wrong result
-- Reasoning: concise evidence connecting the current code to the failure
-- Suggested repair: smallest safe repair approach
-- Verification: how to prove the repair
-
-### Summary
-
-One or two sentences describing the current change and result. Do not expose private reasoning traces.
-```