prizmkit 1.1.119 → 1.1.121

package/bundled/dev-pipeline/templates/sections/phase-review-agent.md

@@ -2,9 +2,9 @@
 
 Review the completed implementation before the scoped feature test gate runs. Use `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/` so the code-review skill can read spec, plan, context snapshot, implementation log, and current diff artifacts. Do not require or read a prior `/prizmkit-test` report here; test generation and test-fix looping happen in the next phase.
 
-Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`.
+Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`. The skill loads its skill-owned Reviewer prompt and workspace protocol, chooses a platform-supported subagent strategy, and verifies that the Reviewer's snapshot is equivalent to the current workspace before review.
 
-The skill runs an internal review-fix loop (Reviewer Agent → filter → orchestrator fix, max 3 rounds) and writes `review-report.md` to the artifact directory.
+The skill runs an internal review-fix loop (Reviewer Agent → filter → orchestrator fix, max 3 rounds) and writes `review-report.md` to the artifact directory. Do not prescribe Agent launch parameters from this pipeline template; the review skill owns strategy selection and workspace-equivalence verification.
 
 **Gate Check — Review Report**:
 After `/prizmkit-code-review` returns, verify the review report:
@@ -15,7 +15,7 @@ If GATE:MISSING:
 - Do not re-run `/prizmkit-code-review` in an unbounded report-repair loop.
 - Perform one bounded status check; retry at most once: inspect the skill output, `review-report.md` path, and any Reviewer agent spawn messages.
 - If the missing report is caused by team/config/lock errors from the Reviewer agent spawn or review skill error, retry `/prizmkit-code-review` at most once only if it appears transient.
-- If the report is still missing after that single check/retry, write `failure-log.md` with the spawn/skill error and last observable state, then either perform a safe inline fallback review (spec/plan/diff/tests → write `review-report.md` with `## Verdict`) or stop with a clear recovery failure.
+- If the report is still missing after that single check/retry, write `failure-log.md` with the spawn/skill error and last observable state, then stop with a clear recovery failure. Do not synthesize a passing report through Main-Agent self-review.
 
 Read `review-report.md` and check the Verdict:
 - `PASS` → proceed to next phase

package/bundled/dev-pipeline/templates/sections/phase-review-full.md

@@ -2,9 +2,11 @@
 
 Review the completed implementation before the scoped feature test gate runs. Use `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/` so the code-review skill can read spec, plan, context snapshot, implementation log, and current diff artifacts. Do not require or read a prior `/prizmkit-test` report here; test generation and test-fix looping happen in the next phase.
 
-Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`.
+Run `/prizmkit-code-review` with `artifact_dir=.prizmkit/specs/{{FEATURE_SLUG}}/`. The skill loads its skill-owned Reviewer prompt and workspace protocol, chooses a platform-supported subagent strategy, and verifies that the Reviewer's snapshot is equivalent to the current workspace before review.
 
-The skill runs an internal review-fix loop (Reviewer Agent → filter → orchestrator fix, max 3 rounds) and writes `review-report.md` to the artifact directory.
+If the independent Reviewer cannot start or verify the snapshot because of a transient platform error, retry at most once. If the second attempt fails, do not keep spawning variants or enter report-polling loops; write `failure-log.md` with the observable error and let the skill report the unresolved verification blocker. Do not replace the independent Reviewer with Main-Agent self-review.
+
+The skill runs an internal review-fix loop (Reviewer Agent → filter → orchestrator fix, max 3 rounds) and writes `review-report.md` to the artifact directory. Do not prescribe Agent launch parameters from this pipeline template; the review skill owns strategy selection and workspace-equivalence verification.
 
 **Gate Check — Review Report**:
 After `/prizmkit-code-review` returns, verify the review report:
@@ -15,7 +17,7 @@ If GATE:MISSING:
 - Do not re-run `/prizmkit-code-review` in an unbounded report-repair loop.
 - Perform one bounded status check; retry at most once: inspect the skill output, `review-report.md` path, and any Reviewer agent spawn messages.
 - If the missing report is caused by team/config/lock errors from the Reviewer agent spawn or review skill error, retry `/prizmkit-code-review` at most once only if it appears transient.
-- If the report is still missing after that single check/retry, write `failure-log.md` with the spawn/skill error and last observable state, then either perform a safe inline fallback review (spec/plan/diff/tests → write `review-report.md` with `## Verdict`) or stop with a clear recovery failure.
+- If the report is still missing after that single check/retry, write `failure-log.md` with the spawn/skill error and last observable state, then stop with a clear recovery failure. Do not synthesize a passing report through Main-Agent self-review.
 
 Read `review-report.md` and check the Verdict:
 - `PASS` → proceed to next phase

package/bundled/dev-pipeline/templates/sections/phase-specify-plan-full.md

@@ -9,6 +9,15 @@ Check existing artifacts first:
 - `context-snapshot.md` exists → use it directly, skip context snapshot building
 - Some missing → generate only missing files
 
+Before planning, check whether feature code already exists in the project (use the helper to search source directories identified from `root.prizm` or the project tree scan):
+```bash
+{{RUNTIME_HELPER_CMD}} text search . --pattern "{{FEATURE_SLUG}}" --json
+```
+
+Record result as `EXISTING_CODE` (helper `match` entries for source files, or empty; ignore `.prizmkit/` artifact matches).
+
+If `EXISTING_CODE` is non-empty: your spec/plan/tasks must reflect this existing implementation — document what exists, identify gaps, and do NOT re-implement what is already done.
+
 **Step A — Build Context Snapshot** (skip if `context-snapshot.md` already exists):
 
 1. Read `.prizmkit/prizm-docs/root.prizm` and relevant L1/L2 prizm docs
@@ -60,4 +69,15 @@ Before proceeding past CP-1, verify:
 
 **CP-1**: Both spec.md and plan.md exist.
 
+### Plan Self-Check — Orchestrator Direct
+
+Do not spawn a top-level Reviewer subagent for planning analysis. Perform a bounded self-check before implementation:
+
+1. Re-read only `context-snapshot.md`, `spec.md`, and `plan.md`.
+2. Cross-check spec.md and plan.md Tasks against the feature description and Verification Gates in the Task Contract.
+3. Verify the plan references the File Manifest and avoids unrelated work.
+4. If you find CRITICAL issues, fix ONLY those issues in spec.md/plan.md before continuing.
+
+**CP-1.5**: Plan self-check complete; no CRITICAL plan issues remain.
+
 

package/bundled/dev-pipeline/templates/sections/refactor-phase-review.md

@@ -1,8 +1,8 @@
 ### Phase 3: Review — Code Review & Behavior Verification
 
-Run `/prizmkit-code-review` directly with `artifact_dir=.prizmkit/refactor/{{REFACTOR_ID}}/`.
+Run `/prizmkit-code-review` directly with `artifact_dir=.prizmkit/refactor/{{REFACTOR_ID}}/`. The skill loads its skill-owned `references/reviewer-agent-prompt.md` and `references/reviewer-workspace-protocol.md`, chooses a platform-supported subagent strategy, and verifies that the Reviewer's snapshot is equivalent to the current workspace before review.
 
-Do not spawn a top-level Reviewer subagent. The code-review skill owns its internal Reviewer Agent → filter → orchestrator fix loop.
+Do not spawn a top-level Reviewer subagent. The code-review skill owns its internal Reviewer Agent → filter → orchestrator fix loop. Do not prescribe Agent launch parameters from this pipeline template; the review skill owns strategy selection and workspace-equivalence verification.
 
 **Gate Check — Review Report**:
 
@@ -12,7 +12,7 @@ Do not spawn a top-level Reviewer subagent. The code-review skill owns its inter
 
 - `PASS` → proceed.
 - `NEEDS_FIXES` → the skill exhausted its internal rounds; log remaining findings and proceed only when they do not block behavior preservation.
-- Missing report → one bounded retry or safe inline fallback review, then write `failure-log.md` if still blocked.
+- Missing report → one bounded retry, then write `failure-log.md` and stop if the independent review protocol remains blocked; do not replace it with Main-Agent self-review.
 
 Verify the review explicitly checks behavior preservation, public API compatibility, imports, tests, and rollback assumptions.
 

package/bundled/dev-pipeline/tests/test_auto_skip.py

@@ -1195,7 +1195,7 @@ def _run_update(fl_path, state_dir, feature_id, session_status, session_id="sess
 
 
 class TestInfraErrorUpdate:
-    def test_infra_error_below_budget_keeps_pending_without_consuming_retry(self, tmp_path):
+    def test_infra_error_below_budget_keeps_in_progress_without_consuming_retry(self, tmp_path):
         features = [_make_feature("F-001", "Root", status="in_progress")]
         fl_path = _write_fl(tmp_path, features)
         state_dir = _init_state(tmp_path, ["F-001"])
@@ -1214,12 +1214,12 @@ class TestInfraErrorUpdate:
             max_infra_retries=3,
         )
 
-        assert result["new_status"] == "pending"
+        assert result["new_status"] == "in_progress"
         assert result["retry_count"] == 2
         assert result["infra_error_count"] == 1
         assert result["max_infra_retries"] == 3
-        assert result["restart_policy"] == "infra_retry"
-        assert _read_statuses(fl_path)["F-001"] == "pending"
+        assert result["restart_policy"] == "in_process_ai_error_continuation"
+        assert _read_statuses(fl_path)["F-001"] == "in_progress"
 
         fs = load_feature_status(state_dir, "F-001")
         assert fs["retry_count"] == 2
@@ -1250,7 +1250,7 @@ class TestInfraErrorUpdate:
         assert result["new_status"] == "failed"
         assert result["retry_count"] == 1
         assert result["infra_error_count"] == 3
-        assert result["restart_policy"] == "infra_retry"
+        assert result["restart_policy"] == "needs_attention"
         assert _read_statuses(fl_path)["F-001"] == "failed"
 
         fs = load_feature_status(state_dir, "F-001")