prizmkit 1.1.113 → 1.1.115

package/bundled/skills/refactor-planner/references/generated-plan-review.md

@@ -0,0 +1,63 @@
+# Generated Plan Review — Refactor Planner
+
+Use this local review loop after `.prizmkit/plans/refactor-list.json` has been generated and validated. This is a planner-output review, not an implementation/code-diff review.
+
+## Trigger
+
+Run only when the current `refactor-planner` session generated, appended, or rewrote final refactor planning content. For validate-only, summary-only, or draft-save flows with no new final planning content, report: `Local generated-plan review: not applicable — no new final planning content written.`
+
+## Direct Artifact Reads
+
+Planning artifacts may be gitignored, untracked, or absent from staged and unstaged diffs. Read the actual files directly:
+
+- Final list: `.prizmkit/plans/refactor-list.json`
+- Draft/source list when present: `.prizmkit/plans/refactor-list.draft.json`
+- Pre-session final list snapshot if captured in memory before edits
+- In-memory draft object if the session has not written a draft file yet
+
+Do not rely on `git status`, `git diff`, or `git diff --cached` to decide whether planner output exists or changed. Do not invoke `/prizmkit-code-review` for this planner-output gate; `/prizmkit-code-review` remains the implementation/code-diff review gate after `/prizmkit-implement`.
+
+## Review Scope
+
+1. If a pre-session final list exists, compare by stable refactor IDs (`R-*`).
+2. Treat refactors as changed only when item fields changed. Ignore root generator metadata and formatting-only differences such as `$schema`, `created_at`, and `created_by`.
+3. Review newly added refactor IDs and changed refactor IDs.
+4. Preserve unchanged historical refactors. Read unchanged entries only when needed to verify dependency references or behavior-preservation interactions with reviewed refactors.
+5. If no snapshot exists, review all refactor entries produced by the current generation flow.
+
+## Review Checklist
+
+For every reviewed refactor entry, check:
+
+- Schema compatibility with `dev-pipeline-refactor-list-v1` and `.prizmkit/dev-pipeline/templates/refactor-list-schema.json`
+- Dependency/DAG soundness, including safe behavior-preserving order
+- Description completeness, target scope clarity, and headless execution readiness
+- Acceptance criteria specificity and measurable behavior-preservation verification
+- `behavior_preservation` strategy quality and consistency with target scope and existing tests
+- User-provided wording preservation in `description`, `acceptance_criteria`, and `user_context`
+- Task-scoped `user_context` isolation: no unrelated sibling refactor goals, target files, constraints, desired end states, or supplementary materials; shared context appears on multiple items only when explicitly global
+- Priority/complexity calibration: every reviewed refactor has short priority and complexity rationales, medium/low assignments are allowed when criteria fit, and high/high is not used merely because the work is cleanup, framework-related, multi-file, or user-requested
+
+## Fix Loop
+
+1. Present findings with IDs, severity, evidence, and suggested draft/source changes.
+2. Accept only findings that improve planner correctness, completeness, or downstream behavior-preserving execution readiness.
+3. Apply accepted fixes to `.prizmkit/plans/refactor-list.draft.json` or the in-memory draft object first.
+4. Regenerate the final list through the existing generator:
+
+```bash
+python3 ${SKILL_DIR}/scripts/validate-and-generate-refactor.py generate --input .prizmkit/plans/refactor-list.draft.json --output .prizmkit/plans/refactor-list.json
+```
+
+5. Re-run validation/generation until valid. Do not hand-patch `.prizmkit/plans/refactor-list.json` as the source of truth.
+6. Repeat the local review only for entries changed by accepted fixes.
+
+## Report Format
+
+Report in the final handoff summary:
+
+- `Local generated-plan review: PASS` or `NEEDS_FIXES`
+- Reviewed refactor IDs
+- Accepted fixes, or `none`
+- Final validation result
+- Note when review was not applicable because no new final planning content was written

package/bundled/skills/refactor-planner/scripts/validate-and-generate-refactor.py

@@ -246,6 +246,15 @@ def validate_refactor_list(data):
                     )
                 )
 
+        # -- Retired fields --
+        for retired_field in ("critic", "critic_count"):
+            if retired_field in refactor:
+                errors.append(
+                    "{}: '{}' field is retired; remove it from refactor-list data".format(
+                        label, retired_field
+                    )
+                )
+
         # -- Scope --
         scope = refactor.get("scope")
         if isinstance(scope, dict):

package/bundled/team/prizm-dev-team.json

@@ -1,12 +1,12 @@
 {
   "name": "prizm-dev-team",
   "team_name": "prizm-dev-team",
-  "description": "PrizmKit-integrated Multi-Agent software development team. 3 specialized agents (Dev, Reviewer, Critic) following PrizmKit spec-driven workflow. Critic supports parallel 3-critic voting with distinct focus lenses.",
+  "description": "PrizmKit-integrated software development team with Dev and Reviewer agents following the PrizmKit spec-driven workflow.",
   "lead": "orchestrator",
   "communication": {
     "protocol": "SendMessage",
     "routing": "mesh",
-    "note": "Teammates communicate directly via SendMessage; key messages must also be sent to Orchestrator (the main AI session). Critic agents operate independently in parallel — they do NOT read each other's reports."
+    "note": "Teammates communicate directly via SendMessage; key messages must also be sent to Orchestrator (the main AI session)."
   },
   "members": [
     {
@@ -22,13 +22,6 @@
       "agentDefinition": "prizm-dev-team-reviewer",
       "prompt": "You are the Reviewer Agent of the prizm-dev-team. Your complete behavior rules are in your agent definition. Run /prizmkit-code-review for diagnosis + fix strategy formulation. You do NOT run tests — the Orchestrator handles testing.",
       "subscriptions": ["*"]
-    },
-    {
-      "name": "critic",
-      "role": "critic",
-      "agentDefinition": "prizm-dev-team-critic",
-      "prompt": "You are the Critic Agent of the prizm-dev-team. Your complete behavior rules are in your agent definition. Challenge plans and implementations for project fitness, style consistency, robustness, and integration quality. Supports parallel 3-critic voting mode. Do NOT verify correctness — that is the Reviewer's job.",
-      "subscriptions": ["*"]
     }
   ]
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prizmkit",
-  "version": "1.1.113",
+  "version": "1.1.115",
   "description": "Create a new PrizmKit-powered project with clean initialization — no framework dev files, just what you need.",
   "type": "module",
   "bin": {

package/src/clean.js

@@ -3,6 +3,19 @@ import path from 'path';
 import fs from 'fs-extra';
 import { loadMetadata, loadRulesMetadata } from './metadata.js';
 import { readManifest } from './manifest.js';
+import { privateProjectMemoryFile, projectMemoryFile } from './platforms.js';
+
+const PRIZMKIT_GITIGNORE_HEADERS = new Set([
+  '# PrizmKit',
+  '# PrizmKit 运行时全部产物（state/、prizm-docs/、.env、logs 等）',
+]);
+const PRIZMKIT_GITIGNORE_ENTRIES = new Set([
+  '.prizmkit/',
+  '.prizmkit/*',
+  'CLAUDE.private.md',
+  'AGENTS.private.md',
+  'CODEBUDDY.private.md',
+]);
 
 async function removePath(targetPath, dryRun) {
   if (!await fs.pathExists(targetPath)) {
@@ -54,11 +67,14 @@ async function cleanGitignore(projectRoot, dryRun) {
   }
 
   const content = await fs.readFile(gitignorePath, 'utf8');
-  const next = content
-    .replace(/\n\n# PrizmKit\n\.prizmkit\/\n?/g, '\n')
-    .replace(/\n# PrizmKit\n\.prizmkit\/\n?/g, '\n');
-
-  if (next === content) {
+  const nextLines = content.split(/\r?\n/).filter(line => {
+    const trimmed = line.trim();
+    return !PRIZMKIT_GITIGNORE_HEADERS.has(trimmed)
+      && !PRIZMKIT_GITIGNORE_ENTRIES.has(trimmed);
+  });
+  const next = nextLines.join('\n').replace(/\n{3,}/g, '\n\n').trimEnd();
+
+  if (`${next}\n` === content || next === content.trimEnd()) {
     return { updated: false, reason: 'no_prizmkit_section' };
   }
 
@@ -66,7 +82,7 @@ async function cleanGitignore(projectRoot, dryRun) {
     return { updated: true, reason: 'dry_run' };
   }
 
-  await fs.writeFile(gitignorePath, next.trimEnd() + '\n');
+  await fs.writeFile(gitignorePath, next ? `${next}\n` : '');
   return { updated: true };
 }
 
@@ -100,6 +116,38 @@ async function cleanMarkedProjectMemory(projectRoot, fileName, dryRun) {
   return { path: filePath, removed: true, note: '(PrizmKit section)' };
 }
 
+async function cleanProjectMemoryImport(projectRoot, fileName, privateFileName, dryRun) {
+  const filePath = path.join(projectRoot, fileName);
+  if (!await fs.pathExists(filePath)) {
+    return { path: filePath, removed: false, reason: 'not_found' };
+  }
+
+  const importPointer = `@./${privateFileName}`;
+  const content = await fs.readFile(filePath, 'utf8');
+  const next = content
+    .split(/\r?\n/)
+    .filter(line => line.trim() !== importPointer)
+    .join('\n')
+    .replace(/\n{3,}/g, '\n\n')
+    .trimEnd();
+
+  if (next === content.trimEnd()) {
+    return { path: filePath, removed: false, reason: 'no_prizmkit_import' };
+  }
+
+  if (dryRun) {
+    return { path: filePath, removed: false, reason: 'dry_run' };
+  }
+
+  if (!next) {
+    await fs.remove(filePath);
+    return { path: filePath, removed: true, note: '(PrizmKit import only)' };
+  }
+
+  await fs.writeFile(filePath, `${next}\n`);
+  return { path: filePath, removed: true, note: '(PrizmKit import)' };
+}
+
 async function removeGeneratedCodexConfig(projectRoot, dryRun) {
   const configPath = path.join(projectRoot, '.codex', 'config.toml');
   if (!await fs.pathExists(configPath)) {
@@ -228,7 +276,12 @@ export async function runClean(directory, options = {}) {
   const legacyCodexRulesDir = path.join(projectRoot, '.codex', 'rules');
   results.push(...await removeKnownEntries(legacyCodexRulesDir, ruleFileNames.map(n => `${n}.md`), dryRun));
 
-  for (const memoryFile of ['CODEBUDDY.md', 'CLAUDE.md', 'AGENTS.md']) {
+  for (const platform of ['codebuddy', 'claude', 'codex']) {
+    const memoryFile = projectMemoryFile(platform);
+    const privateMemoryFile = privateProjectMemoryFile(platform);
+    if (!memoryFile || !privateMemoryFile) continue;
+    results.push(await cleanProjectMemoryImport(projectRoot, memoryFile, privateMemoryFile, dryRun));
+    results.push(await cleanMarkedProjectMemory(projectRoot, privateMemoryFile, dryRun));
     results.push(await cleanMarkedProjectMemory(projectRoot, memoryFile, dryRun));
   }
 

package/src/config.js

@@ -38,6 +38,7 @@ import {
   resolveRuleNamesForRuntime,
   findStaleManagedPipelineFiles,
   removeStaleManagedPipelineFiles,
+  normalizeMainProjectMemoryContent,
 } from './scaffold.js';
 import {
   removeSkillFiles,
@@ -54,7 +55,7 @@ import {
   confirmTeamMode,
   confirmPipeline,
 } from './prompts.js';
-import { isKnownPlatform, platformLabel, projectMemoryFile, resolvePayloadPlatforms } from './platforms.js';
+import { isKnownPlatform, platformLabel, privateProjectMemoryFile, privateProjectMemoryFiles, projectMemoryFile, resolvePayloadPlatforms } from './platforms.js';
 import { normalizeRuntime, runtimeLabel } from './runtimes.js';
 import { applyAiCliLaunchToConfig, resolveAiCliLaunchSelection, storedAiCliLaunch } from './ai-cli-launch.js';
 
@@ -114,6 +115,50 @@ function getProjectMemoryFile(platform) {
   return projectMemoryFile(platform);
 }
 
+function logManagedMemoryWarnings(mainFile, warnings) {
+  for (const warning of warnings) {
+    console.log(chalk.yellow(`      ⚠ ${mainFile}: ${warning}; preserving unmatched marker content`));
+  }
+}
+
+async function removeProjectMemoryArtifacts(platform, projectRoot, dryRun) {
+  const mainFile = projectMemoryFile(platform);
+  const privateFile = privateProjectMemoryFile(platform);
+  if (!mainFile || !privateFile) return;
+
+  const privatePath = path.join(projectRoot, privateFile);
+  if (await fs.pathExists(privatePath)) {
+    if (dryRun) {
+      console.log(chalk.gray(`      [dry-run] remove ${privateFile}`));
+    } else {
+      await fs.remove(privatePath);
+      console.log(chalk.red(`      ✗ removed ${privateFile}`));
+    }
+  }
+
+  const mainPath = path.join(projectRoot, mainFile);
+  if (!await fs.pathExists(mainPath)) return;
+
+  const current = await fs.readFile(mainPath, 'utf-8');
+  const normalized = normalizeMainProjectMemoryContent(current, privateFile);
+  logManagedMemoryWarnings(mainFile, normalized.warnings);
+  const next = normalized.content.trim();
+  if (next === current.trim()) return;
+
+  if (dryRun) {
+    console.log(chalk.gray(`      [dry-run] update ${mainFile} (remove PrizmKit import)`));
+    return;
+  }
+
+  if (!next) {
+    await fs.remove(mainPath);
+    console.log(chalk.red(`      ✗ removed ${mainFile} (empty after PrizmKit import removal)`));
+  } else {
+    await fs.writeFile(mainPath, `${next}\n`, 'utf-8');
+    console.log(chalk.green(`      ✓ updated ${mainFile} (removed PrizmKit import)`));
+  }
+}
+
 async function migrateProjectMemoryOnPlatformDrop(droppedPlatform, newPlatforms, projectRoot, dryRun) {
   const sourceFile = getProjectMemoryFile(droppedPlatform);
   if (!sourceFile) return;
@@ -135,8 +180,13 @@ async function migrateProjectMemoryOnPlatformDrop(droppedPlatform, newPlatforms,
     return;
   }
 
-  const sourceContent = await fs.readFile(sourcePath, 'utf-8');
-  if (!sourceContent.trim()) return;
+  const normalized = normalizeMainProjectMemoryContent(
+    await fs.readFile(sourcePath, 'utf-8'),
+    privateProjectMemoryFile(droppedPlatform),
+  );
+  logManagedMemoryWarnings(sourceFile, normalized.warnings);
+  const sourceContent = normalized.content.trim();
+  if (!sourceContent) return;
 
   if (!await fs.pathExists(targetPath)) {
     const normalized = sourceContent.endsWith('\n') ? sourceContent : `${sourceContent}\n`;
@@ -244,18 +294,8 @@ async function removePlatformFiles(platform, projectRoot, manifest, dryRun) {
     }
   }
 
-  // Project memory file
-  const memoryFile = projectMemoryFile(platform);
-  if (!memoryFile) return;
-  const memoryPath = path.join(projectRoot, memoryFile);
-  if (await fs.pathExists(memoryPath)) {
-    if (dryRun) {
-      console.log(chalk.gray(`      [dry-run] remove ${memoryFile}`));
-    } else {
-      await fs.remove(memoryPath);
-      console.log(chalk.red(`      ✗ removed ${memoryFile}`));
-    }
-  }
+  // Project memory artifacts: remove only managed private file/imports, not user-owned main content.
+  await removeProjectMemoryArtifacts(platform, projectRoot, dryRun);
 
   // Command assets (Claude only)
   if (platform === 'claude') {
@@ -611,10 +651,8 @@ export async function runConfig(directory, options = {}) {
       console.log(chalk.blue('\n    Settings & Rules:'));
       await installSettings(p, projectRoot, { pipeline: newConfig.pipeline, rules: newConfig.rules }, false, newConfig.runtime);
 
-      if (isNew) {
-        console.log(chalk.blue('\n    Project Memory:'));
-        await installProjectMemory(p, projectRoot, false);
-      }
+      console.log(chalk.blue('\n    Project Memory:'));
+      await installProjectMemory(p, projectRoot, false);
 
       if (newConfig.team) {
         console.log(chalk.blue('\n    Team Config:'));
@@ -648,7 +686,10 @@ export async function runConfig(directory, options = {}) {
 
   // 5f. Update .gitignore
   console.log(chalk.blue('\n    Gitignore:'));
-  await installGitignore(projectRoot, { pipeline: newConfig.pipeline }, false);
+  await installGitignore(projectRoot, {
+    pipeline: newConfig.pipeline,
+    privateMemoryFiles: privateProjectMemoryFiles(newPlatforms),
+  }, false);
 
   // 5g. Runtime-aware git hook and PrizmKit helper scripts
   if (newConfig.runtime !== currentConfig.runtime || runtimeManifestNeedsNormalization || runtimeOptionNeedsNormalization) {

package/src/gitignore-template.js

@@ -9,11 +9,14 @@
  * @returns {string}
  */
 export function generateGitignore(options = {}) {
-  void options;
+  const privateMemoryFiles = Array.isArray(options.privateMemoryFiles)
+    ? options.privateMemoryFiles.filter(Boolean)
+    : [];
   const lines = [
-    '# PrizmKit 运行时全部产物（state/、prizm-docs/、.env、logs 等）',
+    '# PrizmKit',
     '.prizmkit/*',
+    ...privateMemoryFiles,
   ];
 
-  return lines.join('\n');
+  return [...new Set(lines)].join('\n');
 }

package/src/manifest.js

@@ -9,7 +9,7 @@
 
 import fs from 'fs-extra';
 import path from 'path';
-import { projectMemoryFile, resolvePayloadPlatforms } from './platforms.js';
+import { privateProjectMemoryFile, projectMemoryFile, resolvePayloadPlatforms } from './platforms.js';
 import { normalizeRuntime } from './runtimes.js';
 
 const MANIFEST_FILE = 'manifest.json';
@@ -100,7 +100,11 @@ export function buildManifest({
       pipeline: pipeline ? [...pipeline] : [],
       extras: extras ? [...extras] : [],
       payloadPlatforms: installedPayloadPlatforms,
-      other: [...new Set(installedPayloadPlatforms.map(projectMemoryFile).filter(Boolean))],
+      memory: {
+        main: [...new Set(installedPayloadPlatforms.map(projectMemoryFile).filter(Boolean))],
+        private: [...new Set(installedPayloadPlatforms.map(privateProjectMemoryFile).filter(Boolean))],
+      },
+      other: [...new Set(installedPayloadPlatforms.map(privateProjectMemoryFile).filter(Boolean))],
     },
   };
 }

package/src/platforms.js

@@ -62,6 +62,20 @@ export function projectMemoryFile(platform) {
   return null;
 }
 
+export function privateProjectMemoryFile(platform) {
+  const mainFile = projectMemoryFile(platform);
+  if (!mainFile) return null;
+  return mainFile.replace(/\.md$/i, '.private.md');
+}
+
+export function projectMemoryFiles(platform) {
+  return [projectMemoryFile(platform), privateProjectMemoryFile(platform)].filter(Boolean);
+}
+
+export function privateProjectMemoryFiles(platforms) {
+  return [...new Set((platforms || []).map(privateProjectMemoryFile).filter(Boolean))];
+}
+
 export function defaultCliForPlatform(platform) {
   if (platform === 'claude') return 'claude';
   if (platform === 'codebuddy') return 'cbc';