prizmkit 1.1.106 → 1.1.108

package/bundled/dev-pipeline/tests/test_generate_bugfix_prompt.py

@@ -12,10 +12,12 @@ from generate_bugfix_prompt import (
     format_environment,
     process_conditional_blocks,
     render_template,
-    load_log_size_section,
 )
 from continuation import append_continuation_handoff
 
+REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
+REMOVED_MAX_LOG_HUMAN = REMOVED_MAX_LOG_ENV + "_HUMAN"
+
 
 # ---------------------------------------------------------------------------
 # find_bug
@@ -193,6 +195,14 @@ class TestExplicitProjectRoot:
         )
         assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
         assert replacements["{{DEV_SUBAGENT_PATH}}"].startswith(str(execution_root.resolve()))
+        assert replacements["{{SESSION_LOG_PATH}}"].endswith(
+            ".prizmkit/state/bugfix/B-001/sessions/session-1/logs/session.log"
+        )
+        assert "{{" + REMOVED_MAX_LOG_ENV + "}}" not in replacements
+        assert "{{" + REMOVED_MAX_LOG_HUMAN + "}}" not in replacements
+        assert "### Checkpoint Update Helper" in replacements["{{CHECKPOINT_SYSTEM}}"]
+        assert "python3 .prizmkit/dev-pipeline/scripts/update-checkpoint.py" in replacements["{{CHECKPOINT_SYSTEM}}"]
+        assert "pipeline progress mechanism" not in replacements["{{CHECKPOINT_SYSTEM}}"]
 
 
 # ---------------------------------------------------------------------------
@@ -218,23 +228,27 @@ class TestSharedHelpers:
 # ---------------------------------------------------------------------------
 
 class TestHeadlessRecoveryReframing:
-    def test_bugfix_log_size_section_is_passive_checkpoint_guidance(self):
-        content = load_log_size_section(str(Path("dev-pipeline/scripts").resolve()))
-
-        assert "passive checkpoint guidance" in content
-        assert "Headless recovery must rely on durable checkpoints" in content
-        assert "fresh continuation session" in content
-        assert "optional interactive convenience only" in content
-        assert "COMPACT_NEEDED" not in content
-        assert "monitor-log" not in content
-        assert "background monitoring subagent" not in content
-        assert "Execute `/compact`" not in content
-        assert "run `/compact`" not in content.lower()
+    def test_bugfix_source_has_no_deleted_log_size_injection(self):
+        deleted_section = "log-size-" + "awareness.md"
+        loader = "load_" + "log_size_section"
+        placeholder = "{{LOG_" + "SIZE_AWARENESS}}"
+        deleted_title = "Session " + "Checkpoint Awareness"
+        source = Path("dev-pipeline/scripts/generate-bugfix-prompt.py").read_text(encoding="utf-8")
+        template = Path("dev-pipeline/templates/bugfix-bootstrap-prompt.md").read_text(encoding="utf-8")
+
+        assert (Path("dev-pipeline/templates/sections") / deleted_section).exists() is False
+        for content in (source, template):
+            for forbidden in (deleted_section, loader, placeholder, deleted_title):
+                assert forbidden not in content
 
     def test_bugfix_template_does_not_spawn_monitor_or_require_compact(self):
         content = Path("dev-pipeline/templates/bugfix-bootstrap-prompt.md").read_text(encoding="utf-8")
 
         assert "Do not spawn persistent background subagents for headless recovery" in content
+        assert REMOVED_MAX_LOG_ENV not in content
+        assert REMOVED_MAX_LOG_HUMAN not in content
+        assert ("209" + "7152") not in content
+        assert ("2" + "MB") not in content
         assert "log-size monitor" not in content
         assert "monitor-log" not in content
         assert "COMPACT_NEEDED" not in content
@@ -263,6 +277,28 @@ class TestBugfixContinuationHandoff:
 
         assert prompt.startswith("BUGFIX PROMPT")
         assert "This is an automatic continuation after context overflow." in prompt
-        assert "Do not attempt `/compact` as the recovery mechanism." in prompt
+        assert "Do not attempt `/compact` as the recovery mechanism." not in prompt
+        assert ("Log " + "monitor") not in prompt
+        assert ("log-" + "monitor") not in prompt
         assert (tmp_path / ".prizmkit/specs/B-007/continuation-summary.md").exists()
         assert (tmp_path / ".prizmkit/bugfix/B-007/continuation-summary.md").exists()
+
+
+HEADLESS_FORBIDDEN_PROMPT_STRINGS = [
+    "### Interactive Claude Code Note",
+    "### Project Conventions",
+    "Scaffold / generated file awareness",
+    "### Resume Behavior",
+    "[NEEDS CLARIFICATION]",
+    "pause for interactive input",
+    "prizmkit-test-gate.py",
+    "/compact",
+    "Session " + "Checkpoint Awareness",
+    "{{LOG_" + "SIZE_AWARENESS}}",
+]
+
+
+def test_template_source_is_clean_for_headless_prompt_contract():
+    content = Path("dev-pipeline/templates/bugfix-bootstrap-prompt.md").read_text(encoding="utf-8")
+    for forbidden in HEADLESS_FORBIDDEN_PROMPT_STRINGS:
+        assert forbidden not in content

package/bundled/dev-pipeline/tests/test_generate_refactor_prompt.py

@@ -1,9 +1,17 @@
 """Tests for generate-refactor-prompt.py continuation behavior."""
 
 from argparse import Namespace
+from pathlib import Path
 
 from continuation import append_continuation_handoff
-from generate_refactor_prompt import generate_refactor_checkpoint, merge_refactor_checkpoint_state
+from generate_refactor_prompt import (
+    build_replacements,
+    generate_refactor_checkpoint,
+    merge_refactor_checkpoint_state,
+)
+
+REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
+REMOVED_MAX_LOG_HUMAN = REMOVED_MAX_LOG_ENV + "_HUMAN"
 
 
 class TestRefactorContinuationHandoff:
@@ -26,7 +34,9 @@ class TestRefactorContinuationHandoff:
 
         assert prompt.startswith("REFACTOR PROMPT")
         assert "This is a fresh headless AI CLI session for the same task." in prompt
-        assert "Do not attempt `/compact` as the recovery mechanism." in prompt
+        assert "Do not attempt `/compact` as the recovery mechanism." not in prompt
+        assert ("Log " + "monitor") not in prompt
+        assert ("log-" + "monitor") not in prompt
         assert (tmp_path / ".prizmkit/specs/R-007/continuation-summary.md").exists()
         assert (tmp_path / ".prizmkit/refactor/R-007/continuation-summary.md").exists()
 
@@ -41,3 +51,145 @@ class TestRefactorCheckpointMerge:
 
         assert merged["steps"][0]["status"] == "skipped"
         assert merged["steps"][1]["status"] == "pending"
+
+
+class TestExplicitProjectRoot:
+    def test_build_replacements_infers_project_root_from_refactor_list(self, tmp_path, monkeypatch):
+        monkeypatch.delenv("PRIZMKIT_PLATFORM", raising=False)
+        project = tmp_path / "project"
+        plan_path = project / ".prizmkit" / "plans" / "refactor-list.json"
+        plan_path.parent.mkdir(parents=True)
+        (project / ".prizmkit" / "config.json").write_text(
+            '{"platform":"claude","ai_cli":"claude"}', encoding="utf-8"
+        )
+        args = Namespace(
+            refactor_list=str(plan_path),
+            refactor_id="R-001",
+            session_id="session-1",
+            run_id="run-1",
+            retry_count="0",
+            resume_phase="null",
+            state_dir=str(project / ".prizmkit" / "state" / "refactor"),
+            output=str(project / "out.md"),
+            template=None,
+            mode=None,
+            critic=None,
+        )
+        refactor = {"id": "R-001", "title": "Restructure", "description": "d"}
+
+        replacements = build_replacements(
+            args, refactor, [refactor], {}, str(Path("dev-pipeline/scripts").resolve())
+        )
+
+        assert replacements["{{PROJECT_ROOT}}"] == str(project.resolve())
+        assert replacements["{{REVIEWER_SUBAGENT_PATH}}"].endswith(
+            ".claude/agents/prizm-dev-team-reviewer.md"
+        )
+        assert replacements["{{REVIEWER_SUBAGENT_PATH}}"].startswith(str(project.resolve()))
+        assert replacements["{{SESSION_STATUS_PATH}}"] == str(
+            project / ".prizmkit" / "state" / "refactor" / "R-001" /
+            "sessions" / "session-1" / "session-status.json"
+        )
+
+    def test_build_replacements_uses_cli_project_root_for_rendered_paths(self, tmp_path, monkeypatch):
+        monkeypatch.setenv("PRIZMKIT_PLATFORM", "claude")
+        execution_root = tmp_path / "worktree"
+        main_checkout = tmp_path / "main"
+        execution_root.mkdir()
+        main_checkout.mkdir()
+        args = Namespace(
+            refactor_list=str(main_checkout / ".prizmkit" / "plans" / "refactor-list.json"),
+            refactor_id="R-001",
+            session_id="session-1",
+            run_id="run-1",
+            retry_count="0",
+            resume_phase="null",
+            state_dir=str(main_checkout / ".prizmkit" / "state" / "refactor"),
+            output=str(main_checkout / ".prizmkit" / "state" / "refactor" / "R-001" / "sessions" / "session-1" / "bootstrap-prompt.md"),
+            template=None,
+            mode=None,
+            critic=None,
+            project_root=str(execution_root),
+        )
+        refactor = {"id": "R-001", "title": "Worktree Refactor", "description": "d"}
+
+        replacements = build_replacements(
+            args,
+            refactor,
+            [refactor],
+            {},
+            str(main_checkout / "dev-pipeline" / "scripts"),
+        )
+
+        assert replacements["{{PROJECT_ROOT}}"] == str(execution_root.resolve())
+        assert replacements["{{SESSION_STATUS_PATH}}"] == str(
+            main_checkout / ".prizmkit" / "state" / "refactor" / "R-001" /
+            "sessions" / "session-1" / "session-status.json"
+        )
+        assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
+        assert replacements["{{DEV_SUBAGENT_PATH}}"].startswith(str(execution_root.resolve()))
+        assert "### Checkpoint Update Helper" in replacements["{{CHECKPOINT_SYSTEM}}"]
+        assert "python3 .prizmkit/dev-pipeline/scripts/update-checkpoint.py" in replacements["{{CHECKPOINT_SYSTEM}}"]
+        assert "pipeline progress mechanism" not in replacements["{{CHECKPOINT_SYSTEM}}"]
+
+
+class TestRefactorPromptMaxLogRemoval:
+    def test_refactor_source_has_no_deleted_log_size_injection(self):
+        deleted_section = "log-size-" + "awareness.md"
+        loader = "load_" + "log_size_section"
+        placeholder = "{{LOG_" + "SIZE_AWARENESS}}"
+        deleted_title = "Session " + "Checkpoint Awareness"
+        source = Path("dev-pipeline/scripts/generate-refactor-prompt.py").read_text(encoding="utf-8")
+        template = Path("dev-pipeline/templates/refactor-bootstrap-prompt.md").read_text(encoding="utf-8")
+
+        assert (Path("dev-pipeline/templates/sections") / deleted_section).exists() is False
+        for content in (source, template):
+            for forbidden in (deleted_section, loader, placeholder, deleted_title):
+                assert forbidden not in content
+
+    def test_refactor_replacements_keep_session_log_without_max_log_placeholders(self, monkeypatch):
+        monkeypatch.setenv("PRIZMKIT_PLATFORM", "claude")
+        args = Namespace(
+            refactor_id="R-001",
+            session_id="session-1",
+            run_id="run-1",
+            retry_count="0",
+            resume_phase="null",
+            state_dir=None,
+            output="out.md",
+            template=None,
+            mode=None,
+            critic=None,
+        )
+        refactor = {"id": "R-001", "title": "Restructure", "description": "d"}
+
+        replacements = build_replacements(
+            args, refactor, [refactor], {}, str(Path("dev-pipeline/scripts").resolve())
+        )
+
+        assert replacements["{{SESSION_LOG_PATH}}"].endswith(
+            ".prizmkit/state/refactor/R-001/sessions/session-1/logs/session.log"
+        )
+        assert "{{" + REMOVED_MAX_LOG_ENV + "}}" not in replacements
+        assert "{{" + REMOVED_MAX_LOG_HUMAN + "}}" not in replacements
+        assert "{{LOG_" + "SIZE_AWARENESS}}" not in replacements
+
+
+HEADLESS_FORBIDDEN_PROMPT_STRINGS = [
+    "### Interactive Claude Code Note",
+    "### Project Conventions",
+    "Scaffold / generated file awareness",
+    "### Resume Behavior",
+    "[NEEDS CLARIFICATION]",
+    "pause for interactive input",
+    "prizmkit-test-gate.py",
+    "/compact",
+    "Session " + "Checkpoint Awareness",
+    "{{LOG_" + "SIZE_AWARENESS}}",
+]
+
+
+def test_template_source_is_clean_for_headless_prompt_contract():
+    content = Path("dev-pipeline/templates/refactor-bootstrap-prompt.md").read_text(encoding="utf-8")
+    for forbidden in HEADLESS_FORBIDDEN_PROMPT_STRINGS:
+        assert forbidden not in content