prizmkit 1.1.105 → 1.1.107

package/bundled/dev-pipeline/tests/test_generate_bootstrap_prompt.py

@@ -28,6 +28,20 @@ from generate_bootstrap_prompt import (
 )
 from continuation import append_continuation_handoff, checkpoint_cursor
 
+REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
+REMOVED_MAX_LOG_HUMAN = REMOVED_MAX_LOG_ENV + "_HUMAN"
+
+FORBIDDEN_DEV_FIX_PROMPT = "dev-" + "fix.md"
+FORBIDDEN_DEV_RESUME_PROMPT = "dev-" + "resume.md"
+FORBIDDEN_DEV_FIX_PLACEHOLDER = "{{AGENT_PROMPT_DEV_" + "FIX}}"
+FORBIDDEN_DEV_RESUME_PLACEHOLDER = "{{AGENT_PROMPT_DEV_" + "RESUME}}"
+FORBIDDEN_REVIEW_DEV_FIX = "Reviewer Agent → filter → " + "Dev Agent fix"
+FORBIDDEN_REVIEWER_DEV_SPAWN = "Reviewer/" + "Dev agent spawn"
+FORBIDDEN_EXPLORE_SUBAGENT = "subagent_type: " + "Explore"
+FORBIDDEN_TEST_CMD_PLACEHOLDER = "(" + "$TEST_CMD" + ")"
+FORBIDDEN_THREE_STRIKE = "3-" + "strike"
+FORBIDDEN_TWENTY_STEP = "20-" + "step window"
+
 
 def scoped_report_text(verdict="PASS", boundary_missing=0,
                        happy_path_only=0, completion_gate="yes",
@@ -222,6 +236,11 @@ class TestExplicitProjectRoot:
         assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
         assert replacements["{{PROJECT_BRIEF}}"] == "worktree brief"
         assert replacements["{{DEV_SUBAGENT_PATH}}"].startswith(str(execution_root.resolve()))
+        assert replacements["{{SESSION_LOG_PATH}}"].endswith(
+            ".prizmkit/state/features/F-001/sessions/session-1/logs/session.log"
+        )
+        assert "{{" + REMOVED_MAX_LOG_ENV + "}}" not in replacements
+        assert "{{" + REMOVED_MAX_LOG_HUMAN + "}}" not in replacements
 
 
     def test_main_writes_checkpoint_under_cli_project_root_and_status_under_state_dir(self, tmp_path, monkeypatch):
@@ -779,11 +798,14 @@ class TestHeadlessRecoveryReframing:
     def test_log_size_awareness_is_passive_checkpoint_guidance(self):
         content = load_log_size_section(str(Path("dev-pipeline/scripts").resolve()))
 
-        assert "Session Log Budget Awareness" in content
+        assert "Session Checkpoint Awareness" in content
         assert "passive checkpoint guidance" in content
         assert "durable checkpoints and artifacts" in content
         assert "fresh continuation session" in content
         assert "optional interactive convenience only" in content
+        assert REMOVED_MAX_LOG_ENV not in content
+        assert ("maximum-" + "log-size") not in content
+        assert ("log size " + "limit") not in content.lower()
         assert "COMPACT_NEEDED" not in content
         assert "monitor-log" not in content
         assert "background monitoring subagent" not in content
@@ -802,6 +824,10 @@ class TestHeadlessRecoveryReframing:
             )
             assert "Headless recovery must rely on durable checkpoints" in rendered
             assert "fresh continuation session" in rendered
+            assert REMOVED_MAX_LOG_ENV not in rendered
+            assert REMOVED_MAX_LOG_HUMAN not in rendered
+            assert ("209" + "7152") not in rendered
+            assert ("2" + "MB") not in rendered
             assert "monitor-log" not in rendered
             assert "COMPACT_NEEDED" not in rendered
             assert "log-size monitor" not in rendered
@@ -818,9 +844,16 @@ class TestDirectOrchestratorImplementationPrompts:
         replacements = load_active_agent_prompts(str(templates_dir))
 
         assert "dev-implement.md" not in ACTIVE_AGENT_PROMPTS
+        assert FORBIDDEN_DEV_FIX_PROMPT not in ACTIVE_AGENT_PROMPTS
+        assert FORBIDDEN_DEV_RESUME_PROMPT not in ACTIVE_AGENT_PROMPTS
         assert "{{AGENT_PROMPT_DEV_IMPLEMENT}}" not in replacements
+        assert FORBIDDEN_DEV_FIX_PLACEHOLDER not in replacements
+        assert FORBIDDEN_DEV_RESUME_PLACEHOLDER not in replacements
         assert "{{AGENT_PROMPT_CRITIC_PLAN_CHALLENGE}}" in replacements
+        assert "{{AGENT_PROMPT_REVIEWER_REVIEW}}" in replacements
         assert (templates_dir / "agent-prompts" / "dev-implement.md").exists() is False
+        assert (templates_dir / "agent-prompts" / FORBIDDEN_DEV_FIX_PROMPT).exists() is False
+        assert (templates_dir / "agent-prompts" / FORBIDDEN_DEV_RESUME_PROMPT).exists() is False
 
     def test_sections_all_modes_use_direct_orchestrator_implementation(self):
         sections_dir = Path("dev-pipeline/templates/sections").resolve()
@@ -840,7 +873,13 @@ class TestDirectOrchestratorImplementationPrompts:
             assert "Implement — Dev" not in rendered
             assert "{{AGENT_PROMPT_DEV_IMPLEMENT}}" not in rendered
             assert "dev-implement.md" not in rendered
-            assert "Reviewer Agent → filter → Dev Agent fix" in rendered
+            assert FORBIDDEN_REVIEW_DEV_FIX not in rendered
+            assert FORBIDDEN_REVIEWER_DEV_SPAWN not in rendered
+            assert FORBIDDEN_EXPLORE_SUBAGENT not in rendered
+            assert FORBIDDEN_TEST_CMD_PLACEHOLDER not in rendered
+            assert FORBIDDEN_THREE_STRIKE not in rendered
+            assert FORBIDDEN_TWENTY_STEP not in rendered
+            assert "Reviewer Agent → filter → orchestrator fix" in rendered
 
     def test_legacy_tier_templates_use_direct_orchestrator_implementation(self):
         for template_name in ("bootstrap-tier2.md", "bootstrap-tier3.md"):
@@ -853,6 +892,12 @@ class TestDirectOrchestratorImplementationPrompts:
             assert "Implement — Dev" not in rendered
             assert "{{AGENT_PROMPT_DEV_IMPLEMENT}}" not in rendered
             assert "dev-implement.md" not in rendered
+            assert FORBIDDEN_REVIEW_DEV_FIX not in rendered
+            assert FORBIDDEN_REVIEWER_DEV_SPAWN not in rendered
+            assert FORBIDDEN_EXPLORE_SUBAGENT not in rendered
+            assert FORBIDDEN_TEST_CMD_PLACEHOLDER not in rendered
+            assert FORBIDDEN_THREE_STRIKE not in rendered
+            assert FORBIDDEN_TWENTY_STEP not in rendered
 
 
 # ---------------------------------------------------------------------------
@@ -898,6 +943,8 @@ class TestContinuationHandoff:
         assert ".prizmkit/state/features/F-123/sessions/F-123-new/logs/session.log" in rendered
         assert ".prizmkit/state/features/F-123/sessions/F-123-new/logs/progress.json" in rendered
         assert ".prizmkit/state/features/F-123/sessions/F-123-new/logs/ai.pid" in rendered
+        assert ("Log " + "monitor") not in rendered
+        assert ("log-" + "monitor") not in rendered
 
         summary = tmp_path / ".prizmkit/specs/123-continuation/continuation-summary.md"
         assert summary.exists()

package/bundled/dev-pipeline/tests/test_generate_bugfix_prompt.py

@@ -16,6 +16,9 @@ from generate_bugfix_prompt import (
 )
 from continuation import append_continuation_handoff
 
+REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
+REMOVED_MAX_LOG_HUMAN = REMOVED_MAX_LOG_ENV + "_HUMAN"
+
 
 # ---------------------------------------------------------------------------
 # find_bug
@@ -193,6 +196,11 @@ class TestExplicitProjectRoot:
         )
         assert not replacements["{{SESSION_STATUS_PATH}}"].startswith(str(execution_root.resolve()))
         assert replacements["{{DEV_SUBAGENT_PATH}}"].startswith(str(execution_root.resolve()))
+        assert replacements["{{SESSION_LOG_PATH}}"].endswith(
+            ".prizmkit/state/bugfix/B-001/sessions/session-1/logs/session.log"
+        )
+        assert "{{" + REMOVED_MAX_LOG_ENV + "}}" not in replacements
+        assert "{{" + REMOVED_MAX_LOG_HUMAN + "}}" not in replacements
 
 
 # ---------------------------------------------------------------------------
@@ -225,6 +233,9 @@ class TestHeadlessRecoveryReframing:
         assert "Headless recovery must rely on durable checkpoints" in content
         assert "fresh continuation session" in content
         assert "optional interactive convenience only" in content
+        assert REMOVED_MAX_LOG_ENV not in content
+        assert ("maximum-" + "log-size") not in content
+        assert ("log size " + "limit") not in content.lower()
         assert "COMPACT_NEEDED" not in content
         assert "monitor-log" not in content
         assert "background monitoring subagent" not in content
@@ -235,6 +246,10 @@ class TestHeadlessRecoveryReframing:
         content = Path("dev-pipeline/templates/bugfix-bootstrap-prompt.md").read_text(encoding="utf-8")
 
         assert "Do not spawn persistent background subagents for headless recovery" in content
+        assert REMOVED_MAX_LOG_ENV not in content
+        assert REMOVED_MAX_LOG_HUMAN not in content
+        assert ("209" + "7152") not in content
+        assert ("2" + "MB") not in content
         assert "log-size monitor" not in content
         assert "monitor-log" not in content
         assert "COMPACT_NEEDED" not in content
@@ -264,5 +279,7 @@ class TestBugfixContinuationHandoff:
         assert prompt.startswith("BUGFIX PROMPT")
         assert "This is an automatic continuation after context overflow." in prompt
         assert "Do not attempt `/compact` as the recovery mechanism." in prompt
+        assert ("Log " + "monitor") not in prompt
+        assert ("log-" + "monitor") not in prompt
         assert (tmp_path / ".prizmkit/specs/B-007/continuation-summary.md").exists()
         assert (tmp_path / ".prizmkit/bugfix/B-007/continuation-summary.md").exists()

package/bundled/dev-pipeline/tests/test_generate_refactor_prompt.py

@@ -1,9 +1,18 @@
 """Tests for generate-refactor-prompt.py continuation behavior."""
 
 from argparse import Namespace
+from pathlib import Path
 
 from continuation import append_continuation_handoff
-from generate_refactor_prompt import generate_refactor_checkpoint, merge_refactor_checkpoint_state
+from generate_refactor_prompt import (
+    build_replacements,
+    generate_refactor_checkpoint,
+    load_log_size_section,
+    merge_refactor_checkpoint_state,
+)
+
+REMOVED_MAX_LOG_ENV = "MAX_" + "LOG_SIZE"
+REMOVED_MAX_LOG_HUMAN = REMOVED_MAX_LOG_ENV + "_HUMAN"
 
 
 class TestRefactorContinuationHandoff:
@@ -27,6 +36,8 @@ class TestRefactorContinuationHandoff:
         assert prompt.startswith("REFACTOR PROMPT")
         assert "This is a fresh headless AI CLI session for the same task." in prompt
         assert "Do not attempt `/compact` as the recovery mechanism." in prompt
+        assert ("Log " + "monitor") not in prompt
+        assert ("log-" + "monitor") not in prompt
         assert (tmp_path / ".prizmkit/specs/R-007/continuation-summary.md").exists()
         assert (tmp_path / ".prizmkit/refactor/R-007/continuation-summary.md").exists()
 
@@ -41,3 +52,41 @@ class TestRefactorCheckpointMerge:
 
         assert merged["steps"][0]["status"] == "skipped"
         assert merged["steps"][1]["status"] == "pending"
+
+
+class TestRefactorPromptMaxLogRemoval:
+    def test_refactor_log_size_section_is_checkpoint_guidance_without_max_log_env(self):
+        content = load_log_size_section(str(Path("dev-pipeline/scripts").resolve()))
+
+        assert "passive checkpoint guidance" in content
+        assert "Headless recovery must rely on durable checkpoints" in content
+        assert "fresh continuation session" in content
+        assert REMOVED_MAX_LOG_ENV not in content
+        assert REMOVED_MAX_LOG_HUMAN not in content
+        assert ("maximum-" + "log-size") not in content
+        assert ("log size " + "limit") not in content.lower()
+
+    def test_refactor_replacements_keep_session_log_without_max_log_placeholders(self):
+        args = Namespace(
+            refactor_id="R-001",
+            session_id="session-1",
+            run_id="run-1",
+            retry_count="0",
+            resume_phase="null",
+            state_dir=None,
+            output="out.md",
+            template=None,
+            mode=None,
+            critic=None,
+        )
+        refactor = {"id": "R-001", "title": "Restructure", "description": "d"}
+
+        replacements = build_replacements(
+            args, refactor, [refactor], {}, str(Path("dev-pipeline/scripts").resolve())
+        )
+
+        assert replacements["{{SESSION_LOG_PATH}}"].endswith(
+            ".prizmkit/state/refactor/R-001/sessions/session-1/logs/session.log"
+        )
+        assert "{{" + REMOVED_MAX_LOG_ENV + "}}" not in replacements
+        assert "{{" + REMOVED_MAX_LOG_HUMAN + "}}" not in replacements