privateer-agent 0.14.4 → 0.14.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "privateer-agent",
-  "version": "0.14.4",
+  "version": "0.14.5",
   "description": "Privacy-first terminal coding agent — bring your own model across 20 providers (Anthropic, OpenAI, OpenRouter, Google, local Ollama…). Safe-by-default permissions, MCP, sub-agents, workflows, and verifiable TEE inference. Built on the Pi toolkit.",
   "type": "module",
   "license": "MIT",

package/src/bridge/engineAdapter.ts

@@ -73,11 +73,17 @@ export function createEngineEventAdapter() {
   let turnTotal: UsageTotals = emptyUsage();
   let lastMessage: any;
   let terminalSent = false;
+  // Between agent_start and agent_settled. Compaction maps to `step-finish` to keep
+  // the app's busy pill lit through an auto-compaction INSIDE a run — but a manual
+  // `/compact` runs with no run around it, and a `step-finish` there opened a turn
+  // in the app that no `finish` would ever close: the pill spun until Stop.
+  let inRun = false;
 
   function toEngineEvents(ev: PiSessionEvent): EngineEvent[] {
     switch (ev.type) {
       case "agent_start":
         terminalSent = false;
+        inRun = true;
         return [];
 
       case "message_update": {
@@ -136,6 +142,7 @@ export function createEngineEventAdapter() {
       }
 
       case "agent_settled": {
+        inRun = false;
         if (terminalSent) return [];
         terminalSent = true;
         const msg = lastMessage;
@@ -158,7 +165,7 @@ export function createEngineEventAdapter() {
       }
 
       case "compaction_start":
-        return [{ type: "step-finish" }];
+        return inRun ? [{ type: "step-finish" }] : [];
       case "compaction_end":
         return [
           {

package/src/cli/chat.ts

@@ -349,6 +349,7 @@ async function main() {
       return;
     }
     turnActive = true;
+    let failure: string | undefined;
     if (remote && echo) console.log(`\n${DIM}⟿ [app] ${text.slice(0, 80)}${RESET}`);
     try {
       // Re-arm the account channel BEFORE the prompt, because nothing downstream can.
@@ -375,10 +376,13 @@ async function main() {
       }
       await session.prompt(mentions.text, mentions.images.length ? { images: mentions.images } : undefined);
     } catch (e) {
-      console.log(`\n${RED}${(e as Error).message}${RESET}`);
+      failure = (e as Error).message || "The turn failed.";
+      console.log(`\n${RED}${failure}${RESET}`);
     } finally {
       turnActive = false;
-      if (remote) bridge.settleTurn();
+      // The failure goes to the app too: a throw here (no model, no key, auth
+      // precheck) used to print on this console only while the app's pill spun on.
+      if (remote) bridge.settleTurn(failure);
     }
   }
 

package/src/config/whatsNew.json

@@ -1,6 +1,6 @@
 {
   "$comment": "The banner's What's New list, newest first: the two to four things a returning user should notice, not a changelog. `reviewedFor` is the release this list was last looked at for. A release can't ship until it equals package.json's version (scripts/check-whats-new.mjs, run by `npm test` and by release.yml before anything builds), so every release, patches included, is a deliberate look at this list. If nothing new is worth a line, bumping `reviewedFor` alone is the answer. `since` is the release an entry arrived in. `cmd` is shown in the accent colour.",
-  "reviewedFor": "0.14.4",
+  "reviewedFor": "0.14.5",
   "items": [
     { "text": "Save to Cargo with no app attached — it lands on your next app open", "since": "0.14.4" },
     { "text": "Several privateer -p runs at once no longer sign each other out", "since": "0.14.3" },

package/src/remote/liveTaskSession.ts

@@ -140,6 +140,7 @@ export async function createLiveTaskSession(spec: TaskSpec, deps: LiveTaskDeps):
   const runTurn = async (text: string): Promise<void> => {
     if (turnActive || stopped) return;
     turnActive = true;
+    let failure: string | undefined;
     lastAnswer = "";   // keep the CLOSING answer, not the whole session
     turnErrored = false;
     try {
@@ -161,10 +162,11 @@ export async function createLiveTaskSession(spec: TaskSpec, deps: LiveTaskDeps):
       await session.prompt(text + note);
     } catch (e) {
       turnErrored = true;
-      deps.log(`live task ${termId} turn error: ${(e as Error).message}`);
+      failure = (e as Error).message || "The turn failed.";
+      deps.log(`live task ${termId} turn error: ${failure}`);
     } finally {
       turnActive = false;
-      bridge.settleTurn();
+      bridge.settleTurn(failure);
     }
   };
 

package/src/remote/remoteBridge.ts

@@ -15,7 +15,8 @@ import { noQuarterActive, setNoQuarter } from "../permissions/noQuarter.ts";
 // Pure env-var accessors (see config/privacyDisabled.ts) — no Pi, no node builtins,
 // so this stays safe to import from the bridge, which boot-ordered code reaches.
 import { onPrivacyDisabledChange, privacyDisabled, setPrivacyDisabled } from "../config/privacyDisabled.ts";
-import type { EngineEvent } from "../engine/events.ts";
+import { emptyUsage, type EngineEvent } from "../engine/events.ts";
+import { redactText } from "../util/redact.ts";
 import type { PermissionRequest } from "../permissions/gate.ts";
 import type { AskOutcome } from "../permissions/modeGate.ts";
 import type { RelayCallbacks } from "./relayClient.ts";
@@ -196,6 +197,14 @@ export class RemoteBridge {
   private turnDriven = false;
   private turnPrompt = "";
   private turnText = "";
+  // Did this turn already put finish/aborted/error on the wire? The app lights its
+  // working pill the moment it SENDS a prompt and only ever puts it out on one of
+  // those three, but Pi's prompt() has paths that never run the agent at all — an
+  // extension command or input hook that handles the text, a throw on the
+  // no-model / no-key / auth precheck, "compaction in progress". Each returned (or
+  // threw into a catch that only printed locally) with no terminal event, and the
+  // driver watched a spinner nothing would ever clear. settleTurn closes the gap.
+  private turnTerminalSent = false;
 
   // Unsubscribes the privacy watcher below. Held so a bridge that outlives its window
   // (the desktop builds one per window, in one process) stops writing to a transport
@@ -232,6 +241,7 @@ export class RemoteBridge {
       this.turnDriven = true;
       this.turnPrompt = text;
       this.turnText = "";
+      this.turnTerminalSent = false;
       const attachments = this.pendingAttachments;
       this.pendingAttachments = [];
       this.cfg.onPrompt(text, attachments);
@@ -460,20 +470,33 @@ export class RemoteBridge {
   // ── turn lifecycle + event forwarding ───────────────────────────────────────
 
   // Mark the end of a turn so the next (possibly local) turn isn't treated as
-  // remote. Call after each driven turn completes.
+  // remote. Call after each driven turn completes, passing the rejection message
+  // if prompt() threw.
+  //
+  // A DRIVEN turn always leaves here with exactly one terminal event on the wire
+  // (see turnTerminalSent): if the session never sent one, this sends it — `error`
+  // carrying the throw, or a plain `finish` for a prompt Pi handled without
+  // running the agent. Desktop's turnSupervisor emits its own terminal before it
+  // settles, so it is seen here and never doubled.
   //
   // Also the one moment we can tell whether the turn had an audience. If the app
   // drove it and is now gone, everything the turn streamed up was dropped by the
   // relay — so hand the answer to the owner for durable delivery rather than letting
   // a completed piece of work evaporate because someone closed their phone.
-  settleTurn(): void {
+  settleTurn(error?: string): void {
     const driven = this.turnDriven;
     const prompt = this.turnPrompt;
     const content = this.turnText.trim();
+    if (driven && !this.turnTerminalSent) {
+      this.forwardEvent(error
+        ? { type: "error", error: redactText(error) }
+        : { type: "finish", usage: emptyUsage(), finishReason: "stop" });
+    }
     this.remote = false;
     this.turnDriven = false;
     this.turnPrompt = "";
     this.turnText = "";
+    this.turnTerminalSent = false;
     if (!driven || !content) return;
     // Unknown (a relay that can't report presence) counts as watched: better to skip
     // delivery than to duplicate something the app already showed in its feed.
@@ -488,6 +511,7 @@ export class RemoteBridge {
     // Keep the driven turn's reply as it streams, in case settleTurn finds nobody
     // was there to read it. Text only: the outbox item is the answer, not a
     // transcript of every tool call.
+    if (ev.type === "finish" || ev.type === "aborted" || ev.type === "error") this.turnTerminalSent = true;
     if (this.turnDriven && ev.type === "text" && this.turnText.length < MAX_TURN_CAPTURE) {
       this.turnText += String(ev.text ?? "");
     }