prismarine-windows 2.5.0 → 2.6.1

package/HISTORY.md

@@ -1,6 +1,14 @@
+## 2.6.1
+
+* fix typo
+
+## 2.6.0
+
+* mcData to registry refactoring + anticipation of feature check refactoring
+
 ## 2.5.0
 
-* Extend the events used for windows
+* Extend the events used for  windows
 
 ## 2.4.4
 * update mcdata

package/index.js

@@ -1,10 +1,11 @@
-function loader (mcVersion) {
-  const Item = require('prismarine-item')(mcVersion)
+function loader (registryOrVersion) {
+  const registry = typeof registryOrVersion === 'string' ? require('prismarine-registry')(registryOrVersion) : registryOrVersion
+  const Item = require('prismarine-item')(registry)
   const Window = require('./lib/Window')(Item)
-  const mcData = require('minecraft-data')(mcVersion)
 
   let windows
-  if (mcData.isNewerOrEqualTo('1.14')) {
+  // if (registry.supportFeature("village&pillageInventoryWindows")) {
+  if (registry.isNewerOrEqualTo('1.14')) { // this line should be discarded for the one above when the corresponding feature is added to minecraft-data
     // https://wiki.vg/Inventory
     windows = {}
     let protocolId = -1
@@ -29,7 +30,8 @@ function loader (mcVersion) {
     windows['minecraft:loom'] = { type: protocolId++, inventory: { start: 4, end: 39 }, slots: 40, craft: 3, requireConfirmation: true }
     windows['minecraft:merchant'] = { type: protocolId++, inventory: { start: 3, end: 38 }, slots: 39, craft: 2, requireConfirmation: true }
     windows['minecraft:shulker_box'] = { type: protocolId++, inventory: { start: 27, end: 62 }, slots: 63, craft: -1, requireConfirmation: true }
-    if (mcData.isNewerOrEqualTo('1.16')) {
+    // if (registry.supportFeature("netherUpdateInventoryWindows")) {
+    if (registry.isNewerOrEqualTo('1.16')) { // this line should be discarded for the one above when the corresponding feature is added to minecraft-data
       windows['minecraft:smithing'] = { type: protocolId++, inventory: { start: 3, end: 38 }, slots: 39, craft: 2, requireConfirmation: true }
     }
     windows['minecraft:smoker'] = { type: protocolId++, inventory: { start: 3, end: 38 }, slots: 39, craft: 2, requireConfirmation: true }
@@ -37,8 +39,10 @@ function loader (mcVersion) {
     windows['minecraft:stonecutter'] = { type: protocolId++, inventory: { start: 2, end: 37 }, slots: 38, craft: 1, requireConfirmation: true }
   } else {
     // https://wiki.vg/index.php?title=Inventory&oldid=14093
+    // const inventorySlots = registry.supportFeature("shieldSlot") ? 46 : 45
+    const inventorySlots = registry.isNewerOrEqualTo('1.9') ? 46 : 45// this line should be discarded for the one above when the corresponding feature is added to minecraft-data
     windows = {
-      'minecraft:inventory': { type: 'minecraft:inventory', inventory: { start: 9, end: 44 }, slots: mcData.isNewerOrEqualTo('1.9') ? 46 : 45, craft: 0, requireConfirmation: true },
+      'minecraft:inventory': { type: 'minecraft:inventory', inventory: { start: 9, end: 44 }, slots: inventorySlots, craft: 0, requireConfirmation: true },
       'minecraft:chest': null,
       'minecraft:crafting_table': { type: 'minecraft:crafting_table', inventory: { start: 10, end: 45 }, slots: 46, craft: 0, requireConfirmation: true },
       'minecraft:furnace': { type: 'minecraft:furnace', inventory: { start: 3, end: 38 }, slots: 39, craft: 2, requireConfirmation: true },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prismarine-windows",
-  "version": "2.5.0",
+  "version": "2.6.1",
   "description": "Represent minecraft windows",
   "main": "index.js",
   "scripts": {
@@ -13,7 +13,7 @@
     "url": "git+ssh://git@github.com/PrismarineJS/prismarine-windows.git"
   },
   "dependencies": {
-    "minecraft-data": "^3.0.0",
+    "prismarine-registry": "^1.5.0",
     "prismarine-item": "^1.5.0",
     "typed-emitter": "^1.0.0"
   },