prism-mcp-server 19.2.7 → 19.2.9

package/dist/tools/__tests__/ledgerHandlers.test.js

@@ -54,6 +54,7 @@ vi.mock("../../../src/config.js", () => ({
     PRISM_GRAPH_PRUNE_MAX_PROJECTS_PER_SWEEP: 25,
     PRISM_ACTR_ENABLED: false,
     PRISM_ACTR_ACCESS_LOG_RETENTION_DAYS: 90,
+    SYNALUX_CONFIGURED: false,
 }));
 vi.mock("../../../src/utils/logger.js", () => ({
     debugLog: vi.fn(),
@@ -427,7 +428,7 @@ describe("ledgerHandlers", () => {
             });
             const text = result.content[0].text;
             // With 100 tokens * 4 chars = 400 char budget, the 5000-char summary gets truncated
-            expect(text).toContain("truncated to fit token budget");
+            expect(text).toContain("Sections omitted to fit token budget");
         });
         it("includes recent sessions in formatted output", async () => {
             storage.loadContext.mockResolvedValue({
@@ -677,36 +678,36 @@ describe("ledgerHandlers", () => {
     describe("sessionForgetMemoryHandler", () => {
         it("soft-deletes a memory entry by default", async () => {
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-123",
+                memory_id: "550e8400-e29b-41d4-a716-446655440123",
             });
             expect(result.isError).toBe(false);
             expect(result.content[0].text).toContain("Soft Deleted");
-            expect(result.content[0].text).toContain("uuid-123");
-            expect(storage.softDeleteLedger).toHaveBeenCalledWith("uuid-123", "test-user-id", undefined);
+            expect(result.content[0].text).toContain("550e8400-e29b-41d4-a716-446655440123");
+            expect(storage.softDeleteLedger).toHaveBeenCalledWith("550e8400-e29b-41d4-a716-446655440123", "test-user-id", undefined);
         });
         it("soft-deletes with reason for audit trail", async () => {
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-456",
+                memory_id: "550e8400-e29b-41d4-a716-446655440456",
                 reason: "GDPR Article 17 request",
             });
             expect(result.isError).toBe(false);
             expect(result.content[0].text).toContain("Reason");
             expect(result.content[0].text).toContain("GDPR Article 17 request");
-            expect(storage.softDeleteLedger).toHaveBeenCalledWith("uuid-456", "test-user-id", "GDPR Article 17 request");
+            expect(storage.softDeleteLedger).toHaveBeenCalledWith("550e8400-e29b-41d4-a716-446655440456", "test-user-id", "GDPR Article 17 request");
         });
         it("hard-deletes when hard_delete is true", async () => {
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-789",
+                memory_id: "550e8400-e29b-41d4-a716-446655440789",
                 hard_delete: true,
             });
             expect(result.isError).toBe(false);
             expect(result.content[0].text).toContain("Hard Deleted");
             expect(result.content[0].text).toContain("permanently removed");
-            expect(storage.hardDeleteLedger).toHaveBeenCalledWith("uuid-789", "test-user-id");
+            expect(storage.hardDeleteLedger).toHaveBeenCalledWith("550e8400-e29b-41d4-a716-446655440789", "test-user-id");
         });
         it("does not call hardDeleteLedger when hard_delete is false", async () => {
             await sessionForgetMemoryHandler({
-                memory_id: "uuid-aaa",
+                memory_id: "550e8400-e29b-41d4-a716-446655440aaa",
                 hard_delete: false,
             });
             expect(storage.hardDeleteLedger).not.toHaveBeenCalled();
@@ -731,7 +732,7 @@ describe("ledgerHandlers", () => {
         it("catches storage errors and returns isError (never throws)", async () => {
             storage.softDeleteLedger.mockRejectedValue(new Error("Entry not found"));
             const result = await sessionForgetMemoryHandler({
-                memory_id: "nonexistent-uuid",
+                memory_id: "550e8400-e29b-41d4-a716-446655440f99",
             });
             expect(result.isError).toBe(true);
             expect(result.content[0].text).toContain("Entry not found");
@@ -739,7 +740,7 @@ describe("ledgerHandlers", () => {
         it("catches hard_delete storage errors gracefully", async () => {
             storage.hardDeleteLedger.mockRejectedValue(new Error("FK constraint"));
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-fail",
+                memory_id: "550e8400-e29b-41d4-a716-446655440f11",
                 hard_delete: true,
             });
             expect(result.isError).toBe(true);
@@ -753,6 +754,7 @@ describe("ledgerHandlers", () => {
         let tempDir;
         beforeEach(async () => {
             tempDir = await mkdtemp(join(tmpdir(), "prism-handler-export-"));
+            process.env.PRISM_EXPORT_ROOT = tempDir;
             storage.listProjects.mockResolvedValue(["test-project"]);
             storage.getLedgerEntries.mockResolvedValue([
                 { id: "entry-1", summary: "Session 1", importance: 3 },
@@ -763,6 +765,7 @@ describe("ledgerHandlers", () => {
             });
         });
         afterEach(async () => {
+            delete process.env.PRISM_EXPORT_ROOT;
             await rm(tempDir, { recursive: true, force: true });
         });
         it("exports JSON file for a single project", async () => {
@@ -832,7 +835,7 @@ describe("ledgerHandlers", () => {
         });
         afterEach(async () => {
             // Clean up vault directory if created
-            const vaultDir = join(os.homedir(), ".prism-mcp", "media", "test-project");
+            const vaultDir = join(os.homedir(), ".prism-mcp", "media", "__test-img__");
             if (fs.existsSync(vaultDir)) {
                 await rm(vaultDir, { recursive: true, force: true });
             }
@@ -840,7 +843,7 @@ describe("ledgerHandlers", () => {
         });
         it("saves an image and returns success with image ID", async () => {
             const result = await sessionSaveImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 file_path: testImagePath,
                 description: "Dashboard screenshot",
             });
@@ -851,7 +854,7 @@ describe("ledgerHandlers", () => {
         });
         it("updates handoff metadata with visual memory entry", async () => {
             await sessionSaveImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 file_path: testImagePath,
                 description: "UI mockup",
             });
@@ -862,8 +865,8 @@ describe("ledgerHandlers", () => {
         });
         it("returns error for non-existent file", async () => {
             const result = await sessionSaveImageHandler({
-                project: "test-project",
-                file_path: "/nonexistent/path/image.png",
+                project: "__test-img__",
+                file_path: join(tempDir, "does-not-exist.png"),
                 description: "Missing image",
             });
             expect(result.isError).toBe(true);
@@ -873,7 +876,7 @@ describe("ledgerHandlers", () => {
             const bmpPath = join(tempDir, "test.bmp");
             fs.writeFileSync(bmpPath, Buffer.from([0x42, 0x4d]));
             const result = await sessionSaveImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 file_path: bmpPath,
                 description: "BMP image",
             });
@@ -883,7 +886,7 @@ describe("ledgerHandlers", () => {
         it("returns error when no active context exists", async () => {
             storage.loadContext.mockResolvedValue(null);
             const result = await sessionSaveImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 file_path: testImagePath,
                 description: "No context image",
             });
@@ -893,7 +896,7 @@ describe("ledgerHandlers", () => {
         // --- Input Validation ---
         it("returns error for invalid args (missing required fields)", async () => {
             const result = await sessionSaveImageHandler({
-                project: "test-project",
+                project: "__test-img__",
             });
             expect(result.isError).toBe(true);
             expect(result.content[0].text).toContain("Invalid arguments");
@@ -912,7 +915,7 @@ describe("ledgerHandlers", () => {
         let vaultImagePath;
         beforeEach(async () => {
             tempDir = await mkdtemp(join(tmpdir(), "prism-view-image-test-"));
-            vaultDir = join(os.homedir(), ".prism-mcp", "media", "test-project");
+            vaultDir = join(os.homedir(), ".prism-mcp", "media", "__test-img__");
             fs.mkdirSync(vaultDir, { recursive: true });
             // Create a test image in the vault
             vaultImagePath = join(vaultDir, "abc12345.png");
@@ -941,7 +944,7 @@ describe("ledgerHandlers", () => {
                 },
             });
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 image_id: "abc12345",
             });
             expect(result.isError).toBe(false);
@@ -964,7 +967,7 @@ describe("ledgerHandlers", () => {
                 },
             });
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 image_id: "nonexistent",
             });
             expect(result.isError).toBe(true);
@@ -976,7 +979,7 @@ describe("ledgerHandlers", () => {
                 metadata: {},
             });
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 image_id: "any-id",
             });
             expect(result.isError).toBe(true);
@@ -997,7 +1000,7 @@ describe("ledgerHandlers", () => {
                 },
             });
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 image_id: "abc12345",
             });
             expect(result.isError).toBe(true);
@@ -1018,7 +1021,7 @@ describe("ledgerHandlers", () => {
                 },
             });
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
                 image_id: "abc12345",
             });
             expect(result.isError).toBe(false);
@@ -1028,7 +1031,7 @@ describe("ledgerHandlers", () => {
         // --- Input Validation ---
         it("returns error for invalid args (missing image_id)", async () => {
             const result = await sessionViewImageHandler({
-                project: "test-project",
+                project: "__test-img__",
             });
             expect(result.isError).toBe(true);
         });
@@ -1154,13 +1157,13 @@ describe("ledgerHandlers", () => {
         });
         it("sessionForgetMemoryHandler includes 'tombstoned' in soft-delete response", async () => {
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-test",
+                memory_id: "550e8400-e29b-41d4-a716-446655440001",
             });
             expect(result.content[0].text).toContain("tombstoned");
         });
         it("sessionForgetMemoryHandler mentions hard_delete option in soft-delete response", async () => {
             const result = await sessionForgetMemoryHandler({
-                memory_id: "uuid-test",
+                memory_id: "550e8400-e29b-41d4-a716-446655440001",
             });
             expect(result.content[0].text).toContain("hard_delete: true");
         });

package/dist/tools/ingestHandler.js

@@ -12,6 +12,7 @@
  * The handler is storage-agnostic — works with SQLite (local) or Supabase (remote).
  */
 import { readFileSync, existsSync } from "fs";
+import { resolve as resolvePath } from "path";
 import { basename } from "path";
 import { PRISM_USER_ID } from "../config.js";
 import { getStorage } from "../storage/index.js";
@@ -103,7 +104,7 @@ export async function ingestKnowledge(args) {
     const { project, source_label, chunk_size = 4000, } = args;
     let content = args.content || "";
     if (args.file_path) {
-        const resolved = require("path").resolve(args.file_path);
+        const resolved = resolvePath(args.file_path);
         const blocked = ["/etc", "/var", "/usr", "/sys", "/proc", "/dev", "/root",
             "/.ssh", "/.env", "/.git/config", "/private/etc"].some(p => resolved.startsWith(p) || resolved.includes("/."));
         if (blocked) {

package/dist/tools/ledgerHandlers.js

@@ -89,7 +89,7 @@ const MEMORY_BOUNDARY_SUFFIX = '\n</prism_memory>';
  * After saving, generates an embedding vector for the entry via fire-and-forget.
  */
 import { computeEffectiveImportance, recordMemoryAccess } from "../utils/cognitiveMemory.js";
-import { formatInferenceMetrics, resetInferenceMetrics } from "../utils/inferenceMetrics.js";
+import { formatInferenceMetrics, resetInferenceMetrics, getInferenceSnapshot } from "../utils/inferenceMetrics.js";
 export async function sessionSaveLedgerHandler(args) {
     if (!isSessionSaveLedgerArgs(args)) {
         throw new Error("Invalid arguments for session_save_ledger");
@@ -581,10 +581,17 @@ export async function sessionLoadContextHandler(args) {
     if (!isSessionLoadContextArgs(args)) {
         throw new Error("Invalid arguments for session_load_context");
     }
-    resetInferenceMetrics();
+    // T3 fix: only reset metrics at true session start (totalCalls==0), not on GATE 5 mid-session
+    // reloads. Resetting on every call wipes accumulated delegation metrics right before
+    // session_save_ledger renders them, making the 📊 block show near-zero after any reload.
+    if (getInferenceSnapshot().totalCalls === 0) {
+        resetInferenceMetrics();
+    }
     const { project, level = "standard", role } = args;
-    const maxTokens = args.max_tokens
-        || parseInt(await getSetting("max_tokens", "0"), 10) || undefined; // v4.0: arg > dashboard setting > none
+    // T6 fix: explicit Number() coercion prevents string "2000" from later concatenating instead of adding
+    const _maxTokensArg = Number(args.max_tokens);
+    const _maxTokensSetting = parseInt(await getSetting("max_tokens", "0"), 10);
+    const maxTokens = (_maxTokensArg > 0 ? _maxTokensArg : undefined) ?? (_maxTokensSetting > 0 ? _maxTokensSetting : undefined);
     const agentName = await getSetting("agent_name", "");
     const validLevels = ["quick", "standard", "deep"];
     if (!validLevels.includes(level)) {
@@ -600,12 +607,30 @@ export async function sessionLoadContextHandler(args) {
     const storage = await getStorage();
     const effectiveRole = role || await getSetting("default_role", "") || undefined;
     const data = await storage.loadContext(project, level, PRISM_USER_ID, effectiveRole); // v3.0: role with dashboard fallback
+    // F4 fix: inject protected skills even for fresh projects.
+    // Previously this returned before skill injection, leaving new projects with zero
+    // behavioral guardrails for the entire session. Now protected skills always load.
     if (!data) {
+        let freshSkillBlock = "";
+        try {
+            const { resolveSkillsForProject: resolveForFresh } = await import("./skillRouting.js");
+            const freshResolved = await resolveForFresh(project);
+            for (const entry of freshResolved.skills.filter(e => e.protected)) {
+                const content = await getSetting(`skill:${entry.name}`, "");
+                if (!content?.trim())
+                    continue;
+                freshSkillBlock += `\n\n[📜 SKILL: ${entry.name}]\n${content.trim()}`;
+            }
+        }
+        catch {
+            debugLog(`[session_load_context] Fresh project skill injection failed — continuing without`);
+        }
         return {
             content: [{
                     type: "text",
                     text: `No session context found for project "${project}" at level ${level}.\n` +
-                        `This project has no previous session history. Starting fresh.`,
+                        `This project has no previous session history. Starting fresh.` +
+                        freshSkillBlock,
                 }],
             isError: false,
         };
@@ -855,6 +880,10 @@ export async function sessionLoadContextHandler(args) {
     const resolved = await resolveSkillsForProject(project);
     const sortedSkills = resolved.skills;
     const userLocalPolicy = resolved.user_local;
+    // F5: surface offline routing to the agent so it knows project/keyword skills may be missing
+    if (resolved.isOffline) {
+        skillBlock += `\n\n[⚠️ OFFLINE ROUTING: synalux.ai unreachable — using stale or fallback routing table. Project-specific and keyword-triggered skills may be missing. Universal protected skills still load.]`;
+    }
     let synaluxContent = {};
     if (SYNALUX_CONFIGURED && storage && typeof storage.fetchSkillContent === "function") {
         const missing = sortedSkills.map(s => s.name).filter(n => !loadedSkills.includes(n));
@@ -994,12 +1023,8 @@ export async function sessionLoadContextHandler(args) {
             behavWarnings.map(w => `- ${w.summary} (importance: ${w.importance})`).join("\n");
         behavBlock = [...rawBlock].slice(0, 2000).join('');
     }
-    let responseText = `${MEMORY_BOUNDARY_PREFIX}📋 Session context for "${project}" (${level}):\n\n${formattedContext.trim()}${splitBrainWarning}${driftReport}${briefingBlock}${sdmRecallBlock}${greetingBlock}${visualMemoryBlock}${behavBlock}${skillBlock}${versionNote}`;
     // ─── v9.4.7: ABA Precision Protocol (foundational) ────────
-    // Injected into EVERY session load so the agent always operates
-    // under these behavioral rules. Never truncated (placed before
-    // token budget check).
-    responseText += `\n\n[🧠 ABA PRECISION PROTOCOL]\n` +
+    const abaProtocol = `\n\n[🧠 ABA PRECISION PROTOCOL]\n` +
         `Rule 1 — Observable Goals: Every task must have a measurable, verifiable outcome. State the specific result.\n` +
         `Rule 2 — Precise Execution: One step at a time. Verify each step. If it fails → STOP → fix → verify → then continue.\n` +
         `Rule 3 — No Reinforcement of Errors: Never repeat the same mistake twice. When the user says something is wrong, read the actual code/data FIRST before forming an opinion.\n` +
@@ -1007,15 +1032,57 @@ export async function sessionLoadContextHandler(args) {
         `Rule 5 — Fix Without Asking: When you see a bug, fix it immediately. Do NOT ask "would you like me to fix that?" — just fix it.\n` +
         `Rule 6 — Action Intent: When user says "fix/run/open/deploy", they want ACTION not a tutorial. Ask for specific info needed in 1-2 sentences, or act directly.\n` +
         `Rule 7 — Tool Redirect: When user asks to "open browser"/"run terminal"/"git push" — output ONLY the URL or command. No follow-up. No explanations. Example: "open browser" → "https://synalux.ai/dashboard"`;
-    // ─── v4.0: Token Budget Truncation ─────────────────────────
-    // 1 token ≈ 4 chars heuristic. Truncate if response exceeds budget.
+    // T5 structural truncation: assemble sections in priority order so budget truncation
+    // drops the LEAST critical sections first (session history), never skills.
+    // Priority high→low: ABA | skills | behavioral warnings | version | drift | briefing | SDM | history
+    // The header + critical rules are always at the top; history is appended last.
+    const criticalPrefix = `${MEMORY_BOUNDARY_PREFIX}📋 Session context for "${project}" (${level}):\n\n` +
+        abaProtocol +
+        behavBlock +
+        skillBlock +
+        versionNote +
+        greetingBlock +
+        splitBrainWarning;
+    const lowerPriority = driftReport +
+        briefingBlock +
+        sdmRecallBlock +
+        visualMemoryBlock;
+    const historySection = formattedContext.trim()
+        ? `\n\n---\n\n📋 Historical Context:\n${formattedContext.trim()}`
+        : "";
+    // ─── v4.0: Token Budget Truncation (T5 structural version) ──
+    // Drops low-priority sections whole (no mid-slice) before falling back
+    // to trimming the history block. Protected sections (skills, ABA) always survive.
+    // T1: use ~3.5 chars/token (better for emoji+code payload) instead of flat 4.
     if (maxTokens && maxTokens > 0) {
-        const maxChars = maxTokens * 4;
+        const maxChars = Math.floor(maxTokens * 3.5);
+        const droppedSections = [];
+        let responseText = criticalPrefix + lowerPriority + historySection;
         if (responseText.length > maxChars) {
-            responseText = responseText.slice(0, maxChars) + "\n\n[… truncated to fit token budget]";
-            debugLog(`[session_load_context] Truncated response to ${maxTokens} tokens (${maxChars} chars)`);
+            // Drop low-priority sections first (SDM recall, briefing, drift)
+            responseText = criticalPrefix + historySection;
+            droppedSections.push("briefing", "drift-report", "sdm-recall");
+            debugLog(`[session_load_context] T5: dropped low-priority sections (${droppedSections.join(", ")})`);
+            if (responseText.length > maxChars) {
+                // History too long — trim it, preserving all critical sections
+                const histAllowed = Math.max(0, maxChars - criticalPrefix.length - 200);
+                const trimmedHistory = histAllowed > 0
+                    ? `\n\n---\n\n📋 Historical Context (trimmed):\n${formattedContext.trim().slice(0, histAllowed)}…`
+                    : "";
+                droppedSections.push("partial-history");
+                responseText = criticalPrefix + trimmedHistory;
+                debugLog(`[session_load_context] T5: trimmed history to ${histAllowed} chars`);
+            }
+        }
+        if (droppedSections.length > 0) {
+            responseText += `\n\n[ℹ️ Sections omitted to fit token budget (${maxTokens} tokens): ${droppedSections.join(", ")}. Skills and behavioral rules were preserved.]`;
         }
+        return {
+            content: [{ type: "text", text: responseText + MEMORY_BOUNDARY_SUFFIX }],
+            isError: false,
+        };
     }
+    let responseText = criticalPrefix + lowerPriority + historySection;
     return {
         content: [{ type: "text", text: responseText + MEMORY_BOUNDARY_SUFFIX }],
         isError: false,