principles-disciple 1.96.0 → 1.98.0

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.96.0",
+  "version": "1.98.0",
   "activation": {
     "onCapabilities": [
       "hook"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.96.0",
+  "version": "1.98.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",
@@ -57,6 +57,7 @@
     "eslint": "^10.4.1",
     "jsdom": "^29.1.1",
     "typescript": "^6.0.3",
+    "vite": "^8.0.16",
     "vitest": "^4.1.8",
     "ws": "^8.18.0"
   },

package/src/index.ts

@@ -70,6 +70,59 @@ const startedWorkspaces = new Set<string>();
 // Used to complete shadow observations when subagent ends
 const pendingShadowObservations = new Map<string, string>();
 
+// ── Conversation Access Health Check (PRI-343) ────────────────────────────
+// Pure function for checking whether OpenClaw plugin config has
+// allowConversationAccess set to true. When missing, llm_output and
+// trajectory hooks are silently blocked by OpenClaw, causing evidence
+// to always be empty (PRI-338 root cause).
+
+/** Keep in sync with @principles/core CONVERSATION_ACCESS_CONFIG_KEY */
+const CONVERSATION_ACCESS_CONFIG_KEY = 'allowConversationAccess' as const;
+
+export interface ConversationAccessCheckResult {
+  authorized: boolean;
+  reason?: string;
+  nextAction?: string;
+}
+
+const CONVERSATION_ACCESS_FIX_COMMAND =
+  'openclaw config set plugins.entries.principles-disciple.hooks.allowConversationAccess true --strict-json';
+
+/**
+ * PRI-343: Pure function — checks if pluginConfig has hooks.allowConversationAccess === true.
+ * Returns a structured result with reason and nextAction when not authorized (ERR-002).
+ */
+export function checkConversationAccessConfig(pluginConfig: unknown): ConversationAccessCheckResult {
+  if (pluginConfig === null || pluginConfig === undefined || typeof pluginConfig !== 'object' || Array.isArray(pluginConfig)) {
+    return {
+      authorized: false,
+      reason: 'pluginConfig is missing or invalid — conversation hooks cannot be registered',
+      nextAction: CONVERSATION_ACCESS_FIX_COMMAND,
+    };
+  }
+
+  const config = pluginConfig as Record<string, unknown>;
+
+  if (typeof config.hooks !== 'object' || config.hooks === null || Array.isArray(config.hooks)) {
+    return {
+      authorized: false,
+      reason: 'allowConversationAccess is not set to true',
+      nextAction: CONVERSATION_ACCESS_FIX_COMMAND,
+    };
+  }
+
+  const hooks = config.hooks as Record<string, unknown>;
+  if (hooks[CONVERSATION_ACCESS_CONFIG_KEY] !== true) {
+    return {
+      authorized: false,
+      reason: 'allowConversationAccess is not set to true',
+      nextAction: CONVERSATION_ACCESS_FIX_COMMAND,
+    };
+  }
+
+  return { authorized: true };
+}
+
 // ── Feature Flag Loader (plugin I/O boundary) ─────────────────────────────
 // Reads workspace feature-flags.yaml and checks a specific flag.
 // Returns the flag definition with effective enabled state.
@@ -161,6 +214,18 @@ const plugin = {
       } else {
         api.logger.info(`[PD:health] Tool hook workspaceDir OK: "${toolWorkspaceDir}"`);
       }
+
+      // PRI-343: Check allowConversationAccess — warn if llm_output/trajectory hooks blocked
+      const accessCheck = checkConversationAccessConfig(api.pluginConfig);
+      if (!accessCheck.authorized) {
+        api.logger.error(
+          `[PD:health] conversation hooks (llm_output / trajectory) will be BLOCKED by OpenClaw.\n` +
+          `  reason: ${accessCheck.reason}\n` +
+          `  nextAction: ${accessCheck.nextAction}`,
+        );
+      } else {
+        api.logger.info(`[PD:health] conversation hooks (allowConversationAccess) OK`);
+      }
     }, 1000);
     healthCheckTimer.unref(); // Don't keep process alive for health check
 

package/tests/index.test.ts

@@ -1,5 +1,6 @@
 import { describe, it, expect } from 'vitest';
 import plugin from '../src/index';
+import { checkConversationAccessConfig } from '../src/index';
 import type { PluginCommandDefinition, OpenClawPluginApi, PluginCommandContext } from '../src/openclaw-sdk.js';
 
 function createMockApi(): { registeredCommands: PluginCommandDefinition[]; api: OpenClawPluginApi } {
@@ -100,3 +101,42 @@ describe('Command Registration', () => {
     expect(ctx.workspaceDir).toBe('/mock/workspace');
   });
 });
+
+describe('checkConversationAccessConfig — PRI-343', () => {
+  it('returns authorized:false with reason and nextAction when allowConversationAccess is not true', () => {
+    const result = checkConversationAccessConfig({ hooks: { allowConversationAccess: false } });
+    expect(result.authorized).toBe(false);
+    expect(result.reason).toBeDefined();
+    expect(typeof result.reason).toBe('string');
+    expect(result.reason!.length).toBeGreaterThan(0);
+    expect(result.nextAction).toBeDefined();
+    expect(typeof result.nextAction).toBe('string');
+    expect(result.nextAction!.length).toBeGreaterThan(0);
+  });
+
+  it('returns authorized:true when allowConversationAccess is true', () => {
+    const result = checkConversationAccessConfig({ hooks: { allowConversationAccess: true } });
+    expect(result.authorized).toBe(true);
+    expect(result.reason).toBeUndefined();
+    expect(result.nextAction).toBeUndefined();
+  });
+
+  it('returns authorized:false when hooks object is missing', () => {
+    const result = checkConversationAccessConfig({ enabled: true });
+    expect(result.authorized).toBe(false);
+    expect(result.reason).toBeDefined();
+    expect(result.nextAction).toBeDefined();
+  });
+
+  it('returns authorized:false when pluginConfig is null', () => {
+    const result = checkConversationAccessConfig(null);
+    expect(result.authorized).toBe(false);
+    expect(result.reason).toBeDefined();
+  });
+
+  it('returns authorized:false when pluginConfig is undefined', () => {
+    const result = checkConversationAccessConfig(undefined);
+    expect(result.authorized).toBe(false);
+    expect(result.reason).toBeDefined();
+  });
+});