principles-disciple 1.66.0 → 1.67.0

package/tests/commands/evolution-status.test.ts

@@ -8,6 +8,8 @@ import { appendCandidateArtifactLineageRecord } from '../../src/core/nocturnal-a
 import { getImplementationAssetRoot } from '../../src/core/code-implementation-storage.js';
 import { EvolutionReducerImpl } from '../../src/core/evolution-reducer.js';
 import { saveLedger } from '../../src/core/principle-tree-ledger.js';
+import { WorkflowFunnelLoader } from '../../src/core/workflow-funnel-loader.js';
+import { RuntimeSummaryService } from '../../src/service/runtime-summary-service.js';
 
 const tempDirs: string[] = [];
 
@@ -338,4 +340,290 @@ describe('evolution commands', () => {
 
     expect(result.text).toContain('internalization routes: P-001:skill@');
   });
+
+  it('renders workflowFunnel blocks when YAML-driven funnels are present', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    // Write workflows.yaml with two funnels matching actual schema
+    const workflowsYaml = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: dreamer_completed
+        eventType: nocturnal_dreamer_completed
+        eventCategory: completed
+        statsField: evolution.nocturnalDreamerCompleted
+      - name: artifact_persisted
+        eventType: nocturnal_artifact_persisted
+        eventCategory: completed
+        statsField: evolution.nocturnalArtifactPersisted
+  - workflowId: rulehost
+    stages:
+      - name: evaluated
+        eventType: rulehost_evaluated
+        eventCategory: evaluated
+        statsField: evolution.rulehostEvaluated
+`;
+    fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), workflowsYaml, 'utf8');
+
+    // Write daily stats with matching event counts (must be in logs/ subdirectory)
+    const today = new Date().toISOString().slice(0, 10);
+    writeJson(path.join(stateDir, 'logs', 'daily-stats.json'), {
+      [today]: {
+        evolution: {
+          nocturnalDreamerCompleted: 3,
+          nocturnalArtifactPersisted: 2,
+          rulehostEvaluated: 15,
+        },
+      },
+    });
+
+    const result = handleEvolutionStatusCommand({
+      config: { workspaceDir: workspace, language: 'en' },
+    } as any);
+
+    expect(result.text).toContain('Workflow Funnel: nocturnal');
+    expect(result.text).toMatch(/dreamer_completed: 3/);
+    expect(result.text).toMatch(/artifact_persisted: 2/);
+    expect(result.text).toContain('Workflow Funnel: rulehost');
+    expect(result.text).toMatch(/evaluated: 15/);
+  });
+
+  it('skips funnel block when workflowFunnels is empty array', () => {
+    const workspace = makeTempDir();
+
+    // Write empty funnels array — valid YAML but no funnels defined
+    const workflowsYaml = `version: "1.0"\nfunnels: []`;
+    fs.writeFileSync(path.join(workspace, '.state', 'workflows.yaml'), workflowsYaml, 'utf8');
+
+    const result = handleEvolutionStatusCommand({
+      config: { workspaceDir: workspace, language: 'en' },
+    } as any);
+
+    expect(result.text).not.toContain('Workflow Funnel:');
+  });
+
+  it('shows degraded status and warning when YAML load has warnings', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    // Write malformed YAML — loader emits a parse warning
+    const badYaml = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: "unclosed string
+`;
+    fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), badYaml, 'utf8');
+
+    const result = handleEvolutionStatusCommand({
+      config: { workspaceDir: workspace, language: 'en' },
+    } as any);
+
+    // Should still render — degraded but not crashed
+    expect(result.text).toContain('Evolution Status');
+    // Loader warning should appear in output
+    expect(result.text).toMatch(/YAML load warning|YAML parse error|workflows\.yaml/);
+  });
+
+  it('renders Chinese workflow funnel labels from YAML', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    const workflowsYaml = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: 做梦完成
+        eventType: nocturnal_dreamer_completed
+        eventCategory: completed
+        statsField: evolution.nocturnalDreamerCompleted
+`;
+    fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), workflowsYaml, 'utf8');
+
+    const today = new Date().toISOString().slice(0, 10);
+    writeJson(path.join(stateDir, 'logs', 'daily-stats.json'), {
+      [today]: {
+        evolution: { nocturnalDreamerCompleted: 7 },
+      },
+    });
+
+    const result = handleEvolutionStatusCommand({
+      config: { workspaceDir: workspace, language: 'zh' },
+    } as any);
+
+    expect(result.text).toContain('Workflow 漏斗: nocturnal');
+    expect(result.text).toMatch(/做梦完成: 7/);
+  });
+});
+
+describe('YAML funnel E2E integration tests', () => {
+  // TEST-01: Full YAML-driven flow with real WorkflowFunnelLoader
+  it('e2e_test_full_yaml_driven_flow', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    // Create real WorkflowFunnelLoader (not mocked)
+    const loader = new WorkflowFunnelLoader(stateDir);
+    loader.watch();
+
+    // Write valid workflows.yaml
+    const workflowsYaml = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: dreamer_completed
+        eventType: nocturnal_dreamer_completed
+        eventCategory: completed
+        statsField: evolution.nocturnalDreamerCompleted
+      - name: artifact_persisted
+        eventType: nocturnal_artifact_persisted
+        eventCategory: completed
+        statsField: evolution.nocturnalArtifactPersisted
+  - workflowId: rulehost
+    stages:
+      - name: evaluated
+        eventType: rulehost_evaluated
+        eventCategory: evaluated
+        statsField: evolution.rulehostEvaluated
+`;
+    fs.writeFileSync(path.join(stateDir, 'workflows.yaml'), workflowsYaml, 'utf8');
+    loader.load(); // reload after writing file
+
+    // Write daily-stats.json
+    const today = new Date().toISOString().slice(0, 10);
+    writeJson(path.join(stateDir, 'logs', 'daily-stats.json'), {
+      [today]: {
+        evolution: {
+          nocturnalDreamerCompleted: 3,
+          nocturnalArtifactPersisted: 2,
+          rulehostEvaluated: 15,
+        },
+      },
+    });
+
+    // Call getSummary directly with real loader data
+    const summary = RuntimeSummaryService.getSummary(workspace, {
+      funnels: loader.getAllFunnels(),
+      loaderWarnings: loader.getWarnings(),
+    });
+
+    // Assert workflowFunnels structure
+    expect(summary.workflowFunnels).toBeDefined();
+    expect(summary.workflowFunnels!.length).toBe(2);
+    expect(summary.workflowFunnels![0].funnelKey).toBe('nocturnal');
+    expect(summary.workflowFunnels![0].stages[0].label).toBe('dreamer_completed');
+    expect(summary.workflowFunnels![0].stages[0].count).toBe(3);
+    expect(summary.workflowFunnels![0].stages[1].label).toBe('artifact_persisted');
+    expect(summary.workflowFunnels![0].stages[1].count).toBe(2);
+    expect(summary.workflowFunnels![1].funnelKey).toBe('rulehost');
+    expect(summary.workflowFunnels![1].stages[0].label).toBe('evaluated');
+    expect(summary.workflowFunnels![1].stages[0].count).toBe(15);
+    expect(summary.workflowFunnels![0].funnelLabel).toBe('nocturnal');
+
+    // DEGRADED-01: valid YAML + valid stats → status ok, no funnel-related warnings
+    expect(summary.metadata.status).toBe('ok');
+    // Note: warnings array may contain non-funnel warnings (GFI/Daily stats defaults); funnel warnings are checked separately
+    const funnelWarnings = summary.metadata.warnings.filter(w => w.includes('statsField') || w.includes('YAML load'));
+    expect(funnelWarnings).toHaveLength(0);
+
+    loader.dispose();
+  });
+
+  // TEST-02: Degraded fallback when YAML is missing
+  it('e2e_test_degraded_fallback_on_missing_yaml', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    // Create real loader pointing at stateDir with NO workflows.yaml
+    const loader = new WorkflowFunnelLoader(stateDir);
+    loader.watch();
+
+    // Write daily-stats.json (so the file exists, but no YAML)
+    const today = new Date().toISOString().slice(0, 10);
+    writeJson(path.join(stateDir, 'logs', 'daily-stats.json'), {
+      [today]: { evolution: {} },
+    });
+
+    // Call getSummary — should not crash
+    const summary = RuntimeSummaryService.getSummary(workspace, {
+      funnels: loader.getAllFunnels(),
+      loaderWarnings: loader.getWarnings(),
+    });
+
+    // Assert degraded status
+    expect(summary.metadata.status).toBe('degraded');
+    // loaderWarnings are prefixed with "YAML load warning: " when propagated to metadata.warnings
+    expect(summary.metadata.warnings).toContain('YAML load warning: workflows.yaml file not found.');
+    // DEGRADED-02: funnels absent/empty when YAML missing — empty array is acceptable, just not rendered
+    expect(summary.workflowFunnels == null || summary.workflowFunnels.length === 0).toBe(true);
+
+    loader.dispose();
+  });
+
+  // TEST-03: Hot-reload — YAML changes reflected after loader.load()
+  it('e2e_test_hot_reload_reflects_yaml_changes', () => {
+    const workspace = makeTempDir();
+    const stateDir = path.join(workspace, '.state');
+
+    const loader = new WorkflowFunnelLoader(stateDir);
+    loader.watch();
+
+    // Write initial workflows.yaml with original_label
+    const workflowsYamlV1 = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: original_label
+        eventType: nocturnal_dreamer_completed
+        eventCategory: completed
+        statsField: evolution.nocturnalDreamerCompleted
+`;
+    const yamlPath = path.join(stateDir, 'workflows.yaml');
+    fs.writeFileSync(yamlPath, workflowsYamlV1, 'utf8');
+    loader.load();
+
+    const today = new Date().toISOString().slice(0, 10);
+    writeJson(path.join(stateDir, 'logs', 'daily-stats.json'), {
+      [today]: { evolution: { nocturnalDreamerCompleted: 5 } },
+    });
+
+    // First call — should show original_label
+    const summary1 = RuntimeSummaryService.getSummary(workspace, {
+      funnels: loader.getAllFunnels(),
+      loaderWarnings: loader.getWarnings(),
+    });
+    expect(summary1.workflowFunnels![0].stages[0].label).toBe('original_label');
+    expect(summary1.workflowFunnels![0].stages[0].count).toBe(5);
+
+    // Modify workflows.yaml to use modified_label
+    const workflowsYamlV2 = `
+version: "1.0"
+funnels:
+  - workflowId: nocturnal
+    stages:
+      - name: modified_label
+        eventType: nocturnal_dreamer_completed
+        eventCategory: completed
+        statsField: evolution.nocturnalDreamerCompleted
+`;
+    fs.writeFileSync(yamlPath, workflowsYamlV2, 'utf8');
+    loader.load(); // trigger hot-reload manually
+
+    // Second call — should show modified_label
+    const summary2 = RuntimeSummaryService.getSummary(workspace, {
+      funnels: loader.getAllFunnels(),
+      loaderWarnings: loader.getWarnings(),
+    });
+    expect(summary2.workflowFunnels![0].stages[0].label).toBe('modified_label');
+    expect(summary2.workflowFunnels![0].stages[0].count).toBe(5);
+
+    loader.dispose();
+  });
 });

package/tests/core/event-log.test.ts

@@ -1,6 +1,6 @@
 import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import { EventLogService, EventLog } from '../../src/core/event-log.js';
-import type { DailyStats, DeepReflectionEventData, DiagnosticianReportEventData } from '../../src/types/event-types.js';
+import type { DailyStats, DiagnosticianReportEventData } from '../../src/types/event-types.js';
 import * as fs from 'fs';
 import * as path from 'path';
 import * as os from 'os';
@@ -19,32 +19,6 @@ describe('EventLog', () => {
     fs.rmSync(tempDir, { recursive: true, force: true });
   });
 
-  describe('recordDeepReflection', () => {
-    it('should record deep reflection event', () => {
-      const data: DeepReflectionEventData = {
-        modelId: 'claude-sonnet-4',
-        modelSelectionMode: 'auto',
-        confidenceScore: 0.85,
-        insightsGenerated: 3,
-        durationMs: 1500,
-        passed: true
-      };
-
-      eventLog.recordDeepReflection('session-1', data);
-      eventLog.flush();
-
-      const today = new Date().toISOString().slice(0, 10);
-      const eventsFile = path.join(tempDir, 'logs', `events_${today}.jsonl`);
-      const content = fs.readFileSync(eventsFile, 'utf-8');
-      const event = JSON.parse(content.trim());
-
-      expect(event.type).toBe('deep_reflection');
-      expect(event.category).toBe('passed');
-      expect(event.data.modelId).toBe('claude-sonnet-4');
-      expect(event.data.modelSelectionMode).toBe('auto');
-    });
-  });
-
   describe('DailyStats', () => {
     it('should aggregate tool call statistics correctly', () => {
       // Record multiple tool calls
@@ -97,8 +71,6 @@ describe('EventLog', () => {
       // Hooks field
       expect(stats.hooks).toBeDefined();
       
-      // Deep Reflection field
-      expect(stats.deepReflection).toBeDefined();
     });
 
     it('should increment tools.failure on error', () => {

package/tests/service/runtime-summary-service.test.ts

@@ -678,7 +678,7 @@ describe('RuntimeSummaryService', () => {
         last_updated: '2026-03-20T10:00:00Z',
       });
       writeJson(path.join(workspace, '.state', 'logs', 'daily-stats.json'), {
-        '2026-03-20': {
+        [new Date().toISOString().slice(0, 10)]: {
           toolCalls: 120,
           painSignals: 15,
           evolutionTasks: 5,