principles-disciple 1.44.0 → 1.45.0

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.44.0",
+  "version": "1.45.0",
   "skills": [
     "./skills"
   ],

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.44.0",
+  "version": "1.45.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",

package/src/hooks/prompt.ts

@@ -402,9 +402,10 @@ export async function handleBeforePromptBuild(
             learner.flush();
           }
         }
-      } catch {
-        // Fallback to hardcoded detection if learner fails
+      } catch (learnerErr) {
+        // Fallback to hardcoded detection if learner fails — log for observability
         correctionCue = detectCorrectionCue(userText);
+        logger?.warn?.(`[PD:Prompt] CorrectionCueLearner.match() failed (${String(learnerErr)}), fallback=${correctionCue ? `matched="${correctionCue}"` : 'no-match'}`);
       }
       let referencesAssistantTurnId: number | null = null;
       const hasPriorAssistant = event.messages

package/src/service/keyword-optimization-service.ts

@@ -31,12 +31,13 @@ export class KeywordOptimizationService {
   applyResult(result: CorrectionObserverResult): void {
     const learner = CorrectionCueLearner.get(this.stateDir);
 
-    if (!result.updated || !result.updates) {
+    const updates = result.updates ?? {};
+    if (!result.updated || Object.keys(updates).length === 0) {
       this.logger?.info?.('[KeywordOptimizationService] No updates to apply');
       return;
     }
 
-    for (const [term, update] of Object.entries(result.updates)) {
+    for (const [term, update] of Object.entries(updates)) {
       try {
         switch (update.action) {
           case 'add': {
@@ -74,6 +75,27 @@ export class KeywordOptimizationService {
         this.logger?.warn?.(`[KeywordOptimizationService] ${update.action.toUpperCase()} failed for term="${term}": ${String(opErr)}`);
       }
     }
+
+    // H-1: Record confirmed false positives — terms where correctionDetected fired
+    // but trajectory analysis shows user wasn't actually expressing frustration.
+    if (result.fpAnalysisStatus === 'completed' && result.fpTerms && result.fpTerms.length > 0) {
+      // Normalize: trim, lowercase, dedupe, sanity cap
+      const MAX_FP_TERMS = 20;
+      const normalizedFpTerms = [...new Set(
+        result.fpTerms
+          .map(t => t.trim().toLowerCase())
+          .filter(t => t.length > 0)
+      )].slice(0, MAX_FP_TERMS);
+
+      for (const term of normalizedFpTerms) {
+        try {
+          learner.recordFalsePositive(term);
+          this.logger?.info?.(`[KeywordOptimizationService] FP recorded for term="${term}" (weight x0.8)`);
+        } catch (fpErr) {
+          this.logger?.warn?.(`[KeywordOptimizationService} recordFalsePositive failed for term="${term}": ${String(fpErr)}`);
+        }
+      }
+    }
   }
 
   /**

package/src/service/subagent-workflow/correction-observer-types.ts

@@ -55,6 +55,19 @@ export interface CorrectionObserverResult {
     falsePositiveRate?: number;
     reasoning: string;
   }>;
+  /**
+   * Terms identified as false positives — user message didn't actually indicate
+   * frustration/correction despite correctionDetected firing for these terms.
+   * CORR-10 / H-1: Calling recordFalsePositive() decays weight by x0.8 per term.
+   * Only meaningful when fpAnalysisStatus='completed'.
+   */
+  fpTerms?: string[];
+  /**
+   * Whether FP analysis was performed. 'skipped' means the LLM did not run
+   * trajectory analysis (e.g., trajectory was empty). 'completed' means fpTerms
+   * contains the LLM's FP findings (may be empty if no FPs were found).
+   */
+  fpAnalysisStatus?: 'completed' | 'skipped';
   /** Human-readable summary */
   summary: string;
 }

package/src/service/subagent-workflow/correction-observer-workflow-manager.ts

@@ -115,6 +115,7 @@ export const correctionObserverWorkflowSpec: SubagentWorkflowSpec<CorrectionObse
             '## TASK',
             'Analyze the current correction keyword store and recent user messages.',
             'Recommend ADD/UPDATE/REMOVE actions to improve correction cue accuracy.',
+            'Also identify terms that triggered false positives (correctionDetected fired but user message doesn\'t indicate actual frustration).',
             '',
             '## Current Keyword Store (' + keywordStoreSummary.totalKeywords + ' terms):',
             termsList,
@@ -129,11 +130,14 @@ export const correctionObserverWorkflowSpec: SubagentWorkflowSpec<CorrectionObse
             '- ADD: If a correction pattern is detected in messages but not in store',
             '- UPDATE: If a term\'s weight should change based on TP/FP ratio',
             '- REMOVE: If a term has 0 hits after many uses AND high false positive rate (>0.3)',
+            '- FALSE POSITIVE: If a term appears in trajectory but the user message doesn\'t actually express frustration (e.g., user said "wrong" but in a factual context, not emotional)',
+            '- fpAnalysisStatus: set to "completed" if you performed trajectory analysis (even if no FPs found), or "skipped" if trajectory was empty/unavailable',
             '- Keep reasoning concise (max 100 chars)',
             '- Weight range: 0.1-0.9',
             '',
             'Return strict JSON (no markdown):',
-            '{"updated": boolean, "updates": {...}, "summary": string}',
+            '{"updated": boolean, "updates": {...}, "fpTerms": ["term1", ...], "fpAnalysisStatus": "completed" | "skipped", "summary": string}',
+            'Note: fpTerms is optional — only include if you identified clear false positives.',
         ].join('\n');
     },
 

package/tests/core/model-deployment-registry.test.ts

@@ -378,8 +378,15 @@ describe('ModelDeploymentRegistry getDeployment / listDeployments', () => {
 
     const deployments = listDeployments(tmpDir);
     expect(deployments).toHaveLength(2);
-    // Most recently updated is last in the list (sorted asc by updatedAt in memory)
-    expect(deployments[0].workerProfile).toBe('local-editor'); // bound second
+    // Verify sort order is descending by updatedAt (most recent first)
+    const [first, second] = deployments;
+    const firstUpdated = new Date(first.updatedAt).getTime();
+    const secondUpdated = new Date(second.updatedAt).getTime();
+    expect(firstUpdated).toBeGreaterThanOrEqual(secondUpdated);
+    // Also verify both expected profiles are present (order-independent)
+    const profiles = deployments.map(d => d.workerProfile);
+    expect(profiles).toContain('local-reader');
+    expect(profiles).toContain('local-editor');
   });
 
   it('listDeployments filters by workerProfile', () => {