principles-disciple 1.41.0 → 1.43.0

package/src/commands/workflow-debug.ts

@@ -21,7 +21,7 @@ function formatState(state: string): string {
 }
 
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function buildOutput(
     workflowId: string,
     summary: ReturnType<InstanceType<typeof WorkflowStore>['getWorkflow']>,

package/src/core/config.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as fs from 'fs';
 import * as path from 'path';
 import { atomicWriteFileSync } from '../utils/io.js';

package/src/core/dictionary.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as fs from 'fs';
 import * as path from 'path';
 import { atomicWriteFileSync } from '../utils/io.js';

package/src/core/event-log.ts

@@ -1,3 +1,4 @@
+ 
 import * as fs from 'fs';
 import * as path from 'path';
 import type {
@@ -94,7 +95,7 @@ export class EventLog {
   /**
    * Clean up event files older than EVENT_LOG_RETENTION_DAYS.
    */
-  private cleanupOldEventFiles(today: string): void {
+  private cleanupOldEventFiles(_today: string): void {
     if (EVENT_LOG_RETENTION_DAYS <= 0) return;
 
     try {
@@ -110,8 +111,8 @@ export class EventLog {
           fs.unlinkSync(filePath);
         }
       }
-    } catch {
-      // Silently fail cleanup
+    } catch (err) {
+      this.logger?.debug?.(`[PD] Event file cleanup failed (non-blocking): ${String(err)}`);
     }
   }
   
@@ -220,6 +221,7 @@ export class EventLog {
     }
   }
 
+   
   private updateStats(entry: EventLogEntry): void {
     let stats = this.statsCache.get(entry.date);
     if (!stats) {
@@ -228,8 +230,6 @@ export class EventLog {
     }
 
     if (entry.type === 'tool_call') {
-       
-      const _data = entry.data as unknown as ToolCallEventData;
       stats.tools.total++;
       if (entry.category === 'success') stats.tools.success++;
       else stats.tools.failure++;
@@ -349,7 +349,8 @@ export class EventLog {
         .map((line) => {
           try {
             return JSON.parse(line) as EventLogEntry;
-          } catch {
+          } catch (err) {
+            this.logger?.warn?.(`[PD] Corrupted event line skipped: ${String(err).slice(0, 100)}`);
             return null;
           }
         })
@@ -499,6 +500,7 @@ export class EventLog {
   /**
    * Aggregate empathy stats for a specific session.
    */
+   
   private aggregateSessionEmpathy(sessionId: string, result: EmpathyEventStats): void {
     for (const entry of this.getMergedEvents()) {
       if (entry.sessionId === sessionId && entry.type === 'pain_signal') {

package/src/core/evolution-types.ts

@@ -1,6 +1,6 @@
 /**
  * Evolution Points System V2.0 - MVP
- * 
+ *
  * Core Philosophy: Growth-driven替代Penalty-driven
  * - 起点0分，只能增加，不扣分
  * - 失败记录教训，不扣分
@@ -8,6 +8,9 @@
  * - 5级成长路径：Seed → Forest
  */
 
+// V2 queue types require TaskKind/TaskPriority from trajectory-types
+import type { TaskKind, TaskPriority } from './trajectory-types.js';
+
 // ===== 等级定义 =====
 
  
@@ -464,3 +467,32 @@ export type EvolutionLoopEvent =
   | { ts: string; type: 'principle_rolled_back'; data: PrincipleRolledBackData }
   | { ts: string; type: 'circuit_breaker_opened'; data: CircuitBreakerOpenedData }
   | { ts: string; type: 'legacy_import'; data: LegacyImportData };
+
+// V2 Queue Types (moved from evolution-worker.ts for shared use)
+export type QueueStatus = 'pending' | 'in_progress' | 'completed' | 'failed' | 'canceled';
+export type TaskResolution = 'marker_detected' | 'auto_completed_timeout' | 'failed_max_retries' | 'runtime_unavailable' | 'canceled' | 'late_marker_principle_created' | 'late_marker_no_principle' | 'stub_fallback' | 'skipped_thin_violation' | 'success' | 'failure' | 'skipped';
+
+export interface EvolutionQueueItem {
+  id: string;
+  taskKind: TaskKind;
+  priority: TaskPriority;
+  source: string;
+  traceId?: string;
+  task?: string;
+  score: number;
+  reason: string;
+  timestamp: string;
+  enqueued_at?: string;
+  started_at?: string;
+  completed_at?: string;
+  assigned_session_key?: string;
+  trigger_text_preview?: string;
+  status: QueueStatus;
+  resolution?: TaskResolution;
+  session_id?: string;
+  agent_id?: string;
+  retryCount: number;
+  maxRetries: number;
+  lastError?: string;
+  resultRef?: string;
+}

package/src/core/external-training-contract.ts

@@ -405,7 +405,7 @@ export function computeConfigFingerprint(config: Partial<TrainingHyperparameters
  */
 export function computeDatasetFingerprint(exportPath: string, sampleCount: number): string {
    
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let contentHash: string;
   try {
     const content = fs.readFileSync(exportPath, 'utf-8');

package/src/core/merge-gate-audit.ts

@@ -342,7 +342,7 @@ function hasValidEvidenceSummary(parsed: unknown): boolean {
  * Validate a single replay report file and return its category.
  */
 function validateSingleReplayReport(reportPath: string): ReplayValidationCategory {
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let rawContent: string;
   try {
     rawContent = fs.readFileSync(reportPath, 'utf-8');
@@ -350,7 +350,7 @@ function validateSingleReplayReport(reportPath: string): ReplayValidationCategor
     return 'io_error';
   }
 
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let parsed: unknown;
   try {
     parsed = JSON.parse(rawContent);
@@ -366,7 +366,7 @@ function validateSingleReplayReport(reportPath: string): ReplayValidationCategor
     return 'missing_evidence_summary';
   }
 
-  // eslint-disable-next-line @typescript-eslint/prefer-destructuring
+   
   const evidenceSummary = parsed.evidenceSummary;
   if (parsed.overallDecision === 'pass' && evidenceSummary.totalSamples === 0) {
     return 'unsupported_pass';

package/src/core/nocturnal-arbiter.ts

@@ -694,7 +694,7 @@ export function parseAndValidateArtifact(
 ): ArbiterResult {
   // Step 1: Parse JSON
    
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let parsed: unknown;
   try {
     parsed = JSON.parse(jsonString);

package/src/core/nocturnal-compliance.ts

@@ -242,31 +242,31 @@ export function detectOpportunity(principleId: string, session: SessionEvents):
    
   switch (principleId) {
     case 'T-01':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT01Opportunity(session);
     case 'T-02':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT02Opportunity(session);
     case 'T-03':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT03Opportunity(session);
     case 'T-04':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT04Opportunity(session);
     case 'T-05':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT05Opportunity(session);
     case 'T-06':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT06Opportunity(session);
     case 'T-07':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT07Opportunity(session);
     case 'T-08':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT08Opportunity(session);
     case 'T-09':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT09Opportunity(session);
     default:
       return { applicable: false, reason: `Unknown principle: ${principleId}` };
@@ -550,31 +550,31 @@ export function detectViolation(principleId: string, session: SessionEvents): Vi
    
   switch (principleId) {
     case 'T-01':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT01Violation(session);
     case 'T-02':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT02Violation(session);
     case 'T-03':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT03Violation(session);
     case 'T-04':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT04Violation(session);
     case 'T-05':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT05Violation(session);
     case 'T-06':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT06Violation(session);
     case 'T-07':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT07Violation(session);
     case 'T-08':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT08Violation(session);
     case 'T-09':
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define
+       
       return detectT09Violation(session);
     default:
       console.warn(`[PD:Compliance] Unknown principle ID: ${principleId} — treating as no violation. Check for typos (P-001 vs P_001).`);
@@ -933,11 +933,11 @@ export function computeCompliance(
       : 0;
 
   // Compute violationTrend using windows
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   const violationTrend = computeViolationTrend(applicableSessions, windowSize);
 
   // Build explanation
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   const explanation = buildExplanation(
     principleId,
     applicableOpportunityCount,
@@ -1009,7 +1009,7 @@ function computeViolationTrend(
  * Builds a human-readable explanation for the compliance result.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function buildExplanation(
   principleId: string,
   applicableOpportunityCount: number,

package/src/core/nocturnal-executability.ts

@@ -278,7 +278,7 @@ function isTooGeneric(text: string): boolean {
  * @param artifact - The validated artifact from arbiter (passed = true)
  * @returns ExecutabilityResult
  */
-    // eslint-disable-next-line complexity -- complexity 14, refactor candidate
+     
 export function validateExecutability(artifact: {
   badDecision: string;
   betterDecision: string;

package/src/core/nocturnal-reasoning-deriver.ts

@@ -144,7 +144,7 @@ export function deriveReasoningChain(assistantTurns: NocturnalAssistantTurn[]):
     // Without thinking tags we cannot extract a genuine reasoning trace, so
     // we fall back to 'low' rather than misleading the downstream pipeline
     // with activation derived from non-thinking patterns in the response text.
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let confidenceSignal: "high" | "medium" | "low";
     if (thinkingContent.length === 0) {
       confidenceSignal = 'low';
@@ -213,7 +213,7 @@ export function deriveDecisionPoints(
 
   // Binary search: find rightmost assistant turn with createdAt < tcTime
   const findBeforeTurn = (tcTime: number): NocturnalAssistantTurn | undefined => {
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let lo = 0, hi = sortedTurns.length - 1, result: NocturnalAssistantTurn | undefined;
     while (lo <= hi) {
       const mid = (lo + hi) >>> 1;
@@ -236,9 +236,9 @@ export function deriveDecisionPoints(
       : '';
 
     // On failure, find next assistant turn after tool call
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let afterReflection: string | undefined;
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let confidenceDelta: number | undefined;
 
     if (tc.outcome === 'failure') {

package/src/core/nocturnal-rule-implementation-validator.ts

@@ -85,7 +85,7 @@ function extractHelperUsage(sourceCode: string): string[] {
   );
 }
 
-    // eslint-disable-next-line complexity -- complexity 11, slightly over threshold
+     
 function validateMeta(meta: unknown): RuleImplementationValidationFailure[] {
   if (!meta || typeof meta !== 'object') {
     return [

package/src/core/nocturnal-snapshot-contract.ts

@@ -53,7 +53,7 @@ export function validateNocturnalSnapshotIngress(
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/prefer-destructuring
+   
   const stats = value.stats;
   if (!isObjectRecord(stats)) {
     reasons.push('snapshot.stats must be an object');

package/src/core/pain-context-extractor.ts

@@ -54,7 +54,7 @@ async function safeTail(filePath: string): Promise<string[]> {
   try {
     // Check existence and stats asynchronously
      
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let stat: fs.Stats;
     try {
       stat = await fsPromises.stat(filePath);
@@ -237,7 +237,7 @@ export async function extractRecentConversation(
 /**
  * Extracts failed tool call context with argument correlation.
  */
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export async function extractFailedToolContext(
   sessionId: string,
   agentId: string,

package/src/core/path-resolver.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as path from 'path';
 import * as os from 'os';
 import * as fs from 'fs';

package/src/core/pd-task-reconciler.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as fs from 'fs';
 import * as path from 'path';
 import * as os from 'os';

package/src/core/pd-task-service.ts

@@ -4,7 +4,7 @@ import { reconcilePDTasks } from './pd-task-reconciler.js';
 export const PDTaskService: OpenClawPluginService = {
   id: 'principles-disciple-task-manager',
 
-    // eslint-disable-next-line complexity -- complexity 14, refactor candidate
+     
   async start(ctx: OpenClawPluginServiceContext): Promise<void> {
     const {workspaceDir} = ctx;
     if (!workspaceDir) {

package/src/core/pd-task-store.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as fs from 'fs';
 import * as path from 'path';
 import type { PDTaskSpec } from './pd-task-types.js';

package/src/core/principle-internalization/deprecated-readiness.ts

@@ -65,7 +65,7 @@ export function assessDeprecatedReadiness(
   );
 
    
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let status: DeprecatedReadinessStatus;
   if (blockingReasons.length === 0 && stableCoverageRatio === 1) {
     status = 'ready';

package/src/core/principle-internalization/principle-lifecycle-service.ts

@@ -38,7 +38,7 @@ export interface PrincipleLifecycleAssessment {
   routeRecommendation: InternalizationRouteRecommendation;
 }
 
-    // eslint-disable-next-line complexity -- complexity 15, refactor candidate
+     
 function createValueMetrics(
   principle: PrincipleLifecycleEvidence,
   adherence: PrincipleAdherenceResult,

package/src/core/principle-training-state.ts

@@ -63,7 +63,7 @@ export function createDefaultPrincipleState(principleId: string): PrincipleTrain
 
 export function loadStore(stateDir: string): PrincipleTrainingStore {
    
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   return ledgerTrainingStore(stateDir);
 }
 
@@ -77,7 +77,7 @@ export function saveStore(stateDir: string, store: PrincipleTrainingStore): void
 
 export async function loadStoreAsync(stateDir: string): Promise<PrincipleTrainingStore> {
    
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define
+   
   return ledgerTrainingStore(stateDir);
 }
 

package/src/core/principle-tree-migration.ts

@@ -50,7 +50,7 @@ function trainingStateToTreePrinciple(
     text: `Principle ${principleId}`, // Minimal text, will be enriched from PRINCIPLES.md if available
     triggerPattern: '', // Unknown from legacy data
     action: '', // Unknown from legacy data
-    // eslint-disable-next-line @typescript-eslint/no-use-before-define
+     
     status: mapInternalizationStatusToPrincipleStatus(state.internalizationStatus),
     priority: 'P1', // Default priority
     scope: 'general',

package/src/core/replay-engine.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as fs from 'fs';
 import * as path from 'path';
 import { withLock } from '../utils/file-lock.js';

package/src/core/risk-calculator.ts

@@ -1,3 +1,4 @@
+ 
 /* global NodeJS */
 import * as fs from 'fs';
 import { isRisky } from '../utils/io.js';
@@ -95,7 +96,7 @@ export function getTargetFileLineCount(absoluteFilePath: string): number | null
  * @returns Maximum allowed lines (at least minLines, at most maxLines if provided)
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function calculatePercentageThreshold(
     targetLineCount: number,
     percentage: number,

package/src/core/rule-host.ts

@@ -71,7 +71,7 @@ export class RuleHost {
 
       // Merge decisions from all active implementations
        
-      // eslint-disable-next-line @typescript-eslint/init-declarations
+       
       let blocked: RuleHostResult | undefined;
       const approvals: RuleHostResult[] = [];
 

package/src/core/session-tracker.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import * as path from 'path';
 import * as fs from 'fs';
 import { atomicWriteFileSync } from '../utils/io.js';

package/src/core/shadow-observation-registry.ts

@@ -534,4 +534,4 @@ export function cleanupExpiredObservations(
   });
 
   return removed;
-}
+}

package/src/core/thinking-models.ts

@@ -202,7 +202,7 @@ let _cachedWorkspace: string | null = null;
  *
  * @param workspaceDir Optional. If provided, loads from that workspace's THINKING_OS.md.
  */
-    // eslint-disable-next-line complexity -- complexity 14, refactor candidate
+     
 export function listThinkingModels(workspaceDir?: string): ThinkingModelDefinition[] {
   const cacheKey = workspaceDir ?? '__global__';
   if (_cachedDefinitions && _cachedWorkspace === cacheKey) {

package/src/core/thinking-os-parser.ts

@@ -45,7 +45,7 @@ export function parseThinkingOsMd(content: string): ThinkingOsDirective[] {
   // Match all <directive ...> ... </directive> blocks
   const directiveRegex = /<directive\s+([^>]*)>([\s\S]*?)<\/directive>/gi;
    
-  // eslint-disable-next-line no-useless-assignment
+   
   let _match: RegExpExecArray | null = null;
 
   while ((_match = directiveRegex.exec(content)) !== null) {

package/src/core/trajectory.ts

@@ -1,3 +1,5 @@
+ 
+ 
 import Database from 'better-sqlite3';
 import fs from 'fs';
 import path from 'path';

package/src/hooks/bash-risk.ts

@@ -39,7 +39,7 @@ export type BashRiskLevel = 'safe' | 'dangerous' | 'normal';
  * @returns The risk level: 'safe', 'dangerous', or 'normal'
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function analyzeBashCommand(
   command: string,
   safePatterns: string[],
@@ -154,7 +154,7 @@ export interface DynamicThresholdConfig {
  * @param config - Configuration with large_change_lines and ep_tier_multipliers
  * @returns The adjusted threshold (minimum 0)
  */
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function calculateDynamicThreshold(
   baseThreshold: number,
   epTier: number,

package/src/hooks/edit-verification.ts

@@ -127,7 +127,7 @@ This is enforced by P-03 (精确匹配前验证原则).`;
  * This enforces P-03 at the tool layer
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function handleEditVerification(
   event: PluginHookBeforeToolCallEvent,
   wctx: WorkspaceContext,
@@ -157,7 +157,7 @@ export function handleEditVerification(
 
   // 2. Resolve and read file
    
-  // eslint-disable-next-line @typescript-eslint/init-declarations
+   
   let absolutePath: string;
   try {
     absolutePath = wctx.resolve(filePath);
@@ -225,7 +225,7 @@ export function handleEditVerification(
 
     // 3. Read current file content with improved error handling
      
-    // eslint-disable-next-line @typescript-eslint/init-declarations
+     
     let currentContent: string;
     try {
       currentContent = fs.readFileSync(absolutePath, 'utf-8');

package/src/hooks/gate.ts

@@ -135,7 +135,7 @@ export function handleBeforeToolCall(
 
     if (mutationMatch) {
        
-      // eslint-disable-next-line @typescript-eslint/prefer-destructuring
+       
       filePath = mutationMatch[1];
     } else {
       const hasRiskPath = profile.risk_paths.some(rp => command.includes(rp));
@@ -169,36 +169,36 @@ export function handleBeforeToolCall(
         toolName: event.toolName,
         normalizedPath: relPath,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         paramsSummary: _extractParamsSummary(event.params),
       },
       workspace: {
         isRiskPath: risky,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         planStatus: _getPlanStatus(ctx.workspaceDir),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         hasPlanFile: _hasPlanFile(ctx.workspaceDir),
       },
       session: {
         sessionId: ctx.sessionId,
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         currentGfi: _getCurrentGfi(ctx.sessionId),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         recentThinking: _hasRecentThinking(ctx.sessionId),
       },
       evolution: {
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         epTier: _getEpTier(wctx.workspaceDir),
       },
       derived: {
         estimatedLineChanges: estimateLineChanges({ toolName: event.toolName, params: event.params }),
          
-        // eslint-disable-next-line @typescript-eslint/no-use-before-define
+         
         bashRisk: _getBashRisk(event, profile),
       },
     };

package/src/hooks/gfi-gate.ts

@@ -48,7 +48,7 @@ export interface GfiGateConfig {
  * Internal helper to call the shared block helper with gfi-gate source tag.
  */
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 function block(
   wctx: WorkspaceContext,
   filePath: string,
@@ -70,7 +70,7 @@ function block(
 }
 
  
-// eslint-disable-next-line @typescript-eslint/max-params
+ 
 export function checkGfiGate(
   event: PluginHookBeforeToolCallEvent,
   wctx: WorkspaceContext,

package/src/hooks/lifecycle-routing.ts

@@ -66,7 +66,7 @@ export type LifecycleIntent = 'promote' | 'disable' | 'rollback' | null;
  * Detect implementation lifecycle intent from user message.
  * Returns the detected intent type or null.
  */
-    // eslint-disable-next-line complexity -- complexity 13, refactor candidate
+     
 export function detectLifecycleIntent(message: string): LifecycleIntent {
   // Check promote patterns
   for (const p of PROMOTE_PATTERNS_EN) {