principles-disciple 1.28.2 → 1.29.0

package/src/tools/deep-reflect.ts

@@ -108,6 +108,7 @@ export function createDeepReflectTool(api: OpenClawPluginApi) {
             }
 
              
+            // eslint-disable-next-line @typescript-eslint/no-use-before-define
             const effectiveWorkspaceDir = resolveReflectionWorkspace(api);
 
             const config = loadConfig(effectiveWorkspaceDir, api);
@@ -121,9 +122,11 @@ export function createDeepReflectTool(api: OpenClawPluginApi) {
 
             try {
                  
+                // eslint-disable-next-line @typescript-eslint/no-use-before-define
                 return await executeReflectionWorkflow(effectiveWorkspaceDir, config, context, depth, model_id, api);
             } catch (err) {
                  
+                // eslint-disable-next-line @typescript-eslint/no-use-before-define
                 return handleReflectionError(err, context, depth, model_id, effectiveWorkspaceDir, api);
             }
         }
@@ -146,6 +149,7 @@ function resolveReflectionWorkspace(api: OpenClawPluginApi): string {
  * Execute the deep reflection workflow: start, poll, collect results.
  */
  
+// eslint-disable-next-line @typescript-eslint/max-params
 async function executeReflectionWorkflow(
     effectiveWorkspaceDir: string,
     config: DeepReflectionConfig,
@@ -177,6 +181,7 @@ async function executeReflectionWorkflow(
         const startTime = Date.now();
         const timeoutMs = config.timeout_ms ?? 60000;
          
+        // eslint-disable-next-line @typescript-eslint/no-use-before-define
         return await pollReflectionCompletion(manager, handle, timeoutMs, startTime, eventLog, effectiveWorkspaceDir, context, model_id, depth);
     } finally {
         manager.dispose();
@@ -187,6 +192,7 @@ async function executeReflectionWorkflow(
  * Poll the reflection workflow until completion, timeout, or error.
  */
  
+// eslint-disable-next-line @typescript-eslint/max-params
 async function pollReflectionCompletion(
     manager: DeepReflectWorkflowManager,
     handle: { workflowId: string; childSessionKey: string },
@@ -207,6 +213,7 @@ async function pollReflectionCompletion(
 
         if (workflowState === 'completed') {
              
+            // eslint-disable-next-line @typescript-eslint/no-use-before-define
             return formatReflectionSuccess(handle, context, depth, model_id, startTime, eventLog, workspaceDir);
         }
 
@@ -222,6 +229,7 @@ async function pollReflectionCompletion(
  * Format the success response from a completed reflection.
  */
  
+// eslint-disable-next-line @typescript-eslint/max-params
 function formatReflectionSuccess(
     handle: { childSessionKey: string },
     context: string,
@@ -275,6 +283,7 @@ ${insights || '反思完成，详见 REFLECTION_LOG。'}
  * Handle reflection errors and format error response.
  */
  
+// eslint-disable-next-line @typescript-eslint/max-params
 function handleReflectionError(
     err: unknown,
     context: string,

package/src/tools/model-index.ts

@@ -62,6 +62,7 @@ export function loadModelIndex(
         const customConfig = loadCustomConfig(wctx);
         
          
+        // eslint-disable-next-line @typescript-eslint/init-declarations
         let modelsDir: string;
         if (customConfig?.modelsDir) {
             modelsDir = path.isAbsolute(customConfig.modelsDir) 

package/src/tools/write-pain-flag.ts

@@ -1,5 +1,6 @@
 import type { OpenClawPluginApi } from '../openclaw-sdk.js';
 import { Type } from '@sinclair/typebox';
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 import { buildPainFlag, writePainFlag } from '../core/pain.js';
 import { resolveWorkspaceDirFromApi } from '../core/path-resolver.js';
 import * as fs from 'fs';

package/src/utils/file-lock.ts

@@ -335,6 +335,7 @@ export async function withAsyncLock<T>(
   
   // 创建新的 Promise 链
    
+  // eslint-disable-next-line @typescript-eslint/init-declarations
   let resolveRelease: () => void;
   const releasePromise = new Promise<void>(resolve => {
     resolveRelease = resolve;

package/src/utils/io.ts

@@ -2,7 +2,7 @@ import * as path from 'path';
 import * as fs from 'fs';
 import { resolvePdPath } from '../core/paths.js';
 
-    // eslint-disable-next-line complexity -- complexity 12, refactor candidate
+     
 export function normalizePath(filePath: string, projectDir: string): string {
   if (!filePath) return '';
 
@@ -18,6 +18,7 @@ export function normalizePath(filePath: string, projectDir: string): string {
   }
 
    
+  // eslint-disable-next-line @typescript-eslint/init-declarations
   let rel: string;
   if (projectIsWin) {
     const projectAbs = path.resolve(projectDir);

package/tests/core/nocturnal-e2e.test.ts

@@ -40,6 +40,11 @@ describe('Phase 4a: Correction rejected integration', () => {
       correctionDetected: true, correctionCue: '错了',
       referencesAssistantTurnId: atId, createdAt: new Date().toISOString(),
     });
+    // Tool call triggers maybeCreateCorrectionSample on success
+    trajectory.recordToolCall({
+      sessionId: 'corr-session', toolName: 'read', outcome: 'success',
+      createdAt: new Date().toISOString(),
+    });
 
     // Verify sample was created
     const samples = trajectory.listCorrectionSamples('pending');
@@ -68,6 +73,11 @@ describe('Phase 4a: Correction rejected integration', () => {
       correctionDetected: true, correctionCue: '改进',
       referencesAssistantTurnId: atId, createdAt: new Date().toISOString(),
     });
+    // Tool call triggers maybeCreateCorrectionSample on success
+    trajectory.recordToolCall({
+      sessionId: 'approved-session', toolName: 'read', outcome: 'success',
+      createdAt: new Date().toISOString(),
+    });
 
     const samples = trajectory.listCorrectionSamples('pending');
     expect(samples.length).toBe(1);

package/tests/tools/write-pain-flag.test.ts

@@ -122,15 +122,28 @@ describe('write_pain_flag tool', () => {
     expect(api._logs.some((l: any) => l.level === 'warn')).toBe(true);
   });
 
-  it('returns clear error when workspace cannot be resolved', async () => {
-    const api = createMockApi('') as any;
-    const tool = createWritePainFlagTool(api);
+  it('falls back to PathResolver when config.workspaceDir is not set', async () => {
+    // Even without explicit workspaceDir, the tool should succeed
+    // by falling back to PathResolver (which finds default workspace)
+    const logs: { level: string; message: string }[] = [];
+    const api = {
+      config: {},
+      logger: {
+        info: (m: string) => logs.push({ level: 'info', message: m }),
+        warn: (m: string) => logs.push({ level: 'warn', message: m }),
+        error: (m: string) => logs.push({ level: 'error', message: m }),
+        debug: (m: string) => logs.push({ level: 'debug', message: m }),
+      },
+      runtime: { subagent: null, agent: null },
+      _logs: logs,
+    } as any;
 
-    const result = await tool.execute('test-3', { reason: 'Test error' });
+    const tool = createWritePainFlagTool(api);
+    const result = await tool.execute('test-3', { reason: 'Test fallback' });
 
-    expect(result.content[0].text).toContain('❌');
-    expect(result.content[0].text).toContain('workspace');
-    expect(api._logs.some((l: any) => l.level === 'error')).toBe(true);
+    // Should succeed via PathResolver fallback
+    expect(result.content[0].text).toContain('✅');
+    expect(result.content[0].text).toContain('Test fallback');
   });
 
   // ─────────────────────────────────────────────────────────
@@ -209,16 +222,19 @@ describe('write_pain_flag tool', () => {
     expect(text).toContain('heartbeat');
   });
 
-  it('provides clear failure feedback with error message', async () => {
+  it('handles missing state directory by creating it automatically', async () => {
     const api = createMockApi(workspaceDir) as any;
-    // Simulate workspace resolution failure by removing the config
-    (api as any).config = {};
+    // Remove .state directory to test auto-creation
+    if (fs.existsSync(stateDir)) {
+      fs.rmSync(stateDir, { recursive: true, force: true });
+    }
 
     const tool = createWritePainFlagTool(api);
-    const result = await tool.execute('test-7', { reason: 'Should fail' });
+    const result = await tool.execute('test-auto', { reason: 'Auto-create state dir' });
 
-    expect(result.content[0].text).toContain('❌');
-    expect(result.content[0].text).toContain('workspace');
+    expect(result.content[0].text).toContain('✅');
+    const painFlagPath = path.join(stateDir, '.pain_flag');
+    expect(fs.existsSync(painFlagPath)).toBe(true);
   });
 
   // ─────────────────────────────────────────────────────────